balazske added inline comments.
================
Comment at: lib/AST/ASTImporter.cpp:88
+ llvm::SmallVector<Decl*, 2> getCanonicalForwardRedeclChain(Decl* D) {
+ // Currently only FunctionDecl is supported
+ auto FD = cast<FunctionDecl>(D);
----------------
Assert for FunctionDecl?
================
Comment at: unittests/AST/ASTImporterTest.cpp:1745
+TEST_P(ImportFunctions, ImportDefinitions) {
+ auto Pattern = functionDecl(hasName("f"));
+
----------------
This test imports the definition two times, the second should result in error.
The import does not check the function body for similarness. Probably a check
can be made for the result of the second import.
Repository:
rC Clang
https://reviews.llvm.org/D47532
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
