r333319 - Revert "[DebugInfo] Don't bother with MD5 checksums of preprocessed files."

2018-05-25 Thread Paul Robinson via cfe-commits
Author: probinson Date: Fri May 25 15:35:59 2018 New Revision: 19 URL: http://llvm.org/viewvc/llvm-project?rev=19&view=rev Log: Revert "[DebugInfo] Don't bother with MD5 checksums of preprocessed files." This reverts commit d734f2aa3f76fbf355ecd2bbe081d0c1f49867ab. Also known as r11.

r333302 - Convert clang-interpreter to ORC JIT API

2018-05-25 Thread Stephane Sezer via cfe-commits
Author: sas Date: Fri May 25 13:23:42 2018 New Revision: 02 URL: http://llvm.org/viewvc/llvm-project?rev=02&view=rev Log: Convert clang-interpreter to ORC JIT API Summary: This mostly re-uses code from the KaleidoscopeJIT example. Reviewers: ddunbar, lhames Reviewed By: lhames Subscrib

RE: r333311 - [DebugInfo] Don't bother with MD5 checksums of preprocessed files.

2018-05-25 Thread via cfe-commits
Reverted in r19 because I got failure notices from http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/17262 and (for stage 1, but not stage 2, which is pretty weird) http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10824 The Bots Know when I'm about to go out of town...

r333320 - [X86] Correct the target features on two avx512bw builtins that were incorrectly labeled as avx512f.

2018-05-25 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri May 25 15:43:20 2018 New Revision: 20 URL: http://llvm.org/viewvc/llvm-project?rev=20&view=rev Log: [X86] Correct the target features on two avx512bw builtins that were incorrectly labeled as avx512f. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 148681. NoQ added a comment. Optimize `simplifySVal()` instead of reducing the threshold. I'll address the memoization separately. https://reviews.llvm.org/D47155 Files: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h lib/StaticAnalyzer/Core/

r333321 - [X86] Add const to another builtin that was missed from r331814.

2018-05-25 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri May 25 15:52:29 2018 New Revision: 21 URL: http://llvm.org/viewvc/llvm-project?rev=21&view=rev Log: [X86] Add const to another builtin that was missed from r331814. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified: cfe/trunk/include/clang/Bas

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I only essentially did one optimization - introduce a short path that returns the original value if visiting its sub-values changed nothing, which is a relatively common case. The reason it works though is that `evalBinOp()` will be called later to combine the sub-values, w

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 148684. NoQ added a comment. Add an explicit brute-force protection against re-entering `simplifySVal()`. Remove the threshold completely. https://reviews.llvm.org/D47155 Files: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h lib/StaticAnalyz

[PATCH] D46895: add AR to acronyms of clang-tidy property check

2018-05-25 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:37-38 /// The acronyms are from /// https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/APIAbbreviations.html#//apple_ref/doc/uid/20

r333324 - Fix typo + reflow comment; NFC

2018-05-25 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Fri May 25 16:40:59 2018 New Revision: 24 URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev Log: Fix typo + reflow comment; NFC Reflow brings said comment below 80 cols Modified: cfe/trunk/include/clang/AST/ASTContext.h Modified: cfe/trunk/include/clang/AST

[PATCH] D47225: Add nonnull; use it for atomics

2018-05-25 Thread JF Bastien via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL25: Add nonnull; use it for atomics (authored by jfb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47225 Files: libcxx/trunk/include/__c

[libcxx] r333325 - Add nonnull; use it for atomics

2018-05-25 Thread JF Bastien via cfe-commits
Author: jfb Date: Fri May 25 16:43:53 2018 New Revision: 25 URL: http://llvm.org/viewvc/llvm-project?rev=25&view=rev Log: Add nonnull; use it for atomics Summary: The atomic non-member functions accept pointers to std::atomic / std::atomic_flag as well as to the non-atomic value. These a

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

2018-05-25 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. If a standard library implements LWG 1203 (which I am implementing in MSVC++ right now) the return value of (istringstream() << A{}) is an rvalue, so it can't have an lvalue reference bound to it. Change this test

[PATCH] D47303: [analyzer] NFC: Merge object construction related state traits into one.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:377 + if (!State->contains(Key)) { +return State->set(Key, V); } george.karpenkov wrote: > nitpick: most C++ containers eliminate the need for two lookups by allowing > the `ge

[PATCH] D47303: [analyzer] NFC: Merge object construction related state traits into one.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 148692. NoQ marked 3 inline comments as done. NoQ added a comment. Fix review comments. https://reviews.llvm.org/D47303 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Core/Expr

r333326 - [analyzer] Add security checks for bcmp(), bcopy(), bzero().

2018-05-25 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri May 25 17:04:26 2018 New Revision: 26 URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev Log: [analyzer] Add security checks for bcmp(), bcopy(), bzero(). These functions are obsolete. The analyzer would advice to replace them with memcmp(), memcpy() or m

[PATCH] D41881: [analyzer] Flag bcmp, bcopy and bzero as obsolete

2018-05-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC26: [analyzer] Add security checks for bcmp(), bcopy(), bzero(). (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41881 Files: include/clang/StaticAnalyzer/

[PATCH] D41881: [analyzer] Flag bcmp, bcopy and bzero as obsolete

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Ouch, this one really got out of hand. Sorry. Repository: rC Clang https://reviews.llvm.org/D41881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47225: Add nonnull; use it for atomics

2018-05-25 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. GCC in libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03 seems to mis-handle ATOMIC_VAR_INIT: File /home/llvm-builder/llvm-buildslave-root/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03/llvm/projects/libcxx/test/libcxx/atomics/diagnose_nonnull.fail.cpp Line 20: non-aggregate type

[libcxx] r333327 - Fix GCC handling of ATOMIC_VAR_INIT

2018-05-25 Thread JF Bastien via cfe-commits
Author: jfb Date: Fri May 25 17:13:53 2018 New Revision: 27 URL: http://llvm.org/viewvc/llvm-project?rev=27&view=rev Log: Fix GCC handling of ATOMIC_VAR_INIT r25 from D47225 added warning checks, and the test was written to be C++11 correct by using ATOMIC_VAR_INIT (note that the com

[PATCH] D47402: [analyzer] Improve simplifySVal performance further.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. Memoize `SValBuilder::simplifySVal()` so that it didn't try to re-simplify the same symbolic expression in the same prog

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

2018-05-25 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-doc/Representation.h:138 + SymbolID USR = + SymbolID(); // Unique identifier for the decl described by this Info. + const InfoType IT = InfoType::IT_default; // InfoType of this particular Info. ioeric

[PATCH] D47299: [CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers

2018-05-25 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1626-1627 + + // Casting to pointer that does not carry dynamic information (provided by + // invariant.group) requires stripping it. + Src = Builder.CreateStripInvariantGroup(Src); -

[PATCH] D47402: [analyzer] Improve simplifySVal performance further.

2018-05-25 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. @NoQ we should make sure the memory is not exploding and that we don't make the analyzer slower in other cases. Though we could commit this, and then let CI figure out potential regressions. Repository: rC Clang https://reviews.llvm.org/D47402 __

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

2018-05-25 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D47340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D47402: [analyzer] Improve simplifySVal performance further.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. The remaining slowness is in `removeDead()`. It's going to be fun to optimize. Some parts of it are already memoized (eg. the live set in `SymbolReaper`). Memory usage on the artificial test seems stable. Repository: rC Clang https://reviews.llvm.org/D47402 _

[PATCH] D47405: [analyzer] Re-enable C++17-specific return value constructors.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. The refactoring conducted in https://reviews.llvm.org/D47304 made it easy for the analyzer to find the target region for

[PATCH] D47405: [analyzer] Re-enable C++17-specific return value constructors.

2018-05-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: test/Analysis/cxx17-mandatory-elision.cpp:185-191 +// Check if the last destructor is an automatic destructor. +// A temporary destructor would have fired by now. +#if __cplusplus >= 201703L +clang_analyzer_eval(v.len == 1); // e

[PATCH] D47341: [Sema] Disable creating new delayed typos while correcting existing.

2018-05-25 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai planned changes to this revision. vsapsai added a comment. After looking into this more, I think there are 2 different bugs: one with infinite loop and another with `DelayedTypos.empty() && "Uncorrected typos!"` assertion. And disabling typo correction happened to fix both of them. Infi

r333333 - Test commit; please ignore.

2018-05-25 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Fri May 25 19:29:14 2018 New Revision: 33 URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev Log: Test commit; please ignore. Modified: cfe/trunk/lib/Sema/SemaAttr.cpp Modified: cfe/trunk/lib/Sema/SemaAttr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tru

Re: r333333 - Test commit; please ignore.

2018-05-25 Thread Richard Smith via cfe-commits
Congratulations? On Fri, 25 May 2018, 19:33 George Burgess IV via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date: Fri May 25 19:29:14 2018 > New Revision: 33 > > URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev > Log: > Test commit; please ignore. > > Modi

Re: r333333 - Test commit; please ignore.

2018-05-25 Thread George Burgess IV via cfe-commits
Thanks. :) On Fri, May 25, 2018, 7:56 PM Richard Smith wrote: > Congratulations? > > On Fri, 25 May 2018, 19:33 George Burgess IV via cfe-commits, < > cfe-commits@lists.llvm.org> wrote: > >> Author: gbiv >> Date: Fri May 25 19:29:14 2018 >> New Revision: 33 >> >> URL: http://llvm.org/viewvc/

[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

2018-05-25 Thread Karl-Johan Karlsson via Phabricator via cfe-commits
Ka-Ka added a reviewer: JDevlieghere. Ka-Ka added a comment. Added Jonas Devlieghere as reviewer as he was involved in the review of https://reviews.llvm.org/rL327851 (which seems to be the reason for this patch). https://reviews.llvm.org/D45686 __

<    1   2