NoQ added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:377
+ if (!State->contains<ObjectsUnderConstruction>(Key)) {
+ return State->set<ObjectsUnderConstruction>(Key, V);
}
----------------
george.karpenkov wrote:
> nitpick: most C++ containers eliminate the need for two lookups by allowing
> the `get` method to return a reference. I'm not sure whether this can be done
> here though.
It's likely to be harder than usual because one doesn't simply obtain a
non-const reference to an object from an immutable map.
That's said, it's quite unimportant what do we do if the object is already
there.
https://reviews.llvm.org/D47303
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
