yvvan marked an inline comment as done.
yvvan added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:4148
+
+ CompletionSucceded |= DoCompletion(Base, IsArrow, None);
+
yvvan wrote:
> ilya-biryukov wrote:
> > NIT: maybe swap the two cases to do the non
yvvan updated this revision to Diff 148553.
yvvan added a comment.
NIT-s addressed
https://reviews.llvm.org/D41537
Files:
include/clang/Driver/CC1Options.td
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/CodeCompleteOptions.h
include/clang/Sema/Sema.h
lib/Frontend/ASTUni
Rakete updated this revision to Diff 148555.
Rakete added a comment.
Rebase and friendly ping :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.c
sammccall added a comment.
Wow, nice!
Just unsure about the test helper. (We can rewrite it in another way if needed)
Comment at: clangd/ClangdUnit.h:88
- /// This function returns all top-level decls, including those that come
- /// from Preamble. Decls, coming from Preamb
ioeric added a comment.
Nice! This looks good to me. Just some nits. I'll let Sam stamp.
Comment at: clangd/ClangdUnit.h:81
ASTContext &getASTContext();
const ASTContext &getASTContext() const;
IIUC, `ASTContext` in a `ParsedAST` may not contain informa
yvvan updated this revision to Diff 148559.
yvvan added a comment.
Update according to c++ part changes
https://reviews.llvm.org/D46862
Files:
include/clang-c/Index.h
test/Index/complete-arrow-dot.cpp
tools/c-index-test/c-index-test.c
tools/libclang/CIndex.cpp
tools/libclang/CIndexCod
Rakete updated this revision to Diff 148564.
Rakete added a comment.
Rebased + friendly ping :)
https://reviews.llvm.org/D39679
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/references.cpp
Index: test/SemaCXX/references.cpp
==
ioeric added a comment.
The change looks mostly good. Some nits and questions about the testing.
Comment at: clangd/index/Index.h:158
unsigned References = 0;
-
+ /// Whether or not this is symbol is meant to be used for the global
+ /// completion.
s/this
ioeric added a comment.
In https://reviews.llvm.org/D47223#1110571, @malaperle wrote:
> In https://reviews.llvm.org/D47223#1109247, @ilya-biryukov wrote:
>
> > I'm not sure if we have tests for that, but I remember that we kept the
> > enumerators in the outer scope so that completion could find
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks for addressing the NITs. LGTM!
https://reviews.llvm.org/D41537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
tzik updated this revision to Diff 148570.
tzik marked 2 inline comments as done.
tzik added a comment.
style fix. -O0 IR test.
Repository:
rC Clang
https://reviews.llvm.org/D47067
Files:
include/clang/AST/Decl.h
include/clang/Sema/Scope.h
lib/Sema/Scope.cpp
lib/Sema/SemaDecl.cpp
l
ioeric added a comment.
The reduce logic seems to be in a good shape. Some nits and questions inlined.
Comment at: clang-doc/Reducer.cpp:19
+
+#define REDUCE(INFO)
\
+ {
dstenb updated this revision to Diff 148577.
dstenb retitled this revision from "[Tooling] Clean up tmp files when creating
a fixed compilation database" to "[Driver] Clean up tmp files when deleting
Compilation objects".
dstenb edited the summary of this revision.
dstenb added a comment.
I have
lebedev.ri added inline comments.
Comment at: include/clang/Driver/Compilation.h:126
+ /// Whether to save temporary files.
+ bool SaveTempsEnabled;
+
`KeepTempFiles`?
Comment at: lib/Driver/Compilation.cpp:276-277
+
+ // Temporary files add
CarlosAlbertoEnciso updated this revision to Diff 148578.
CarlosAlbertoEnciso edited the summary of this revision.
CarlosAlbertoEnciso added a comment.
This patch addresses the reviewers comments:
1. Merge the -Wunused-local-typedefs and -Wunused-usings implementations
2. Update the Release Notes
CarlosAlbertoEnciso marked 2 inline comments as done.
CarlosAlbertoEnciso added inline comments.
Comment at: lib/Serialization/ASTReader.cpp:8101-8103
+UsingDecl *D = dyn_cast_or_null(
+GetDecl(UnusedUsingCandidates[I]));
+if (D)
dblaikie wrote:
>
sammccall added a comment.
In https://reviews.llvm.org/D47223#1110571, @malaperle wrote:
> In https://reviews.llvm.org/D47223#1109247, @ilya-biryukov wrote:
>
> > I'm not sure if we have tests for that, but I remember that we kept the
> > enumerators in the outer scope so that completion could f
tzik added inline comments.
Comment at: lib/Sema/Scope.cpp:122-123
+void Scope::setNRVOCandidate(VarDecl *Candidate) {
+ for (auto* D : DeclsInScope) {
+VarDecl* VD = dyn_cast_or_null(D);
+if (VD && VD != Candidate && VD->isNRVOCandidate())
rsmith wrote:
lebedev.ri added a comment.
Please improve test coverage a bit.
`-Wunused-using` is part of `-Wunused`.
And `-Wunused` is part of `-Wall`.
That needs to be tested.
Also, one small test to show that it is not on by default,
and `-Wno-unused-using` actually disables it is needed.
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333269: [ASTImporter] Fix ClassTemplateSpecialization in
wrong DC (authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47058
Fil
Author: martong
Date: Fri May 25 04:21:24 2018
New Revision: 333269
URL: http://llvm.org/viewvc/llvm-project?rev=333269&view=rev
Log:
[ASTImporter] Fix ClassTemplateSpecialization in wrong DC
Summary:
ClassTemplateSpecialization is put in the wrong DeclContex if implicitly
instantiated. This patc
xbolva00 added inline comments.
Comment at: lib/Sema/Scope.cpp:128
- if (getEntity())
-return;
-
- if (NRVO.getInt())
-getParent()->setNoNRVO();
- else if (NRVO.getPointer())
-getParent()->addNRVOCandidate(NRVO.getPointer());
+ if (getParent())
+getParent()-
martong created this revision.
martong added reviewers: a.sidorin, r.stahl, xazax.hun.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
In order to avoid build failures on MS, we use -fms-compatibility too in the
tests which use the TestBase.
Repository:
rC Clang
https://reviews.llvm.
martong added a comment.
@a.sidorin
Yes, that is a very good idea.
Just created a new patch which adds that switch for the tests which use the
TestBase.
https://reviews.llvm.org/D47367
Repository:
rC Clang
https://reviews.llvm.org/D46950
___
cf
martong added a comment.
This patch does not target `testImport` because I am not sure how to handle the
options there:
auto RunOptsFrom = getRunOptionsForLanguage(FromLang);
auto RunOptsTo = getRunOptionsForLanguage(ToLang);
for (const auto &FromArgs : RunOptsFrom)
for (const auto &To
gramanas updated this revision to Diff 148588.
gramanas added a comment.
I added a test that illustrates what @vsk is talking about.
Sorry for not providing the relevant information but I thought this would
be a simple one liner like https://reviews.llvm.org/rL327800. I will update the
revision'
ebevhan added a comment.
With the exception of the two inline comments, this looks good to me now!
Comment at: include/clang/Basic/LangOptions.def:301
+LANGOPT(FixedPointEnabled, 1, 0, "Fixed point types are enabled")
+
Just a minor nit... The 'Enabled' is su
Author: yvvan
Date: Fri May 25 05:56:26 2018
New Revision: 333272
URL: http://llvm.org/viewvc/llvm-project?rev=333272&view=rev
Log:
Optionally add code completion results for arrow instead of dot
Currently getting such completions requires source correction, reparsing
and calling completion again
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333272: Optionally add code completion results for arrow
instead of dot (authored by yvvan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41
dstenb updated this revision to Diff 148592.
dstenb marked an inline comment as done.
dstenb added a comment.
Renamed SaveTempsEnabled field to KeepTempFiles.
https://reviews.llvm.org/D45686
Files:
include/clang/Driver/Compilation.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
Index
erichkeane added inline comments.
Comment at: lib/Driver/Compilation.cpp:42
+ TranslatedArgs(_TranslatedArgs), ContainsError(ContainsError),
+ KeepTempFiles(D.isSaveTempsEnabled()) {
// The offloading host toolchain is the default toolchain.
I'd pref
baloghadamsoftware added inline comments.
Comment at: test/clang-tidy/bugprone-exception-escape.cpp:178
+void indirect_implicit() noexcept {
+ // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function 'indirect_implicit'
throws
+ implicit_int_thrower();
lebedev.ri
Author: szelethus
Date: Fri May 25 06:18:38 2018
New Revision: 333275
URL: http://llvm.org/viewvc/llvm-project?rev=333275&view=rev
Log:
[analyzer] Added template argument lists to the Pathdiagnostic output
Because template parameter lists were not displayed
in the plist output, it was difficult t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333275: [analyzer] Added template argument lists to the
Pathdiagnostic output (authored by Szelethus, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.o
dstenb added inline comments.
Comment at: lib/Driver/Compilation.cpp:276-277
+
+ // Temporary files added by diagnostics should be kept.
+ SaveTempsEnabled = true;
}
lebedev.ri wrote:
> Is there a test that breaks without this?
Yes, the following tests fail:
lebedev.ri added a comment.
LGTM, but i'm quite unfamiliar with this area of the code,
so please wait for someone else to accept :)
Comment at: lib/Driver/Compilation.cpp:276-277
+
+ // Temporary files added by diagnostics should be kept.
+ SaveTempsEnabled = true;
}
---
ilya-biryukov updated this revision to Diff 148599.
ilya-biryukov added a comment.
- Rebase, fix merge conflicts
- Simpler implemenataion of the Cache
- s/IdleASTs/ASTCache
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47063
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
ilya-biryukov added a comment.
I have addressed the comments regarding the cache implementation. ASTBuilder
ones are still pending, but I would appreciate the feedback on how
`TUScheduler.cpp` looks like.
Comment at: clangd/ClangdUnit.h:132
-/// Manages resources, required
Author: yvvan
Date: Fri May 25 06:46:07 2018
New Revision: 333276
URL: http://llvm.org/viewvc/llvm-project?rev=333276&view=rev
Log:
Fix members initialization order in constructor (fails with -Werror)
Modified:
cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h
Modified: cfe/trunk/include/c
filcab added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
I'd prefer to have the way
sammccall added a comment.
The cache looks way simpler now, thank you!
As discussed offline, flattening ASTBuilder right into ASTWorker still seems
like a good idea to me, but happy with what you come up with there.
Comment at: clangd/TUScheduler.cpp:71
+
+ /// Update the fun
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.h:81
ASTContext &getASTContext();
const ASTContext &getASTContext() const;
ioeric wrote:
> IIUC, `ASTContext` in a `ParsedAST` may not contain information from
> preambles and thus may gi
ilya-biryukov updated this revision to Diff 148602.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
- Rename the field in addition to the getter
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47331
Files:
clangd/ClangdU
tzik updated this revision to Diff 148603.
tzik added a comment.
reuse getParent() result
Repository:
rC Clang
https://reviews.llvm.org/D47067
Files:
include/clang/AST/Decl.h
include/clang/Sema/Scope.h
lib/Sema/Scope.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaSt
tzik added inline comments.
Comment at: lib/Sema/Scope.cpp:128
- if (getEntity())
-return;
-
- if (NRVO.getInt())
-getParent()->setNoNRVO();
- else if (NRVO.getPointer())
-getParent()->addNRVOCandidate(NRVO.getPointer());
+ if (getParent())
+getParent()->set
dstenb updated this revision to Diff 148604.
dstenb added a comment.
Query TheDriver.isSaveTempsEnabled() at uses instead of storing the value in
the constructor.
https://reviews.llvm.org/D45686
Files:
include/clang/Driver/Compilation.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
ilya-biryukov updated this revision to Diff 148605.
ilya-biryukov added a comment.
- Rewrote findDecl, it will deserialize decls if needed now
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47331
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/XRefs.cpp
unittest
a.sidorin added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:89
SymMgr(context, BasicVals, alloc), MemMgr(context, alloc),
-StateMgr(stateMgr), ArrayIndexTy(context.LongLongTy),
+StateMgr(stateMgr), ArrayIndex
ebevhan added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:89
SymMgr(context, BasicVals, alloc), MemMgr(context, alloc),
-StateMgr(stateMgr), ArrayIndexTy(context.LongLongTy),
+StateMgr(stateMgr), ArrayIndexTy
Author: szelethus
Date: Fri May 25 07:48:33 2018
New Revision: 333278
URL: http://llvm.org/viewvc/llvm-project?rev=333278&view=rev
Log:
[analyzer] Added a getLValue method to ProgramState for bases
Differential Revision: https://reviews.llvm.org/D46891
Modified:
cfe/trunk/include/clang/Stat
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333278: [analyzer] Added a getLValue method to ProgramState
for bases (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46891
Files:
include/clang/StaticAnalyzer
Author: ibiryukov
Date: Fri May 25 07:55:18 2018
New Revision: 333280
URL: http://llvm.org/viewvc/llvm-project?rev=333280&view=rev
Log:
[clangd] Temporarily disable the test that crashes under asan.
It turns out that our fix did not solve the problem completely and the
crash due to stale preamble
pgousseau created this revision.
pgousseau added reviewers: rsmith, filcab, probinson, gbedwell.
Herald added a subscriber: cfe-commits.
NFC for targets other than PS4.
Simplify users' workflow when enabling asan or ubsan and calling the linker
separately.
Repository:
rC Clang
https://revie
yaxunl created this revision.
yaxunl added a reviewer: tra.
CUDA and HIP action builder currently tries to do offloading for -M, which
causes dependency file
not generated.
This patch changes action builder so that only host compilation is performed to
generate dependency
file.
This assumes th
probinson added a comment.
LGTM with the indicated test tweak, but best if @filcab also takes a look.
Comment at: lib/Driver/ToolChains/PS4CPU.cpp:87
+CmdArgs.push_back("--dependent-lib=libSceDbgAddressSanitizer_stub_weak.a");
+ }
+}
Don't bother with brac
probinson added a comment.
@trixirt do you mind if I commandeer this review? I think I have a patch.
Repository:
rC Clang
https://reviews.llvm.org/D47260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: hahnfeld
Date: Fri May 25 08:56:12 2018
New Revision: 333283
URL: http://llvm.org/viewvc/llvm-project?rev=333283&view=rev
Log:
[Sema] Add tests for weak functions
I found these checks to be missing, just add some simple cases.
Differential Revision: https://reviews.llvm.org/D47200
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333283: [Sema] Add tests for weak functions (authored by
Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47200?vs=148021&id=148616#t
jakehehrlich added a comment.
This is causing breaks in fuchsia,
Code that looks like this
uintptr_t last_unlogged =
atomic_load_explicit(&unlogged_tail, memory_order_acquire);
do {
if (last_unlogged == 0)
return;
} while (!atomic_compare_exchange_weak_explicit(
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D47357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
jfb added a comment.
In https://reviews.llvm.org/D47229#1112549, @jakehehrlich wrote:
> This is causing breaks in fuchsia,
>
> Code that looks like this
>
> uintptr_t last_unlogged =
>atomic_load_explicit(&unlogged_tail, memory_order_acquire);
>do {
>if (last_unlogged == 0)
Author: jfb
Date: Fri May 25 10:36:49 2018
New Revision: 333290
URL: http://llvm.org/viewvc/llvm-project?rev=333290&view=rev
Log:
Follow-up fix for nonnull atomic non-member functions
Handling of the third parameter was only checking for *_n and not for the C11
variant, which means that cmpxchg
jfb added a comment.
Fixed by r333290.
Repository:
rL LLVM
https://reviews.llvm.org/D47229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
I think the approach makes sense.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if (CGM.ge
probinson added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
filcab wrote:
> I'd pref
Quuxplusone added a comment.
Just commenting to say that this LGTM and I have no further nitpicks. I have
verified that I cannot detect any change in the behavior of
`-Wpessimizing-move` or `-Wreturn-std-move` due to this change (and I //can//
successfully detect the additional copy-elision du
leonardchan updated this revision to Diff 148637.
leonardchan added a comment.
Changed flag names
Repository:
rC Clang
https://reviews.llvm.org/D46084
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Basic/DiagnosticCommon
leonardchan marked 2 inline comments as done.
leonardchan added inline comments.
Comment at: include/clang/Driver/Options.td:882
+def enable_fixed_point : Flag<["-", "--"], "enable-fixed-point">,
Group,
+ Flags<[CC1Option]>, HelpText<"Enable fixed point
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good!
Do you have commit access? I think you should get commit access.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1650
+
+// If there is a list, but no
rsmith added a comment.
In https://reviews.llvm.org/D46845#1105638, @erik.pilkington wrote:
> make __map_node_handle use a const_cast on the key instead of type-punning
> between pair and pair. Add calls to std::launder in key()
> and before inserting a node handle.
Can you do this as a separ
trixirt added a comment.
commandeer away!
Sure that is fine.
Repository:
rC Clang
https://reviews.llvm.org/D47260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
Ping.
https://reviews.llvm.org/D46918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Fri May 25 13:16:03 2018
New Revision: 01
URL: http://llvm.org/viewvc/llvm-project?rev=01&view=rev
Log:
[OPENMP, NVPTX] Fixed codegen for orphaned parallel region.
If orphaned parallel region is found, the next code must be emitted:
```
if(__kmpc_is_spmd_exec_mode()
This revision was automatically updated to reflect the committed changes.
Closed by commit rL02: Convert clang-interpreter to ORC JIT API (authored
by sas, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45897?vs=143376&id=148656#t
rsmith added a comment.
In https://reviews.llvm.org/D41039#984009, @ahatanak wrote:
> Yes, please document this in itanium-cxx-abi. Thanks!
Looks like this hasn't happened yet.
Repository:
rL LLVM
https://reviews.llvm.org/D41039
___
cfe-commit
Author: phosek
Date: Fri May 25 13:39:37 2018
New Revision: 07
URL: http://llvm.org/viewvc/llvm-project?rev=07&view=rev
Log:
[Support] Avoid normalization in sys::getDefaultTargetTriple
The return value of sys::getDefaultTargetTriple, which is derived from
-DLLVM_DEFAULT_TRIPLE, is used t
probinson updated this revision to Diff 148663.
probinson added a comment.
Upload patch to suppress checksums when we see a preprocessed file.
https://reviews.llvm.org/D47260
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugInfo.h
clang/test/CodeGen/md5-checksum-crash.c
Author: jfb
Date: Fri May 25 13:43:57 2018
New Revision: 08
URL: http://llvm.org/viewvc/llvm-project?rev=08&view=rev
Log:
Fix optional deduction guide test breakage
Modified:
libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/deduct.fail.cpp
libcxx/tru
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Minor comment inline.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:378
return None;
+ if (Entry.getFile().hasLineDirectives()) {
+EmitFileChecksums = false;
probinson marked an inline comment as done.
probinson added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:378
return None;
+ if (Entry.getFile().hasLineDirectives()) {
+EmitFileChecksums = false;
aprantl wrote:
> Can you add a comment e
This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
Closed by commit rC11: [DebugInfo] Don't bother with MD5 checksums of
preprocessed files. (authored by probinson, committed by ).
Changed prior to commit:
https://reviews.ll
Author: probinson
Date: Fri May 25 13:59:29 2018
New Revision: 11
URL: http://llvm.org/viewvc/llvm-project?rev=11&view=rev
Log:
[DebugInfo] Don't bother with MD5 checksums of preprocessed files.
The checksum will not reflect the real source, so there's no clear
reason to include them in t
This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
Closed by commit rL11: [DebugInfo] Don't bother with MD5 checksums of
preprocessed files. (authored by probinson, committed by ).
Herald added a subscriber: llvm-commits.
Chan
xbolva00 added a comment.
Ok?
https://reviews.llvm.org/D47340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Ok! Putting any remaining work into follow-up patches would be great indeed.
Let's land this into `alpha.cplusplus` for now because i still haven't made up
my mind for how to organize the proposed `bugprone` category (sorry!).
Comment at: lib/StaticAnalyz
Author: jfb
Date: Fri May 25 14:17:43 2018
New Revision: 15
URL: http://llvm.org/viewvc/llvm-project?rev=15&view=rev
Log:
Fix array deduction guide test breakage
No matching constructor
Modified:
libcxx/trunk/test/std/containers/sequences/array/array.cons/deduct.pass.cpp
Modified:
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D46918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
stephanemoore created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rC Clang
https://reviews.llvm.org/D47393
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
===
Author: bwilson
Date: Fri May 25 14:26:03 2018
New Revision: 16
URL: http://llvm.org/viewvc/llvm-project?rev=16&view=rev
Log:
Support Swift calling convention for PPC64 targets
This adds basic support for the Swift calling convention with PPC64 targets.
Patch provided by Atul Sowani in bu
bob.wilson closed this revision.
bob.wilson added a comment.
Committed in Clang r16
Repository:
rC Clang
https://reviews.llvm.org/D46550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
stephanemoore updated this revision to Diff 148672.
Repository:
rC Clang
https://reviews.llvm.org/D47393
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
===
--- uni
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
(FYI, Please use a weekly frequency for Pings).
Repository:
rCXX libc++
https://reviews.llvm.org/D47225
___
cfe-commits mailing list
gtbercea created this revision.
gtbercea added reviewers: Hahnfeld, hfinkel, caomhin, carlo.bertolli, tra.
Herald added subscribers: cfe-commits, guansong.
So far, the clang-offload-bundler has been the default tool for bundling
together various files types produced by the different OpenMP offloa
Author: jfb
Date: Fri May 25 14:32:27 2018
New Revision: 17
URL: http://llvm.org/viewvc/llvm-project?rev=17&view=rev
Log:
Fix optional test breakage
It seems GCC and clang disagree. Talked to mclow on IRC, disabling for now.
Modified:
libcxx/trunk/test/std/utilities/optional/optiona
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
I'm not sure if libcxx is asserting UTF-8 here; but on Windows the full char
value is always passed through in its entirety, since the default codepage is
something like Windows-1252. The replacement character is
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:265-276
+ const llvm::APSInt &from = i->From(), &to = i->To();
+ const llvm::APSInt &newFrom = (to.isMinSignedValue() ?
+ BV.getMaxValue(to) :
+
gtbercea updated this revision to Diff 148677.
Repository:
rC Clang
https://reviews.llvm.org/D47394
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/Compilation.cp
Author: ctopper
Date: Fri May 25 15:07:43 2018
New Revision: 18
URL: http://llvm.org/viewvc/llvm-project?rev=18&view=rev
Log:
[X86] Mark a few more builtins const that were missed in r331814.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
Modified: cfe/trunk/include/clang/Ba
trixirt added a comment.
Herald added a reviewer: george.karpenkov.
I need someone to commit this..
Repository:
rC Clang
https://reviews.llvm.org/D41881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
juliehockett updated this revision to Diff 148678.
juliehockett marked 11 inline comments as done.
juliehockett added a comment.
Reworking the reducer interface a bit to address comments.
https://reviews.llvm.org/D43341
Files:
clang-doc/BitcodeReader.cpp
clang-doc/BitcodeReader.h
clang-do
1 - 100 of 133 matches
Mail list logo
