yvvan marked an inline comment as done. yvvan added inline comments.
================ Comment at: lib/Sema/SemaCodeComplete.cpp:4148 + + CompletionSucceded |= DoCompletion(Base, IsArrow, None); + ---------------- yvvan wrote: > ilya-biryukov wrote: > > NIT: maybe swap the two cases to do the non-fixit ones first? It is the > > most common case, so it should probably go first. > The actual completion should be the last because of the "Completion context". > I've put them in this order intentionally. I will add comment about that. I've rechecked this part - I can actually now move it without breaking anything https://reviews.llvm.org/D41537 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
