[PATCH] D47341: [Sema] Disable creating new delayed typos while correcting existing.

arphaman added inline comments. Comment at: clang/test/SemaCXX/typo-correction-delayed.cpp:146 + // expected-error@+1 {{use of undeclared identifier 'variableX'}} int x = variableX.getX(); } Loosing typo correction for 'getX' is fine, however, I think we sti

[PATCH] D47341: [Sema] Disable creating new delayed typos while correcting existing.

rsmith added a comment. Rather than disabling typo correction in `TransformTypos`, it would be preferable to attempt to immediately correct them. (That should allow the `variableX.getX()` case to still work.) https://reviews.llvm.org/D47341 ___ cf

[PATCH] D47350: [analyzer] Track class member initializer constructors path-sensitively within their construction context.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. Same as https://reviews.llvm.org/D47305 but for `CXXCtorInitializer`-based constructors, based on the discussion in htt

[PATCH] D47350: [analyzer] Track class member initializer constructors path-sensitively within their construction context.

NoQ updated this revision to Diff 148502. NoQ added a comment. Add a forgotten FIXME to the test. https://reviews.llvm.org/D47350 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Core/ExprEngineCXX.cpp test/Ana

[PATCH] D47229: Make atomic non-member functions as nonnull

jfb updated this revision to Diff 148504. jfb marked an inline comment as done. jfb added a comment. - Address nit. - Change suggested by Richard Repository: rC Clang https://reviews.llvm.org/D47229 Files: lib/Sema/SemaChecking.cpp test/Sema/atomic-ops.c Index: test/Sema/atomic-ops.c ==

[PATCH] D47229: Make atomic non-member functions as nonnull

jfb added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3497 +else if (Form == Copy || Form == Xchg) { + if (!IsC11 && !IsN) +// The value pointer is always dereferenced, a nullptr is undefined. rsmith wrote: > arphaman wrot

[PATCH] D47351: [analyzer] Re-enable C++17-specific variable and member variable construction contexts.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. The recent refactoring allows us to easily support C++17 "copy-elided" constructor syntax for variables and constructor-

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148506. leonardchan added a comment. Re-added individual getters/members for _Accum types Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def in

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan added inline comments. Comment at: include/clang/Basic/TargetInfo.h:382 +// enough bits to fit the minumum. +if (getIntWidth() < MinSignedAccumDataBits) + return getLongWidth(); ebevhan wrote: > I'm not sure I agree with this interpretati

Advice for a Newcoming Subscriber

Dear All LLVM list members, Hello to all of you. As I am a brand new subscriber, it is easy to get lost in the plethora of open source projects I may get started in! For now, I am mostly interested in optimizing Clang's performance. I just have three questions: 1. What have been the toughest, m

r333246 - Make atomic non-member functions as nonnull

Author: jfb Date: Thu May 24 17:07:09 2018 New Revision: 333246 URL: http://llvm.org/viewvc/llvm-project?rev=333246&view=rev Log: Make atomic non-member functions as nonnull Summary: As a companion to libc++ patch https://reviews.llvm.org/D47225, mark builtin atomic non-member functions which ac

[PATCH] D47229: Make atomic non-member functions as nonnull

This revision was automatically updated to reflect the committed changes. Closed by commit rL333246: Make atomic non-member functions as nonnull (authored by jfb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47229 Files: cfe/trunk/li

[PATCH] D47225: Add nonnull; use it for atomics

jfb added a comment. Ping! clang side landed in https://reviews.llvm.org/rL333246 Repository: rCXX libc++ https://reviews.llvm.org/D47225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

rtrieu added a comment. Instead of adding a break, you should add a noreturn attribute to the PrintFatalError function. LLVM has the macro LLVM_ATTRIBUTE_NORETURN to do this. You can confirm that PrintFatalError is a noreturn function by seeing that it unconditionally calls llvm::PrintFatalEr

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

xbolva00 updated this revision to Diff 148523. xbolva00 added a comment. Add correct NORETURN attribute https://reviews.llvm.org/D47340 Files: utils/TableGen/ClangDiagnosticsEmitter.cpp Index: utils/TableGen/ClangDiagnosticsEmitter.cpp ===

[PATCH] D47354: [CodeGen][Darwin] Set the calling-convention of a thread-local variable initialization function to fix calling-convention mismatch

ahatanak created this revision. ahatanak added reviewers: rjmccall, t.p.northover. There is a bug in IRGen where the calling convention of initialization functions for thread-local static members of c++ template classes isn't set. This caused InstCombine to remove a call to an initialization fun

[PATCH] D47355: [CMake] Allow specifying extra dependencies of bootstrap stage

phosek created this revision. phosek added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. This allows adding additional bootstrap dependencies to the bootstrap compiler that may be needed by later stages. Repository: rC Clang https://reviews.llvm.org/D47355 Files: clang/

[PATCH] D47356: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang

phosek created this revision. phosek added reviewers: beanz, jakehehrlich, mcgrathr. Herald added subscribers: cfe-commits, mgorny, dberris. Herald added a reviewer: EricWF. We want to build the second stage compiler with libc++ and compiler-rt, also include builtins and runtimes into extra bootst

[PATCH] D47355: [CMake] Allow specifying extra dependencies of bootstrap stage

phosek added inline comments. Comment at: clang/CMakeLists.txt:586 + if(CLANG_BOOTSTRAP_EXTRA_COMPONENTS) +add_dependencies(clang-bootstrap-deps ${CLANG_BOOTSTRAP_EXTRA_COMPONENTS}) I don't know if `COMPONENTS` is the best term, this could also possibly be

[PATCH] D44888: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation

shiva0217 added a comment. In https://reviews.llvm.org/D44888#1109361, @asb wrote: > This is looking good to me, just needs an update to address this > request for a test in > riscv-features.c that demonstrates the default +relax/-relax setting.

[libcxx] r333251 - Add deduction guides for optional

Author: marshall Date: Thu May 24 19:08:49 2018 New Revision: 333251 URL: http://llvm.org/viewvc/llvm-project?rev=333251&view=rev Log: Add deduction guides for optional Added: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/deduct.fail.cpp libcxx/trunk/test

[libcxx] r333252 - Add one more test for optional

Author: marshall Date: Thu May 24 19:22:54 2018 New Revision: 333252 URL: http://llvm.org/viewvc/llvm-project?rev=333252&view=rev Log: Add one more test for optional Modified: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/deduct.pass.cpp Modified: libcxx/tru

[PATCH] D47357: [Driver] Rename DefaultTargetTriple to TargetTriple

phosek created this revision. phosek added reviewers: hans, rnk, echristo. Herald added a subscriber: cfe-commits. While this value is initialized with the DefaultTargetTriple, it can be later overriden using the -target flag so TargetTriple is a more accurate name. This change also provides an ac

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone updated this revision to Diff 148540. Quuxplusone added a comment. Oops. If we do get an underaligned result, let's not leak it! Repository: rCXX libc++ https://reviews.llvm.org/D47344 Files: src/experimental/memory_resource.cpp Index: src/experimental/memory_resource.cpp ===

[PATCH] D47354: [CodeGen][Darwin] Set the calling-convention of a thread-local variable initialization function to fix calling-convention mismatch

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D47354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 148542. Quuxplusone retitled this revision from "Implement monotonic_buffer_resource in " to ": Implement monotonic_buffer_resource.". Quuxplusone added 1 blocking reviewer(s): EricWF. Quuxplusone added a comment. Fix one visibility macro. Repository:

[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone created this revision. Quuxplusone added a reviewer: EricWF. Herald added a subscriber: cfe-commits. Split out from https://reviews.llvm.org/D47090. This patch is based on top of (depends on) https://reviews.llvm.org/D47111, but I'm posting it now for review. Repository: rCXX libc

[PATCH] D44888: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation

asb added a comment. In https://reviews.llvm.org/D44888#920, @shiva0217 wrote: > In https://reviews.llvm.org/D44888#1109361, @asb wrote: > > > This is looking good to me, just needs an update to address this > > request for a test in > > riscv

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked 4 inline comments as done. yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4148 + + CompletionSucceded |= DoCompletion(Base, IsArrow, None); + ilya-biryukov wrote: > NIT: maybe swap the two cases to do the non-fixit ones first

r333256 - [x86] invpcid intrinsic

Author: gbuella Date: Thu May 24 23:34:42 2018 New Revision: 333256 URL: http://llvm.org/viewvc/llvm-project?rev=333256&view=rev Log: [x86] invpcid intrinsic An intrinsic for an old instruction, as described in the Intel SDM. Reviewers: craig.topper, rnk Reviewed By: craig.topper, rnk Differen

[PATCH] D47142: [x86] invpcid intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL333256: [x86] invpcid intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47142?vs=148341&id=148547#toc Repositor

[PATCH] D44888: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation

shiva0217 updated this revision to Diff 148548. Repository: rL LLVM https://reviews.llvm.org/D44888 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-features.c Index: test/Driver/riscv-features.c =

[PATCH] D44888: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation

shiva0217 added a comment. In https://reviews.llvm.org/D44888#995, @asb wrote: > In https://reviews.llvm.org/D44888#920, @shiva0217 wrote: > > > In https://reviews.llvm.org/D44888#1109361, @asb wrote: > > > > > This is looking good to me, just needs an update to address this > > >

[PATCH] D47090: Implement C++17 .

Quuxplusone abandoned this revision. Quuxplusone added a comment. I'm re-submitting this as a series of smaller patches that first bring `` up to date with C++17, and then copy it over to ``. In order, these smaller patches are: https://reviews.llvm.org/D46806 https://reviews.llvm.org/D47109 ht

[PATCH] D46807: Rename test_memory_resource.hpp -> test_experimental_memory_resource.hpp. NFC.

Quuxplusone abandoned this revision. Quuxplusone added a comment. This is now part of https://reviews.llvm.org/D47360. Repository: rCXX libc++ https://reviews.llvm.org/D46807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

<    1   2