jbcoe added a comment.
I will try to commit this today.
Repository:
rC Clang
https://reviews.llvm.org/D46383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
In https://reviews.llvm.org/D46520#1092233, @rnk wrote:
> Please don't do this, this is actually really problematic, since `#line`
> directives lose information about what's a system header. That means the
> result of -E usually won't compile, since Windows headers are typ
SimeonEhrig added a comment.
Okay, I will close the request and thank you very much for your help and your
hints.
https://reviews.llvm.org/D44435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
devnexen added a comment.
ping
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rja accepted this revision.
rja added a comment.
LG
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GBuella updated this revision to Diff 145876.
https://reviews.llvm.org/D46541
Files:
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGen/target-features-error-2.c
test/CodeGen/target-features-error.c
Index: test/CodeGen/target-features
GBuella added a comment.
In https://reviews.llvm.org/D46540#1091625, @Hahnfeld wrote:
> Could you maybe add some short summaries to your patches? It's hard for
> non-Intel employees to guess what all these instructions do...
Well, I was thinking I could copy-paste this from
https://software.i
Lekensteyn abandoned this revision.
Lekensteyn added a comment.
Per discussion in https://reviews.llvm.org/D46521, resolving symlinks might
introduce issues that are are worse than the issue that was solved here. It
seems better to carry this patch downstream (in Debian) since the problem only
Author: atanasyan
Date: Wed May 9 01:42:30 2018
New Revision: 331856
URL: http://llvm.org/viewvc/llvm-project?rev=331856&view=rev
Log:
[driver] Add mips_Features_Group to Options to improve documentation sorting
Move all of the MIPS-only options into a new m_mips_Features_Group.
Nearly all other
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331856: [driver] Add mips_Features_Group to Options to
improve documentation sorting (authored by atanasyan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
atanasyan added a comment.
Committed at https://reviews.llvm.org/rL331856.
Thanks for the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D46450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: krasimir
Date: Wed May 9 02:02:11 2018
New Revision: 331857
URL: http://llvm.org/viewvc/llvm-project?rev=331857&view=rev
Log:
[clang-format] Respect BreakBeforeClosingBrace while calculating length
Summary:
This patch makes `getLengthToMatchingParen` respect the
`BreakBeforeClosingBrace
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331857: [clang-format] Respect BreakBeforeClosingBrace while
calculating length (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46519?vs=145677&id=145881#toc
R
r.stahl created this revision.
r.stahl added reviewers: alexfh, NoQ, george.karpenkov.
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
Fixes issue introduced by https://reviews.llvm.org/rC331556.
Closes bug: https://bugs.llvm.org/show_bug.cgi?id=37357
Repository:
rC Clang
Author: mstorsjo
Date: Wed May 9 02:11:01 2018
New Revision: 331858
URL: http://llvm.org/viewvc/llvm-project?rev=331858&view=rev
Log:
Revert "[Driver] Use -fuse-line-directives by default in MSVC mode"
This reverts commit SVN r331666.
It was afterwards pointed out in https://reviews.llvm.org/D4
ilya-biryukov updated this revision to Diff 145883.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Renames and other comments
- Don't include brief comments in signature help either, comments there are
also handled by the code completion code now.
Repository:
ilya-biryukov added inline comments.
Comment at: clangd/CodeCompletionStrings.h:24
+/// Gets a raw documentation comment of \p Result.
+/// Returns empty string when no comment is available.
sammccall wrote:
> What does raw mean - range of the file? indentation
mstorsjo closed this revision.
mstorsjo added a comment.
Reverted in SVN r331858.
Repository:
rL LLVM
https://reviews.llvm.org/D46520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: hans
Date: Wed May 9 02:29:58 2018
New Revision: 331861
URL: http://llvm.org/viewvc/llvm-project?rev=331861&view=rev
Log:
Revert r331843 "[DebugInfo] Generate debug information for labels."
It broke the Chromium build (see reply on the review).
> Generate DILabel metadata and call llvm.
hans added a comment.
This broke the Chromium build. I've uploaded a reproducer at
https://bugs.chromium.org/p/chromium/issues/detail?id=841170#c1
I'm guessing maybe a Clang bootstrap with debug info might also reproduce the
problem, but I haven't tried that.
Reverted in r331861.
Repository:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thank you for the fix!
LG
The fix looks trivial and I'll commit your patch to unblock our internal
release. If there are comments from other reviewers, they can be resolved
post-commit.
Rep
ilya-biryukov updated this revision to Diff 145890.
ilya-biryukov added a comment.
- Moved tests to clang
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46002
Files:
clangd/ClangdUnit.cpp
clangd/CodeComplete.cpp
Index: clangd/CodeComplete.cpp
=
dstenb added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D44568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dstenb added reviewers: bruno, vsapsai.
dstenb added subscribers: bruno, vsapsai.
dstenb added a comment.
@bruno, @vsapsai: I added you since you I saw that you recently reviewed,
respectively delivered, https://reviews.llvm.org/D30881. That is the only
DependencyFile commit since October; altho
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1494
+def NoStackProtector : InheritableAttr {
+ let Spellings = [GCC<"no_stack_protector">];
+ let Subjects = SubjectList<[Function]>;
rnk wrote:
> aaron.ballman wrote:
> > manojgupta
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit.
Comment at: unittests/Lex/PPCallbacksTest.cpp:53
+this->Imported = Imported;
+this->FileType = FileType;
}
Ca
Author: alexfh
Date: Wed May 9 05:27:21 2018
New Revision: 331870
URL: http://llvm.org/viewvc/llvm-project?rev=331870&view=rev
Log:
Fixes issue introduced by r331556.
Closes bug: https://bugs.llvm.org/show_bug.cgi?id=37357
Patch by Rafael Stahl!
Differential revision: https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331870: Fixes issue introduced by r331556. (authored by
alexfh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46633?vs=145880&id=145899#toc
lebedev.ri planned changes to this revision.
lebedev.ri added inline comments.
Comment at: docs/clang-tidy/index.rst:762
+
+To enable profiling info collection, use ``-enable-check-profile`` argument.
+The timings will be outputted to the ``stderr`` as a table. Example output:
--
lebedev.ri updated this revision to Diff 145900.
lebedev.ri retitled this revision from "[Support] Print TimeRecord as CSV" to
"[Support] TimerGroup changes".
lebedev.ri edited the summary of this revision.
lebedev.ri added a reviewer: NoQ.
lebedev.ri added subscribers: xazax.hun, szepet, a.sidori
lebedev.ri updated this revision to Diff 145901.
lebedev.ri retitled this revision from "[clang-tidy] Store checks profiling
info as CSV files" to "[clang-tidy] Store checks profiling info as YAML files".
lebedev.ri added reviewers: george.karpenkov, NoQ.
lebedev.ri added a comment.
- Deduplicate
Author: nico
Date: Wed May 9 05:38:51 2018
New Revision: 331871
URL: http://llvm.org/viewvc/llvm-project?rev=331871&view=rev
Log:
Remove unused lit setting, see https://reviews.llvm.org/D46619
Modified:
cfe/trunk/test/lit.site.cfg.py.in
Modified: cfe/trunk/test/lit.site.cfg.py.in
URL:
http
lebedev.ri updated this revision to Diff 145903.
lebedev.ri added a comment.
Add lock to now-public `printJSONValues()`.
I have no understanding of the `static TimerGroupList`,
but this is symmetrical with other [public] `TimerGroup::*print*` methods.
Repository:
rL LLVM
https://reviews.llvm
Author: svenvh
Date: Wed May 9 06:16:17 2018
New Revision: 331874
URL: http://llvm.org/viewvc/llvm-project?rev=331874&view=rev
Log:
[OpenCL] Restrict various keywords in OpenCL C++ mode
Restrict the following keywords in the OpenCL C++ language mode,
according to Sections 2.2 & 2.9 of the OpenCL
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331874: [OpenCL] Restrict various keywords in OpenCL C++
mode (authored by svenvh, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46022?vs=144745&id=145904#toc
Repository:
rC Clan
Author: klimek
Date: Wed May 9 06:20:03 2018
New Revision: 331875
URL: http://llvm.org/viewvc/llvm-project?rev=331875&view=rev
Log:
Do not warn on unused parameters for functions with empty bodies.
If a function has an empty body, all parameters are trivially unused.
Modified:
clang-tools-e
Author: stulova
Date: Wed May 9 06:23:26 2018
New Revision: 331877
URL: http://llvm.org/viewvc/llvm-project?rev=331877&view=rev
Log:
[OpenCL] Add constant address space to __func__ in AST.
Added string literal helper function to obtain the type
attributed by a constant address space.
Also fixed
lebedev.ri updated this revision to Diff 145906.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.
Herald added a subscriber: llvm-commits.
- Produce valid-er YAML.
Repository:
rL LLVM
https://reviews.llvm.org/D46602
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/Cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331877: [OpenCL] Add constant address space to __func__ in
AST. (authored by stulova, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46049?vs
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Although I think `vaarg` is common too. :)
https://reviews.llvm.org/D46601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
lebedev.ri added inline comments.
Comment at: docs/clang-tidy/index.rst:783
+ {
+"time.clang-tidy.readability-function-size.wall": 1.0421266555786133e+00,
+"time.clang-tidy.readability-function-size.user": 9.208840005421e-01,
Hmm, thinking about it a
GBuella added a comment.
In https://reviews.llvm.org/D45616#1067492, @efriedma wrote:
> > The fcmp opcode has no defined behavior with NaN operands in the
> > comparisions handled in this patch.
>
> Could you describe the problem here in a bit more detail? As far as I know,
> the LLVM IR fcmp
yvvan marked 3 inline comments as done.
yvvan added a comment.
I have some failing tests... So I will update the diff a bit later (Friday most
likely)
Comment at: include/clang/Sema/CodeCompleteConsumer.h:564
+
+ /// \brief For this completion result correction is required.
+
Author: abataev
Date: Wed May 9 07:15:18 2018
New Revision: 331879
URL: http://llvm.org/viewvc/llvm-project?rev=331879&view=rev
Log:
[OPENMP] Mark global tors/dtors as used.
If the global variables are marked as declare target and they need
ctors/dtors, these ctors/dtors are emitted and then inv
alexfh added a comment.
In https://reviews.llvm.org/D46602#1092111, @rja wrote:
> +1 for JSON
Could you explain why would you use YAML or JSON for this? How are you going to
use/process this data?
Repository:
rL LLVM
https://reviews.llvm.org/D46602
_
alexfh added a comment.
Roman, it looks to me that a simpler storage scheme would be sufficient. For
example, MMDDhhmmss-InputFileName.cpp.csv. Main things are: 1. include a
timestamp, so there's no need to overwrite old results, 2. include just the
name of the file without any parent direc
lebedev.ri added a comment.
In https://reviews.llvm.org/D46602#1092883, @alexfh wrote:
> In https://reviews.llvm.org/D46602#1092111, @rja wrote:
>
> > +1 for JSON
>
>
> Could you explain why would you use YAML or JSON for this? How are you going
> to use/process this data?
I personally don't h
alexfh added a comment.
I wonder why JSON? What kind of a tool do folks use to process the outputs of
printJSONValue? Is there anything existing or is JSON used "just in case"? I
personally use either spreadsheets, python or shell when I deal with this kind
of data, and all three of them can wo
lebedev.ri added a comment.
In https://reviews.llvm.org/D46602#1092890, @alexfh wrote:
> Roman, it looks to me that a simpler storage scheme would be sufficient. For
> example, MMDDhhmmss-InputFileName.cpp.csv.
> Main things are:
>
> 1. include a timestamp, so there's no need to overwrite o
ilya-biryukov created this revision.
ilya-biryukov added reviewers: bkramer, aaron.ballman, sammccall.
This change fixes lack of completions in the following case
('^'designates completion points) :
void f(^);
struct Incomplete;
Incomplete g(^);
Repository:
rC Clang
https://reviews.llv
lebedev.ri added a comment.
In https://reviews.llvm.org/D46602#1092902, @lebedev.ri wrote:
> In https://reviews.llvm.org/D46602#1092890, @alexfh wrote:
>
> > Roman, it looks to me that a simpler storage scheme would be sufficient.
> > For example, MMDDhhmmss-InputFileName.cpp.csv.
> > Main
alexfh added inline comments.
Comment at: clang-tidy/modernize-use-auto-min-type-name-length.cpp:61-83
+long int li = static_cast(foo());
+// CHECK-FIXES-0-0: auto li = {{.*}}
+// CHECK-FIXES-0-5: auto li = {{.*}}
+// CHECK-FIXES-1-0: auto li = {{.*}}
+// CHE
Author: shiva
Date: Tue May 8 19:41:56 2018
New Revision: 331843
URL: http://llvm.org/viewvc/llvm-project?rev=331843&view=rev
Log:
[DebugInfo] Generate debug information for labels.
Generate DILabel metadata and call llvm.dbg.label after label
statement to associate the metadata with the label.
pfultz2 updated this revision to Diff 145925.
pfultz2 added a comment.
Some changes based on feedback.
https://reviews.llvm.org/D46159
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/
yaxunl created this revision.
yaxunl added a reviewer: rjmccall.
Some targets have constant address space (e.g. amdgcn). For them string literal
should be
emitted in constant address space then casted to default address space.
https://reviews.llvm.org/D46643
Files:
lib/CodeGen/CGDecl.cpp
l
juliehockett updated this revision to Diff 145934.
juliehockett added a comment.
Adding test
https://reviews.llvm.org/D46614
Files:
include/clang/Lex/PPCallbacks.h
include/clang/Lex/PreprocessingRecord.h
lib/CodeGen/MacroPPCallbacks.cpp
lib/CodeGen/MacroPPCallbacks.h
lib/Frontend/Depe
aaron.ballman added inline comments.
Comment at: unittests/Lex/PPCallbacksTest.cpp:142-143
// the InclusionDirective callback.
- CharSourceRange InclusionDirectiveFilenameRange(const char* SourceText,
- const char* HeaderPath, bool SystemHeader) {
+ InclusionDirectiveC
juliehockett updated this revision to Diff 145941.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing formatting and tests.
https://reviews.llvm.org/D46614
Files:
include/clang/Lex/PPCallbacks.h
include/clang/Lex/PreprocessingRecord.h
lib/CodeGen/MacroPPCa
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
https://reviews.llvm.org/D46614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett added a comment.
This will break things in clang-tools-extra without
https://reviews.llvm.org/D46615, so I'm going to hold off landing this until
that goes through
https://reviews.llvm.org/D43341
___
cfe-commits mailing list
cfe-commi
craig.topper added a comment.
This looks pretty good to me. @echristo what do you think?
https://reviews.llvm.org/D46541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
In https://reviews.llvm.org/D45900#1083377, @rjmccall wrote:
> Oh, I see, it's not that the lifetime intrinsics don't handle pointers in the
> alloca address space, it's that we might have already promoted them into
> `DefaultAS`.
>
> Do the LLVM uses of lifetime intrins
Author: ctopper
Date: Wed May 9 09:57:48 2018
New Revision: 331893
URL: http://llvm.org/viewvc/llvm-project?rev=331893&view=rev
Log:
[X86] Only enable the __ud2 and __int2c builtins if intrin.h has been included.
Differential Revision: https://reviews.llvm.org/D46332
Modified:
cfe/trunk/inc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331893: [X86] Only enable the __ud2 and __int2c builtins if
intrin.h has been included. (authored by ctopper, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46332
Files:
include/clan
rjmccall added a comment.
In https://reviews.llvm.org/D45900#1093154, @yaxunl wrote:
> In https://reviews.llvm.org/D45900#1083377, @rjmccall wrote:
>
> > Oh, I see, it's not that the lifetime intrinsics don't handle pointers in
> > the alloca address space, it's that we might have already promot
Author: yaxunl
Date: Wed May 9 10:07:06 2018
New Revision: 331895
URL: http://llvm.org/viewvc/llvm-project?rev=331895&view=rev
Log:
[OpenCL] Fix typos in emitted enqueue kernel function names
Two typos:
vaarg => vararg
get_kernel_preferred_work_group_multiple =>
get_kernel_preferred_work_group
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331895: [OpenCL] Fix typos in emitted enqueue kernel
function names (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46601
ilya-biryukov added a comment.
In https://reviews.llvm.org/D42966#1085303, @mikhail.ramalho wrote:
> Hi,
>
> > Where do virtual files come from in the first place?
>
> From the linemarker:
I tried dumping locations in presence of line markers.
They have non-null `FileEntry` and a reasonable off
juliehockett added a comment.
In https://reviews.llvm.org/D43341#1093117, @juliehockett wrote:
> This will break things in clang-tools-extra without
> https://reviews.llvm.org/D46615, so I'm going to hold off landing this until
> that goes through
Oops wrong patch disregard
https://reviews.
juliehockett added a comment.
This will break things in clang-tools-extra without
https://reviews.llvm.org/D46615, so I'm going to hold off landing this until
that goes through
https://reviews.llvm.org/D46614
___
cfe-commits mailing list
cfe-commi
bruno added a comment.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D46485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
svenvh created this revision.
svenvh added reviewers: yaxunl, Anastasia.
Herald added a subscriber: cfe-commits.
Stop crashing on placement new/delete in OpenCL C++ mode, and reject
non-placement new/delete with a diagnostic instead of a crash.
Repository:
rC Clang
https://reviews.llvm.org/D4
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a minor nit, LGTM (no need for more review, you can fix the nit and
commit).
Comment at: clang-move/ClangMove.cpp:135
+ con
Author: abataev
Date: Wed May 9 11:02:37 2018
New Revision: 331899
URL: http://llvm.org/viewvc/llvm-project?rev=331899&view=rev
Log:
[OPENMP] Generate unique names for offloading regions id.
It is required to emit unique names for offloading regions ids. Required
to support compilation and linki
mikerice created this revision.
mikerice added reviewers: rnk, thakis, erichkeane, cfe-commits.
Implement support for MS-style PCH through headers.
This enables support for /Yc and /Yu where the through header is either
on the command line or included in the source. It replaces the current
suppo
george.karpenkov added a comment.
Looks good, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D46633
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
The part about string literals looks fine, but:
Comment at: lib/CodeGen/CGDecl.cpp:1375
+Loc = Address(EmitCastToVoidPtrInAllocaAddrSpace(Loc.getPointer()),
+ Loc.getAlignment());
I don't understand why a patch a
Author: juliehockett
Date: Wed May 9 11:27:33 2018
New Revision: 331904
URL: http://llvm.org/viewvc/llvm-project?rev=331904&view=rev
Log:
[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective
Adding a SrcMgr::CharacteristicKind parameter to the InclusionDirective
in PPCallbacks, a
Author: juliehockett
Date: Wed May 9 11:27:37 2018
New Revision: 331905
URL: http://llvm.org/viewvc/llvm-project?rev=331905&view=rev
Log:
[tools] Updating PPCallbacks::InclusionDirective calls
[revision] added SrcMgr::CharacteristicKind to the InclusionDirective
callback, this revision updates i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331904: [clang] Adding CharacteristicKind to
PPCallbacks::InclusionDirective (authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
This revision was automatically updated to reflect the committed changes.
juliehockett marked an inline comment as done.
Closed by commit rL331905: [tools] Updating PPCallbacks::InclusionDirective
calls (authored by juliehockett, committed by ).
Herald added subscribers: llvm-commits, ilya-biryuko
rjmccall added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:2030
+ }
+}
I think a better interpretation of this rule would be to just error on attempts
to use the standard non-placement operator new/delete instead of trying to
outlaw the ope
vsapsai added a comment.
In https://reviews.llvm.org/D45470#1092260, @jfb wrote:
> In https://reviews.llvm.org/D45470#1092212, @vsapsai wrote:
>
> > Here is another approach that should emit an error only when mixing headers
> > causes compilation problems.
> >
> > Have no ideas how to test the
juliehockett added inline comments.
Comment at: docs/ReleaseNotes.rst:116
+
+ Checks for allowed system includes and suggests removal of any others. If no
+ includes are specified, the check will exit without issuing any warnings.
Eugene.Zelenko wrote:
> Is it
juliehockett updated this revision to Diff 145978.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Updating the inclusiondirective to filter out non-system files
https://reviews.llvm.org/D43778
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaT
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX331910: Allow copy elision in path concatenation (authored
by xbolva00, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D46593
Files:
include/experimental/filesystem
Index: incl
craig.topper created this revision.
craig.topper added a reviewer: spatel.
Currently we emit something like
rotl(x, n) {
n &= bitwidth -1;
return n != 0 ? ((x << n) | (x >> (bitwidth - n)) : x;
}
We use a select to avoid the undefined behavior on the (bitwidth - n) shift.
The middle and backend
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1375
+Loc = Address(EmitCastToVoidPtrInAllocaAddrSpace(Loc.getPointer()),
+ Loc.getAlignment());
rjmccall wrote:
> I don't understand
benhamilton created this revision.
benhamilton added reviewers: alexfh, Wizard, hokein.
Herald added a subscriber: cfe-commits.
Previously, `google-readability-casting` would trigger for
Objective-C++ code using C-style casts to or from Objective-C object
types.
The official Google Objective-C st
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM - thanks!
https://reviews.llvm.org/D46656
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
manojgupta updated this revision to Diff 145988.
manojgupta added a comment.
Updated test case for error msg with arguments.
Updated the documentation.
Repository:
rC Clang
https://reviews.llvm.org/D46300
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/Co
benhamilton added a comment.
An alternative implementation would be to allow C-style casts (either always or
only for ObjC objects) within Objective-C methods inside Objective-C++ files,
but that may get messy with things like shared macros.
Repository:
rCTE Clang Tools Extra
https://review
leonardchan updated this revision to Diff 145993.
leonardchan added a comment.
- Restrict usage of fixed point types only to C
https://reviews.llvm.org/D46084
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Basic/DiagnosticC
lebedev.ri updated this revision to Diff 145994.
lebedev.ri added a comment.
- Use sane (not the same as the one right before..) suffix for when
json-printing mem usage. Admittedly, i haven't tried it, but it just does not
make sense otherwise.
Repository:
rL LLVM
https://reviews.llvm.org/D
lebedev.ri updated this revision to Diff 145995.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.
- Make json less flat, store source filename in it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46602
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/C
smeenai added a comment.
Yeah, I think we all agree now that a portability warning isn't really
tractable. Note that even for the warnings that motivated this diff, they
should have only fired if `size_t` and NSInteger had separate types, so it
wasn't a portability warning in that sense to begi
> On May 9, 2018, at 1:25 PM, Shoaib Meenai via Phabricator
> wrote:
>
> smeenai added a comment.
>
> Yeah, I think we all agree now that a portability warning isn't really
> tractable. Note that even for the warnings that motivated this diff, they
> should have only fired if `size_t` and N
efriedma added a comment.
There is no difference between "signalling" and "non-signalling" unless you're
using "#pragma STDC FENV_ACCESS", which is currently not supported. Presumably
the work to implement that will include some LLVM IR intrinsic which can encode
the difference, but for now we
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D46300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
manojgupta added a comment.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 162 matches
Mail list logo
