aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Aside from a minor nit, LGTM (no need for more review, you can fix the nit and commit). ================ Comment at: clang-move/ClangMove.cpp:135 + const clang::Module * /*Imported*/, + SrcMgr::CharacteristicKind FileType) override { if (const auto *FileEntry = SM.getFileEntryForID(SM.getFileID(HashLoc))) ---------------- Put `FileType` into comments so the parameter is unnamed like the other unused ones. https://reviews.llvm.org/D46615 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits