[PATCH] D46112: Allow _Atomic to be specified on incomplete types

rsmith added inline comments. Comment at: lib/Sema/SemaType.cpp:8022 +else if (LangOpts.CPlusPlus && isCompleteType(Loc, T) && + !T.isTriviallyCopyableType(Context)) // Some other non-trivially-copyable type (probably a C++ class) efriedma

[PATCH] D46109: [ARM, AArch64] Add intrinsics for dot product instructions

flyingforyou added inline comments. Comment at: test/CodeGen/arm-neon-dot-product.c:1 +// RUN: %clang_cc1 -triple armv8-linux-gnueabihf -target-cpu cortex-a57 -target-feature +dotprod \ +// RUN: -disable-O0-optnone -emit-llvm -o - %s | opt -S -instcombine | FileCheck %s --

[PATCH] D46109: [ARM, AArch64] Add intrinsics for dot product instructions

efriedma added inline comments. Comment at: test/CodeGen/arm-neon-dot-product.c:1 +// RUN: %clang_cc1 -triple armv8-linux-gnueabihf -target-cpu cortex-a57 -target-feature +dotprod \ +// RUN: -disable-O0-optnone -emit-llvm -o - %s | opt -S -instcombine | FileCheck %s --

[PATCH] D45713: [libclang] Fix the type of 'int (Foo);'

strager added a comment. Ping! I'd like a code review for this bug fix. Repository: rC Clang https://reviews.llvm.org/D45713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46109: [ARM, AArch64] Add intrinsics for dot product instructions

flyingforyou added inline comments. Comment at: test/CodeGen/arm-neon-dot-product.c:1 +// RUN: %clang_cc1 -triple armv8-linux-gnueabihf -target-cpu cortex-a57 -target-feature +dotprod \ +// RUN: -disable-O0-optnone -emit-llvm -o - %s | opt -S -instcombine | FileCheck %s --

[PATCH] D46155: Add warning flag -Wordered-compare-function-pointers.

efriedma created this revision. efriedma added a reviewer: rsmith. The C standard doesn't allow comparisons like "f1 < f2" (where f1 and f2 are function pointers), but we allow them as an extension. Add awarning flag to control this warning. (Not sure I like the name, but this seems to des

[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

pfultz2 created this revision. pfultz2 added reviewers: aaron.ballman, hokein, ilya-biryukov. Herald added subscribers: cfe-commits, xazax.hun. The alpha checkers can already be enabled using the clang driver, this allows them to be enabled using the clang-tidy as well. This can make it easier to

[PATCH] D46109: [ARM, AArch64] Add intrinsics for dot product instructions

efriedma added inline comments. Comment at: test/CodeGen/arm-neon-dot-product.c:1 +// RUN: %clang_cc1 -triple armv8-linux-gnueabihf -target-cpu cortex-a57 -target-feature +dotprod \ +// RUN: -disable-O0-optnone -emit-llvm -o - %s | opt -S -instcombine | FileCheck %s --

[PATCH] D45814: Fix an assertion when -print-prog-name=

compnerd added a comment. I'm torn on this. The other `-print` options will perform the validation implicitly at the higher level before calling the inner functions. It is certainly reasonable to support that, but, for the common path, this check seems unnecessary (and this function is used e

[PATCH] D46165: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl

bruno created this revision. bruno added a reviewer: rsmith. Herald added a subscriber: jkorous. Support for ObjC/C ODR-like semantics with structural equivalence checking was added back in r306918. There enums are handled and also checked for structural equivalence. However, at use time of Enum

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang https://reviews.llvm.org/D45382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r331010 - [Driver] Don't enable "-fregister-global-dtors-with-atexit" by default

Author: ahatanak Date: Thu Apr 26 18:42:33 2018 New Revision: 331010 URL: http://llvm.org/viewvc/llvm-project?rev=331010&view=rev Log: [Driver] Don't enable "-fregister-global-dtors-with-atexit" by default when compiling the kernel or kexts. Destructors should be registered with atexit by default

r331013 - Parse A::template B as an identifier rather than as a template-id with no

Author: rsmith Date: Thu Apr 26 19:00:13 2018 New Revision: 331013 URL: http://llvm.org/viewvc/llvm-project?rev=331013&view=rev Log: Parse A::template B as an identifier rather than as a template-id with no template arguments. This fixes some cases where we'd incorrectly accept "A::template B" wh

r331014 - [analyzer] Fix operator delete[] array-type-sub-expression handling.

Author: dergachev Date: Thu Apr 26 19:16:03 2018 New Revision: 331014 URL: http://llvm.org/viewvc/llvm-project?rev=331014&view=rev Log: [analyzer] Fix operator delete[] array-type-sub-expression handling. Avoid crash when the sub-expression of operator delete[] is of array type. This is not the

[PATCH] D46146: [analyzer] pr37152: Fix operator delete[] array-type-sub-expression handling.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL331014: [analyzer] Fix operator delete[] array-type-sub-expression handling. (authored by dergachev, committed by ). Heral

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc updated this revision to Diff 144269. russellmcc added a comment. Responded to review feedback. Improved documentation comments for new options. While adding tests for the other constructor line break styles, I noticed an inconsistency with the way "after colon" behaved with `Constr

r331016 - [CodeGen] Avoid destructing a callee-destructued struct type in a

Author: ahatanak Date: Thu Apr 26 21:21:51 2018 New Revision: 331016 URL: http://llvm.org/viewvc/llvm-project?rev=331016&view=rev Log: [CodeGen] Avoid destructing a callee-destructued struct type in a function if a function delegates to another function. Fix a bug introduced in r328731, which cau

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rC331016: [CodeGen] Avoid destructing a callee-destructued struct type in a (authored by ahatanak, committed by ). Repository: rC Clang https://reviews.llvm.org/D45382 Files: lib/CodeGen/CGCall.cpp

r331017 - Fix typo.

Author: rsmith Date: Thu Apr 26 21:27:26 2018 New Revision: 331017 URL: http://llvm.org/viewvc/llvm-project?rev=331017&view=rev Log: Fix typo. Modified: cfe/trunk/include/clang/Basic/SourceManager.h Modified: cfe/trunk/include/clang/Basic/SourceManager.h URL: http://llvm.org/viewvc/llvm-pro

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc updated this revision to Diff 144280. russellmcc marked an inline comment as done. russellmcc added a comment. Further update doc comments, render rst file https://reviews.llvm.org/D40988 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Continuat

r331019 - Revert "[CodeGen] Avoid destructing a callee-destructued struct type in a"

Author: ahatanak Date: Thu Apr 26 22:56:55 2018 New Revision: 331019 URL: http://llvm.org/viewvc/llvm-project?rev=331019&view=rev Log: Revert "[CodeGen] Avoid destructing a callee-destructued struct type in a" This reverts commit r331016, which broke a windows bot. http://lab.llvm.org:8011/build

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai marked an inline comment as done. HsiangKai added a comment. @chenwj Do you have any comments for this patch? Repository: rC Clang https://reviews.llvm.org/D45045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 144285. yvvan marked 4 inline comments as done. yvvan added a comment. Minor clean-up according to the last comments https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeComplet

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:704 +CXAvailabilityKind Availability, +const std::vector &Corrections) : Allocator(Allocator), CCTUInfo(CCTUInfo), Priority(Priority), ---

<    1   2