compnerd added a comment.

I'm torn on this.  The other `-print` options will perform the validation 
implicitly at the higher level before calling the inner functions.  It is 
certainly reasonable to support that, but, for the common path, this check 
seems unnecessary (and this function is used elsewhere in clang).  There is a 
similar problem that exists with `-print-file-name=`.  We should probably fix 
both at the same time.  Can you also please add a test case for this?


Repository:
  rC Clang

https://reviews.llvm.org/D45814



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to