aaron.ballman added a comment.
In https://reviews.llvm.org/D45835#1073883, @efriedma wrote:
> > If any of those options we care about wind up being changed, there's a good
> > chance we may need to change something on our end anyway, so breaking us is
> > actually useful.
>
> I'm not sure I fol
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
devnexen added a comment.
If anybody can land for me, I would appreciate. Thanks regardless :-)
Repository:
rC Clang
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
t.p.northover updated this revision to Diff 143506.
t.p.northover added a comment.
Moved diagnostic emission next to where the decision is made.
Repository:
rC Clang
https://reviews.llvm.org/D45319
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/CodeGen/CGAtomic.cpp
c
Author: tnorthover
Date: Mon Apr 23 01:16:24 2018
New Revision: 330566
URL: http://llvm.org/viewvc/llvm-project?rev=330566&view=rev
Log:
[Atomics] warn about atomic accesses using libcalls
If an atomic variable is misaligned (and that suspicion is why Clang emits
libcalls at all) the runtime supp
t.p.northover closed this revision.
t.p.northover added a comment.
Ah, I see you approved it before, presumably with the suggested changes. I've
committed as r330566.
Repository:
rC Clang
https://reviews.llvm.org/D45319
___
cfe-commits mailing l
Author: krasimir
Date: Mon Apr 23 01:50:36 2018
New Revision: 330569
URL: http://llvm.org/viewvc/llvm-project?rev=330569&view=rev
Log:
Revert "[clang-format] Improve Incomplete detection for (text) protos"
This reverts commit r330016.
The incomplete detection has too many false positives, picking
whisperity added a comment.
@george.karpenkov @NoQ `bugprone.` as a category sounds nice. It also nicely
corresponds to the Clang-Tidy `bugprone-` category. It would not be nice to
further fragment the "top levels" of checker categories.
I can say with confidence that CodeChecker does not break
hokein updated this revision to Diff 143508.
hokein marked 7 inline comments as done.
hokein added a comment.
Refine the patch and address all review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45717
Files:
clangd/ClangdServer.cpp
clangd/XRefs.cpp
clangd/XRef
hokein added a comment.
I have updated the patch according to offline discussion -- for each symbol, we
will return both decl and def locations (if available, def first) as they seems
to be most sensible to users. We always prefer location from AST over Index
when conflicts.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330571: Use special new Clang flag
'FrontendTimesIsEnabled' instead of 'llvm… (authored by avt77,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
Author: avt77
Date: Mon Apr 23 02:22:30 2018
New Revision: 330571
URL: http://llvm.org/viewvc/llvm-project?rev=330571&view=rev
Log:
Use special new Clang flag 'FrontendTimesIsEnabled' instead of
'llvm::TimePassesIsEnabled' inside -ftime-report feature.
Differential Revision: https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330572: [Solaris] __float128 is supported on Solaris/x86
(authored by ro, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41240?vs=127348&id=1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330573: Format closing braces when reformatting the line
containing the opening brace. (authored by klimek, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
Author: klimek
Date: Mon Apr 23 02:34:26 2018
New Revision: 330573
URL: http://llvm.org/viewvc/llvm-project?rev=330573&view=rev
Log:
Format closing braces when reformatting the line containing the opening brace.
This required a couple of yaks to be shaved:
1. MatchingOpeningBlockLineIndex was mis
Author: krasimir
Date: Mon Apr 23 03:02:59 2018
New Revision: 330574
URL: http://llvm.org/viewvc/llvm-project?rev=330574&view=rev
Log:
[clang-format] Fix clang-tidy readability problems, NFCI
Modified:
cfe/trunk/lib/Format/BreakableToken.h
cfe/trunk/lib/Format/NamespaceEndCommentsFixer.cp
Author: miyuki
Date: Mon Apr 23 03:08:46 2018
New Revision: 330575
URL: http://llvm.org/viewvc/llvm-project?rev=330575&view=rev
Log:
[CodeGen] Reland r330442: Add an option to suppress output of llvm.ident
The test case in the original patch was overly contrained and
failed on PPC targets.
Added
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie.
The following code is currently accepted without a diagnostic when it should be
prohibited:
void f(const int *ptr) {
__sync_fetch_and_add(ptr, 1);
}
NB: the above code is diagnosed by GCC and ICC. Howe
Author: ro
Date: Mon Apr 23 02:28:08 2018
New Revision: 330572
URL: http://llvm.org/viewvc/llvm-project?rev=330572&view=rev
Log:
[Solaris] __float128 is supported on Solaris/x86
When rebasing https://reviews.llvm.org/D40898 with GCC 5.4 on Solaris 11.4, I
ran
into a few instances of
In file inc
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, modulo a tiny commenting nit.
Comment at: lib/Lex/Lexer.cpp:1667
+ // Note that code completion token is not added as a separate character
+ //
Author: svenvh
Date: Mon Apr 23 04:23:47 2018
New Revision: 330579
URL: http://llvm.org/viewvc/llvm-project?rev=330579&view=rev
Log:
[OpenCL] Reject virtual functions for OpenCL C++
Differential Revision: https://reviews.llvm.org/D45873
Added:
cfe/trunk/test/Parser/opencl-cxx-virtual.cl
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330579: [OpenCL] Reject virtual functions for OpenCL C++
(authored by svenvh, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45873?vs=143330&id=143524#toc
Repository:
rC Clang
ht
lebedev.ri added a comment.
Please always upload all patches with full context (`-U9`)
https://reviews.llvm.org/D45944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:226
+DiagnosticBuilder &Diag) {
+ if (getLangOpts().CPlusPlus11) {
+StringRef NewFuncName = (Name[0] != 'w') ? "strncpy_s" : "wcsncpy_s";
Charusso wrote
aaron.ballman updated this revision to Diff 143526.
aaron.ballman added a comment.
Updated with more context.
https://reviews.llvm.org/D45944
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/builtins.c
Index: test/Sema/builtins.c
aaron.ballman added a comment.
In https://reviews.llvm.org/D45944#1075055, @lebedev.ri wrote:
> Please always upload all patches with full context (`-U9`)
I'm not keen on uploading patches with that much context. For instance, it
disables syntax highlighting in Phab for many of our files.
Author: klimek
Date: Mon Apr 23 04:47:59 2018
New Revision: 330580
URL: http://llvm.org/viewvc/llvm-project?rev=330580&view=rev
Log:
Fix tests after changes to clang-format in r330573.
We do now both:
- stop reformatting a sequence after a closing brace in more cases, in
order to not misindent
avt77 reopened this revision.
avt77 added a comment.
This revision is now accepted and ready to land.
It's terrible but my new test was failed again as result of commit of this
patch!
///b/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/clang/test/Frontend/ftime-report-template-decl.cpp:155:11
krytarowski added subscribers: joerg, krytarowski.
krytarowski added a comment.
Does it work for you for 32-bit? @joerg opposed adoption of 32-bit version as
it seemed to be unimplemented..
Repository:
rL LLVM
https://reviews.llvm.org/D41240
___
Author: henrywong
Date: Mon Apr 23 06:36:51 2018
New Revision: 330589
URL: http://llvm.org/viewvc/llvm-project?rev=330589&view=rev
Log:
[analyzer] CStringChecker.cpp - Code refactoring on bug report.
Reviewers: NoQ, george.karpenkov, xazax.hun
Reviewed By: george.karpenkov
Differential Revis
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330589: [analyzer] CStringChecker.cpp - Code refactoring on
bug report. (authored by henrywong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44557?vs=138682&id=143545#toc
Reposito
a.sidorin marked 2 inline comments as done.
a.sidorin added a comment.
Thank you Gabor!
Comment at: unittests/AST/ASTImporterTest.cpp:356
+ ImportAction(StringRef FromFilename, StringRef ToFilename,
+ const std::string &DeclName)
+ : FromFilename(FromFilenam
In any case, when you see a test failing on bots and the fix isn't obvious,
revert first to get the bots back green.
On Mon, Apr 23, 2018 at 8:54 AM, Andrew V. Tischenko via Phabricator via
cfe-commits wrote:
> avt77 reopened this revision.
> avt77 added a comment.
> This revision is now accepte
sammccall added a comment.
Thanks for the changes! I still find the logic quite confusing. Happy to chat
offline if useful.
Comment at: clangd/XRefs.cpp:137
+
+IdentifiedSymbol getSymbolAtPosition(ParsedAST &AST, SourceLocation Pos) {
+ auto DeclMacrosFinder = std::make_share
Author: d0k
Date: Mon Apr 23 07:30:21 2018
New Revision: 330595
URL: http://llvm.org/viewvc/llvm-project?rev=330595&view=rev
Log:
[index] Fix methods that take a shared_ptr to just take a reference.
There is no ownership here, passing a shared_ptr just adds confusion. No
functionality change inte
Author: d0k
Date: Mon Apr 23 07:30:21 2018
New Revision: 330595
URL: http://llvm.org/viewvc/llvm-project?rev=330595&view=rev
Log:
[index] Fix methods that take a shared_ptr to just take a reference.
There is no ownership here, passing a shared_ptr just adds confusion. No
functionality change inte
mstorsjo updated this revision to Diff 143558.
mstorsjo retitled this revision from "[WIP] [GCC] Match a GCC version with a
patch suffix without a third version component" to "[GCC] Match a GCC version
with a patch suffix without a third version component".
mstorsjo edited the summary of this rev
mstorsjo created this revision.
mstorsjo added reviewers: sepavloff, hfinkel, hans, rnk.
If -no-canonical-prefixes isn't used, the clang executable name used is the one
of the actual executable, not the name of the symlink that the user invoked.
In these cases, the target prefix was overridden
bjope added a comment.
In https://reviews.llvm.org/D45619#1075089, @avt77 wrote:
> It's terrible but my new test was failed again as result of commit of this
> patch!
>
> ///b/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/clang/test/Frontend/ftime-report-template-decl.cpp:155:11:
> error: e
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330596: [analyzer] Move `TaintBugVisitor` from
`GenericTaintChecker.cpp` to… (authored by henrywong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45682?vs=142621&id=143561#toc
Rep
Author: henrywong
Date: Mon Apr 23 07:41:17 2018
New Revision: 330596
URL: http://llvm.org/viewvc/llvm-project?rev=330596&view=rev
Log:
[analyzer] Move `TaintBugVisitor` from `GenericTaintChecker.cpp` to
`BugReporterVisitors.h`.
Summary: `TaintBugVisitor` is a universal visitor, and many checker
miyuki created this revision.
miyuki added a reviewer: eli.friedman.
Herald added subscribers: chrib, kristof.beyls, eraman, rengolin.
Herald added a reviewer: javed.absar.
The getConstraintRegister method is used by semantic checking of
inline assembly statements in order to diagnose conflicts be
ddunbar added a comment.
In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote:
> I don't think this is quite right. I know at least `make`-based incremental
> builds wouldn't deal well with this.
This is actually not a novel problem w.r.t. this patch. The exact same
situation comes
thakis created this revision.
thakis added a reviewer: JDevlieghere.
Herald added a subscriber: mgorny.
It used to symlink `dsymutil` to `llvm-dsymutil`, but after r327790 llvm's
dsymutil binary is now called dsymutil without prefix.
r327792 then reversed the direction of the symlink if
LLVM_IN
Author: d0k
Date: Mon Apr 23 07:58:18 2018
New Revision: 330599
URL: http://llvm.org/viewvc/llvm-project?rev=330599&view=rev
Log:
[clangd] Prune some dead declarations. No functionality change.
Modified:
clang-tools-extra/trunk/clangd/Diagnostics.h
clang-tools-extra/trunk/clangd/Trace.h
avt77 added a comment.
In https://reviews.llvm.org/D45619#1075260, @thakis wrote:
> In any case, when you see a test failing on bots and the fix isn't obvious,
> revert first to get the bots back green.
I reverted it immediatly.
Repository:
rL LLVM
https://reviews.llvm.org/D45619
_
avt77 added a comment.
In https://reviews.llvm.org/D45619#1075385, @bjope wrote:
> Anyway, if the order isn't deteministic, then a solution could be to use
> CHECK-DAG instead of CHECK for the checks that may be reordered. For example:
Thank you very much! I'll try to fix it in this way.
Rep
yvvan updated this revision to Diff 143566.
yvvan added a comment.
Use wrapped FixItHint to keep corrections.
Can be quite easily changed from Optional to some container if required.
https://reviews.llvm.org/D41537
Files:
include/clang-c/Index.h
include/clang/Basic/DiagnosticSemaKinds.td
bjope added a comment.
I can't see that it has been reverted.
But I guess that the table maybe is sorted based on time spent in each pass? So
that is why it might be sorted differently on different buildbots (or when
using pipe etc).
So I think a quick fix is to add -DAG to the checks that can
dexonsmith added a comment.
In https://reviews.llvm.org/D30882#1075407, @ddunbar wrote:
> In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote:
>
> > I don't think this is quite right. I know at least `make`-based
> > incremental builds wouldn't deal well with this.
>
>
> This is actua
Author: nico
Date: Mon Apr 23 08:26:15 2018
New Revision: 330601
URL: http://llvm.org/viewvc/llvm-project?rev=330601&view=rev
Log:
Remove unused code (made unused by r161073, and later more so by r248043).
Modified:
cfe/trunk/tools/diagtool/CMakeLists.txt
Modified: cfe/trunk/tools/diagtool/C
Author: d0k
Date: Mon Apr 23 08:27:42 2018
New Revision: 330602
URL: http://llvm.org/viewvc/llvm-project?rev=330602&view=rev
Log:
[clangd] Fix Context::derive to actually call the right method.
C++ is weird.
Modified:
clang-tools-extra/trunk/clangd/Context.h
Modified: clang-tools-extra/trun
yvvan updated this revision to Diff 143572.
yvvan added a comment.
Use vector instead of optional as Ilya suggested
https://reviews.llvm.org/D41537
Files:
include/clang-c/Index.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/Code
Author: nico
Date: Mon Apr 23 08:41:08 2018
New Revision: 330604
URL: http://llvm.org/viewvc/llvm-project?rev=330604&view=rev
Log:
Fix case of LLVM library names.
Modified:
cfe/trunk/tools/clang-import-test/CMakeLists.txt
Modified: cfe/trunk/tools/clang-import-test/CMakeLists.txt
URL:
http:
Author: a.sidorin
Date: Mon Apr 23 08:41:44 2018
New Revision: 330605
URL: http://llvm.org/viewvc/llvm-project?rev=330605&view=rev
Log:
[analyzer] Don't crash on printing ConcreteInt of size >64 bits
Printing of ConcreteInts with size >64 bits resulted in assertion failure
in get[Z|S]ExtValue() b
a.sidorin closed this revision.
a.sidorin added a comment.
Closed with https://reviews.llvm.org/rC330605. Forgot to mention the
Differential Revision, sorry.
Repository:
rC Clang
https://reviews.llvm.org/D45417
___
cfe-commits mailing list
cfe-c
avt77 added a comment.
In https://reviews.llvm.org/D45619#1075437, @bjope wrote:
> I can't see that it has been reverted.
> But I guess that the table maybe is sorted based on time spent in each pass?
> So that is why it might be sorted differently on different buildbots (or when
> using pipe
asb added a comment.
In https://reviews.llvm.org/D45284#1074282, @apazos wrote:
> Hi Alex, it seems the table expects these extensions in a canonical order
> too: all x extensions, followed by all s extensions, and then all sx
> extensions.
>
> I can make the change, no problem. I have also cod
Author: jkorous
Date: Mon Apr 23 08:55:07 2018
New Revision: 330608
URL: http://llvm.org/viewvc/llvm-project?rev=330608&view=rev
Log:
[clangd][tests] Fix handling of EOF in delimited input
Request in delimited input ended by EOF shouldn't be an error state.
Comments at the end of test file should
Author: jkorous
Date: Mon Apr 23 08:58:42 2018
New Revision: 330609
URL: http://llvm.org/viewvc/llvm-project?rev=330609&view=rev
Log:
[clangd][tests] Fix delimiter handling
Empty line shouldn't be considered a delimiter
Differential Revision: https://reviews.llvm.org/D45764
Added:
clang-too
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330609: [clangd][tests] Fix delimiter handling (authored by
jkorous, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.llvm.org/D45764?vs=142918&id
jkorous closed this revision.
jkorous added a comment.
I forgot to mention review in commit message.
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@330608
91177308-0d34-0410-b5e6-96231b3b80d8
https://reviews.llvm.org/D45763
thopre added inline comments.
Comment at: lib/Basic/Targets/AArch64.h:85-89
+ StringRef getConstraintRegister(StringRef Constraint,
+ StringRef Expression) const override {
+return Expression;
+ }
+
From what I understood of
Author: a.sidorin
Date: Mon Apr 23 09:38:29 2018
New Revision: 330613
URL: http://llvm.org/viewvc/llvm-project?rev=330613&view=rev
Log:
Quick fix for rC330605: specify a target arch for test
Modified:
cfe/trunk/test/Analysis/sval-dump-int128.c
Modified: cfe/trunk/test/Analysis/sval-dump-int
paquette updated this revision to Diff 143584.
paquette added a comment.
Add context to diff.
https://reviews.llvm.org/D45917
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/arm64-outline.c
Index: test/CodeGen/arm64-outline.c
===
pete added a comment.
In https://reviews.llvm.org/D30882#1075461, @dexonsmith wrote:
> In https://reviews.llvm.org/D30882#1075407, @ddunbar wrote:
>
> > In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote:
> >
> > > I don't think this is quite right. I know at least `make`-based
> > >
dexonsmith added a comment.
In https://reviews.llvm.org/D30882#1075576, @pete wrote:
> Oh, that actually wasn't my intention when I wrote it.
>
> Honestly I didn't expect it to log anything for missing paths at all, as we
> don't currently log all the missing (but attempted) paths for regular
>
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8426
+ llvm::Type *BTy = llvm::VectorType::get(CGF.Builder.getInt8Ty(), N * 8);
+ SmallVector ShuffleMask;
+ for (unsigned i = 0; i < N; ++i)
Size the ShuffleMask to N when it's cr
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8431
+ CGF.Builder.CreateZExt(CGF.Builder.CreateShuffleVector(
+ AD, llvm::UndefValue::get(BTy), ShuffleMask),
+ VTy);
Author: abataev
Date: Mon Apr 23 10:33:41 2018
New Revision: 330620
URL: http://llvm.org/viewvc/llvm-project?rev=330620&view=rev
Log:
[OPENMP] Do not cast captured by value variables with pointer types in
NVPTX target.
When generating the wrapper function for the offloading region, we need
to cal
mclow.lists added a comment.
I'm fine with this change, but I'm wondering:
- if there are similar tests in the filesystem test suite, and you haven't
tripped over them because you spelled your error message the same as we did.
- Should part of this test be moved into test/libcxx
https://review
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: bixia.
This looks ready to land to me.
Comment at:
libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:122
+static_asser
rjmccall added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:2342
+ if (isa(Ty))
+return false;
return true;
erik.pilkington wrote:
> rjmccall wrote:
> > rjmccall wrote:
> > > rjmccall wrote:
> > > > I agree with your analysis that this sho
bjope added a comment.
buildbots have been failing all day (and were still failing). So I pushed my
suggested fix.
I hope that was OK.
Repository:
rL LLVM
https://reviews.llvm.org/D45619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
dexonsmith added a comment.
In https://reviews.llvm.org/D30882#1075589, @dexonsmith wrote:
> In https://reviews.llvm.org/D30882#1075576, @pete wrote:
>
> > Would it be ok to turn this on by default, without a flag, only in the case
> > of the path actually existing, and only the found path being
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:70-72
+ if (Bytes.find_if([](char C) {
+return static_cast(C) > 0x7Fu;
+ }) != StringRef::npos)
I think you can use `isASCII()` from CharInfo.h rather th
Author: bjope
Date: Mon Apr 23 11:05:35 2018
New Revision: 330622
URL: http://llvm.org/viewvc/llvm-project?rev=330622&view=rev
Log:
Improve checks in test/Frontend/ftime-report-template-decl.cpp
Some buildbots seems to have problems with the CHECKs in
test/Frontend/ftime-report-template-decl.cpp.
aaron.ballman added a reviewer: rsmith.
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:11284
+ case Stmt::MemberExprClass: {
+const MemberExpr *ME = cast(expr);
+expr = ME->getBase();
Can use `const auto *` here in
BillyONeal added a comment.
In https://reviews.llvm.org/D45715#1075665, @mclow.lists wrote:
> - if there are similar tests in the filesystem test suite, and you haven't
> tripped over them because you spelled your error message the same as we did.
Almost certainly. But we aren't running your f
Author: rsmith
Date: Mon Apr 23 11:38:30 2018
New Revision: 330626
URL: http://llvm.org/viewvc/llvm-project?rev=330626&view=rev
Log:
DR727: remove wrong assertion for use of class-scope explicit
specialization without -fms-extensions.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
cfe/trun
timshen updated this revision to Diff 143610.
timshen added a comment.
Update formatting on static_asserts.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/include/module.modulemap
libcxx/test/libcxx/double_include.sh.c
Author: timshen
Date: Mon Apr 23 11:47:07 2018
New Revision: 330627
URL: http://llvm.org/viewvc/llvm-project?rev=330627&view=rev
Log:
[libcxx] implement declarations based on P0214R7.
Summary:
The patch includes all declarations, and also implements the following features:
* ABI.
* narrowing-con
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330627: [libcxx] implement
declarations based on P0214R7. (authored by timshen, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
joerg added a comment.
Things are different for a libgcc-based toolchain and a compiler-rt based
toolchain.
Repository:
rL LLVM
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
danalbert added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D45291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danalbert added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D45597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danalbert added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D45292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Guys, what do you think about a checker that warns on uninitialized fields only
when at least one field is initialized? I'd be much more confident about
turning such check on by default. We can still keep a `pedantic` version.
> I can say with confidence that CodeChecker do
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangedConstraintManager.h:130
+template <>
+struct ProgramStateTrait
+ : public ProgramStatePartialTrait {
george.karpenkov wrote:
> Why not also `REGISTER_TRAIT_WITH_PROGRAMSTATE` here?
```
33
NoQ added a comment.
In https://reviews.llvm.org/D45920#1074439, @george.karpenkov wrote:
> Another approach would be to instead teach `RangedConstraintManager` to
> convert it's constraints to Z3. That would be an unwanted dependency, but the
> change would be much smaller, and the internals o
Author: nico
Date: Mon Apr 23 12:22:52 2018
New Revision: 330633
URL: http://llvm.org/viewvc/llvm-project?rev=330633&view=rev
Log:
Fix typo in comment.
Modified:
cfe/trunk/tools/libclang/CMakeLists.txt
Modified: cfe/trunk/tools/libclang/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-projec
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:44
+char const *const MultibyteSnowman("\xE2\x98\x83");
+// CHECK-FIXES: {{^}}char const *const MultibyteSnowman("\xE2\x98\x83");{{$}}
IIRC, the default behavi
On Mon, Apr 23, 2018 at 11:53 AM, Andrew V. Tischenko via Phabricator via
cfe-commits wrote:
> avt77 added a comment.
>
> In https://reviews.llvm.org/D45619#1075437, @bjope wrote:
>
> > I can't see that it has been reverted.
> > But I guess that the table maybe is sorted based on time spent in e
NoQ added a comment.
In https://reviews.llvm.org/D45517#1074422, @rnkovacs wrote:
> In https://reviews.llvm.org/D45517#1074057, @NoQ wrote:
>
> > So, yeah, that's a good optimization that we're not invoking the solver on
> > every node. But i don't think we should focus on improving this
> > op
NoQ marked 2 inline comments as done.
NoQ added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:145-147
+ if (Name.endswith_lower(".c") || Name.endswith_lower(".cpp") ||
+ Name.endswith_lower(".cc") || Name.endswith_lo
Author: abataev
Date: Mon Apr 23 12:53:05 2018
New Revision: 330634
URL: http://llvm.org/viewvc/llvm-project?rev=330634&view=rev
Log:
[OPENMP] Formatting and code improvement, NFC.
Modified:
cfe/trunk/lib/Parse/ParseOpenMP.cpp
Modified: cfe/trunk/lib/Parse/ParseOpenMP.cpp
URL:
http://llvm.o
ahatanak updated this revision to Diff 143624.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D45382
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen
vsapsai added a comment.
In https://reviews.llvm.org/D45015#1064930, @EricWF wrote:
> In https://reviews.llvm.org/D45015#1064922, @vsapsai wrote:
>
> > Another approach is `__has_feature` but I don't think it is applicable in
> > this case.
> >
> > Is there a way right now to detect that aligned
Author: timshen
Date: Mon Apr 23 12:56:20 2018
New Revision: 330636
URL: http://llvm.org/viewvc/llvm-project?rev=330636&view=rev
Log:
Revert "[libcxx] implement declarations based on P0214R7."
This reverts commit r330627.
This causes several bots to freak out.
Removed:
libcxx/trunk/include
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D45920#1074437, @george.karpenkov wrote:
> > I could also move RangedConstraintManager.h under include
>
> We probably don't want to do that: currently it can only be impo
1 - 100 of 162 matches
Mail list logo
