mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: bixia.
This looks ready to land to me.
================
Comment at:
libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:122
+static_assert(is_simd_mask_v<fixed_size_simd_mask<float, 32>>, "");
+static_assert(is_simd_mask_v<fixed_size_simd_mask<double, 32>>, "");
+
----------------
Minor formatting nit. When I have stacks of tests like this, I usually leave a
space after the '(', so that positive and negative tests line up, and so I can
see at a glance which are which.
Example:
static_assert( is_simd_mask_v<fixed_size_simd_mask<double, 32>>, "");
static_assert(!is_simd_mask_v<void>, "");
https://reviews.llvm.org/D41148
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
