yvvan added a comment.
Or is your idea is to return the char sequence instead to use this correction
in some universal way?
https://reviews.llvm.org/D41537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
krisb updated this revision to Diff 135375.
krisb added a comment.
Herald added a subscriber: nhaehnle.
Updated one more test where attributes became mismatched.
Repository:
rC Clang
https://reviews.llvm.org/D43570
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOpti
pacxx updated this revision to Diff 135372.
pacxx retitled this revision from "[NameMangling] Make ASTContext owning the
ManglingContext during entire compilation" to "[Indexing] Fixing
inconsistencies between FUNCDNAME and generated code by improving ASTContext's
API for MangleContext".
pacxx e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325760: [libcxx] Do not include the C math.h header before
__config (authored by miyuki, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43579
Author: ioeric
Date: Thu Feb 22 02:14:05 2018
New Revision: 325764
URL: http://llvm.org/viewvc/llvm-project?rev=325764&view=rev
Log:
[clangd] Not collect include headers for dynamic index for now.
Summary:
The new behaviors introduced by this patch:
o When include collection is enabled, we always
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
Thanks for fixing all the comments! LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325764: [clangd] Not collect include headers for dynamic
index for now. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43550
krytarowski created this revision.
krytarowski added reviewers: joerg, rnk.
krytarowski added a project: clang.
Herald added a subscriber: llvm-commits.
GCC and PCC define _PTHREADS for -pthreads
on NetBSD.
The _PTHREADS preprocessor macro is used in
the NetBSD header in .
NetBSD uses both: _REE
sammccall updated this revision to Diff 135382.
sammccall marked an inline comment as done.
sammccall added a comment.
add param names to decls
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43518
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServ
sammccall added a comment.
Not convinced about the flow control stuff - I think you might be
underestimating the complexity of the cancellation-based approach with the
extra functionality.
But if you think it would still be more readable the other way, happy to get a
third opinion.
=
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41537#1015563, @yvvan wrote:
> Or is your idea is to return the char sequence instead to use this correction
> in some universal way?
Exactly. Editors that implement corrections would pick up any new corrections
automatically, rather
Seems safe. Merged in r325766.
On Thu, Feb 22, 2018 at 1:15 AM, Richard Trieu wrote:
> Hi Hans,
>
> If there's still time for rc3, I'd like to get this crash fix in. This adds
> a null check to prevent a crash on invalid.
>
> Richard
>
> On Mon, Feb 5, 2018 at 6:58 PM, Richard Trieu via cfe-comm
oren_ben_simhon updated this revision to Diff 135386.
oren_ben_simhon added a comment.
Implemented comments posted until 02/22 (Thanks Aaron).
Repository:
rL LLVM
https://reviews.llvm.org/D41880
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
oren_ben_simhon marked 2 inline comments as done.
oren_ben_simhon added a comment.
I added a comment ignoring nocf_check attribute in case -fcf-protection is not
set.
Now LLVM is identical to GCC.
Comment at: test/Sema/attr-nocf_check.c:18-20
+ FuncPointerWithNoCfCheck fNoCfC
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.cpp:298
+ while (shouldSkipHeadLocked())
+Requests.pop_front();
+ assert(!Requests.empty() && "skipped the whole queue");
sammccall wrote:
> ilya-biryukov wrote:
> > Instead of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325771: [OpenCL] Add '-cl-uniform-work-group-size'
compile option (authored by AlexeySotkin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43570
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM (just one more possibly useful nit about const)
Comment at: clangd/TUScheduler.cpp:298
+ while (shouldSkipHeadLocked())
+Requests.pop_front();
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a minor nit.
Comment at: clangd/CodeComplete.cpp:705
}
+ CI->getDiagnosticOpts().IgnoreWarnings = true;
auto Clang = prepareCompilerInstance(
-
Author: sammccall
Date: Thu Feb 22 05:11:12 2018
New Revision: 325774
URL: http://llvm.org/viewvc/llvm-project?rev=325774&view=rev
Log:
[clangd] Allow embedders some control over when diagnostics are generated.
Summary:
Through the C++ API, we support for a given snapshot version:
- Yes: make su
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325774: [clangd] Allow embedders some control over when
diagnostics are generated. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
hokein updated this revision to Diff 135399.
hokein added a comment.
- add a comment
- find one more incorrect usage, and fix it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43569
Files:
clangd/CodeComplete.cpp
clangd/Headers.cpp
Index: clangd/Headers.cpp
=
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:705
}
+ CI->getDiagnosticOpts().IgnoreWarnings = true;
auto Clang = prepareCompilerInstance(
ilya-biryukov wrote:
> Could we add a comment that this
alexfh added a reviewer: ioeric.
alexfh added a comment.
In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
> > It seems, when they are apply directly from clang-tidy, the RefactoringTool
> > engine is smart enough to remove trailing tokens. However, when fixes are
> > exported,
Author: hokein
Date: Thu Feb 22 05:35:01 2018
New Revision: 325779
URL: http://llvm.org/viewvc/llvm-project?rev=325779&view=rev
Log:
[clangd] Correct setting ignoreWarnings in CodeCompletion.
Summary:
We should set the flag before creating ComplierInstance -- when
CopmilerInstance gets initialize
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL325779: [clangd] Correct setting ignoreWarnings in
CodeCompletion. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL L
lebedev.ri added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:149
+
+/// \brief Emits a record ID in the BLOCKINFO block.
+void ClangDocBitcodeWriter::emitRecordID(RecordId ID) {
For me, with no prior knowledge of llvm's bitstreams, it was not obvious
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325784: [clangd] DidChangeConfiguration Notification
(authored by simark, committed by ).
Herald added a subscriber: llvm-
asb added a comment.
Herald added a subscriber: shiva0217.
As @efriedma noted in https://reviews.llvm.org/D43106, it would be good to have
some test coverage for ABI lowering. I'd suggest updating
test/Driver/riscv32-abi.c with something like:
#ifdef __SIZEOF_INT128__
// CHECK-FORCEINT128-L
nruslan added a comment.
@hans, @craig.topper, @MatzeB: Can someone commit
https://reviews.llvm.org/D43108 (this) and https://reviews.llvm.org/D43107 on
my behalf? I do not think, I have commit access.
https://reviews.llvm.org/D43108
___
cfe-commi
Out of interest, do you know why the non-experimental version doesn't have
to_string()? What are folks supposed to use instead?
On Mon, Feb 5, 2018 at 6:43 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Feb 5 15:43:34 2018
> New Revision: 32
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2691
+def warn_nocf_check_attribute_ignored :
+ Warning<"nocf_check attribute ignored. Use -fcf-prtection flag to enable
it">,
+ InGroup;
Diagnostics are not complete s
Author: miyuki
Date: Thu Feb 22 01:34:08 2018
New Revision: 325760
URL: http://llvm.org/viewvc/llvm-project?rev=325760&view=rev
Log:
[libcxx] Do not include the C math.h header before __config
Summary:
Certain C libraries require configuration macros defined in __config
to provide the correct fun
Author: AlexeySotkin
Date: Thu Feb 22 03:54:14 2018
New Revision: 325771
URL: http://llvm.org/viewvc/llvm-project?rev=325771&view=rev
Log:
[OpenCL] Add '-cl-uniform-work-group-size' compile option
Summary:
OpenCL 2.0 specification defines '-cl-uniform-work-group-size' option,
which requires that
Author: simark
Date: Thu Feb 22 06:00:39 2018
New Revision: 325784
URL: http://llvm.org/viewvc/llvm-project?rev=325784&view=rev
Log:
[clangd] DidChangeConfiguration Notification
Summary:
Implementation of DidChangeConfiguration notification handling in
clangd. This currently only supports chang
Author: sammccall
Date: Thu Feb 22 07:33:33 2018
New Revision: 325801
URL: http://llvm.org/viewvc/llvm-project?rev=325801&view=rev
Log:
[clangd] fix test use-after-free from r325774
Modified:
clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp
Modified: clang-tools-extra/trunk/unit
robot marked an inline comment as done.
robot added a comment.
Have you had the time to review the second revision?
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D42644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
ikudrin created this revision.
ikudrin added reviewers: phosek, Hahnfeld, logan, rnk.
ikudrin added a project: clang.
Right now, we have to add an `.exe` suffix when using this switch, like
`-fuse-ld=lld.exe`.
If the suffix is omitted, `llvm::sys::fs::exists()` cannot find the file on
Windows,
w
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChain.cpp:415
// second-guess that.
-if (llvm::sys::fs::exists(UseLinker))
+if (llvm::sys::fs::can_execute(UseLinker))
return UseLinker;
I don't think we should do this for absolute pa
ikudrin added inline comments.
Comment at: lib/Driver/ToolChain.cpp:415
// second-guess that.
-if (llvm::sys::fs::exists(UseLinker))
+if (llvm::sys::fs::can_execute(UseLinker))
return UseLinker;
Hahnfeld wrote:
> I don't think we should do thi
I have a small personal project where I used to use this. I tried switching
to instead, but that apparently requires -std=c++17. With that,
things build fine with my locally-built clang, but latest Xcode clang
doesn't accept that flag yet. So I tried -std=c++1z, but latest Xcode (9.2)
doesn't even
carlo.bertolli updated this revision to Diff 135429.
carlo.bertolli added a comment.
[OpenMP] Add regression test: this verifies that only one call to the runtime
for reduction is done in a combined construct with distribute, without simd,
and with at least one pragma accepting reduction as a cl
amccarth added a comment.
This must be new-ish code, since I've routinely used `-fuse-ld=lld` (without
`.exe`) on Windows.
Repository:
rC Clang
https://reviews.llvm.org/D43621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
ABataev added a comment.
LG
Repository:
rC Clang
https://reviews.llvm.org/D43513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rksimon
Date: Thu Feb 22 08:12:27 2018
New Revision: 325802
URL: http://llvm.org/viewvc/llvm-project?rev=325802&view=rev
Log:
Fix "not all control paths return a value" MSVC warning. NFCI.
Modified:
clang-tools-extra/trunk/clangd/TUScheduler.cpp
Modified: clang-tools-extra/trunk/clan
Hahnfeld added a comment.
In https://reviews.llvm.org/D43621#1015888, @amccarth wrote:
> This must be new-ish code, since I've routinely used `-fuse-ld=lld` (without
> `.exe`) on Windows.
Well, since 12/2016: https://reviews.llvm.org/rC289668
Repository:
rC Clang
https://reviews.llvm.org/
gtbercea created this revision.
gtbercea added reviewers: ABataev, carlo.bertolli, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
Remove this scheme for now since it will be covered by another more generic
scheme using global memory. This code will be worked into an optimi
ioeric added a comment.
In https://reviews.llvm.org/D43500#1015208, @jdemeule wrote:
> In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote:
>
> > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
> >
> > > Is there a way to make clang-apply-replacements smarter rath
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:564
+llvm::Value *FnArgs[] = {ZeroAddr.getPointer(), ZeroAddr.getPointer()};
+emitCall(CGF, Fn, FnArgs);
Pass non-null `SourceLocation` here as the last argument
Repositor
Author: hahnfeld
Date: Thu Feb 22 09:06:27 2018
New Revision: 325805
URL: http://llvm.org/viewvc/llvm-project?rev=325805&view=rev
Log:
[docs] Fix duplicate arguments for JoinedAndSeparate
We can't see how many arguments are in the meta var name, so just
assume that it is the right number.
Differ
Author: hahnfeld
Date: Thu Feb 22 09:06:35 2018
New Revision: 325806
URL: http://llvm.org/viewvc/llvm-project?rev=325806&view=rev
Log:
[docs] Improve help for OpenMP options, NFC.
* Add HelpText for -fopenmp so that it appears in clang --help.
* Hide -fno-openmp-simd, only list the positive opt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325805: [docs] Fix duplicate arguments for JoinedAndSeparate
(authored by Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42840?vs=1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325806: [docs] Improve help for OpenMP options, NFC.
(authored by Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42841?vs=132571&id
Author: hahnfeld
Date: Thu Feb 22 09:10:28 2018
New Revision: 325807
URL: http://llvm.org/viewvc/llvm-project?rev=325807&view=rev
Log:
[docs] Regenerate command line reference
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
Modified: cfe/trunk/docs/ClangCommandLineReference.rst
URL:
bjope added inline comments.
Comment at: unittests/Format/FormatTest.cpp:11727
+TEST(FormatStyle, GetStyleWithEmptyFileName) {
+ auto Style1 = getStyle("file", "", "Google");
+ ASSERT_TRUE((bool)Style1);
Do you really want to try to find a ".clang-format" file
erichkeane created this revision.
erichkeane added reviewers: rnk, echristo, aaron.ballman, rsmith.
Herald added subscribers: mgrang, mgorny.
I'm currently working on the cpu_dispatch and cpu_specific multiversion
support, which is making this functionality require a significant amount
of function
jrtc27 created this revision.
Herald added a subscriber: cfe-commits.
When targeting x32, the x32 libraries and headers should be used, not
the x86_64 ones (which may not even be available), so prioritise those
and use the right multiarch triple.
Repository:
rC Clang
https://reviews.llvm.org/
hfinkel added a comment.
In https://reviews.llvm.org/D42366#1014546, @rjmccall wrote:
> In https://reviews.llvm.org/D42366#1014157, @kosarev wrote:
>
> > I think zero would serve better as the unknown-size value. People who are
> > not aware of TBAA internals would guess that since zero-sized ac
juliehockett updated this revision to Diff 135453.
juliehockett marked 13 inline comments as done.
juliehockett added a comment.
Cleaning up bitcode writer
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLists.tx
juliehockett added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:219
+
+void ClangDocBitcodeWriter::emitIntRecord(int Value, RecordId ID) {
+ if (!Value) return;
lebedev.ri wrote:
> Now, all these three `emit*Record` functions now have the 'same signa
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
This would allow us to disable diagnostics when didChange is called but
diagnostics are not wanted (e.g. code completion).
Repository:
rCTE Clang Tools
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, this will be useful for at least a couple of editor integrations.
Comment at: clangd/Protocol.h:301
+
+ /// If this is not set, diagnostics will be generated fo
amccarth added a comment.
> Right now, we have to add an .exe suffix when using this switch, like
> -fuse-ld=lld.exe.
That's weird, because lots of lldb tests compile and link test binaries on
Windows with `-fuse-ld=lld` (without the `.exe`). What makes you say the
`.exe` is necessary?
Repo
Author: abataev
Date: Thu Feb 22 10:33:31 2018
New Revision: 325812
URL: http://llvm.org/viewvc/llvm-project?rev=325812&view=rev
Log:
[OPENMP] Require valid SourceLocation in function call, NFC.
Removed default empty SourceLocation argument from `emitCall` function
and require valid location.
Mo
ioeric updated this revision to Diff 135463.
ioeric marked 2 inline comments as done.
ioeric added a comment.
Addressed review comments. Removed test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43634
Files:
clangd/ClangdLSPServer.cpp
clangd/Protocol.cpp
clangd/Protoco
Author: ioeric
Date: Thu Feb 22 10:40:39 2018
New Revision: 325813
URL: http://llvm.org/viewvc/llvm-project?rev=325813&view=rev
Log:
[clangd] Extend textDocument/didChange to specify whether diagnostics should be
generated.
Summary:
This would allow us to disable diagnostics when didChange is ca
Author: tra
Date: Thu Feb 22 10:40:52 2018
New Revision: 325814
URL: http://llvm.org/viewvc/llvm-project?rev=325814&view=rev
Log:
[CUDA] Added missing functions.
Initial commit missed sincos(float), llabs() and few atomics that we
used to pull in from device_functions.hpp, which we no longer incl
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325813: [clangd] Extend textDocument/didChange to specify
whether diagnostics should be… (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43634?vs=135463&id=1354
ahatanak added inline comments.
Comment at: include/clang/AST/Type.h:1121
+ /// after it is moved, as opposed to a truely destructive move in which the
+ /// source object is placed in an uninitialized state.
+ PrimitiveCopyKind isNonTrivialToPrimitiveDestructiveMove() const;
Wizard created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43640
Files:
clang-tidy/google/GlobalVariableDeclarationCheck.cpp
test/clang-tidy/google-objc-global-variable-declaration.m
Index: test/clang-tidy/goo
Quuxplusone updated this revision to Diff 135484.
Quuxplusone added a reviewer: rsmith.
Quuxplusone added a subscriber: Rakete.
Quuxplusone added a comment.
Eliminate a couple of `auto` per comment by @Rakete.
Repository:
rC Clang
https://reviews.llvm.org/D43322
Files:
include/clan
stephanemoore added a comment.
I have this change out for review as well:
https://reviews.llvm.org/D43581
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
majnemer added a comment.
We should really, really avoid making this sort of change without first trying
to desugar uuidof into a reference to a variable. That would solve a ton of
problems, problems like this one.
https://reviews.llvm.org/D43576
stephanemoore updated this revision to Diff 135489.
stephanemoore added a comment.
I forgot to update the diagnostic message per the change.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43581
Files:
clang-tidy/google/GlobalVariableDeclarationCheck.cpp
test/clang-tidy/goog
Wizard added a comment.
In https://reviews.llvm.org/D43640#1016287, @stephanemoore wrote:
> I have this change out for review as well:
> https://reviews.llvm.org/D43581
Ah cool. Your change looks good. Technically the same as mine. I will discard
this diff.
Repository:
rCTE Clang Tools Ex
Wizard requested changes to this revision.
Wizard added a comment.
This revision now requires changes to proceed.
Please update the warning info to indicate that prefix 'k' is not the only
option for constants. Something like:
"const global variable '%0' must have an appropriate prefix or a name
erichkeane added a comment.
It seems to me that the test here is very much lacking. It doesn't seem to
include the example you've mentioned, and has no validation to ensure that
there is a single instantiation happening. I'd like to see what happens when a
UUID is passed as a pack, how SFINAE
NoQ updated this revision to Diff 135480.
NoQ added a comment.
Address comments.
https://reviews.llvm.org/D43533
Files:
include/clang/Analysis/CFG.h
include/clang/Analysis/ConstructionContext.h
lib/Analysis/CFG.cpp
lib/Analysis/CMakeLists.txt
lib/Analysis/ConstructionContext.cpp
lib
yaxunl updated this revision to Diff 135474.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D34367
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCall.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExprCXX.cpp
lib
stephanemoore added a comment.
In https://reviews.llvm.org/D43581#1016300, @Wizard wrote:
> Please update the warning info to indicate that prefix 'k' is not the only
> option for constants. Something like:
> "const global variable '%0' must have an appropriate prefix or a name which
> starts
NoQ added inline comments.
Comment at: include/clang/Analysis/ConstructionContext.h:119
+ static const ConstructionContext *
+ finalize(BumpVectorContext &C, const ConstructionContextLayer *TopLayer);
+
a.sidorin wrote:
> Maybe just `build()`? For me, `finalize
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325814: [CUDA] Added missing functions. (authored by tra,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43602?vs=135348&id=135466#toc
Repository:
rC Clang
https://reviews.llvm.o
Wizard updated this revision to Diff 135485.
Wizard added a comment.
fix format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43640
Files:
clang-tidy/google/GlobalVariableDeclarationCheck.cpp
test/clang-tidy/google-objc-global-variable-declaration.m
Index: test/clang-tid
Author: cbertol
Date: Thu Feb 22 11:38:14 2018
New Revision: 325822
URL: http://llvm.org/viewvc/llvm-project?rev=325822&view=rev
Log:
[OpenMP] Limit reduction support for pragma 'distribute' when combined with
pragma 'simd'
Differential Revision: https://reviews.llvm.org/D43513
This is a bug fi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325822: [OpenMP] Limit reduction support for pragma
'distribute' when combined with… (authored by cbertol, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Wizard accepted this revision.
Wizard added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D43581#1016318, @stephanemoore wrote:
> In https://reviews.llvm.org/D43581#1016300, @Wizard wrote:
>
> > Please update the warning info to indicate that prefix 'k' i
mgrang updated this revision to Diff 135493.
mgrang retitled this revision from "[RISCV] Enable __int128_t and uint128_t
through clang flag" to "[RISCV] Enable __int128_t and __uint128_t through clang
flag".
mgrang edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm
mgrang added a comment.
Added tests for ABI lowering and preprocessor defines as per comments.
Repository:
rC Clang
https://reviews.llvm.org/D43105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:1121
+ /// after it is moved, as opposed to a truely destructive move in which the
+ /// source object is placed in an uninitialized state.
+ PrimitiveCopyKind isNonTrivialToPrimitiveDestructiveMove() const;
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3446
+ return LV.asAggregateRValue();
+}
+
No, I don't think this is right. This method should always return an
independent RValue; if the CallArg is storing an LValue, it should copy from it
yaxunl updated this revision to Diff 135499.
yaxunl added a comment.
sync to ToT.
https://reviews.llvm.org/D34367
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCall.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExprCXX.cpp
lib/CodeGen/CGGPUB
stephanemoore updated this revision to Diff 135497.
stephanemoore added a comment.
Update the diagnostic information to link to the Google Objective-C style guide
for guidance on an appropriate prefix.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43581
Files:
clang-tidy/go
stephanemoore added a comment.
In https://reviews.llvm.org/D43581#1016327, @Wizard wrote:
> In https://reviews.llvm.org/D43581#1016318, @stephanemoore wrote:
>
> > In https://reviews.llvm.org/D43581#1016300, @Wizard wrote:
> >
> > > Please update the warning info to indicate that prefix 'k' is no
aaron.ballman added inline comments.
Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92
+ "an appropriate prefix (see "
+ "http://google.github.io/styleguide/objcguide#constants).")
<< Decl->getName() << generateFixItHint(Decl, true);
---
zahiraam updated this revision to Diff 135502.
https://reviews.llvm.org/D43576
Files:
test/CodeGenCXX/instantiate-uuid.cpp
test/Sema/member-reference-dll.cpp
Index: test/Sema/member-reference-dll.cpp
===
--- test/Sema/member-re
zahiraam added a comment.
Adding test case.
https://reviews.llvm.org/D43576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
ping
https://reviews.llvm.org/D42776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam added a comment.
In https://reviews.llvm.org/D43576#1016295, @majnemer wrote:
> We should really, really avoid making this sort of change without first
> trying to desugar uuidof into a reference to a variable. That would solve a
> ton of problems, problems like this one.
Not sure I
Wizard added inline comments.
Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92
+ "an appropriate prefix (see "
+ "http://google.github.io/styleguide/objcguide#constants).")
<< Decl->getName() << generateFixItHint(Decl, true);
--
Thanks, Hans!
On Thu, Feb 22, 2018 at 3:27 AM, Hans Wennborg wrote:
> Seems safe. Merged in r325766.
>
> On Thu, Feb 22, 2018 at 1:15 AM, Richard Trieu wrote:
> > Hi Hans,
> >
> > If there's still time for rc3, I'd like to get this crash fix in. This
> adds
> > a null check to prevent a crash
stephanemoore updated this revision to Diff 135510.
stephanemoore added a comment.
Revert the inclusion of the link to the Google Objective-C style guide in the
diagnostic message.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43581
Files:
clang-tidy/google/GlobalVariableDe
1 - 100 of 147 matches
Mail list logo
