Wizard added inline comments.
================ Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92 + "an appropriate prefix (see " + "http://google.github.io/styleguide/objcguide#constants).") << Decl->getName() << generateFixItHint(Decl, true); ---------------- aaron.ballman wrote: > We don't usually put hyperlinks in the diagnostic messages, so please remove > this. > > My suggestion about describing what constitutes an appropriate prefix was > with regards to the style guide wording itself. For instance, that document > doesn't mention that two capital letters is good. That's not on you to fix > before this patch goes in, of course. Btw it is actually "2 or more" characters for prefix. I think it makes sense because we need at least 2 or more characters to call it a "prefix" :-) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
