pacxx created this revision.
pacxx added reviewers: rnk, rsmith.
Herald added a subscriber: cfe-commits.
The ASTContext is only used to create a Mangling Context and forwards ownership
to everyone who requests a ManglingContext.
The problem fixed by this commit is located in the handling of the
a.sidorin accepted this revision.
a.sidorin added a comment.
Thank you! Just some of nits inline.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:394
+
+bool ExprEngine::areTemporaryMaterializationsClear(
+ProgramStateRef State, const LocationContext *FromLC,
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325668: [Sema] Classify conversions from enum to float as
narrowing (authored by miyuki, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42545
Files:
lib/Sema/SemaOverload.cpp
test/
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:282
scheduleReparseAndDiags(PathRef File, VersionedDraft Contents,
+ WantDiagnostics,
Tagged>
TaggedFS);
Maybe add a parameter name here
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, sammccall, hokein.
Herald added subscribers: cfe-commits, jkorous-apple, klimek.
The new behaviors introduced by this patch:
o When include collection is enabled, we always set IncludeHeader field in
Symbol
even if it's the same
kosarev added a comment.
I think zero would serve better as the unknown-size value. People who are not
aware of TBAA internals would guess that since zero-sized accesses make no
sense, they are likely to have some special meaning. Similarly, for code that
is supposed to process the size fields
ilya-biryukov added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:83
+// least one error.
+class MultipleErrorCHeckingDiagConsumer : public DiagnosticsConsumer {
+public:
NIT: misspelling: ErrorCHecking instead of ErrorChecking
Merged to 6.0 in r325672.
On Wed, Feb 21, 2018 at 1:16 AM, Craig Topper via cfe-commits
wrote:
> Author: ctopper
> Date: Tue Feb 20 16:16:50 2018
> New Revision: 325655
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325655&view=rev
> Log:
> [X86] Disable CLWB in Cannon Lake
>
> Cannon Lake does
ilya-biryukov added a comment.
Is there a way to still enable include insertion but in a restricted manner,
e.g. only for the current project?
File of canonical declaration is usually a pretty good guess and it would be
nice to have it. Maybe we could allowing to disable the include insertion vi
ioeric added a comment.
In https://reviews.llvm.org/D43550#1014319, @ilya-biryukov wrote:
> Is there a way to still enable include insertion but in a restricted manner,
> e.g. only for the current project?
I'm not sure if this is currently supported, as we don't have a good definition
of a "p
a.sidorin accepted this revision.
a.sidorin added inline comments.
Comment at: include/clang/Analysis/ConstructionContext.h:119
+ static const ConstructionContext *
+ finalize(BumpVectorContext &C, const ConstructionContextLayer *TopLayer);
+
Maybe just `build(
a.sidorin accepted this revision.
a.sidorin added a comment.
Looks good to me as an 'alpha' checker. Thank you David!
I'd prefer this patch to be accepted by somebody else as well before committing
it.
https://reviews.llvm.org/D42645
___
cfe-commit
stettberger updated this revision to Diff 135227.
stettberger added a comment.
Rebased to HEAD, Run (external) clang-hash testsuite and ASTTest
Repository:
rC Clang
https://reviews.llvm.org/D40731
Files:
include/clang/AST/AttrDataCollectors.td
include/clang/AST/CHashVisitor.h
include/c
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
As discussed offline, properly supporting IWYU pragma in the dynamic index
seems like too much design work for now and it's not gonna get fixed soon.
So opting for disabling the f
simark marked 5 inline comments as done.
simark added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:492
+
+ EXPECT_TRUE(DiagConsumer.contains(FooCpp));
+ EXPECT_TRUE(DiagConsumer.contains(BarCpp));
ilya-biryukov wrote:
> Maybe expose a copy of t
simark marked an inline comment as done.
simark added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:492
+
+ EXPECT_TRUE(DiagConsumer.contains(FooCpp));
+ EXPECT_TRUE(DiagConsumer.contains(BarCpp));
simark wrote:
> ilya-biryukov wrote:
> > Maybe
simark updated this revision to Diff 135229.
simark added a comment.
New version
Address comments in https://reviews.llvm.org/D39571#1014237
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServe
ioeric created this revision.
ioeric added a reviewer: bkramer.
Herald added subscribers: cfe-commits, klimek.
Example:
template class X {}; class A {};
// Explicit instantiation declaration.
extern template class X;
Repository:
rC Clang
https://reviews.llvm.org/D43567
Files:
include/cla
yvvan added a comment.
I've already added hints in this patch and it also do not add extra completions
unless the flag IncludeCorrections is set. So this will not force editors to
use corrections.
Did you mean that you think it's good to have extra fixit hints even if this
flag is not set?
h
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rC Clang
https://reviews.llvm.org/D43567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:23-25
+ // if (const auto *D = Node.getDefinition()) {
+ // return D->getExplicitVisibility(NamedDecl::VisibilityForType) == V;
+ // }
Can remove these comments.
===
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a nit with the help text, this LGTM.
Comment at: clang-tidy/tool/run-clang-tidy.py:188-189
+ '
Author: miyuki
Date: Wed Feb 21 02:08:18 2018
New Revision: 325668
URL: http://llvm.org/viewvc/llvm-project?rev=325668&view=rev
Log:
[Sema] Classify conversions from enum to float as narrowing
Summary:
According to [dcl.init.list]p7:
A narrowing conversion is an implicit conversion
- ...
-
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: ioeric, jkorous-apple, klimek.
We should set the flag before creating ComplierInstance -- when
CopmilerInstance gets initialized, it also initializes the DiagnosticsEngine
using the DiagnosticOptions.
krisb created this revision.
Herald added subscribers: cfe-commits, Anastasia, yaxunl.
krisb added reviewers: yaxunl, Anastasia.
OpenCL 2.0 specification defines '-cl-uniform-work-group-size' option,
which requires that the global work-size be a multiple of the work-group
size specified to clEnque
Author: ioeric
Date: Wed Feb 21 05:51:27 2018
New Revision: 325678
URL: http://llvm.org/viewvc/llvm-project?rev=325678&view=rev
Log:
[ASTMatchers] isTemplateInstantiation: also match explicit instantiation
declaration.
Summary:
Example:
template class X {}; class A {};
// Explicit instantiation
On Wed, Feb 21, 2018 at 8:51 AM, Eric Liu via cfe-commits
wrote:
> Author: ioeric
> Date: Wed Feb 21 05:51:27 2018
> New Revision: 325678
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325678&view=rev
> Log:
> [ASTMatchers] isTemplateInstantiation: also match explicit instantiation
> declaratio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325678: [ASTMatchers] isTemplateInstantiation: also match
explicit instantiation… (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
Oops, I only saw this after landing the patch. I'll send another one to
update the doc. Sorry about that!
On Wed, Feb 21, 2018 at 2:54 PM Aaron Ballman
wrote:
> On Wed, Feb 21, 2018 at 8:51 AM, Eric Liu via cfe-commits
> wrote:
> > Author: ioeric
> > Date: Wed Feb 21 05:51:27 2018
> > New Revis
On Wed, Feb 21, 2018 at 8:56 AM, Eric Liu wrote:
> Oops, I only saw this after landing the patch. I'll send another one to
> update the doc. Sorry about that!
No worries! I didn't see the patch until after the commit anyway.
Thanks for taking care of it!
~Aaron
>
> On Wed, Feb 21, 2018 at 2:54
miyuki created this revision.
miyuki added reviewers: faisalv, rsmith.
This patch adds tests of narrowing conversion diagnostics for the
'unscoped enum -> integer' case.q
https://reviews.llvm.org/D43572
Files:
test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp
Index: test/CXX/dcl.decl/dcl.i
emaste added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until th
emaste accepted this revision.
emaste added a comment.
In https://reviews.llvm.org/D43378#1010574, @devnexen wrote:
> As I see only x86_64 arch implements everything (e.g. custom event), making
> things easier maybe. arm family might be enabled, power pc might need to
> rewrite as x86_64 arch s
ioeric added inline comments.
Comment at: clangd/index/FileIndex.cpp:18
-const CanonicalIncludes *canonicalIncludesForSystemHeaders() {
- static const auto *Includes = [] {
ilya-biryukov wrote:
> Should we also remove the mutex from `CanonicalIncludes` now?
I
ioeric updated this revision to Diff 135244.
ioeric marked 2 inline comments as done.
ioeric added a comment.
Properly use toURI.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43550
Files:
clangd/CodeComplete.cpp
clangd/index/FileIndex.cpp
clangd/index/Index.h
clangd/i
Author: ioeric
Date: Wed Feb 21 06:22:42 2018
New Revision: 325682
URL: http://llvm.org/viewvc/llvm-project?rev=325682&view=rev
Log:
[ASTMatchers] Regenerate documentation after r325678
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.htm
devnexen added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until
szepet added a comment.
In https://reviews.llvm.org/D16403#1011218, @NoQ wrote:
> Yeah, i mean, like, if we change the scope markers to also appear even when
> no variables are present in the scope, then it would be possible to replace
> loop markers with some of the scope markers, right?
OK,
rjmccall added a comment.
In https://reviews.llvm.org/D42366#1014157, @kosarev wrote:
> I think zero would serve better as the unknown-size value. People who are not
> aware of TBAA internals would guess that since zero-sized accesses make no
> sense, they are likely to have some special meanin
emaste added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until th
devnexen added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419
+// Operating systems specific PROT_READ/PROT_WRITE values is not implemented,
+// thus ought to be overriden with the proper analyser-config variables
+// remain in alpha until
devnexen updated this revision to Diff 135258.
devnexen added a comment.
Rephrasing Checkers.td comment
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
Author: benhamilton
Date: Wed Feb 21 07:54:31 2018
New Revision: 325691
URL: http://llvm.org/viewvc/llvm-project?rev=325691&view=rev
Log:
[clang-format] New API guessLanguage()
Summary:
For clients which don't have a filesystem, calling getStyle() doesn't
make much sense (there's no .clang-format
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D43570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325691: [clang-format] New API guessLanguage() (authored by
benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43522?vs=135121&id=135261#toc
Repository:
rC Clang
https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325691: [clang-format] New API guessLanguage() (authored by
benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43522
Files:
cfe/trunk
Author: dblaikie
Date: Wed Feb 21 08:00:50 2018
New Revision: 325692
URL: http://llvm.org/viewvc/llvm-project?rev=325692&view=rev
Log:
Remove use of the 'gmlt' term from the -fsplit-dwarf-inlining flag description
to make it more readily legible
Modified:
cfe/trunk/include/clang/Driver/Optio
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3505
+if (AS != LangAS::Default && AS != LangAS::opencl_private &&
+AS != CGM.getASTAllocaAddressSpace())
+ Flag = CallArg::ByValArgNeedsCopy;
This is an odd condition. What are
miyuki created this revision.
miyuki added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.
Certain C libraries require configuration macros defined in __config
to provide the correct functionality for libc++. This patch ensures
that the C header math.h is always included after the __conf
Author: szepet
Date: Wed Feb 21 08:06:56 2018
New Revision: 325693
URL: http://llvm.org/viewvc/llvm-project?rev=325693&view=rev
Log:
[analyzer] Prevent AnalyzerStatsChecker from crash
The checker marks the locations where the analyzer creates sinks. However, it
can happen that the sink was create
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325693: [analyzer] Prevent AnalyzerStatsChecker from crash
(authored by szepet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42266?vs=130501&id=135266#toc
Repository:
rC Clang
Author: ioeric
Date: Wed Feb 21 08:17:25 2018
New Revision: 325694
URL: http://llvm.org/viewvc/llvm-project?rev=325694&view=rev
Log:
[clangd] Update canonical header mapping for STL
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: clang-tools-extra/trunk/clangd/
stephanemoore created this revision.
Herald added a subscriber: cfe-commits.
The current Objective-C global variable declaration check restricts naming that
is permitted by the Objective-C style guide.
The Objective-C style guide states the following:
"Global and file scope constants should have
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This LGTM.
https://reviews.llvm.org/D43579
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a few additional test cases.
It'd be nice if the style guide linked actually described what a "good" prefix
is rather than make the reader guess.
Co
lebedev.ri added a comment.
Nice!
Comment at: clang-doc/BitcodeWriter.cpp:33
+ llvm::IndexedMap BlockIdNameMap;
+ BlockIdNameMap.resize(BI_LAST - BI_FIRST + 1);
+
So here's the thing.
We know how many enumerators we have (`BI_LAST - BI_FIRST + 1`).
An
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3505
+if (AS != LangAS::Default && AS != LangAS::opencl_private &&
+AS != CGM.getASTAllocaAddressSpace())
+ Flag = CallArg::ByValArgNeedsCopy;
rjmccall wrote:
> This is an odd condi
djasper added inline comments.
Comment at: cfe/trunk/lib/Format/Format.cpp:2298
+FormatStyle::LanguageKind guessLanguage(StringRef FileName, StringRef Code) {
+ FormatStyle::LanguageKind result = getLanguageByFileName(FileName);
+ if (result == FormatStyle::LK_Cpp) {
--
tmsriram added a comment.
Ping. This patch goes with https://reviews.llvm.org/D42216, Rafael can you
approve this too if you think it is ok? Thanks.
https://reviews.llvm.org/D42217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
benhamilton added inline comments.
Comment at: cfe/trunk/lib/Format/Format.cpp:2298
+FormatStyle::LanguageKind guessLanguage(StringRef FileName, StringRef Code) {
+ FormatStyle::LanguageKind result = getLanguageByFileName(FileName);
+ if (result == FormatStyle::LK_Cpp) {
--
bsdjhb created this revision.
bsdjhb added a reviewer: sdardis.
Herald added subscribers: christof, mgorny.
This is done via a new LIBUNWIND_TEST_CFLAGS variable.
Repository:
rUNW libunwind
https://reviews.llvm.org/D43585
Files:
CMakeLists.txt
test/lit.site.cfg.in
Index: test/lit.site.
bsdjhb updated this revision to Diff 135285.
bsdjhb added a comment.
- Unexpand tabs.
Repository:
rUNW libunwind
https://reviews.llvm.org/D43585
Files:
CMakeLists.txt
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
--
bsdjhb added a comment.
@sdardis requested this functionality in the review of
https://reviews.llvm.org/D39074. Simon, can you confirm that this works for
you in your testing?
Repository:
rUNW libunwind
https://reviews.llvm.org/D43585
___
cfe-
stephanemoore updated this revision to Diff 135291.
stephanemoore added a comment.
Added excerpts from the Google Objective-C style guide section on constant
naming (http://google.github.io/styleguide/objcguide#constants) as additional
test cases.
Repository:
rCTE Clang Tools Extra
https://
juliehockett added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
lebedev.ri wrote:
> Hmm, common pattern again
> ```
lebedev.ri added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
juliehockett wrote:
> lebedev.ri wrote:
> > Hmm, comm
stephanemoore marked an inline comment as done.
stephanemoore added a comment.
In https://reviews.llvm.org/D43581#1014664, @aaron.ballman wrote:
> LGTM with a few additional test cases.
>
> It'd be nice if the style guide linked actually described what a "good"
> prefix is rather than make the r
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3510
+ args.add(RValue::getAggregate(Dest.getAddress()), type, L);
}
return;
Please move all this conditionality to the call-emission code; just check
whether you have a load of an
bsdjhb created this revision.
bsdjhb added a reviewer: sdardis.
Herald added subscribers: cfe-commits, christof.
Currently this is only planned to be used by libunwind's tests.
Repository:
rCXX libc++
https://reviews.llvm.org/D43584
Files:
utils/libcxx/test/config.py
Index: utils/libcxx/
yaxunl updated this revision to Diff 135301.
yaxunl added a comment.
Replace Flag with LValue in CallArg.
https://reviews.llvm.org/D34367
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCall.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGObjCGNU.cpp
lib/CodeGen/ItaniumCX
lebedev.ri added inline comments.
Comment at: clang-doc/Representation.h:79
+ std::string Filename;
+};
+
Hmm, have you tried adding a constructor here?
```
struct Location {
int LineNumber;
std::string Filename;
Location() = default;
Location(int Line
compnerd updated this revision to Diff 135304.
compnerd added a comment.
Update comment
Repository:
rC Clang
https://reviews.llvm.org/D43586
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenCXX/block-inalloca.cpp
Index: test/CodeGenCXX/block-inalloca.cpp
==
Author: erichkeane
Date: Wed Feb 21 12:29:05 2018
New Revision: 325716
URL: http://llvm.org/viewvc/llvm-project?rev=325716&view=rev
Log:
Replace incorrect usage of isInvalidDecl with intended setInvalidDecl
This typo would cause an attempt to multiversion 'main' to issue an
error, but not mark t
efriedma added a comment.
> FWIW, I'd very much prefer the details of the optimizer wouldn't be exposed
> as frontend flags.
Yes, definitely this. Frontend flags to control the optimizer should state an
expected result, not just turn off some completely arbitrary set of transforms.
Otherwise
aaron.ballman added a comment.
In https://reviews.llvm.org/D43581#1014903, @stephanemoore wrote:
> In https://reviews.llvm.org/D43581#1014664, @aaron.ballman wrote:
>
> > LGTM with a few additional test cases.
> >
> > It'd be nice if the style guide linked actually described what a "good"
> > pr
ahatanak added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1423
+ if (capturedByInit)
+drillIntoBlockVariable(*this, lvalue, cast(D));
+
rjmccall wrote:
> The "delay" is that we generally handle `__block` captures within
> initializers by de
compnerd created this revision.
compnerd added a reviewer: rnk.
Herald added a subscriber: cfe-commits.
When using blocks with C++ on Windows x86, it is possible to have the
block literal be pushed into the inalloca'ed parameters. Teach IRGen to
handle the case properly by extracting the block li
juliehockett updated this revision to Diff 135305.
juliehockett marked 20 inline comments as done.
juliehockett added a comment.
Cleaning up bitcode writer and fixing pointers for CommentInfos
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/Bitc
morehouse added a comment.
In https://reviews.llvm.org/D43423#1011170, @davide wrote:
> Some high level comments:
>
> 1. This is something that GCC does relatively frequently (adding frontend
> options to control optimization passes), but LLVM tends to not expose these
> details. FWIW, I'd very
ahatanak updated this revision to Diff 135309.
ahatanak marked 14 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D41228
Files:
docs/LanguageExtensions.rst
include/clang/AST/Decl.h
include/clang/AST/Type.h
include/clang/Basic/Diagnost
smeenai added a comment.
Patch is missing context.
Comment at: lib/CodeGen/CGDecl.cpp:1851
// The only implicit argument a block has is its literal.
// We assume this is always passed directly.
if (BlockInfo) {
This comment needs to be updated.
NoQ updated this revision to Diff 135312.
NoQ marked 4 inline comments as done.
NoQ added a comment.
- Address comments.
- Add a FIXME test case that demonstrates that automatic destructors don't fire
after lifetime extension through a POD field, even though lifetime extension
itself seems to wo
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:396
+ProgramStateRef State, const LocationContext *FromLC,
+const LocationContext *ToLC) {
+ const LocationContext *LC = FromLC;
a.sidorin wrote:
> EndLC? (similar to iterators
benhamilton created this revision.
benhamilton added reviewers: vsapsai, jolesiak, krasimir.
Herald added subscribers: cfe-commits, klimek.
https://reviews.llvm.org/D43522 caused an assertion failure when getStyle() was
called with
an empty filename:
https://reviews.llvm.org/P8065
This adds a t
Thanks for the report, and sorry for the breakage.
Here's the fix: https://reviews.llvm.org/D43590
Ben
On Wed, Feb 21, 2018 at 1:47 PM wrote:
> Hi Ben,
>
> Your change is causing a test failure on one of the bots, can you take a
> look?
>
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x8
Hi Ben,
Your change is causing a test failure on one of the bots, can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/25515
FAIL: Clang Tools :: clang-apply-replacements/format.cpp (12526 of 38114)
TEST 'Clang Tools :: cla
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D43570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
I'm not familiar with this code, so post-commit review by someone more
knowledgeable might be a good idea.
Code-wise it looks good. I feel uneasy about using fake file name, but it is
exact
Author: benhamilton
Date: Wed Feb 21 13:27:27 2018
New Revision: 325722
URL: http://llvm.org/viewvc/llvm-project?rev=325722&view=rev
Log:
[clang-format] Fix regression when getStyle() called with empty filename
Summary:
D43522 caused an assertion failure when getStyle() was called with
an empty f
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:1108
+PCK_ARCStrong, // objc strong pointer.
+PCK_Struct // non-trivial C struct.
+ };
These should all be /// documentation comments, and they mostly shouldn't talk
about fields si
Fix landed in r325722.
On Wed, Feb 21, 2018 at 1:53 PM Ben Hamilton wrote:
> Thanks for the report, and sorry for the breakage.
>
> Here's the fix: https://reviews.llvm.org/D43590
>
> Ben
>
> On Wed, Feb 21, 2018 at 1:47 PM wrote:
>
>> Hi Ben,
>>
>> Your change is causing a test failure on one
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325722: [clang-format] Fix regression when getStyle() called
with empty filename (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43590?vs=135314&id=135321#to
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I hate `inalloca` so much. Okay.
Repository:
rC Clang
https://reviews.llvm.org/D43586
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: pcc
Date: Wed Feb 21 13:36:18 2018
New Revision: 325723
URL: http://llvm.org/viewvc/llvm-project?rev=325723&view=rev
Log:
libcxx: Unbreak external thread library configuration.
Differential Revision: https://reviews.llvm.org/D42503
Modified:
libcxx/trunk/include/__threading_support
mstorsjo added a comment.
Ping @rnk
Repository:
rC Clang
https://reviews.llvm.org/D43184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX325723: libcxx: Unbreak external thread library
configuration. (authored by pcc, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D42503?vs=131
Author: compnerd
Date: Wed Feb 21 13:47:51 2018
New Revision: 325724
URL: http://llvm.org/viewvc/llvm-project?rev=325724&view=rev
Log:
CodeGen: handle blocks correctly when inalloca'ed
When using blocks with C++ on Windows x86, it is possible to have the
block literal be pushed into the inalloca'
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
compnerd closed this revision.
compnerd added a comment.
SVN r325724
Repository:
rC Clang
https://reviews.llvm.org/D43586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jakehehrlich added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
lebedev.ri wrote:
> juliehockett wrote:
> > lebedev
1 - 100 of 135 matches
Mail list logo
