aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a few additional test cases.
It'd be nice if the style guide linked actually described what a "good" prefix
is rather than make the reader guess.
================
Comment at: test/clang-tidy/google-objc-global-variable-declaration.m:33
static NSString* const kGood = @"hello";
+static NSString* const XYGood = @"hello";
static NSString* gMyIntGood = 0;
----------------
Can you also add the code from the style guide as a test case?
```
extern NSString *const GTLServiceErrorDomain;
typedef NS_ENUM(NSInteger, GTLServiceError) {
GTLServiceErrorQueryResultMissing = -3000,
GTLServiceErrorWaitTimedOut = -3001,
};
```
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43581
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
