hokein added inline comments.
Comment at: clangd/ClangdUnit.cpp:197
-
-log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
- Location, Message));
I'm not sure, do we care about this particular case (diagnostic outside main
a.sidorin added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2858
+
+ // Templated declarations should never appear in the enclosing DeclContext.
+ if (!D->getDescribedVarTemplate())
martong wrote:
> In case of class templates, the explicit instantiatio
keith.walker.arm added a comment.
review request ping.
There was one line in the compiler itself which is different to what had been
previously reviewed and approved ... so hopefully that change is easily
reviewed.
However this change also resulted in updates to the associated tests, and the
hans added a comment.
I see in the PR that matches a MinGW flag, but I'm curious to the motivation
here. In what scenario would the user want to use this, i.e. how do they know
it's safe to drop the probes?
Comment at: lib/CodeGen/TargetInfo.cpp:2358
-static void addStackPr
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added a subscriber: klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43174
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
ioeric added a comment.
The fix is quite subtle and not obvious to tell from the test. Could you
elaborate on the issue this fixes in the patch description? Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43174
___
cfe-commi
Merged to 6.0 in r324871.
On Sat, Jan 20, 2018 at 3:34 PM, Dimitry Andric via cfe-commits
wrote:
> Author: dim
> Date: Sat Jan 20 06:34:33 2018
> New Revision: 323040
>
> URL: http://llvm.org/viewvc/llvm-project?rev=323040&view=rev
> Log:
> Assume the shared library path variable is LD_LIBRARY_PA
Author: hans
Date: Mon Feb 12 02:04:36 2018
New Revision: 324874
URL: http://llvm.org/viewvc/llvm-project?rev=324874&view=rev
Log:
Merging r324855:
r324855 | dim | 2018-02-11 23:31:05 +0100 (Sun, 11 Feb 2018) | 26 lines
Add
Merged to 6.0 in r324874.
On Sun, Feb 11, 2018 at 11:31 PM, Dimitry Andric via cfe-commits
wrote:
> Author: dim
> Date: Sun Feb 11 14:31:05 2018
> New Revision: 324855
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324855&view=rev
> Log:
> Add default C++ ABI libname and include paths for FreeB
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
> Is it possible to see this landed before clang+llvm 6 is released?
I don't know in detail how releases work, but I believe the release branch has
already been created an
koldaniel updated this revision to Diff 133814.
https://reviews.llvm.org/D40787
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp
clang-tidy/modernize/UseUncaughtExceptionsCheck.h
docs/ReleaseNotes
Hahnfeld added inline comments.
Comment at: test/Driver/cuda-external-tools.cu:11
+// RUN: | FileCheck -check-prefix CHECK -check-prefix ARCH64 \
+// RUN: -check-prefix SM20 -check-prefix OPT0 %s
// RUN: %clang -### -target x86_64-linux-gnu -O1 -c %s 2>&1 \
-
Hahnfeld updated this revision to Diff 133816.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Use `--check-prefixes` instead of multiple `--check-prefix`.
https://reviews.llvm.org/D42920
Files:
test/Driver/cuda-external-tools.cu
Index: test/Driver/cuda-external-tools.cu
Hahnfeld updated this revision to Diff 133817.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Hide help for `-fcuda-rdc` until support is ready.
https://reviews.llvm.org/D42921
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/Options.td
lib/Driver/Tool
Hahnfeld added inline comments.
Comment at: include/clang/Driver/Options.td:572
+ HelpText<"Generate relocatable device code, also known as separate
compilation mode.">;
+def fno_cuda_rdc : Flag<["-"], "fno-cuda-rdc">;
def dA : Flag<["-"], "dA">, Group;
tra wr
Author: hahnfeld
Date: Mon Feb 12 02:46:34 2018
New Revision: 324877
URL: http://llvm.org/viewvc/llvm-project?rev=324877&view=rev
Log:
[CUDA] Fix test cuda-external-tools.cu
This didn't verify the CHECK prefix before!
Differential Revision: https://reviews.llvm.org/D42920
Modified:
cfe/trun
Author: hahnfeld
Date: Mon Feb 12 02:46:45 2018
New Revision: 324878
URL: http://llvm.org/viewvc/llvm-project?rev=324878&view=rev
Log:
[CUDA] Add option to generate relocatable device code
As a first step, pass '-c/--compile-only' to ptxas so that it
doesn't complain about references to external
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324878: [CUDA] Add option to generate relocatable device
code (authored by Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42921?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324877: [CUDA] Fix test cuda-external-tools.cu (authored by
Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42920?vs=133816&id=13381
ilya-biryukov updated this revision to Diff 133825.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
Herald added a subscriber: mgorny.
- Added CaptureProxy helper, use it to implement runCodeComplete.
- Documented that we deliberately don't expose the sync API in tes
Author: ibiryukov
Date: Mon Feb 12 03:37:28 2018
New Revision: 324883
URL: http://llvm.org/viewvc/llvm-project?rev=324883&view=rev
Log:
[clangd] Remove codeComplete that returns std::future<>
Summary:
It was deprecated and callback version and is used everywhere.
Only changes to the testing code
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324883: [clangd] Remove codeComplete that returns
std::future<> (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43068
Fil
ilya-biryukov added inline comments.
Comment at: unittests/clangd/SyncAPI.h:1
+//===--- SyncAPI.h - Sync version of ClangdServer's API --*-
C++-*-===//
+//
sammccall wrote:
> Being able to call synchronously is really nice for tests.
> It's a bit unfortu
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:197
-
-log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
- Location, Message));
hokein wrote:
> I'm not sure, do we care about this particular case (
ilya-biryukov updated this revision to Diff 133827.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Renamed logIgnoredDiag to log.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43123
Files:
clangd/ClangdUnit.cpp
clangd/Compiler.cpp
clangd
kosarev added a comment.
Hal, a friendly ping.
Repository:
rL LLVM
https://reviews.llvm.org/D42366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: filcab
Date: Mon Feb 12 03:49:02 2018
New Revision: 324884
URL: http://llvm.org/viewvc/llvm-project?rev=324884&view=rev
Log:
ASan+operator new[]: Add an option for more thorough operator new[] cookie
poisoning
Summary:
Right now clang is skipping array cookie poisoning for any operator
n
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324884: ASan+operator new[]: Add an option for more thorough
operator new[] cookie… (authored by filcab, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43013?vs=133389&id=133830#toc
Hahnfeld updated this revision to Diff 133831.
Hahnfeld added a comment.
Rebase and fix `Debug` build.
https://reviews.llvm.org/D42922
Files:
lib/CodeGen/CGCUDANV.cpp
Index: lib/CodeGen/CGCUDANV.cpp
===
--- lib/CodeGen/CGCUDANV.
Hahnfeld planned changes to this revision.
Hahnfeld added a comment.
Still no regression tests.
I did some functional tests though (https://reviews.llvm.org/F5822023): With
this patch Clang can generate valid object files with relocatable device code.
For linking I still defer to `nvcc` and I'm
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: hokein
Date: Mon Feb 12 04:26:12 2018
New Revision: 324886
URL: http://llvm.org/viewvc/llvm-project?rev=324886&view=rev
Log:
[clang-move] Fix the incorrect expansion end location.
Summary:
Before the fix, if clang-move decides to move the following macro statement, it
only moves the firs
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clangd/ClangdUnit.cpp:197
-
-log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
- Location, Message));
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324886: [clang-move] Fix the incorrect expansion end
location. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43174
Files:
sylvestre.ledru accepted this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.
Looks good, thanks.
Repository:
rC Clang
https://reviews.llvm.org/D42593
___
cfe-commits mailing list
cfe-commits@lists.llvm
avt77 closed this revision.
avt77 added a comment.
Fixed by 324721.
https://reviews.llvm.org/D42530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added inline comments.
Comment at: clangd/Threading.h:60
+/// A point in time we may wait for, or None to wait forever.
+/// (We use Optional because buggy implementations of std::chrono overflow...)
+using Deadline = llvm::Optional;
Maybe remove th
Author: ibiryukov
Date: Mon Feb 12 04:48:51 2018
New Revision: 324888
URL: http://llvm.org/viewvc/llvm-project?rev=324888&view=rev
Log:
[clangd] Log all ignored diagnostics.
Summary:
To aid debugging failures and crashes.
Only part of ignored diagnostics was logged before, now we log all of
them.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324888: [clangd] Log all ignored diagnostics. (authored by
ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43123
Files:
clang-tools-
joerg added a comment.
I really don't like ignoring options that are supposed to provide actual
functionality. Most of the other options are for pointless fine tuning and
workarounds for broken gcc behavior in ancient versions.
Repository:
rC Clang
https://reviews.llvm.org/D42593
___
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This adds support for text proto extensions, like:
msg {
[type.type/ext] {
key: value
}
}
Repository:
rC Clang
https://reviews.llvm.org/D43180
Files:
lib/Format/ContinuationIndenter.cpp
lib/
kosarev created this revision.
kosarev added a reviewer: rjmccall.
kosarev added a project: clang.
Herald added a subscriber: llvm-commits.
Currently, clang compiles explicit initializers for array elements into series
of store instructions. For large arrays of built-in types this results in
blo
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek.
- Change the offset range to half-open, [start, end).
- Fix a few fixmes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43182
Files:
clan
Author: aaronballman
Date: Mon Feb 12 05:38:25 2018
New Revision: 324890
URL: http://llvm.org/viewvc/llvm-project?rev=324890&view=rev
Log:
Allow the NS, CF, and ObjC attributes to be used with
-fdouble-square-bracket-attributes. The syntactic locations for such attributes
on ObjC constructs have
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks for the detailed review! I've commit in r324890.
https://reviews.llvm.org/D41553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Typz created this revision.
Typz added reviewers: krasimir, djasper, klimek.
When a block is started after a case label, clang-format does add extra
indent to the content of this block: the block content is indented one
level (with respect to the switch) while the closing brace is not
indented, an
ioeric added a comment.
I'm wondering if there is any further plan for this? ;)
https://reviews.llvm.org/D39050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo created this revision.
mstorsjo added reviewers: rnk, majnemer, smeenai, compnerd.
The first member of the type info structs/objects is a pointer to the vtable of
the type info class. If the standard C++ library that provides this vtable is
linked as a DLL, this field of the struct need
xazax.hun added subscribers: dkrupp, whisperity.
xazax.hun added a comment.
@alexfh did you have any chance to think about this change?
https://reviews.llvm.org/D38171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
kosarev created this revision.
kosarev added a reviewer: rsmith.
kosarev added a project: clang.
Herald added a subscriber: llvm-commits.
This patch fixes clang to not consider braced initializers for aggregate
elements of arrays to be potentially dependent on the indices of the
initialized elem
sdesmalen created this revision.
sdesmalen added reviewers: CarlosAlbertoEnciso, probinson, aprantl.
Herald added a subscriber: JDevlieghere.
This patch also adds the 'DW_AT_artificial' flag to the generated variable.
https://reviews.llvm.org/D43189
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGe
sammccall updated this revision to Diff 133857.
sammccall marked 3 inline comments as done.
sammccall added a comment.
Change AsyncTaskRunner::wait() to be LLVM_NODISCARD when used with a deadline.
Restore NoConcurrentDiagnostics test to its former glory (with comments)
Other comment fixes.
Repo
sammccall added inline comments.
Comment at: clangd/Threading.h:60
+/// A point in time we may wait for, or None to wait forever.
+/// (We use Optional because buggy implementations of std::chrono overflow...)
+using Deadline = llvm::Optional;
ilya-biryukov wrote
djasper added inline comments.
Comment at: unittests/Format/FormatTestTextProto.cpp:317
+
+TEST_F(FormatTestTextProto, FormatsExtensions) {
+ verifyFormat("[type] { key: value }");
It might be useful to attach a test case for what happens if the "[...]" does
no
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice!
Comment at: clangd/index/Index.cpp:40
raw_ostream &operator<<(raw_ostream &OS, const Symbol &S) {
- return OS << S.Scope << S.Name;
+ return OS << S.Scope << S
gerazo added inline comments.
Comment at: tools/scan-build-py/libscanbuild/analyze.py:702
+
# To have good results from static analyzer certain compiler options shall be
george.karpenkov wrote:
> This blank line should not be in this PR.
Scheduled to be done.
sammccall added a comment.
Insertion still LG (couple of nits, inline).
For indexing, my biggest questions:
- I worry CanonicalIncludes doesn't get enough information to make good
decisions - passing the include stack in some form may be better
- CanonicalIncludes has slightly weird patterns of
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.cpp:286
} // unlock Mutex.
RequestsCV.notify_one();
}
Change to `notify_all()`? Otherwise we might wake up some thread waiting on
`blockUntilIdle()`, but not the worker thread.
Author: marshall
Date: Mon Feb 12 07:41:25 2018
New Revision: 324895
URL: http://llvm.org/viewvc/llvm-project?rev=324895&view=rev
Log:
While implementing P0777 - preventing unnecessary decay, I found some
non-public uses of decay that could be replaced by __uncvref. NFC intented
Modified:
li
Szelethus updated this revision to Diff 133860.
Szelethus added a comment.
Fixed almost everything mentioned in comments.
I also came up with this problem:
RegularException funcReturningExceptioniTest(int i) {
return RegularException();
}
void returnedValueTest() {
funcRet
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This patch fixes a bug where the comment indent of comments in text protos gets
messed up because by default paren states get created with AlignColons = true
(which makes snese for ObjC).
Repository:
rC Clang
htt
Author: krasimir
Date: Mon Feb 12 07:49:09 2018
New Revision: 324896
URL: http://llvm.org/viewvc/llvm-project?rev=324896&view=rev
Log:
[clang-format] Fix comment indentation in text protos
Summary: This patch fixes a bug where the comment indent of comments in text
protos gets messed up because
Szelethus marked 7 inline comments as done.
Szelethus added inline comments.
Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:45
+ diag(TemporaryExpr->getLocStart(),
+ "exception instantiated but not bound (did you intend to 'throw'?)");
+}
aaron.b
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324896: [clang-format] Fix comment indentation in text
protos (authored by krasimir, committed by ).
Changed prior to com
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324896: [clang-format] Fix comment indentation in text
protos (authored by krasimir, committed by ).
Herald added a subscr
sammccall updated this revision to Diff 133868.
sammccall marked 3 inline comments as done.
sammccall added a comment.
Review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43127
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/TUScheduler.cpp
clangd
sammccall added inline comments.
Comment at: clangd/TUScheduler.cpp:286
} // unlock Mutex.
RequestsCV.notify_one();
}
ilya-biryukov wrote:
> Change to `notify_all()`? Otherwise we might wake up some thread waiting on
> `blockUntilIdle()`, but not the work
Author: chill
Date: Mon Feb 12 08:12:52 2018
New Revision: 324900
URL: http://llvm.org/viewvc/llvm-project?rev=324900&view=rev
Log:
Re-commit r324490: [DebugInfo] Improvements to representation of enumeration
types (PR36168)
Differential revision: https://reviews.llvm.org/D42736
Added:
cfe
On Wed, Feb 7, 2018 at 10:38 AM Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Wed Feb 7 10:36:51 2018
> New Revision: 324498
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324498&view=rev
> Log:
> [Driver] Add option to manually control discarding v
majnemer added a comment.
Do I understand correctly that this workarounds a feature missing in lld? Does
MinGW emit the same sorts of object files as clang in these scenarios?
Repository:
rC Clang
https://reviews.llvm.org/D43184
___
cfe-commits
Author: erichkeane
Date: Mon Feb 12 08:24:08 2018
New Revision: 324902
URL: http://llvm.org/viewvc/llvm-project?rev=324902&view=rev
Log:
Add Invalid-note test negllected in R324673,324674,324675,324676
Added:
cfe/trunk/test/Misc/target-invalid-cpu-note.c
Added: cfe/trunk/test/Misc/target-inv
benhamilton added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:1130
+if (FormatTok->Tok.is(tok::l_brace)) {
+ if (Style.BraceWrapping.AfterObjCDeclaration)
+addUnwrappedLine();
Typz wrote:
> benhamilton wrote:
> > T
Unit test?
On Fri, Feb 9, 2018 at 10:45 AM Phabricator via Phabricator via
llvm-commits wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL324761: Introduce an API for LLDB to compute the
> default module cache path (authored by adrian, commit
FWIW, you can write "*M" rather than M.getValue() if you reckon that's
neater.
And you could roll the declaration/initialization of M into the 'if'
condition - but I can understand why you might prefer not to, given it's a
many-line statement, etc.
On Tue, Feb 6, 2018 at 4:39 PM Erich Keane via c
malaperle added a comment.
In https://reviews.llvm.org/D39050#1004937, @ioeric wrote:
> I'm wondering if there is any further plan for this? ;)
I'd like to comment on the amount of data that will be stored but that can be
done outside this review. I still have a few things to figure out before
krasimir updated this revision to Diff 133872.
krasimir added a comment.
- Add tests with long [...]
Repository:
rC Clang
https://reviews.llvm.org/D43180
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: unittests/Format/FormatTestTextProto.cpp:317
+
+TEST_F(FormatTestTextProto, FormatsExtensions) {
+ verifyFormat("[type] { key: value }");
djasper wrote:
> It might be useful t
ilya-biryukov added a comment.
In https://reviews.llvm.org/D35894#1003356, @simark wrote:
> In https://reviews.llvm.org/D35894#1003342, @simark wrote:
>
> > The only problem I see is that when hovering a function/struct name, it now
> > prints the whole function/struct definition. When talking
gtbercea created this revision.
gtbercea added reviewers: Hahnfeld, ABataev, carlo.bertolli, caomhin, grokos.
Herald added subscribers: cfe-commits, guansong.
This patch adds an additional flag to the OpenMP device offloading toolchain to
link in the runtime library bitcode.
Repository:
rC Cl
echristo added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325
+llvm::AttrBuilder Attrs;
+if (GetCPUAndFeaturesAttributes(D, Attrs)) {
+ // We know that GetCPUAndFeaturesAttributes will always have the
+ // newest set, since
Author: erichkeane
Date: Mon Feb 12 09:01:41 2018
New Revision: 324907
URL: http://llvm.org/viewvc/llvm-project?rev=324907&view=rev
Log:
Make attribute-target on a Definition-after-use update the LLVM attributes
As reported here: https://bugs.llvm.org/show_bug.cgi?id=36301
The issue is that the '
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324907: Make attribute-target on a Definition-after-use
update the LLVM attributes (authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43095?vs=133519&id=133880#t
erichkeane marked 3 inline comments as done.
erichkeane added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325
+llvm::AttrBuilder Attrs;
+if (GetCPUAndFeaturesAttributes(D, Attrs)) {
+ // We know that GetCPUAndFeaturesAttributes will a
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Looks good with one additional change to the test.
Side note: We should also add all the LLVM extensions to
http://wiki.dwarfstd.org/index.php?title=Vendor_Extensions.
Co
echristo added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:1318-1325
+llvm::AttrBuilder Attrs;
+if (GetCPUAndFeaturesAttributes(D, Attrs)) {
+ // We know that GetCPUAndFeaturesAttributes will always have the
+ // newest set, since
rnk added a comment.
In https://reviews.llvm.org/D43110#1004107, @rsmith wrote:
> Thanks! I'd noticed this weirdness but wasn't sure what we could do about it
> without breaking MS compat. I like this approach a lot.
Great, sorry for the delay.
> If we want to change the C behavior too, I thi
grokos added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:559
+if (!FoundBCLibrary)
+ getDriver().Diag(diag::remark_drv_omp_offload_target_missingbcruntime);
+ }
Should we be more specific when it comes to the name of the missing bc file
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGDecl.cpp:1002
getContext().CreateTypeSourceInfo(QT), SC_Auto);
+ ArtificialDecl->setImplicit();
Thanks!
h
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM. Other clean up can be done as a separate patch.
Comment at: test/CodeGenOpenCL/address-spaces.cl:37
+// SPIR: i32 addrspace(2)* %arg
+// GIZ: i32 addrspace(4)* %arg
void
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprAgg.cpp:421
+ // with explicit initializers should be large enough.
+ if (NumInitElements > 8 && elementType->isBuiltinType()) {
+CodeGen::CodeGenModule &CGM = CGF.CGM;
Is there a good reason to
Author: erichkeane
Date: Mon Feb 12 09:19:57 2018
New Revision: 324909
URL: http://llvm.org/viewvc/llvm-project?rev=324909&view=rev
Log:
Update target-note-test to be current with the AMDGPU changes
Modified:
cfe/trunk/test/Misc/target-invalid-cpu-note.c
Modified: cfe/trunk/test/Misc/target-
sdardis added a comment.
The only thing this needs now is to get correct testing support. Could you add
support for passing down to the configuration script an additional set of
cflags like compiler-rt and libomp do (as a separate patch)? If you look at
libomp, you'll see LIBOMP_TEST_CFLAGS def
CarlosAlbertoEnciso added a comment.
LGTM.
Thanks.
https://reviews.llvm.org/D43189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea updated this revision to Diff 133882.
gtbercea added a comment.
Fix warning message.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
==
Author: marshall
Date: Mon Feb 12 09:26:40 2018
New Revision: 324911
URL: http://llvm.org/viewvc/llvm-project?rev=324911&view=rev
Log:
Implement LWG#2908 - The less-than operator for shared pointers could do more,
and mark 2878 as complete as well (we already do that)
Modified:
libcxx/trunk/
rnk added a comment.
In https://reviews.llvm.org/D43184#1005161, @majnemer wrote:
> Do I understand correctly that this workarounds a feature missing in lld?
> Does MinGW emit the same sorts of object files as clang in these scenarios?
You can see it that way, but having the linker synthesize
Anastasia added a comment.
In https://reviews.llvm.org/D42844#1004663, @Fznamznon wrote:
> Yes, we don't have anything OpenCL specific for atomic pointers.
> But we have OpenCL specific in pointers and atomics separately and we have
> address spaces.
> Why not to test all at once?
We don't
Author: rnk
Date: Mon Feb 12 09:37:06 2018
New Revision: 324913
URL: http://llvm.org/viewvc/llvm-project?rev=324913&view=rev
Log:
[Sema] Don't mark plain MS enums as fixed
Summary:
This fixes a flaw in our AST: PR27098
MSVC always gives plain enums the underlying type 'int'. Clang does this
as w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324913: [Sema] Don't mark plain MS enums as fixed
(authored by rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43110?vs=133670&id=133886#
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324913: [Sema] Don't mark plain MS enums as fixed
(authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43110?vs=133670&id=133887#toc
Repository:
rC Clang
https://revi
1 - 100 of 180 matches
Mail list logo
