hokein added inline comments.
================
Comment at: clangd/ClangdUnit.cpp:197
-
- log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
- Location, Message));
----------------
I'm not sure, do we care about this particular case (diagnostic outside main
file)? With the new change, we don't know whether the diag is from main file or
outside main file。
================
Comment at: clangd/Compiler.h:27
public:
+ static void logIgnoredDiag(DiagnosticsEngine::Level DiagLevel,
+ const clang::Diagnostic &Info);
----------------
maybe just name it `log`? since this method is already in `IgnoreDiagnostics`
class.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43123
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
