Merged to 6.0 in r324579.
On Tue, Feb 6, 2018 at 11:39 PM, Volodymyr Sapsai via cfe-commits
wrote:
> Author: vsapsai
> Date: Tue Feb 6 14:39:25 2018
> New Revision: 324419
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324419&view=rev
> Log:
> [Lex] Fix handling numerical literals ending with
EricWF added a comment.
@rsmith. Sorry, you're right. I didn't notice that we already used
`_LIBCPP_BUILDING_LIBRARY` in libc++abi. I wasn't sure if `_BUILDING_LIBRARY`
changed the linkage or of any symbols, or changed their explicit instantiation.
And, indeed, on Windows there's a problem with
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D42957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, hokein, ioeric.
Herald added subscribers: jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43065
Files:
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clan
filcab added a comment.
In https://reviews.llvm.org/D43013#1001006, @rjmccall wrote:
> I don't understand why your description of this patch mentions the void*
> placement new[] operator. There's no cookie to poison for that operator.
Hah, sorry. In writing this commit log I used parts of the
filcab updated this revision to Diff 133389.
filcab added a comment.
Update commit message.
Repository:
rC Clang
https://reviews.llvm.org/D43013
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/ItaniumCXXABI.cpp
lib/Frontend/CompilerInvocat
Author: krasimir
Date: Thu Feb 8 02:47:12 2018
New Revision: 324591
URL: http://llvm.org/viewvc/llvm-project?rev=324591&view=rev
Log:
[clang-format] Do not break before long string literals in protos
Summary:
This patch is a follow-up to r323319 (which disables string literal breaking for
text p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324591: [clang-format] Do not break before long string
literals in protos (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324594: Fix for #31362 - ms_abi is implemented incorrectly
for values >=16 bytes. (authored by aivchenk, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324594: Fix for #31362 - ms_abi is implemented incorrectly
for values >=16 bytes. (authored by aivchenk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43016?vs=133198&id=133395#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX324596: [libcxx] Avoid spurious construction of valarray
elements (authored by miyuki, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41992
Files:
include/valarray
test/std/n
ilya-biryukov added inline comments.
Comment at: include/clang-c/Index.h:6159
+ */
+ CXSymbolRole role;
} CXIdxEntityRefInfo;
MaskRay wrote:
> ilya-biryukov wrote:
> > Why do we need to store both `CXIdxEntityRefKind` and `CXSymbolRole`? Can
> > we store jus
sdardis added a comment.
Ok, I've found my issue. inttypes.h in libcxx include_next's ,
which on my debian linux systems has the include chain , ,
. "helpfully" provides #defines of the various _ABIXXX
macros, which normally the compiler defines depending on the ABI. The include
chain for oth
sabel83 updated this revision to Diff 133400.
sabel83 marked an inline comment as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, sammccall.
Herald added subscribers: jkorous-apple, klimek.
It was deprecated and callback version and is used everywhere.
Only changes to the testing code were needed.
Repository:
rCTE Clang Tools Extra
https
Author: ibiryukov
Date: Thu Feb 8 04:46:34 2018
New Revision: 324599
URL: http://llvm.org/viewvc/llvm-project?rev=324599&view=rev
Log:
[clangd] Update include guard in Annotations.h. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/Annotations.h
Modified: clang-tools-extra/trunk/unitt
avt77 updated this revision to Diff 133404.
avt77 added a comment.
I propagated qualifiers accordingly to rjmccall's suggestion. But I changed the
diagnostic: now it's more realistic from my point of view.
https://reviews.llvm.org/D42530
Files:
lib/Sema/SemaExpr.cpp
lib/Sema/SemaExprMember
erichkeane updated this revision to Diff 133276.
erichkeane retitled this revision from "Make march/target-cpu print a note with
the list of valid values" to "Make march/target-cpu print a note with the list
of valid values for ARM".
erichkeane edited the summary of this revision.
https://review
Hahnfeld added a comment.
I think this means that the Clang test needs to be updated whenever somebody
adds an architecture to LLVM? Maybe just test that Clang emits a note and don't
check which values it prints? These should be checked in the backend...
https://reviews.llvm.org/D42978
fhahn added a comment.
In https://reviews.llvm.org/D42978#1001616, @Hahnfeld wrote:
> I think this means that the Clang test needs to be updated whenever somebody
> adds an architecture to LLVM? Maybe just test that Clang emits a note and
> don't check which values it prints? These should be ch
Author: aivchenk
Date: Thu Feb 8 03:15:21 2018
New Revision: 324594
URL: http://llvm.org/viewvc/llvm-project?rev=324594&view=rev
Log:
Fix for #31362 - ms_abi is implemented incorrectly for values >=16 bytes.
Summary:
This patch is a fix for following issue:
https://bugs.llvm.org/show_bug.cgi?id=
Author: miyuki
Date: Thu Feb 8 03:33:48 2018
New Revision: 324596
URL: http://llvm.org/viewvc/llvm-project?rev=324596&view=rev
Log:
[libcxx] Avoid spurious construction of valarray elements
Summary:
Currently libc++ implements some operations on valarray by using the
resize method. This method h
miyuki updated this revision to Diff 133408.
miyuki added a comment.
Added a test for __sqr
https://reviews.llvm.org/D41629
Files:
include/complex
test/libcxx/numerics/complex.number/__sqr.pass.cpp
test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp
test/std/numerics
ioeric updated this revision to Diff 133411.
ioeric marked 13 inline comments as done.
ioeric added a comment.
- Added tests for all components; more cleanup; s/IncludeURI/IncludeHeader/
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42640
Files:
clangd/CMakeLists.txt
clang
ioeric added a comment.
Thanks for the comments!
Sorry that I didn't clean up the code before sending out the prototype. I
planned to deal with code structure and style issues after getting some early
feedback, but I think the patch is ready for review now.
Comment at: clang
Author: jkorous
Date: Thu Feb 8 06:37:58 2018
New Revision: 324607
URL: http://llvm.org/viewvc/llvm-project?rev=324607&view=rev
Log:
[Parser][FixIt] Better diagnostics for "typedef" instead of "typename" typo
rdar://problem/10214588
Differential Revision: https://reviews.llvm.org/D42170
Added:
sdardis added a reviewer: compnerd.
sdardis added a comment.
I am not sure what the answer is. There's a slightly different issue in that
returning the contents of a floating point register on MIPS and expecting it to
be a double is not necessarily correct. For a 64bit FPU, the result of
lwc1/m
cameron314 added a comment.
@yvvan: The clang frontend tests (`PCHPreambleTest` and friends) are disabled
on Windows in the makefile (I think because the VFS tests depend on linux-like
paths). So running the tests on Windows without failures is encouraging but not
the whole story.
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324607: [Parser][FixIt] Better diagnostics for
"typedef" instead of "typename" typo (authored by jkorous,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42170?vs=132135&id=133412#to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324607: [Parser][FixIt] Better diagnostics for
"typedef" instead of "typename" typo (authored by jkorous,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
ioeric added a comment.
Nice! The code looks much simpler!
Just some drive-by nits. I don't know the threading work well enough to give
useful comments. Will leave the approval to others.
Comment at: clangd/ClangdUnit.cpp:399
+ std::unique_ptr CI;
+ {
+// FIXME(ibiryuko
ilya-biryukov added a comment.
Thanks for picking this up!
I have just one major comment related to how we generate the hover text.
Current implementation tries to get the actual source code for every
declaration and then patch it up to look nice on in the output.
It is quite a large piece of co
Szelethus added inline comments.
Comment at: lib/Sema/Sema.cpp:40
#include "clang/Sema/TemplateDeduction.h"
+#include "clang/Sema/TemplateInstCallback.h"
#include "llvm/ADT/DenseMap.h"
xazax.hun wrote:
> Do you need to add this include?
Yes, in `Sema.h` the cla
yvvan added a comment.
In https://reviews.llvm.org/D41005#1001854, @cameron314 wrote:
> @yvvan: The clang frontend tests (`PCHPreambleTest` and friends) are disabled
> on Windows in the makefile (I think because the VFS tests depend on
> linux-like paths). So running the tests on Windows withou
ioeric added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
Any reason not to put sync APIs in ClangdServer
Author: marshall
Date: Thu Feb 8 06:51:22 2018
New Revision: 324609
URL: http://llvm.org/viewvc/llvm-project?rev=324609&view=rev
Log:
Update the status of removed components
Modified:
libcxx/trunk/www/TS_deprecation.html
Modified: libcxx/trunk/www/TS_deprecation.html
URL:
http://llvm.org/v
ilya-biryukov added a comment.
Thanks for the NITs :-)
Comment at: clangd/ClangdUnit.cpp:399
+ std::unique_ptr CI;
+ {
+// FIXME(ibiryukov): store diagnostics from CommandLine when we start
ioeric wrote:
> Do we still need this block?
I added it to avoid
ilya-biryukov updated this revision to Diff 133416.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Removed braces
- s/latest/last/
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43065
Files:
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
cla
ioeric added inline comments.
Comment at: clangd/ClangdUnit.cpp:399
+ std::unique_ptr CI;
+ {
+// FIXME(ibiryukov): store diagnostics from CommandLine when we start
ilya-biryukov wrote:
> ioeric wrote:
> > Do we still need this block?
> I added it to avoid
SjoerdMeijer closed this revision.
SjoerdMeijer added a comment.
Herald added a subscriber: hintonda.
Committed as r323005
https://reviews.llvm.org/D41792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
MTC created this revision.
MTC added reviewers: NoQ, xazax.hun.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet.
Herald added a reviewer: george.karpenkov.
It should be an omission when committing https://reviews.llvm.org/rL302016.
Repository:
rC Clang
https://reviews.llvm.
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added a subscriber: klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43075
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
MTC updated this revision to Diff 133421.
MTC added a comment.
Herald added a reviewer: george.karpenkov.
rebase
Repository:
rC Clang
https://reviews.llvm.org/D42300
Files:
lib/StaticAnalyzer/Checkers/AnalysisOrderChecker.cpp
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/Analysis/Inputs/
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D43074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Anastasia added a comment.
Sorry for delay... Does this test anything OpenCL specific? As far as I
remember we don't have any changes to `PointerType` with an atomic pointee type.
Repository:
rC Clang
https://reviews.llvm.org/D42844
___
cfe-comm
ioeric added a comment.
Lg. Thanks for the change!
Comment at: clang-move/ClangMove.cpp:526
unless(usingDirectiveDecl()), // using namespace decl.
+ notInMacro(),
InOldHeader,
I'd probably relax the condition a bit; theoretically tools would
gtbercea accepted this revision.
gtbercea added a comment.
LG
https://reviews.llvm.org/D42841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: benhamilton
Date: Thu Feb 8 08:07:25 2018
New Revision: 324618
URL: http://llvm.org/viewvc/llvm-project?rev=324618&view=rev
Log:
[clang-format] Do not break Objective-C string literals inside array literals
Summary:
Concatenating Objective-C string literals inside an array literal
raises
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324618: [clang-format] Do not break Objective-C string
literals inside array literals (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42704?vs=132031&id=1334
arichardson added a comment.
Looks good to me but I guess someone else should approve the change.
I added a bunch of hacks in our fork to ensure that functions end up being in
address space 200 but this would be much better.
Repository:
rC Clang
https://reviews.llvm.org/D37057
__
Author: marshall
Date: Thu Feb 8 08:25:57 2018
New Revision: 324619
URL: http://llvm.org/viewvc/llvm-project?rev=324619&view=rev
Log:
Clean up string's deduction guides tests. Mark old versions of clang as
unsupported, b/c they don't have deduction guides, even in C++17 mode
Added:
libcxx/
ilya-biryukov added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
ioeric wrote:
> Any reason not to put syn
Author: marshall
Date: Thu Feb 8 09:06:08 2018
New Revision: 324624
URL: http://llvm.org/viewvc/llvm-project?rev=324624&view=rev
Log:
Once more, with feeling. Spell 'clang-4.0' correctly this time
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
arsenm created this revision.
arsenm added a reviewer: yaxunl.
Herald added a subscriber: wdng.
https://reviews.llvm.org/D43078
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenOpenCL/address-space-constant-initializers.cl
test/CodeGenOpenCL/private-array-initialization.cl
Index: test/CodeGenOpe
ioeric added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
ilya-biryukov wrote:
> ioeric wrote:
> > Any rea
jtbandes updated this revision to Diff 133440.
jtbandes added a comment.
Using a slightly more invasive fix. I haven't come up with any other test cases
that exhibit the problem, which makes me unsure this fix is needed in all these
locations. Maybe someone with more knowledge of this function c
MaskRay updated this revision to Diff 133441.
MaskRay added a comment.
Don't deprecate CXIdxEntityRefInfo
Repository:
rC Clang
https://reviews.llvm.org/D42895
Files:
include/clang-c/Index.h
include/clang/Index/IndexSymbol.h
test/Index/index-decls.m
test/Index/index-refs.cpp
test/In
rnk accepted this revision.
rnk added a comment.
lgtm
This works even though we pass -Wa,-mbig-obj?
Repository:
rC Clang
https://reviews.llvm.org/D41597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
MaskRay marked 4 inline comments as done.
MaskRay added inline comments.
Comment at: include/clang-c/Index.h:6159
+ */
+ CXSymbolRole role;
} CXIdxEntityRefInfo;
ilya-biryukov wrote:
> MaskRay wrote:
> > ilya-biryukov wrote:
> > > Why do we need to store both
erichkeane updated this revision to Diff 133443.
erichkeane added a comment.
removed careless newline, also rebases off ARM patch.
https://reviews.llvm.org/D43041
Files:
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
test/Misc/target-invalid-cpu-note.c
Index: test/Misc/target-invalid
ilya-biryukov added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
ioeric wrote:
> ilya-biryukov wrote:
> >
ioeric added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
ilya-biryukov wrote:
> ioeric wrote:
> > ilya-bi
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Hahnfeld added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:1670-1672
+#define PROC_ALIAS(ENUM, ALIAS)
\
+ if (checkCPUKind(getCPUKind(ALIAS)))
\
+Values.emplace_back(ALIAS);
-
Hahnfeld added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:1670-1672
+#define PROC_ALIAS(ENUM, ALIAS)
\
+ if (checkCPUKind(getCPUKind(ALIAS)))
\
+Values.emplace_back(ALIAS);
-
sp4r74n-117 updated this revision to Diff 133447.
sp4r74n-117 added a comment.
Thanks for the explanation, seems like I was on the wrong track.
I now do realize that my initial approach was in fact duplicating the logic of
'BI__builtin_object_size'.
I've removed most of the changes applied to the
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, thanks. LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D43013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
MaskRay updated this revision to Diff 133455.
MaskRay added a comment.
Add option `Enabled` which defaults to 0.
Suggest std::simd (-std=c++2a) or std::experimental::std (-std=c++11) only if
enabled.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/read
MaskRay marked 9 inline comments as done.
MaskRay added a comment.
The check must be manually enabled now:
% clang-tidy -checks='-*,readability-simd-intrinsics' a.cc -- -std=c++2a
# Not enabled by default
% clang-tidy -checks='-*,readability-simd-intrinsics' -config='{CheckOptions:
[{ke
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D43078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
erichkeane updated this revision to Diff 133456.
erichkeane added a comment.
Cleaned up the test as suggested.
https://reviews.llvm.org/D43041
Files:
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
test/Misc/target-invalid-cpu-note.c
Index: test/Misc/target-invalid-cpu-note.c
rjmccall added a comment.
Thanks, that looks a lot better. One minor piece of feedback, but otherwise
LGTM.
Comment at: lib/Sema/SemaExpr.cpp:4402
+Qualifiers MemberQuals =
+Context.getCanonicalType(ResultType).getQualifiers();
+Qualifiers Combined = BaseQuals
rjmccall added a comment.
I'm somewhat surprised LLVM doesn't already canonicalize this, but ok.
Should we also do this when building a constant struct?
Comment at: lib/CodeGen/CGExprConstant.cpp:873
Elts.push_back(C);
+ if (!C->isNullValue())
+AllNullValue
MaskRay updated this revision to Diff 133457.
MaskRay added a comment.
Set `Enabled` to 1 in test/clang-tidy/readability-simd-intrinsics.cpp
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityT
erichkeane updated this revision to Diff 133458.
erichkeane added a comment.
rebased, reflowed tests.
https://reviews.llvm.org/D43045
Files:
include/clang/Basic/Cuda.h
lib/Basic/Cuda.cpp
lib/Basic/Targets/NVPTX.cpp
lib/Basic/Targets/NVPTX.h
test/Misc/target-invalid-cpu-note.c
Index:
erichkeane updated this revision to Diff 133459.
erichkeane added a comment.
rebased, reflowed tests.
https://reviews.llvm.org/D43057
Files:
lib/Basic/Targets/AMDGPU.cpp
lib/Basic/Targets/AMDGPU.h
lib/Basic/Targets/AVR.cpp
lib/Basic/Targets/AVR.h
lib/Basic/Targets/BPF.cpp
lib/Basic/
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM with an inline comment.
Comment at: include/clang/Basic/Cuda.h:49
SM_72,
+ LAST,
};
We have last, invalid, etc... maybe we should pick one amon
Author: marshall
Date: Thu Feb 8 11:33:03 2018
New Revision: 324640
URL: http://llvm.org/viewvc/llvm-project?rev=324640&view=rev
Log:
The apple versions of clang don't support deduction guides yet.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cp
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
I've glanced at this and didn't notice anything. I think any problems can be
fixed in post-commit review if necessary.
https://reviews.llvm.org/D43057
_
Author: arsenm
Date: Thu Feb 8 11:37:09 2018
New Revision: 324641
URL: http://llvm.org/viewvc/llvm-project?rev=324641&view=rev
Log:
Fix crash on array initializer with non-0 alloca addrspace
Modified:
cfe/trunk/lib/CodeGen/CGDecl.cpp
cfe/trunk/test/CodeGenOpenCL/address-space-constant-in
arsenm closed this revision.
arsenm added a comment.
r324641
https://reviews.llvm.org/D43078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
Nit: Generally speaking th
Fair. Did you want to handle this a different way? I thought the list at
least seemed reasonable for spelling.
On Thu, Feb 8, 2018, 11:44 AM Artem Belevich via Phabricator <
revi...@reviews.llvm.org> wrote:
> tra added inline comments.
>
>
>
> Comment at: test/Misc/target-invalid
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D42581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
erichkeane added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
tra wrote:
> Nit: G
tra added inline comments.
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
erichkeane wrote:
> tra wr
Author: erichkeane
Date: Thu Feb 8 12:04:22 2018
New Revision: 324644
URL: http://llvm.org/viewvc/llvm-project?rev=324644&view=rev
Log:
Fix improper indentation issue in CodeGenModule [NFC]
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
U
Author: ctopper
Date: Thu Feb 8 12:16:17 2018
New Revision: 324647
URL: http://llvm.org/viewvc/llvm-project?rev=324647&view=rev
Log:
[X86] Replace kortest intrinsics with native IR.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: cfe/tru
MTC added a comment.
@NoQ Sorry to bother you again. It seems that this patch is useless to analyzer
temporarily, if you think so, I will abandon it : ).
Repository:
rC Clang
https://reviews.llvm.org/D42300
___
cfe-commits mailing list
cfe-commi
MaskRay updated this revision to Diff 133474.
MaskRay added a comment.
Herald added subscribers: kbarton, nemanjai.
Split test/clang-tidy/readability-simd-intrinsics.cpp to x86 and ppc
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLis
NoQ updated this revision to Diff 133475.
NoQ added a comment.
Add a simple test for a class with no destructor.
https://reviews.llvm.org/D43062
Files:
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
test/Analysis/temporaries.cpp
Index: test/Analysis/temporaries.cpp
=
MaskRay updated this revision to Diff 133476.
MaskRay added a comment.
.rst
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/SIMDIntrinsicsCheck.cpp
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
All right, i guess we already do have a pair of callbacks for `IntegerLiteral`
and it doesn't hurt, especially because here they'd eventually be actually
useful. I think it should land, just to make
simark added a comment.
In https://reviews.llvm.org/D35894#1001875, @ilya-biryukov wrote:
> Thanks for picking this up!
> I have just one major comment related to how we generate the hover text.
>
> Current implementation tries to get the actual source code for every
> declaration and then patc
NoQ added a comment.
Hmm, maybe it'd also be a good idea to disable the check completely when a
likely-correct value for the macro cannot be determined.
Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:74-75
+ mgr.registerChecker();
+ Mwec->ProtExecOv =
+
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Tests look good. You can't test deadcode :)
https://reviews.llvm.org/D42745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: arphaman
Date: Thu Feb 8 13:20:43 2018
New Revision: 324651
URL: http://llvm.org/viewvc/llvm-project?rev=324651&view=rev
Log:
PR36307: Consume the #pragma options align annotation token after
semantic analysis to prevent incorrect -Wpragma-pack warning for an included
file
rdar://3735495
Author: george.karpenkov
Date: Thu Feb 8 13:22:42 2018
New Revision: 324652
URL: http://llvm.org/viewvc/llvm-project?rev=324652&view=rev
Log:
[analyzer] [tests] Test different projects concurrently
Differential Revision: https://reviews.llvm.org/D43031
Modified:
cfe/trunk/utils/analyzer/SAT
NoQ added a comment.
All right, so this change is indeed safe, i.e. no crashes or changes in
analyzer behavior so far on my large codebase run. Will commit now.
https://reviews.llvm.org/D42672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ accepted this revision.
NoQ added a comment.
Woohoo thanks nice.
Repository:
rC Clang
https://reviews.llvm.org/D43074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 172 matches
Mail list logo
