Fair. Did you want to handle this a different way? I thought the list at
least seemed reasonable for spelling.
On Thu, Feb 8, 2018, 11:44 AM Artem Belevich via Phabricator <
revi...@reviews.llvm.org> wrote:

> tra added inline comments.
>
>
> ================
> Comment at: test/Misc/target-invalid-cpu-note.c:38
> +// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32,
> sm_35,
> +// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70,
> sm_72
> ----------------
> Nit: Generally speaking this note is false. For any given version of CUDA,
> some of the listed GPU variants will not be accepted. E.g. CUDA versions
> before 9.1 do not know anything about sm_72, but CUDA-9.1  does not
> supports sm_20.
>
>
> https://reviews.llvm.org/D43045
>
>
>
>
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to