Hahnfeld updated this revision to Diff 132103.
Hahnfeld marked 3 inline comments as done.
Hahnfeld added a comment.
Add some `sysroot` arguments to new test to make sure it doesn't accidentally
find CUDA installations in the system.
https://reviews.llvm.org/D42642
Files:
include/clang/Driver
Author: hahnfeld
Date: Wed Jan 31 00:26:51 2018
New Revision: 323848
URL: http://llvm.org/viewvc/llvm-project?rev=323848&view=rev
Log:
[CUDA] Detect installation in PATH
If the CUDA toolkit is not installed to its default locations
in /usr/local/cuda, the user is forced to specify --cuda-path.
Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323848: [CUDA] Detect installation in PATH (authored by
Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42642?vs=132103&id=132104#to
ilya-biryukov updated this revision to Diff 132105.
ilya-biryukov added a comment.
- An initial version of thread-per-file approach.
This is by no means a final version, we should definitely move things between
files, do some renames, etc. before landing the final version.
Some things are not us
ilya-biryukov updated this revision to Diff 132107.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
Addressed last review comments:
- Rename blockingRead to blockingRun
- Added a comment to ThreadPool's destructor
Repository:
rCTE Clang Tools Extra
https://revi
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.h:23
+/// synchronously).
+unsigned getDefaultAsyncThreadsCount();
+
sammccall wrote:
> just use llvm::hardware_concurrency()?
It can return 0, which will cause clangd to run synchronously. This
Author: ibiryukov
Date: Wed Jan 31 00:51:16 2018
New Revision: 323851
URL: http://llvm.org/viewvc/llvm-project?rev=323851&view=rev
Log:
[clangd] Refactored threading in ClangdServer
Summary:
We now provide an abstraction of Scheduler that abstracts threading
and resource management in ClangdServe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323851: [clangd] Refactored threading in ClangdServer
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42174
Files:
clan
jolesiak added inline comments.
Comment at: lib/Format/Format.cpp:765
GoogleStyle.ColumnLimit = 100;
+GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never;
}
If I understand correctly this is meant to be ObjC-specific flag. I feel like
this s
sammccall added a comment.
Really sorry about the delay in getting to this.
At a high level, I'm most concerned about:
- the monolithic in-memory intermediate format, which seems to put hard limits
on performance and scalability
- having high-level documentation and clear APIs
- having multiple
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:708
+// Find old.h includes "old.h".
+if (AbsoluteOldHeader == AbsoluteOldHeader) {
+ OldHeaderIncludeRangeInHeader = IncludeFilenameRange;
io
hokein updated this revision to Diff 132111.
hokein marked an inline comment as done.
hokein added a comment.
address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42639
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
unittests/clang-move/ClangMov
alexfh added inline comments.
Comment at: clang-tidy/ClangTidyOptions.h:93
+ /// \brief Show color diagnostics.
+ llvm::Optional ShowColor;
+
itessier wrote:
> alexfh wrote:
> > This doesn't belong to ClangTidyOptions. It's specific to the CLI, but CLI
> > is
hokein added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:115
+
+bool prefixedPropertyNameMatches(const llvm::StringRef &PropertyName,
+ const std::vector &Acronyms) {
benhamilton wrote:
> Wizard wrote:
alexfh added inline comments.
Comment at: test/clang-tidy/show-color.cpp:7
+ int *value = 0;
+ // CHECK-COLOR: [[BOLD:.\[1m]]{{.*}}[[@LINE+2]]:10:
[[RESET:.\[0m]][[MAGENTA:.\[0;1;35m]]warning: [[RESET]][[BOLD]]Dereference of
null pointer (loaded from variable 'value')
[clang
Author: ibiryukov
Date: Wed Jan 31 01:50:21 2018
New Revision: 323859
URL: http://llvm.org/viewvc/llvm-project?rev=323859&view=rev
Log:
[clangd] Attempt to fix compilation breakage with MSVC.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Modified: clang-tools-extra/trunk/clangd/C
Author: krasimir
Date: Wed Jan 31 02:14:10 2018
New Revision: 323860
URL: http://llvm.org/viewvc/llvm-project?rev=323860&view=rev
Log:
[clang-format] Adds space around braces in text protos
Summary:
This patch modifies the text proto Google style to add spaces around braces.
I investigated using
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323860: [clang-format] Adds space around braces in text
protos (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42685?vs=131947&id=132117#toc
Repository:
rC C
krasimir created this revision.
krasimir added a reviewer: djasper.
Herald added subscribers: cfe-commits, klimek.
This patch adds spaces around angle brackets in text proto Google style.
Previously these were detected as template openers and closers, which happened
to have the expected effect. No
krasimir updated this revision to Diff 132121.
krasimir added a comment.
- Remove braces around single statement
Repository:
rC Clang
https://reviews.llvm.org/D42727
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/For
hokein updated this revision to Diff 132122.
hokein marked 4 inline comments as done.
hokein added a comment.
- address review comments.
- add tests for indexing main files
- use SourceLocation.printToString
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42575
Files:
clangd/i
hokein updated this revision to Diff 132123.
hokein added a comment.
Update test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42575
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/Annotations.cpp
unittests/clangd/Annotations.h
unittests/clangd/SymbolCollecto
hokein added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:108
+std::string PrintableLoc(SourceLocation Loc, SourceManager &SM) {
+ if (Loc.isInvalid())
ioeric wrote:
> `PrintLoc`? `PrintableLoc` sounds like a checker for whether a location is
Typz created this revision.
Typz added reviewers: krasimir, djasper, klimek.
In some case, the heuristic used to identify the type of blocks (in
UnwrappedLineParser) mistakens a Block for a BracedInit, when the
TokenAnnotator eventually finds (correclty) that this is a function
declaration.
This
Typz updated this revision to Diff 132130.
Typz added a comment.
update commit message
Repository:
rC Clang
https://reviews.llvm.org/D42729
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
massberg created this revision.
massberg added a reviewer: alexfh.
Herald added subscribers: cfe-commits, hintonda, mgorny.
In C++17 several classes, types and functions from functional.h are no longer
available.
In this change we add first clang-tidy checks for occurrences of
- std::unary_funct
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: ibiryukov
Date: Wed Jan 31 03:26:43 2018
New Revision: 323863
URL: http://llvm.org/viewvc/llvm-project?rev=323863&view=rev
Log:
[clangd] Second attempt to fix MSVC compilation breakage.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Modified: clang-tools-extra/trunk/clangd
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clangd/index/SymbolCollector.cpp:127
+// location instead.
+if (llvm::StringRef(PrintableLoc(Loc, SM)).startswith(" ioeric wrote:
> > To reduce some co
alexfh added a comment.
Thank you for this new check! A few minor comments (mostly style issues).
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.cpp:37
+void AvoidFunctionalCheck::check(const MatchFinder::MatchResult &Result) {
+ if (const auto* const un_or_binary_deriv
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:77
+ /// See WithContext and WithContextValue for how to do this safely.
+ static Context ¤t();
Maybe we could return `const Context&` here and have a separate `setCurrent()`
method for replac
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/IoFunctionsMisusedCheck.cpp:33
+ has(cxxMemberCallExpr(
+ on(hasType(namedDecl(matchesName("istream"))
Author: jroelofs
Date: Wed Jan 31 04:06:15 2018
New Revision: 323864
URL: http://llvm.org/viewvc/llvm-project?rev=323864&view=rev
Log:
Fix typo. NFC
Modified:
cfe/trunk/www/analyzer/scan-build.html
Modified: cfe/trunk/www/analyzer/scan-build.html
URL:
http://llvm.org/viewvc/llvm-project/cfe
jkorous-apple updated this revision to Diff 132135.
jkorous-apple added a comment.
Tried to make test more readable.
https://reviews.llvm.org/D42170
Files:
FixIt/fixit-typedef-instead-of-typename-typo.cpp
Parse/ParseTemplate.cpp
clang/Basic/DiagnosticParseKinds.td
Index: FixIt/fixit-typ
Author: hokein
Date: Wed Jan 31 04:12:29 2018
New Revision: 323865
URL: http://llvm.org/viewvc/llvm-project?rev=323865&view=rev
Log:
[clang-move] Clever on handling header file which includes itself.
Summary:
Previously, we assume only old.cc includes "old.h", which would
introduce incorrect fixe
jkorous-apple added a comment.
Thanks for your patience with me still learning lit/filecheck. What do you
think about the test now? I totally agree that this is subjective matter but I
appreciate your feedback.
https://reviews.llvm.org/D42170
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323865: [clang-move] Clever on handling header file which
includes itself. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42639?vs=132111&id=132136#toc
Reposi
massberg updated this revision to Diff 132137.
massberg retitled this revision from "Add clang-tidy check for use of
types/classes/functions from functional.h which are deprecated and removed in
C++17" to "Add clang-tidy check for use of types/classes/functions from
header which are deprecated
Typz added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1911
+ if (Next && Next->is(tok::l_brace) && Next->BlockKind == BK_BracedInit)
+ Next->BlockKind = BK_Block;
+}
this may actually not be enough in all cases: to completely mat
sdesmalen added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:990
+ D.getLocation(), D.getLocation(), &NameIdent, QT,
+ getContext().CreateTypeSourceInfo(QT), SC_Auto);
+
aprantl wrote:
> sdesmalen wrote:
> > aprantl wrote:
> > > I think i
sammccall marked 3 inline comments as done.
sammccall added a comment.
Thanks!
Comment at: clangd/Context.h:77
+ /// See WithContext and WithContextValue for how to do this safely.
+ static Context ¤t();
ilya-biryukov wrote:
> Maybe we could return `const C
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clangd/JSONRPCDispatcher.h:60
+/// Current context must derive from JSONRPCDispatcher::Handler.
+void reply(json::Expr &&Result);
+/// Sends an error response to the client, and logs it.
ilya-biryukov added a comment.
I don't see a patch corresponding to the fixed comments. `arc diff` didn't go
through?
Comment at: clangd/Trace.cpp:131
+return Context::current().clone();
+ WithContextValue WithArgs{std::unique_ptr(Args)};
+ return T->beginSpan(Name, Args
Author: hokein
Date: Wed Jan 31 04:56:51 2018
New Revision: 323867
URL: http://llvm.org/viewvc/llvm-project?rev=323867&view=rev
Log:
[clangd] Better handling symbols defined in macros.
Summary:
For symbols defined inside macros:
* use expansion location, if the symbol is formed via macro concate
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323867: [clangd] Better handling symbols defined in
macros. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42575?vs=132123&id=132143#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323867: [clangd] Better handling symbols defined in macros.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42575?vs=1321
ilya-biryukov added inline comments.
Comment at: clangd/JSONRPCDispatcher.h:60
+/// Current context must derive from JSONRPCDispatcher::Handler.
+void reply(json::Expr &&Result);
+/// Sends an error response to the client, and logs it.
sammccall wrote:
> ilya-bir
sammccall added a comment.
In https://reviews.llvm.org/D42517#993131, @ilya-biryukov wrote:
> I don't see a patch corresponding to the fixed comments. `arc diff` didn't go
> through?
Indeed, sorry. Should be up to date now.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D4251
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM modulo two NITs.
Really excited to see this land.
Comment at: clangd/Context.cpp:32
+
+Context Context::swap(Context Replacement) {
+ std::swap(Replacemen
djasper added a comment.
I think this case is not important enough to fix. Please tell users to just
delete the useless semicolon.
In particular, my concern is that this makes the data-flow significantly more
complicated. Early on in the development, we had separate token classes for the
diffe
yvvan updated this revision to Diff 132146.
yvvan added a comment.
Use https://reviews.llvm.org/D42474 code. Add missing parts and tests for
errors and fixits.
https://reviews.llvm.org/D41537
Files:
include/clang-c/Index.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Cod
Author: alexfh
Date: Wed Jan 31 05:31:51 2018
New Revision: 323871
URL: http://llvm.org/viewvc/llvm-project?rev=323871&view=rev
Log:
Update header guard.
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/IncorrectRoundingsCheck.h
Modified: clang-tools-extra/trunk/clang-tidy/bugprone/Inco
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clangd/Context.h:196
+ ~WithContext() {
+if (Restore)
+ Context::swap(std::move(*Restore));
ilya-biryukov wrote:
> I think it can't be `null` after move ctor is del
Typz added a comment.
There are actually other cases, e.g. with macros "containing" the semicolon:
void abort() {
FOO()
BAR()
};
gets reformatted to this (still wrong with this patch, but the space after the
parenthesis is added):
void abort(){ FOO() BAR() };
And also this one (
Typz added a comment.
In https://reviews.llvm.org/D42729#993159, @djasper wrote:
> I think this case is not important enough to fix. Please tell users to just
> delete the useless semicolon.
I would agree if were simple to spot: but often this may manifest itself only
with a missing space bet
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.cpp:21
+void AvoidFunctionalCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(
+ cxxRecordDecl(allOf(anyOf(isDerivedFrom("std::binary_function"),
I
sammccall added a comment.
Not a complete review, but this looks pretty good!
You probably want to read the last comment first - the gc thread is the
threadpooliest bit of code left, and you may (or may not) want to eliminate it.
Comment at: clangd/TUScheduler.cpp:23
+retu
Anastasia closed this revision.
Anastasia added a comment.
Committed in r323875 with changes as requested.
https://reviews.llvm.org/D42307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
This should also fix the current windows buildbot breakage
(http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/9838/steps/ninja%20check%20
chill created this revision.
chill added reviewers: dblaikie, keith.walker.arm.
Herald added subscribers: JDevlieghere, aprantl.
This is the `clang` counterpart to https://reviews.llvm.org/D42734
This patch:
- fixed an incorrect sign-extension of unsigned values, when emitting debug
info metad
massberg updated this revision to Diff 132169.
massberg added a comment.
Addressed comments of reviewer.
https://reviews.llvm.org/D42730
Files:
clang-tidy/modernize/AvoidFunctionalCheck.cpp
clang-tidy/modernize/AvoidFunctionalCheck.h
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modern
massberg marked 6 inline comments as done.
massberg added a comment.
Alex and Aaron, thanks for the comments!
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.cpp:21
+void AvoidFunctionalCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(
+ cxxRecord
Anastasia added a comment.
In https://reviews.llvm.org/D41699#990894, @yaxunl wrote:
> whereas the old definition may fail to detect (not always, only for certain
> combinations).
For this reason I think it would be good to fix this. I don't think it's good
to report errors inconsistently
>
massberg marked 4 inline comments as done.
massberg added inline comments.
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19
+
+/// Check for several deprecated types and classes from header
+///
massberg wrote:
> aaron.ballman wrote:
> > Missing full s
miyuki added inline comments.
Comment at: include/regex:3465
+case '{':
+case '}':
+break;
Quuxplusone wrote:
> FWIW, I don't understand what's going on in this switch.
> Is it intentional that `'('` and `'|'` now take diff
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.cpp:220
+
+ GCThread.cleanupFile(std::move(Data->Worker));
}
sammccall wrote:
> in the spirit of "just spawn a thread, and write direct code"...
>
> can we just spawn a shared_ptr to do the wo
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this once and for all!
Comment at: clangd/ClangdLSPServer.cpp:23
+/// \brief Supports a test URI scheme with relaxed constraints for lit tests.
+/// T
sfertile added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:750
+ // If we can use a plt entry as the symbol address we can assume it
+ // is local.
+ if (isa(D) && !CGOpts.NoPLT)
I don't think this is the case. I think this would break ppc
nik abandoned this revision.
nik added a comment.
Abandoning since the change is already in.
Repository:
rC Clang
https://reviews.llvm.org/D42099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.h:63
+ Context Ctx, ParseInputs Inputs,
+ UniqueFunction>)>
+ OnUpdated);
sammccall wrote:
> do we want to move the callback to be a clangd-global thing, rather than a
> per-u
djasper added a comment.
I don't think cases where there is only a semicolon-less macro are particularly
frequent/important either. You probably could even add a semicolon in those
cases, right? How frequent are such cases in your codebase? Either way, they
aren't fixed by this patch, so they a
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19
+
+/// Check for several deprecated types and classes from header
+///
massberg wrote:
> massberg wrote:
> > aaron.ballman wrote:
> > > Missing full stop at the end o
Author: ioeric
Date: Wed Jan 31 08:26:27 2018
New Revision: 323885
URL: http://llvm.org/viewvc/llvm-project?rev=323885&view=rev
Log:
[clangd] Add a test URI scheme for lit tests to unbreak platform-specific URI
failures.
Summary:
This should also fix the current windows buildbot breakage
(http:/
ioeric updated this revision to Diff 132180.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42735
Files:
clangd/ClangdLSPServer.cpp
clangd/Protocol.cpp
test/clangd/authority-less
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323885: [clangd] Add a test URI scheme for lit tests to
unbreak platform-specific URI… (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42735?vs=132180&id=132181
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323885: [clangd] Add a test URI scheme for lit tests to
unbreak platform-specific URI… (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
sammccall created this revision.
sammccall added reviewers: ilya-biryukov, bkramer.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek.
thread_local has nice syntax and semantics, but requires __cxa_thread_atexit,
and some not-ancient runtime libraries don't provide it.
The clang
benhamilton updated this revision to Diff 132185.
benhamilton added a comment.
Move to general property section
Repository:
rC Clang
https://reviews.llvm.org/D42708
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
=
benhamilton marked an inline comment as done.
benhamilton added inline comments.
Comment at: lib/Format/Format.cpp:765
GoogleStyle.ColumnLimit = 100;
+GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never;
}
jolesiak wrote:
> If I understand co
benhamilton updated this revision to Diff 132187.
benhamilton marked 2 inline comments as done.
benhamilton added a comment.
- BinPackObjCProtocolList -> ObjCBinPackProtocolList
Repository:
rC Clang
https://reviews.llvm.org/D42650
Files:
include/clang/Format/Format.h
lib/Format/Continuat
benhamilton added inline comments.
Comment at: lib/Format/Format.cpp:765
GoogleStyle.ColumnLimit = 100;
+GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never;
}
benhamilton wrote:
> jolesiak wrote:
> > If I understand correctly this is meant t
benhamilton updated this revision to Diff 132188.
benhamilton marked an inline comment as done.
benhamilton added a comment.
- BinPackObjCProtocolList -> ObjCBinPackProtocolList
Repository:
rC Clang
https://reviews.llvm.org/D42708
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestO
sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D37831#871238, @dschuff wrote:
> I think the reasoning was really just that code size reduction is even more
> important on wasm than other platforms, and because
benhamilton updated this revision to Diff 132189.
benhamilton added a comment.
Fix comment.
Repository:
rC Clang
https://reviews.llvm.org/D42708
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
=
aprantl requested changes to this revision.
aprantl added a comment.
This revision now requires changes to proceed.
The correct way to fix this is to generate the stack object unconditionally (it
will get optimized away by mem2reg when optimizations are enabled) and only
emit the dbg.declare whe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins
functions (authored by dfukalov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42578
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins
functions (authored by dfukalov, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D42578
Files:
include/clang/Basic/BuiltinsAMDGPU
> On Jan 30, 2018, at 4:32 PM, Saleem Abdulrasool wrote:
>
> Thanks for the note here. I’ll try to take a look at that, but, yes, the
> frontend change itself is correct. I’ve seen many, many places where the
> ObjCARC passes break down in the backend, and I’ve filed a few bugs on it in
>
bsdjhb added a comment.
My only question is if we want an OS version check as the FreeBSD driver does
now for libc++ vs libstdc++? FreeBSD started using libcompiler_rt for
libgcc.a in 9.0.
Repository:
rC Clang
https://reviews.llvm.org/D42310
dschuff added a comment.
In https://reviews.llvm.org/D37831#992822, @sbc100 wrote:
> After a little discussion about this and the -gc-sections linker flag, the
> augments for the tools having sensible defaults seem to be winning.
Well sure, when you put it that way, nobody can argue against se
Typz updated this revision to Diff 132198.
Typz added a comment.
Force wrap after multi-line template declaration
Repository:
rC Clang
https://reviews.llvm.org/D42684
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/TokenAnnota
alexfh added inline comments.
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19
+
+/// Check for several deprecated types and classes from header
+///
aaron.ballman wrote:
> massberg wrote:
> > massberg wrote:
> > > aaron.ballman wrote:
> > > > Missing
alexfh added inline comments.
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19
+
+/// Check for several deprecated types and classes from header
+///
alexfh wrote:
> aaron.ballman wrote:
> > massberg wrote:
> > > massberg wrote:
> > > > aaron.ballman w
kubamracek added a comment.
Cool. Can we get a lit test as well?
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D42644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19
+
+/// Check for several deprecated types and classes from header
+///
alexfh wrote:
> alexfh wrote:
> > aaron.ballman wrote:
> > > massberg wrote:
> > > > massberg w
m.ostapenko added a comment.
In https://reviews.llvm.org/D16403#992452, @NoQ wrote:
> Thank you, this explanation looks very reasonable.
>
> All right, so right after the termination of the loop we have
>
> [B1]
> 1: ForStmt (LoopExit)
> 2: [B4.5].~A() (Implicit destructor)
> 3: [B5.3].~A
khuttun added a comment.
Herald added a subscriber: hintonda.
Any more comments on this?
https://reviews.llvm.org/D41655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
One small note about `-fdiagnostics-parseable-fixits`. The rest looks good to
me. And the test looks readable.
Comment at: FixIt/fixit-typedef-instead-of-typename-typo.cpp
sp4r74n-117 created this revision.
sp4r74n-117 added reviewers: george.karpenkov, dcoughlin, dergachev.a.
sp4r74n-117 created this object with visibility "All Users".
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
Added evaluation of __builtin_constant_p to the dedicated Stat
Author: apazos
Date: Wed Jan 31 10:11:09 2018
New Revision: 323894
URL: http://llvm.org/viewvc/llvm-project?rev=323894&view=rev
Log:
Revert "Revert rC322769: [RISCV] Propagate -mabi and -march values to GNU
assembler."
Summary: Bringing back the code change and simplified test cases to test 32/6
1 - 100 of 180 matches
Mail list logo
