alexfh added inline comments.
================ Comment at: test/clang-tidy/show-color.cpp:7 + int *value = 0; + // CHECK-COLOR: [[BOLD:.\[1m]]{{.*}}[[@LINE+2]]:10: [[RESET:.\[0m]][[MAGENTA:.\[0;1;35m]]warning: [[RESET]][[BOLD]]Dereference of null pointer (loaded from variable 'value') [clang-analyzer-core.NullDereference][[RESET]] + // CHECK-NO-COLOR: [[@LINE+1]]:10: warning: Dereference of null pointer (loaded from variable 'value') [clang-analyzer-core.NullDereference] ---------------- nit: I'd prefer to depend on the wording and format of static analyzer warnings only where necessary. Static analyzer is in a different repository and when it changes, it's a bit more difficult for folks to detect failures in clang-tidy. Here we could use any native clang-tidy check instead. https://reviews.llvm.org/D41720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits