Re: [libcxx] r323380 - [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

Hi Eric, I am getting a build failure after this revision: llvm/projects/libcxx/include/tuple:175:27: error: no return statement in constexpr function static constexpr bool __can_bind_reference() { ^ 1 error generated. It looks like if the #if in __can_bind_referenc

[PATCH] D42508: AST: support protocol conformances on id/class/interfaces in MS ABI

compnerd created this revision. compnerd added reviewers: rjmccall, rnk. Herald added a subscriber: cfe-commits. Add support for mangling ObjC protocol conformances in MS ABI as if they are COM interfaces. By diverging from the itanium mangling of `objc_protocol` prefixed names, this approach a

Re: [libcxx] r323380 - [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

Looking. On Wed, Jan 24, 2018 at 3:52 PM, Richard Trieu wrote: > Hi Eric, > > I am getting a build failure after this revision: > > llvm/projects/libcxx/include/tuple:175:27: error: no return statement in > constexpr function > static constexpr bool __can_bind_reference() { >

r323387 - FreeBSD needs also execinfo (in sanitizers)

Author: kamil Date: Wed Jan 24 15:08:49 2018 New Revision: 323387 URL: http://llvm.org/viewvc/llvm-project?rev=323387&view=rev Log: FreeBSD needs also execinfo (in sanitizers) Summary: As NetBSD, FreeBSD needs execinfo for backtrace's matters. Patch by: David CARLIER. Reviewers: joerg, vitalybu

Re: [libcxx] r323380 - [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

Sorry for the breakage. Fixed in r323389. On Wed, Jan 24, 2018 at 4:08 PM, Eric Fiselier wrote: > Looking. > > On Wed, Jan 24, 2018 at 3:52 PM, Richard Trieu wrote: > >> Hi Eric, >> >> I am getting a build failure after this revision: >> >> llvm/projects/libcxx/include/tuple:175:27: error: no r

[libcxx] r323389 - Fix missing return in __tuple_leaf::__can_bind_reference when __reference_binds_to_temporary added in r323380.

Author: ericwf Date: Wed Jan 24 15:10:02 2018 New Revision: 323389 URL: http://llvm.org/viewvc/llvm-project?rev=323389&view=rev Log: Fix missing return in __tuple_leaf::__can_bind_reference when __reference_binds_to_temporary added in r323380. Modified: libcxx/trunk/include/tuple Modified:

[PATCH] D42467: FreeBSD needs also execinfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL323387: FreeBSD needs also execinfo (in sanitizers) (authored by kamil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42467?vs=131359&id=131

[PATCH] D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

timshen added a comment. `__can_bind_reference()` doesn't return anything when __reference_binds_to_temporary doesn't exist. This causes builds break with old compilers. Should it just return true if __reference_binds_to_temporary doesn't exist? Repository: rCXX libc++ https://reviews.llvm

Re: [PATCH] D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

Yes, it should. That was a silly mistake, and should already have been fixed in trunk. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

timshen added a comment. Created https://reviews.llvm.org/D42510 for discussion. I'm not sure if it's a good idea, though. Repository: rCXX libc++ https://reviews.llvm.org/D41977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D42510: [libcxx] Always allow temporary binding when __reference_binds_to_temporary doesn't exist

timshen created this revision. timshen added reviewers: EricWF, rsmith. Herald added a subscriber: sanjoy. This is a follow-up to https://reviews.llvm.org/D41977. https://reviews.llvm.org/D42510 Files: libcxx/include/tuple Index: libcxx/include/tuple

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131368. Wizard marked an inline comment as done. Wizard added a comment. check for class extentsion Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-prop

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard marked 7 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:120 + auto RegexExp = llvm::Regex( + llvm::StringRef(validPropertyNameRegex(Acronyms).replace(0, 2, "^"))); + return RegexExp.match(llvm::StringR

[PATCH] D42357: Under limitation of allocated buffer, inplace_merge() does NOT take usage of partial allocated buffer but applies native rotate directly.

WeiChungChang added a comment. Here gives the comparison after fix. F5783231: o1.png It is better now but still slower; also, one could notice the standard variance (each round the execution time is unstable even the input is uniform) The problem will be sho

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, that works, thanks! LGTM. https://reviews.llvm.org/D41539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[libcxx] r323390 - Fix PR35564 - std::list splice/erase incorrectly throw in debug mode.

Author: ericwf Date: Wed Jan 24 16:02:48 2018 New Revision: 323390 URL: http://llvm.org/viewvc/llvm-project?rev=323390&view=rev Log: Fix PR35564 - std::list splice/erase incorrectly throw in debug mode. There was a bug in the implementation of splice where the container sizes were updated before

[PATCH] D42490: [cmake] Set cmake policy CMP0068 to suppress warnings on OSX

hintonda added a comment. It turns out that policies don't survive a call to `cmake_minimum_required()`, so we need to rethink how llvm, et al, handles policies, e.g.: - move `cmake_minimum_required()` inside the `if( CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR )` branch. - move all `cma

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

tra created this revision. tra added reviewers: jlebar, jholewinski. Herald added subscribers: hintonda, mgorny, sanjoy. Clang can use CUDA-9.1 now, though new builtins (__hmma_m32n8k16*) are not implemented yet. The major change is that headers in CUDA-9.1 went through substantial changes that

Re: [libcxx] r323380 - [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

Thanks, Eric. On Wed, Jan 24, 2018 at 3:11 PM, Eric Fiselier wrote: > Sorry for the breakage. Fixed in r323389. > > On Wed, Jan 24, 2018 at 4:08 PM, Eric Fiselier wrote: > >> Looking. >> >> On Wed, Jan 24, 2018 at 3:52 PM, Richard Trieu wrote: >> >>> Hi Eric, >>> >>> I am getting a build failu

[PATCH] D42508: AST: support protocol conformances on id/class/interfaces in MS ABI

majnemer added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:2459-2465 + if (T->isObjCId()) +mangleSourceName("objc_object"); + else if (T->isObjCClass()) +mangleSourceName("objc_class"); + else +mangleSourceName(T->getInterface()->getName()); +

[PATCH] D42508: AST: support protocol conformances on id/class/interfaces in MS ABI

rjmccall added a comment. The basic idea here seems fine to me; I'll leave David to review the details. Repository: rC Clang https://reviews.llvm.org/D42508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing inline comments. Do you have commit access? If not, I'll commit once updated. Comment at: test/std/utilities/function.objects/refwrap/refwrap.const/ty

[libcxxabi] r323397 - [libc++abi] Fix unused function when building with LIBCXXABI_SILENT_TERMINATE

Author: pcc Date: Wed Jan 24 17:38:43 2018 New Revision: 323397 URL: http://llvm.org/viewvc/llvm-project?rev=323397&view=rev Log: [libc++abi] Fix unused function when building with LIBCXXABI_SILENT_TERMINATE This fixes: src/cxa_default_handlers.cpp:25:13: error: unused function 'demangling_termi

[PATCH] D42508: AST: support protocol conformances on id/class/interfaces in MS ABI

compnerd updated this revision to Diff 131379. compnerd marked an inline comment as done. compnerd added a comment. scope the template back references and add a comment. https://reviews.llvm.org/D42508 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenObjCXX/msabi-protocol-conformance.mm Ind

[PATCH] D42219: [analyzer] Enable c++-allocator-inlining by default?

NoQ added a comment. I committed this for now, but i'm totally open for post-commit review and reacting on any "unknown unknowns" that may be found. Repository: rL LLVM https://reviews.llvm.org/D42219 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D42517: [clangd] RFC: Pass Context implicitly using TLS.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek. This is mostly to show what it would look like. I think it's pretty nice! The lit tests pass, but the unit tests don't build because I ripped out some

<    1   2