majnemer added inline comments.
================ Comment at: lib/AST/MicrosoftMangle.cpp:2459-2465 + if (T->isObjCId()) + mangleSourceName("objc_object"); + else if (T->isObjCClass()) + mangleSourceName("objc_class"); + else + mangleSourceName(T->getInterface()->getName()); + ---------------- Hmm, this is a template... I don't think this will do the right thing wrt backreferences. ================ Comment at: lib/AST/MicrosoftMangle.cpp:2468 + Out << 'Y'; + mangleSourceName(Q->getName()); + Out << '@'; ---------------- Probably want a comment stating that this is cointerface. Repository: rC Clang https://reviews.llvm.org/D42508 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits