[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: r322350 - [ODRHash] Don't hash friend functions.

That's good to hear. Thanks! 2018年1月17日(水) 13:51 Richard Trieu : > I feel it's best to merge this change into the release branch instead of > reverting the previous change. I've filed a bug to request this revision, > and a few others that fix the test case, to be merged. > https://bugs.llvm.org

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware added a comment. Thanks you for your comments! I have one question: Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1256 +if (Cond(Reg.second)) { + State = setIteratorPosition(State, Reg.first, Proc(Reg.second)); +} a

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:382 } + } else if (!isa(&Call)) { +// The main purpose of iterators is to abstract away from different

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1256 +if (Cond(Reg.second)) { + State = setIteratorPosition(State, Reg.first, Proc(Reg.second)); +} baloghadamsoftware wrote: > a.sidorin wrote: > > Updating

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 130113. JonasToth marked an inline comment as done. JonasToth added a comment. - [Misc] remove spurious format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp clang-tidy/cppc

[clang-tools-extra] r322624 - [clang-tidy] fix minor formatting issue

Author: jonastoth Date: Wed Jan 17 02:23:50 2018 New Revision: 322624 URL: http://llvm.org/viewvc/llvm-project?rev=322624&view=rev Log: [clang-tidy] fix minor formatting issue Modified: clang-tools-extra/trunk/clang-tidy/hicpp/HICPPTidyModule.cpp Modified: clang-tools-extra/trunk/clang-tidy/

[clang-tools-extra] r322626 - [clang-tidy] implement check for goto

Author: jonastoth Date: Wed Jan 17 02:27:41 2018 New Revision: 322626 URL: http://llvm.org/viewvc/llvm-project?rev=322626&view=rev Log: [clang-tidy] implement check for goto The usage of `goto` is discourage in C++ since forever. This check implements a warning for every `goto`. Even though there

[PATCH] D41815: [clang-tidy] implement check for goto

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322626: [clang-tidy] implement check for goto (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D41815?vs=130113&id=130115#toc Repository: rCTE Clang Tools E

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This should be fine. https://reviews.llvm.org/D41788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

alexfh added a comment. In https://reviews.llvm.org/D41708#977000, @hans wrote: > Alex, do you think the fix is still OK for the 6.0 branch? Let me know, and > I'll merge it. Yes, please. Thank you! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41708

[PATCH] D42071: [Sema] Add a callback in VisibleDeclConsumer allowing client to know which DeclContext is going to visit.

hokein updated this revision to Diff 130117. hokein marked 2 inline comments as done. hokein added a comment. Herald added a subscriber: mgorny. Refine the patch: - expose visited contexts to client by adding `getVisitedContexts` in CodeCompleteContext. - add unittest for sema code completion.

[PATCH] D42072: [Sema] Expose current scope in qualified-id code completion.

hokein abandoned this revision. hokein added a comment. This is not needed now, we decide to keep lookup logic in Sema instead of clangd side. Repository: rC Clang https://reviews.llvm.org/D42072 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: r322350 - [ODRHash] Don't hash friend functions.

Merged in r322632. On Wed, Jan 17, 2018 at 9:52 AM, NAKAMURA Takumi via cfe-commits wrote: > That's good to hear. Thanks! > > > 2018年1月17日(水) 13:51 Richard Trieu : >> >> I feel it's best to merge this change into the release branch instead of >> reverting the previous change. I've filed a bug to

[PATCH] D42164: [clangd] Don't crash on LSP calls for non-added files

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric, hokein. Herald added a subscriber: klimek. We will return errors for non-added files for now. Another alternative for clangd would be to read non-added files from disk and provide useful features anyway. There

[PATCH] D42164: [clangd] Don't crash on LSP calls for non-added files

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/ClangdLSPServer.cpp:153 + + auto Code = Server.getDocument(File); + if (!Code) don't you want to do this before computing repl

r322634 - [clang-format] Reorganize RawStringFormat based on language

Author: krasimir Date: Wed Jan 17 04:24:59 2018 New Revision: 322634 URL: http://llvm.org/viewvc/llvm-project?rev=322634&view=rev Log: [clang-format] Reorganize RawStringFormat based on language Summary: This patch changes the structure for raw string formatting options by making it language base

[PATCH] D42098: [clang-format] Reorganize RawStringFormat based on language

This revision was automatically updated to reflect the committed changes. Closed by commit rL322634: [clang-format] Reorganize RawStringFormat based on language (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42098

[PATCH] D42164: [clangd] Don't crash on LSP calls for non-added files

ilya-biryukov updated this revision to Diff 130127. ilya-biryukov added a comment. - Do the check in rename before calling into ClangdServer Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42164 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.

[PATCH] D42164: [clangd] Don't crash on LSP calls for non-added files

ilya-biryukov updated this revision to Diff 130125. ilya-biryukov added a comment. - Renamed crash.test to crash-non-added-files.test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42164 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h tes

[clang-tools-extra] r322637 - [clangd] Don't crash on LSP calls for non-added files

Author: ibiryukov Date: Wed Jan 17 04:30:24 2018 New Revision: 322637 URL: http://llvm.org/viewvc/llvm-project?rev=322637&view=rev Log: [clangd] Don't crash on LSP calls for non-added files Summary: We will return errors for non-added files for now. Another alternative for clangd would be to read

[PATCH] D42164: [clangd] Don't crash on LSP calls for non-added files

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:153 + + auto Code = Server.getDocument(File); + if (!Code) sammccall wrote: > don't you want to do this before computing replacements? Makes sense. Comment at: clangd

[PATCH] D42164: [clangd] Don't crash on LSP calls for non-added files

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322637: [clangd] Don't crash on LSP calls for non-added files (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D42164?vs=130127&id=130130#toc Repository: rC

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

hokein added inline comments. Comment at: clang-tools-extra/trunk/clang-tidy/objc/PropertyDeclarationCheck.cpp:45 +"FTP;" +"ID"; We also need to update the doc of the check. Repository: rL LLVM https://reviews.llvm.org/D42143 __

Re: [PATCH] D41837: Add Function multiversion to the release notes.

Did this functionality land before the 6.0 branch, that is, should we copy the release notes to the branch? Thanks Hans On Tue, Jan 9, 2018 at 12:37 AM, Erich Keane via Phabricator wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rC322043: Doc

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch adds enclosing function detection to raw string formatting. Repository: rC Clang https://reviews.llvm.org/D42167 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Co

Re: r322236 - In C++17, when instantiating an out-of-line definition of an inline static data

Merged to 6.0 in r322641. On Thu, Jan 11, 2018 at 12:08 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Jan 10 15:08:26 2018 > New Revision: 322236 > > URL: http://llvm.org/viewvc/llvm-project?rev=322236&view=rev > Log: > In C++17, when instantiating an out-of-line definitio

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

krasimir updated this revision to Diff 130142. krasimir added a comment. - Update comments Repository: rC Clang https://reviews.llvm.org/D42167 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h

[clang-tools-extra] r322602 - add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

Author: wizard Date: Tue Jan 16 16:19:35 2018 New Revision: 322602 URL: http://llvm.org/viewvc/llvm-project?rev=322602&view=rev Log: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix. Reviewers: benhamilton, hokein Rev

Re: [PATCH] D41881: [analyzer] Flag bcmp, bcopy and bzero as obsolete

I do not have commit access. Can you please commit this for me ? Tom On 01/12/2018 05:50 PM, Devin Coughlin via Phabricator wrote: dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Thanks for adding these! This looks good to me. Do

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

Hahnfeld created this revision. Hahnfeld added reviewers: gtbercea, ABataev, carlo.bertolli. Herald added subscribers: cfe-commits, guansong. If there are multiple files with target regions, each file and region must generate a unique name or the linker will complain. Repository: rC Clang htt

[PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks for fixing! https://reviews.llvm.org/D42157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

lebedev.ri added a comment. Thank you for working on this! Some thoughts below. Comment at: clang-tidy/readability/CMakeLists.txt:31 UniqueptrDeleteReleaseCheck.cpp + UnnecessaryIntermediateVarCheck.cpp Please upload patches with full context (`-U99`)

Re: r322390 - [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.

Merged in r322649. (Richard, please shout if you object to the merging; I figured since you lgtm'ed it, this would be fine.) On Fri, Jan 12, 2018 at 8:43 PM, Volodymyr Sapsai wrote: > Hans, I am nominating this change to be merged into 6.0.0 release branch. > > Thanks, > Volodymyr > >> On Jan 12

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware updated this revision to Diff 130149. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D32747 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/Inputs/sys

[PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

thakis closed this revision. thakis added a comment. r322652, thanks! https://reviews.llvm.org/D42157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r322652 - [clang-cl] Let /FA output use intel assembly.

Author: nico Date: Wed Jan 17 05:34:20 2018 New Revision: 322652 URL: http://llvm.org/viewvc/llvm-project?rev=322652&view=rev Log: [clang-cl] Let /FA output use intel assembly. cl's assembly output is in intel syntax, so clang-cl's should be too, PR35031. https://reviews.llvm.org/D42157 Modified

[PATCH] D42071: [Sema] Add visited contexts to CodeCompleteContext

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Look at the comments for a few NITs. Comment at: include/clang/Sema/CodeCompleteConsumer.h:271 + using VisitedContextSet = llvm::SmallPtrSet; + ---

[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

jkorous-apple created this revision. https://reviews.llvm.org/D42170 Files: Parse/ParseTemplate.cpp Parser/typedef-instead-of-typename-typo.hpp clang/Basic/DiagnosticParseKinds.td Index: Parser/typedef-instead-of-typename-typo.hpp ==

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

asb added a comment. In https://reviews.llvm.org/D41271#977222, @apazos wrote: > I tested this on windows and I had to add an assembler placeholder > executable, just like it was done with the linker in the RISCV multilib dir > checked under Inputs. > Other observations, are these known issue

[PATCH] D42071: [Sema] Add visited contexts to CodeCompleteContext

hokein updated this revision to Diff 130155. hokein marked 5 inline comments as done. hokein retitled this revision from " [Sema] Add visited contexts to CodeCompleteContext" to "[Sema] Add visited contexts to CodeCompleteContext". hokein edited the summary of this revision. hokein added a comment

[PATCH] D42071: [Sema] Add visited contexts to CodeCompleteContext

hokein added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:271 + using VisitedContextSet = llvm::SmallPtrSet; + ilya-biryukov wrote: > Given that lookup does not visit the same `DeclContext` twice, we're probably > fine with vector he

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

hans added a comment. In https://reviews.llvm.org/D41708#978186, @alexfh wrote: > In https://reviews.llvm.org/D41708#977000, @hans wrote: > > > Alex, do you think the fix is still OK for the 6.0 branch? Let me know, and > > I'll merge it. > > > Yes, please. Thank you! Oh, it was already merged

[PATCH] D42173: [clangd] Simplify code handling compile commands

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, bkramer. Herald added a subscriber: klimek. CppFile can now change compilation arguments during rebuild. This allows simplifying code that manages CppFiles. Repository: rCTE Clang Tools Extra https://reviews.llvm.o

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, bkramer. Herald added a subscriber: klimek. We now provide an abstraction of Scheduler that abstracts threading and resource management in ClangdServer. No changes to behavior are intended with an exception of changed e

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42177: DO NOT SUBMIT. Combined diff of D42174 and D42173.

ilya-biryukov created this revision. Herald added subscribers: cfe-commits, klimek. To simplify review of both changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42177 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

ilya-biryukov added a comment. Here's also a combined diff from both this and child revision: https://reviews.llvm.org/D42177 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42174 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1454 +// found. +static StringRef getEnclosingFunctionName(const FormatToken& Current) { + // Look for: 'function(' or 'function(' before Current. This function doesn't look clang-for

[libcxx] r322659 - Merging r321963:

Author: hans Date: Wed Jan 17 06:26:10 2018 New Revision: 322659 URL: http://llvm.org/viewvc/llvm-project?rev=322659&view=rev Log: Merging r321963: r321963 | dim | 2018-01-07 08:45:11 -0800 (Sun, 07 Jan 2018) | 51 lines Add

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

vladimir.plyashkun added a comment. Friendly ping Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r321963 - Add pre-C++11 is_constructible wrappers for 3 arguments

Merged to 6.0 in r322659. On Sun, Jan 7, 2018 at 5:45 PM, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Sun Jan 7 08:45:11 2018 > New Revision: 321963 > > URL: http://llvm.org/viewvc/llvm-project?rev=321963&view=rev > Log: > Add pre-C++11 is_constructible wrappers for 3 arguments >

[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

ilya-biryukov added a comment. LGTM, but could we add a test that checks the VFS is actually used? Repository: rC Clang https://reviews.llvm.org/D41947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

r322661 - [Sema] Add visited contexts to CodeCompleteContext

Author: hokein Date: Wed Jan 17 06:29:25 2018 New Revision: 322661 URL: http://llvm.org/viewvc/llvm-project?rev=322661&view=rev Log: [Sema] Add visited contexts to CodeCompleteContext Summary: This would allow code completion clients to know which context is visited during Sema code completion.

[PATCH] D42071: [Sema] Add visited contexts to CodeCompleteContext

This revision was automatically updated to reflect the committed changes. Closed by commit rC322661: [Sema] Add visited contexts to CodeCompleteContext (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D42071?vs=130155&id=130170#toc Repository: rC Clang

[PATCH] D42181: [clangd] Merge index-provided completions with those from Sema.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, mgrang, ilya-biryukov, klimek. - we match on USR, and do a field-by-field merge if both have results - scoring is post-merge, with both sets of information available (for now, sema priority

[PATCH] D41921: [Parse] Forward brace locations to TypeConstructExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D41921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

baloghadamsoftware updated this revision to Diff 130174. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Updated according to some comments. https://reviews.llvm.org/D32845 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/C

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

krasimir updated this revision to Diff 130177. krasimir added a comment. - Format a function Repository: rC Clang https://reviews.llvm.org/D42167 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.

RE: [PATCH] D41837: Add Function multiversion to the release notes.

It did not, I held it until just after the branch was made. -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: Wednesday, January 17, 2018 4:47 AM To: reviews+d41837+public+36225483e5851...@reviews.llvm.org Cc: Keane, Erich ; Richa

Re: [PATCH] D41837: Add Function multiversion to the release notes.

OK, thanks for clarifying. On Wed, Jan 17, 2018 at 4:18 PM, Keane, Erich wrote: > It did not, I held it until just after the branch was made. > > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans > Wennborg > Sent: Wednesday, January 17, 2018

[clang-tools-extra] r322668 - [clangd] Avoid divide-by-zero

Author: sammccall Date: Wed Jan 17 07:25:55 2018 New Revision: 322668 URL: http://llvm.org/viewvc/llvm-project?rev=322668&view=rev Log: [clangd] Avoid divide-by-zero Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp URL: http://l

[PATCH] D41760: Introduce __builtin_load_no_speculate

kristof.beyls added a comment. The API design has been discussed over the past weeks in detail on the gcc mailing list. As a result of that, we propose to adapt the API, to enable efficient code generation also on architectures that need to generate a barrier instruction to achieve the desired

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

bkramer added inline comments. Comment at: clangd/ClangdServer.h:107 +/// A simple fixed-size thread pool implementation. +class SimpleThreadPool { public: What's so simple about it? Why not `clangd::ThreadPool`? Also there's `llvm::ThreadPool`, what's the diff

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D42167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/TrailingReturnCheck.cpp:23 + const auto *F = cast(T); + return F->hasTrailingReturn(); +} I'd rewrite this as: `return Node.getType()->castAs()->hasTrailingReturnType();` Co

[PATCH] D16403: Add scope information to CFG

m.ostapenko updated this revision to Diff 130183. m.ostapenko retitled this revision from "Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements" to "Add scope information to CFG". m.ostapenko added a comment. Some code cleanup + updated test case. https://reviews.ll

[PATCH] D32860: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons

baloghadamsoftware updated this revision to Diff 130186. baloghadamsoftware added a comment. Rebased. https://reviews.llvm.org/D32860 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index: test/Analysis/mismatched-iterator.cpp ==

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 130185. baloghadamsoftware added a comment. Rebased. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index: test/Analysis/mismatched-iterator.cpp ==

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. After some investigation, I think this whole code is incorrect. We should not rely on the fact that there is no padding on some architectures and should mix the type generated by the Clang and initial value, generated by LLVM. Repository: rC Clang https://reviews.ll

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

Hahnfeld added a comment. In https://reviews.llvm.org/D42168#978593, @ABataev wrote: > After some investigation, I think this whole code is incorrect. We should not > rely on the fact that there is no padding on some architectures and should > mix the type generated by the Clang and initial val

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

hokein created this revision. hokein added a reviewer: bkramer. Herald added a subscriber: klimek. No doc update on the LibASTMatchersReference.html - The dump_ast_matchers.py script has been broken since r318304. Repository: rC Clang https://reviews.llvm.org/D42185 Files: include/clang/AS

Re: [PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

Hi Nico, On 17 January 2018 at 14:35, Nico Weber via Phabricator via cfe-commits wrote: > thakis closed this revision. > thakis added a comment. > > r322652, thanks! This commit broke ARM bots: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/14839 Cheers, Yvan > > https://review

r322672 - [Index] Fix GCC warning. This is silly, but no llvm_unreachable and no C99.

Author: sammccall Date: Wed Jan 17 07:57:14 2018 New Revision: 322672 URL: http://llvm.org/viewvc/llvm-project?rev=322672&view=rev Log: [Index] Fix GCC warning. This is silly, but no llvm_unreachable and no C99. Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/

[PATCH] D41074: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style

benhamilton added a comment. Any way we can get an accept on this one? Repository: rC Clang https://reviews.llvm.org/D41074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r322674 - Attempt to fix test/Driver/masm.c on the ARM bots.

Author: nico Date: Wed Jan 17 08:03:08 2018 New Revision: 322674 URL: http://llvm.org/viewvc/llvm-project?rev=322674&view=rev Log: Attempt to fix test/Driver/masm.c on the ARM bots. Modified: cfe/trunk/test/Driver/masm.c Modified: cfe/trunk/test/Driver/masm.c URL: http://llvm.org/viewvc/llv

Re: r322549 - Squash -Wcovered-switch-default wairning

Fixed in r322672. (Slightly awkwardly, because we don't have llvm_unreachable in C) On Tue, Jan 16, 2018 at 11:52 PM, Galina Kistanova wrote: > Hello Sam, > > This commit broke one of our builders: > http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4517 > > . . . > FAILED: /usr/loca

Re: [PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

r322674 attempts to fix. On Wed, Jan 17, 2018 at 10:54 AM, Yvan Roux via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Nico, > > On 17 January 2018 at 14:35, Nico Weber via Phabricator via > cfe-commits wrote: > > thakis closed this revision. > > thakis added a comment. > > > > r322652,

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. In https://reviews.llvm.org/D42168#978594, @Hahnfeld wrote: > In https://reviews.llvm.org/D42168#978593, @ABataev wrote: > > > After some investigation, I think this whole code is incorrect. We should > > not rely on the fact that there is no padding on some architecture

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. Or, there is another one solution - mark `_tgt_offload_entry` record as packed. Repository: rC Clang https://reviews.llvm.org/D42168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a reviewer: jkorous-apple. Big +1 to the change here. Just suggestions for the comments. Comment at: clangd/CodeComplete.cpp:522 - // Attempt to reuse t

Re: r321777 - PR35028: Retain duplicate alignas attributes in template instantiation.

Merged to 6.0 in r322676. On Thu, Jan 4, 2018 at 2:02 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Jan 3 17:02:18 2018 > New Revision: 321777 > > URL: http://llvm.org/viewvc/llvm-project?rev=321777&view=rev > Log: > PR35028: Retain duplicate alignas attributes in templat

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

ABataev added a comment. 1. Please, mark the record as packed. 2. Tests Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3576-3577 EntryInit.addInt(CGM.Int32Ty, 0); - llvm::GlobalVariable *Entry = -EntryInit.finishAndCreateGlobal(".omp_offloading.entry", -

Re: r321779 - PR35045: Convert injected-class-name to its corresponding simple-template-id

Merged to 6.0 in r322677. On Thu, Jan 4, 2018 at 2:24 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Jan 3 17:24:17 2018 > New Revision: 321779 > > URL: http://llvm.org/viewvc/llvm-project?rev=321779&view=rev > Log: > PR35045: Convert injected-class-name to its correspondi

r322678 - [clang-format] adds enclosing function detection to raw string formatting

Author: krasimir Date: Wed Jan 17 08:17:26 2018 New Revision: 322678 URL: http://llvm.org/viewvc/llvm-project?rev=322678&view=rev Log: [clang-format] adds enclosing function detection to raw string formatting Summary: This patch adds enclosing function detection to raw string formatting. Reviewe

[PATCH] D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Herald added a reviewer: jkorous-apple. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:109 + // Deduplicate the result by key. + // FIXME(io

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rC322678: [clang-format] adds enclosing function detection to raw string formatting (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D42167?vs=130177&id=130191#toc

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rL322678: [clang-format] adds enclosing function detection to raw string formatting (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130192. benhamilton added a comment. - Remove unused variable. Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

Re: r322246 - [X86] Fix vpshrd builtins to require an ICE for their constant argument to match vpshld.

Merged to 6.0 in r322682. On Thu, Jan 11, 2018 at 2:38 AM, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Wed Jan 10 17:38:00 2018 > New Revision: 322246 > > URL: http://llvm.org/viewvc/llvm-project?rev=322246&view=rev > Log: > [X86] Fix vpshrd builtins to require an ICE for their

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. This needs to be added to the dynamic matcher registry and also should not be commit until the documentation is generated for it. Comment at: unittes

[PATCH] D41852: [clang-tidy] Don't generate fix for argument constructed from std::initializer_list.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM modulo a change to the 'initializer_list.h'. Do we really need it for this patch? Comment at: test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

ilya-biryukov updated this revision to Diff 130193. ilya-biryukov added a comment. - Rewrote the comment for prepareCompilerInstance - Call CanReuse() and discard its results. We have clients that rely on having the stat() calls for files from preamble Repository: rCTE Clang Tools Extra http

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

ilya-biryukov updated this revision to Diff 130194. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Use a better comment suggest by Sam Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41991 Files: clangd/CodeComplete.cpp clangd/Compiler.cpp

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:522 - // Attempt to reuse the PCH from precompiled preamble, if it was built. - if (Preamble) { -auto Bounds = -ComputePreambleBounds(*CI->getLangOpts(), ContentsBuffer.get(), 0); -if (!P

[PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

seurer added a comment. This patch fails on powerpc64 http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14380 http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/13463 - TEST 'Clang :: Driver/masm.c' FAILED Script: --- /home/buildbots/ppc64le-clang-

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

ilya-biryukov updated this revision to Diff 130195. ilya-biryukov added a comment. - Fixed a typo Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41991 Files: clangd/CodeComplete.cpp clangd/Compiler.cpp clangd/Compiler.h Index: clangd/Compiler.h =

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

sammccall accepted this revision. sammccall added a comment. Thanks, LG! Comment at: clangd/Compiler.h:39 +/// Returns null on errors. When non-null value is returned, it is expected to +/// be consumed by FrontendAction::BeginSourceFile to properly destroy buffer +/// for \p M

r322687 - Update dump_ast_matchers for many recent changes.

Author: d0k Date: Wed Jan 17 08:50:14 2018 New Revision: 322687 URL: http://llvm.org/viewvc/llvm-project?rev=322687&view=rev Log: Update dump_ast_matchers for many recent changes. The html file hasn't been updated in a long time so there are quite a few changes in there. No matchers were removed

  1   2   3   >