sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/ClangdLSPServer.cpp:153 + + auto Code = Server.getDocument(File); + if (!Code) ---------------- don't you want to do this before computing replacements? ================ Comment at: clangd/ClangdLSPServer.cpp:155 + if (!Code) + return replyError(C, ErrorCode::InternalError, + "onRename called for non-added file"); ---------------- invalidparams Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42164 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
