nik added a comment.
Hmm, could libclang profit from something like this, too? (or does it already?)
Repository:
rL LLVM
https://reviews.llvm.org/D41495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
hintonda created this revision.
hintonda added reviewers: compnerd, beanz, phosek.
Herald added a subscriber: mgorny.
Add new linux toolchain file that allows cross compiling to
linux from other systems, e.g., Darwin.
Also, add a new variable, ADDITIONAL_CLANG_BOOTSTRAP_DEPS, which
allows adding
Author: sammccall
Date: Tue Jan 2 01:35:10 2018
New Revision: 321639
URL: http://llvm.org/viewvc/llvm-project?rev=321639&view=rev
Log:
[Driver] Fix unused variables and test-writing-into-workdir after r321621
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/test/Driver/config-file.c
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41495#965627, @nik wrote:
> Hmm, could libclang profit from something like this, too? (or does it
> already?)
It could. The problem with ASTUnit is that it returns all diagnostics from
`store_diag_begin`/`end`, not just the ones from
smeenai added a comment.
Why is this a cache file rather than a toolchain file (but passing itself as a
toolchain file to CMake under some circumstances?) Aren't toolchain files
traditionally used for cross-compilation?
Comment at: cmake/caches/linux-toolchain.cmake:20
+#
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ilya-biryukov, klimek.
For some cases, GoToDefinition will navigate to the forward class
declaration, we should always navigate to the class definition.
Repository:
rCTE Clang Tools Extra
https://revie
xgsa added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:839-840
+case NolintCommentType::Nolint:
+ Message = "there is no diagnostics on this line, "
+"the NOLINT comment is redundant";
+ break;
hintonda added a comment.
In https://reviews.llvm.org/D41660#965656, @smeenai wrote:
> Why is this a cache file rather than a toolchain file (but passing itself as
> a toolchain file to CMake under some circumstances?) Aren't toolchain files
> traditionally used for cross-compilation?
Thanks
seaneveson added a comment.
Ping.
https://reviews.llvm.org/D40712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 128409.
hintonda added a comment.
Use CMAKE_(C|CXX)_COMPILER_TARGET instead of
CMAKE_(C|CXX)_COMPILER_ARG1, and pass all target variables via
CLANG_BOOTSTRAP_CMAKE_ARGS.
Add variable tests and Fix/update comments.
Repository:
rC Clang
https://reviews.ll
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/XRefs.cpp:54
if (isSearchedLocation(FID, Offset))
- Decls.push_back(D);
+ Decls.push_back(ASTNode.OrigD);
return true;
--
luporl marked an inline comment as done.
luporl added a comment.
@compnerd, @mstorsjo, I don't have permission to commit to the repository.
Could you check in the changes for me?
https://reviews.llvm.org/D41386
___
cfe-commits mailing list
cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321645: ASan+operator new[]: Fix operator new[] cookie
poisoning (authored by filcab, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41301
Files:
cfe/trunk/lib/CodeGen/ItaniumCXXABI.c
Author: filcab
Date: Tue Jan 2 05:21:50 2018
New Revision: 321645
URL: http://llvm.org/viewvc/llvm-project?rev=321645&view=rev
Log:
ASan+operator new[]: Fix operator new[] cookie poisoning
Summary:
The C++ Itanium ABI says:
No cookie is required if the new operator being used is ::operator
new[
Author: filcab
Date: Tue Jan 2 05:46:12 2018
New Revision: 321647
URL: http://llvm.org/viewvc/llvm-project?rev=321647&view=rev
Log:
Revert "ASan+operator new[]: Fix operator new[] cookie poisoning"
This reverts r321645.
I missed a compiler-rt test that needs updating.
Modified:
cfe/trunk/l
nik added inline comments.
Comment at: lib/Frontend/PrecompiledPreamble.cpp:461
std::map::iterator Overridden =
OverriddenFiles.find(Status.getUniqueID());
nik wrote:
> ilya-biryukov wrote:
> > Will anything fail if we remove the map from `UniqueI
nik updated this revision to Diff 128416.
nik added a comment.
Rebased and renamed the counter variable only.
I do not feel comfortable changing the "std::map OverriddenFiles". I can do this in a follow-up change if you
want.
@Ivan: Coul you please run the tests with this change on Windows?! If
aaron.ballman added a comment.
Post-holiday ping.
https://reviews.llvm.org/D41317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Post-holiday ping.
https://reviews.llvm.org/D15935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Post-holiday ping.
https://reviews.llvm.org/D41553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Post-holiday ping.
https://reviews.llvm.org/D33563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
In https://reviews.llvm.org/D41660#965686, @hintonda wrote:
> In https://reviews.llvm.org/D41660#965656, @smeenai wrote:
>
> >
>
>
> Cache files are preferred since they are only loaded once
Isn't that precisely the behavior needed for cross-compilation though? You want
beanz added a comment.
You should split the CMake cache file you created into two files, (1) a CMake
Cache to manage the build configuration and (2) a tool chain file for targeting
Linux. As @semeenai pointed out we absolutly want the behavior of the toolchain
file being loaded multiple times.
hokein created this revision.
hokein added reviewers: sammccall, ioeric.
Herald added subscribers: ilya-biryukov, klimek.
Use the YAML-format symbols (generated by the global-symbol-builder tool) to
do the global code completion.
It is **experimental** only , but it allows us to experience global
Author: marshall
Date: Tue Jan 2 09:17:01 2018
New Revision: 321658
URL: http://llvm.org/viewvc/llvm-project?rev=321658&view=rev
Log:
Implement most of P0607: Inline Variables for the Standard Library. This
involved marking a lot of variables as inline (but only for C++17 and later).
Modified:
mclow.lists abandoned this revision.
mclow.lists added a comment.
This was committed as part of r321658
https://reviews.llvm.org/D41239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
On Tue, Dec 19, 2017 at 9:43 PM Akira Hatanaka wrote:
> On Tue, Dec 12, 2017 at 12:12 PM, John McCall wrote:
>
>> On Tue, Dec 12, 2017 at 1:45 PM, David Blaikie
>> wrote:
>>
>>> On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote:
>>>
On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie
wro
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:440
def TautologicalUnsignedEnumZeroCompare :
DiagGroup<"tautological-unsigned-enum-zero-compare">;
+def TautologicalRangeCompare :
DiagGroup<"tautological-constant-range-compare">;
def T
smeenai added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:440
def TautologicalUnsignedEnumZeroCompare :
DiagGroup<"tautological-unsigned-enum-zero-compare">;
+def TautologicalRangeCompare :
DiagGroup<"tautological-constant-range-compare">;
def Tautolo
Author: vsapsai
Date: Tue Jan 2 10:02:19 2018
New Revision: 321660
URL: http://llvm.org/viewvc/llvm-project?rev=321660&view=rev
Log:
[Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.
rdar://problem/33251668
Reviewers: arphaman, ahatanak
Reviewed By: arphaman
Subscriber
This patch has already landed — also IIRC e.g. vim on dvorak also uses hjkl
navigation with no issues.
> On Dec 25, 2017, at 11:21 AM, David Blaikie wrote:
>
> any chance this can be implemented based on keyboard layout, so it's good for
> dvorak users as well? (maybe it already is, I don't kn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321660: [Sema] Don't emit the -Wstrict-prototypes
warning for variadic functions. (authored by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41528?vs=127965&id=128430#toc
lebedev.ri added a comment.
@aaron.ballman, @smeenai, thank you for feedback!
Comment at: include/clang/Basic/DiagnosticGroups.td:440
def TautologicalUnsignedEnumZeroCompare :
DiagGroup<"tautological-unsigned-enum-zero-compare">;
+def TautologicalRangeCompare :
DiagGroup<"ta
Sure, this is post-commit review feedback.
vim with dvorak works in the sense that it's not unusable, but it's pretty
awkward (see, for example, discussions like this:
http://vim.wikia.com/wiki/Using_Vim_with_the_Dvorak_keyboard_layout )
On Tue, Jan 2, 2018 at 10:03 AM George Karpenkov
wrote:
>
xgsa updated this revision to Diff 128431.
xgsa added a comment.
Rename the check `nolint-usage` => `readability-nolint-usage` for consistency.
Update diagnostics message according to the review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41326
Files:
clang-tidy/
hintonda added a comment.
In https://reviews.llvm.org/D41660#965877, @beanz wrote:
> You should split the CMake cache file you created into two files, (1) a CMake
> Cache to manage the build configuration and (2) a tool chain file for
> targeting Linux. As @semeenai pointed out we absolutly wan
Author: marshall
Date: Tue Jan 2 10:41:01 2018
New Revision: 321661
URL: http://llvm.org/viewvc/llvm-project?rev=321661&view=rev
Log:
A couple more inlined variables that I missed the first time
Modified:
libcxx/trunk/include/type_traits
libcxx/trunk/www/cxx1z_status.html
Modified: libc
weimingz added a comment.
Should we go with current patch? or provide a srand/rand based implementation
as an option?
Repository:
rCXX libc++
https://reviews.llvm.org/D41316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
nlewycky added a comment.
Ping!
https://reviews.llvm.org/D40850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
I think you should track lazy partial specializations separately from lazy full
specializations -- we need to load all the partial specializations when doing
partial specialization selection, and don't want to load all full
specializations at the same time.
==
Author: marshall
Date: Tue Jan 2 10:57:47 2018
New Revision: 321663
URL: http://llvm.org/viewvc/llvm-project?rev=321663&view=rev
Log:
Temporarily revert the inlining of 'piecewise_construct' because it is exported
from the dylib.
Modified:
libcxx/trunk/include/utility
Modified: libcxx/trun
Author: marshall
Date: Tue Jan 2 11:01:45 2018
New Revision: 321664
URL: http://llvm.org/viewvc/llvm-project?rev=321664&view=rev
Log:
Un-inline a few more variables that are exported from the dylib.
Modified:
libcxx/trunk/include/__functional_base
libcxx/trunk/include/functional
Modifie
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, I agree with your reasoning.
https://reviews.llvm.org/D40850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
khuttun marked 7 inline comments as done.
khuttun added a comment.
In https://reviews.llvm.org/D41655#965551, @JonasToth wrote:
> I think it would be more user friendly if the configured list can be a list
> and the `|` concatenation is done within your code.
What do you exactly mean by list?
Author: nicholas
Date: Tue Jan 2 11:10:12 2018
New Revision: 321665
URL: http://llvm.org/viewvc/llvm-project?rev=321665&view=rev
Log:
Suppress undefined-template warnings when the pattern is declared in a system
header.
The way to fix an undefined-template warning is to add lines to the header
Quuxplusone added a comment.
@weimingz: Since your platform supports `srand(0)`, is it possible to look at
how your platform implements `srand(0)` and "inline" that implementation into
`random_device`? That seems like it would be more in keeping with the other
ifdefs in this file.
I'm confiden
hintonda added a comment.
In https://reviews.llvm.org/D41660#965935, @hintonda wrote:
> In https://reviews.llvm.org/D41660#965877, @beanz wrote:
>
> > You should split the CMake cache file you created into two files, (1) a
> > CMake Cache to manage the build configuration and (2) a tool chain fi
Author: marshall
Date: Tue Jan 2 11:23:30 2018
New Revision: 321666
URL: http://llvm.org/viewvc/llvm-project?rev=321666&view=rev
Log:
One more (should be) inline variable that is defined in the dylib
Modified:
libcxx/trunk/include/__mutex_base
Modified: libcxx/trunk/include/__mutex_base
URL
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3147-3149
+def warn_impcast_literal_to_bool : Warning<
+ "implicit conversion from %0 to %1; will always evaluate to "
+ "'%select{false|true}2'">, InGroup;
Warning groups are
phosek added a comment.
@hintonda I think this should be a platform file in
https://github.com/llvm-mirror/llvm/tree/master/cmake/platforms rather than
Clang cache file. Platform files are concerned with the host platform
(including cross-compilation), while cache files are related to the
dis
dneilson created this revision.
dneilson added a reviewer: rjmccall.
Herald added subscribers: fedor.sergeev, kbarton, aheejin, sbc100, javed.absar,
nhaehnle, nemanjai, jyknight.
Upstream LLVM is changing the the prototypes of the @llvm.memcpy/memmove/memset
intrinsics. This change updates the Cl
Author: mstorsjo
Date: Tue Jan 2 12:10:54 2018
New Revision: 321667
URL: http://llvm.org/viewvc/llvm-project?rev=321667&view=rev
Log:
[PPC64] Port to ppc64le - initial version
Initial working version of libunwind for PowerPC 64. Tested on
little-endian ppc64 host only.
Based on the existing Powe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321667: [PPC64] Port to ppc64le - initial version (authored
by mstorsjo, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41386?vs=127516&id=128445#toc
Repository:
rL LLVM
https://
STL_MSFT added a comment.
Ping? (And happy new year!)
https://reviews.llvm.org/D41213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
In https://reviews.llvm.org/D41660#966023, @phosek wrote:
> @hintonda I think this should be a platform file in
> https://github.com/llvm-mirror/llvm/tree/master/cmake/platforms rather than
> Clang cache file. Platform files are concerned with the host platform
> (inc
Author: dyung
Date: Tue Jan 2 12:39:29 2018
New Revision: 321669
URL: http://llvm.org/viewvc/llvm-project?rev=321669&view=rev
Log:
[DOXYGEN] Fix doxygen and content issues in emmintrin.h
- Fixed innaccurate instruction mappings for various intrinsics.
- Fixed description of NaN handling in compa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321669: [DOXYGEN] Fix doxygen and content issues in
emmintrin.h (authored by dyung, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41516?vs=127939&id=128447#toc
Repository:
rL LLV
Author: dyung
Date: Tue Jan 2 12:42:53 2018
New Revision: 321670
URL: http://llvm.org/viewvc/llvm-project?rev=321670&view=rev
Log:
[DOXYGEN] Fix doxygen and content issues in pmmintrin.h
- Fix incorrect wording in various intrinsic descriptions. Previously the
descriptions used "low-order" and
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321670: [DOXYGEN] Fix doxygen and content issues in
pmmintrin.h (authored by dyung, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41518?vs=127947&id=128448#toc
Repository:
rL LLV
elsteveogrande added a comment.
Hi @arphaman, thanks very much! Sorry, I didn't notice there was activity on
this old patch until now.
I'll make these changes as suggested and re-send it with full context.
Repository:
rL LLVM
https://reviews.llvm.org/D38320
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321671: [DOXYGEN] Fix doxygen and content issues in
smmintrin.h (authored by dyung, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41520?vs=127949&id=128449#toc
Repository:
rL LLV
Author: dyung
Date: Tue Jan 2 12:45:29 2018
New Revision: 321671
URL: http://llvm.org/viewvc/llvm-project?rev=321671&view=rev
Log:
[DOXYGEN] Fix doxygen and content issues in smmintrin.h
- Fix formatting issue due to hyphenated terms at line breaks.
- Fix typo
This patch was made by Craig Flore
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I'm glad to hear that progress is finally happening on this.
The change to CGBuilder looks good to me. I'm going to take your word for it
that the test changes are all just obvious update
dneilson added a comment.
In https://reviews.llvm.org/D41677#966094, @rjmccall wrote:
> I'm glad to hear that progress is finally happening on this.
>
> The change to CGBuilder looks good to me. I'm going to take your word for it
> that the test changes are all just obvious updates; if there's
Author: rnk
Date: Tue Jan 2 13:34:16 2018
New Revision: 321676
URL: http://llvm.org/viewvc/llvm-project?rev=321676&view=rev
Log:
[WinEH] Allow for multiple terminatepads
Fixes verifier errors with Windows EH and OpenMP, which injects a
terminate scope around parallel blocks.
Fixes PR35778
Modi
george.karpenkov created this revision.
george.karpenkov added reviewers: dcoughlin, NoQ.
Herald added subscribers: a.sidorin, szepet, kristof.beyls, xazax.hun, aemerson.
This addresses an issue introduced in r183451: since
`removePiecesWithInvalidLocations` is called *after* `adjustCallLocations
v.g.vassilev updated this revision to Diff 128460.
v.g.vassilev marked 2 inline comments as done.
v.g.vassilev added a comment.
Address inline comments: order the read operations.
https://reviews.llvm.org/D41416
Files:
include/clang/AST/DeclTemplate.h
lib/AST/DeclTemplate.cpp
lib/Serializ
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:440
def TautologicalUnsignedEnumZeroCompare :
DiagGroup<"tautological-unsigned-enum-zero-compare">;
+def TautologicalRangeCompare :
DiagGroup<"tautological-constant-range-compare">;
def T
lebedev.ri updated this revision to Diff 128462.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
Renamed `TautologicalRangeCompare` to `TautologicalInRangeCompare`.
Given that previous version of this differential was already previously
accepted,
and the fact that this n
elsteveogrande updated this revision to Diff 128466.
elsteveogrande edited the summary of this revision.
elsteveogrande added a comment.
Fixed local var names. Using `arc diff` which hopefully submits latest changes
w/ full context
Repository:
rC Clang
https://reviews.llvm.org/D38320
Files
mattd added a comment.
Ping :) I would like someone to commit this on my behalf, thanks!
https://reviews.llvm.org/D41421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev updated this revision to Diff 128465.
v.g.vassilev added a comment.
Teach `ASTReader::CompleteRedeclChain` to load only the template
specializations with the same template argument list.
https://reviews.llvm.org/D41416
Files:
include/clang/AST/DeclTemplate.h
lib/AST/DeclTempla
v.g.vassilev added inline comments.
Comment at: lib/Serialization/ASTReaderDecl.cpp:92
for (unsigned I = 0, Size = Record.readInt(); I != Size; ++I)
-IDs.push_back(ReadDeclID());
+IDs.push_back(LazySpecializationInfo(ReadDeclID(), Record.readInt()));
}
timshen added a comment.
The static_assert on line 1189 fails with the following build on x86:
cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON -DLLVM_PATH=$PATH_TO_LLVM
$PATH_TO_LIBUNWIND && ninja libunwind.a
It seems that 136 in `# define _LIBUNWIND_CONTEXT_SIZE 136` is too small.
Rever
mstorsjo added a comment.
In https://reviews.llvm.org/D41386#966187, @timshen wrote:
> The static_assert on line 1189 fails with the following build on x86:
>
> cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON
> -DLLVM_PATH=$PATH_TO_LLVM $PATH_TO_LIBUNWIND && ninja libunwind.a
>
>
> It s
Author: timshen
Date: Tue Jan 2 14:04:03 2018
New Revision: 321678
URL: http://llvm.org/viewvc/llvm-project?rev=321678&view=rev
Log:
Revert `rL321667: [PPC64] Port to ppc64le - initial version`
Differential Revision: https://reviews.llvm.org/D41386
Modified:
libunwind/trunk/include/__libunw
timshen added a comment.
In https://reviews.llvm.org/D41386#966189, @mstorsjo wrote:
> In https://reviews.llvm.org/D41386#966187, @timshen wrote:
>
> > The static_assert on line 1189 fails with the following build on x86:
> >
> > cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON
> > -DLLVM_P
rsmith added a comment.
This is looking like a really good start; we'll still want to do something
about partial specializations, but this should already help a lot.
Can you produce some sample performance numbers for this change? This is
replacing a linear-time algorithm (with a high constant)
Author: mstorsjo
Date: Tue Jan 2 14:11:22 2018
New Revision: 321679
URL: http://llvm.org/viewvc/llvm-project?rev=321679&view=rev
Log:
Don't use a strict larger-than comparison in the check_fit/does_fit static
assert
For builds that only target one architecture, this was required to
be an exact
Author: mstorsjo
Date: Tue Jan 2 14:11:30 2018
New Revision: 321680
URL: http://llvm.org/viewvc/llvm-project?rev=321680&view=rev
Log:
Reland [PPC64] Port to ppc64le - initial version
Initial working version of libunwind for PowerPC 64. Tested on
little-endian ppc64 host only.
Based on the existi
lebedev.ri updated this revision to Diff 128470.
lebedev.ri added a comment.
Actually update the diagnostic flag :)
I'm going to hold off committing just yet, and wait for @rsmith to sign off.
Repository:
rC Clang
https://reviews.llvm.org/D41512
Files:
include/clang/Basic/DiagnosticGroups
george.karpenkov added a comment.
The error is triggered when analyzer finds a bug *inside* the callable captured
by the body farm.
Probably we didn't see the crash in the wild because either
a) the clang build did not have assertions enabled
or
b) the HTML output was not enabled
and the bug nee
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yep, so it still doesn't answer if `removePiecesWithInvalidLocations()` was
dead code to begin with (considering that the assertion in
`adjustCallLocations()` says that everything but call locations
efriedma added inline comments.
Comment at: include/clang/AST/Expr.h:1728
+ UnaryOperator(Expr *input, Opcode opc, QualType type, ExprValueKind VK,
+ExprObjectKind OK, SourceLocation l, bool CanOverflow = false)
+ : Expr(UnaryOperatorClass, type, VK, OK,
---
vsapsai added a comment.
Cannot tell for sure from code but looks like we are still emitting
`-Wdate-time` "expansion of date or time macro is not reproducible" with this
flag. At least it's not covered by tests. And another similar warning is
`-Wpch-date-time`.
https://reviews.llvm.org/D2393
Author: george.karpenkov
Date: Tue Jan 2 15:05:47 2018
New Revision: 321682
URL: http://llvm.org/viewvc/llvm-project?rev=321682&view=rev
Log:
[analyzer] do not crash with assertion on processing locations of bodyfarmed
functions
This addresses an issue introduced in r183451: since
`removePieces
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321682: [analyzer] do not crash with assertion on processing
locations of bodyfarmed… (authored by george.karpenkov, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41680
Files:
lib/S
efriedma added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:2252
+ TM.tm_isdst = -1;
+ mktime(&TM);
+ Opts.FixedDateTime = TM;
Does using mktime like this depend on the local timezone?
https://reviews.llvm.org/D23934
__
Hey, Richard et al. Akira and I were talking about the right ABI rule for
deciding can-pass-in-registers-ness for structs in the presence of trivial_abi,
and I think I like Akira's approach but wanted to get your input.
The current definition in Itanium is:
non-trivial for the purposes of ca
Author: rsmith
Date: Tue Jan 2 15:52:42 2018
New Revision: 321683
URL: http://llvm.org/viewvc/llvm-project?rev=321683&view=rev
Log:
Fix and simplify handling of return type for (generic) lambda conversion
function to function pointer.
Previously, we would:
* compute the type of the conversion
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Hi Hubert,
Thanks for fixing this. `cp -R` is sufficient IMO. LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41545
___
cfe-commits mailing
NoQ added a comment.
Because it wasn't immediately obvious to me how to apply both this patch and
https://reviews.llvm.org/D39398 (there are a couple of minor conflicts between
them), i wanted to post a few pictures for the reference, because
`debug.ViewCFG` graphs are much easier to comprehend
NoQ added a comment.
(edited my comment: fixed the suggested change to mention the right block)
https://reviews.llvm.org/D41150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mattd abandoned this revision.
mattd added a comment.
Abandoning as this is no longer a problem with release builds.
https://reviews.llvm.org/D40398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
rjmccall added a comment.
You're sure you just want a single TBAA tag on memcpy's? I would think that it
might be useful to encode separate path information for the two operands.
https://reviews.llvm.org/D41539
___
cfe-commits mailing list
cfe-com
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Ok.
Repository:
rL LLVM
https://reviews.llvm.org/D41547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
hintonda abandoned this revision.
hintonda added a comment.
Thanks for all your suggestions.
Planning to rework and move the toolchain specific part to llvm/cmake/platform
and abandon the cache part altogether.
Repository:
rC Clang
https://reviews.llvm.org/D41660
rjmccall added a comment.
Aren't these always loads and stores from allocas? I would expect TBAA to be
useless here because it's always strictly less informative than basic-AA, which
knows that the access doesn't alias with anything.
Repository:
rL LLVM
https://reviews.llvm.org/D41562
_
NoQ added a comment.
Herald added subscribers: dkrupp, a.sidorin, rnkovacs.
These CFGs make perfect sense to me so far, and i guess this is a must-have.
Thank you!
> Note: In case of IndirectGotoStmt, it could happen that we generate LoopExit
> elements even for loops which is not exited by tha
NoQ added a comment.
//*asked stuff in https://reviews.llvm.org/D39398 regarding how indirect gotos
are supported*//
https://reviews.llvm.org/D41151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
1 - 100 of 117 matches
Mail list logo
