Sure, this is post-commit review feedback. vim with dvorak works in the sense that it's not unusable, but it's pretty awkward (see, for example, discussions like this: http://vim.wikia.com/wiki/Using_Vim_with_the_Dvorak_keyboard_layout )
On Tue, Jan 2, 2018 at 10:03 AM George Karpenkov <ekarpen...@apple.com> wrote: > This patch has already landed — also IIRC e.g. vim on dvorak also uses > hjkl navigation with no issues. > > > On Dec 25, 2017, at 11:21 AM, David Blaikie <dblai...@gmail.com> wrote: > > any chance this can be implemented based on keyboard layout, so it's good > for dvorak users as well? (maybe it already is, I don't know - just > mentioning it in case) > > On Thu, Dec 21, 2017 at 2:58 PM George Karpenkov via Phabricator via > cfe-commits <cfe-commits@lists.llvm.org> wrote: > >> This revision was automatically updated to reflect the committed changes. >> Closed by commit rC321320: [analyzer] Add Javascript to analyzer HTML >> output to allow keyboard navigation. (authored by george.karpenkov, >> committed by ). >> Herald added a subscriber: cfe-commits. >> >> Changed prior to commit: >> https://reviews.llvm.org/D41414?vs=127919&id=127954#toc >> >> Repository: >> rC Clang >> >> https://reviews.llvm.org/D41414 >> >> Files: >> lib/Rewrite/HTMLRewrite.cpp >> lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
