This revision was automatically updated to reflect the committed changes.
Closed by commit rL319830: [libunwind][CMake] Set TARGET_TRIPLE if
LIBUNWND_TARGET_TRIPLE is set (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40820?vs=125458&id=125594#toc
Repository:
rL LLV
NoQ added a comment.
This looks great for understanding what exactly is going on in a large
real-world report.
If you want to turn this into a form of user-facing analyzer output variant,
you may want to implement it as a `PathDiagnosticConsumer` rather than a
visitor. If we only want a neat d
NoQ added a comment.
In https://reviews.llvm.org/D40809#945551, @NoQ wrote:
> If you want to turn this into a form of user-facing analyzer output variant,
> you may want to implement it as a `PathDiagnosticConsumer` rather than a
> visitor.
Or maybe no, actually it's totally wrong, never mind
Author: george.karpenkov
Date: Tue Dec 5 13:19:59 2017
New Revision: 319834
URL: http://llvm.org/viewvc/llvm-project?rev=319834&view=rev
Log:
[analyzer] do not crash on cases where an array subscript is an rvalue
Array subscript is almost always an lvalue, except for a few cases where
it is not,
jdenny added a comment.
In https://reviews.llvm.org/D40752#945255, @ABataev wrote:
> In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
>
> > r319774 works for my current use cases. Thanks.
> >
> > While we're on this topic, do you happen to know the rationale behind the
> > OpenMP restr
ABataev added a comment.
In https://reviews.llvm.org/D40752#945571, @jdenny wrote:
> In https://reviews.llvm.org/D40752#945255, @ABataev wrote:
>
> > In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
> >
> > > r319774 works for my current use cases. Thanks.
> > >
> > > While we're on thi
On Tue, Dec 5, 2017 at 11:40 AM, Richard Smith via cfe-commits
wrote:
> Sorry about that, fixed in r319817.
Hey Richard,
Looks like that's not enough on darwin:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/44764/consoleFull#-126347322349ba4694-19c4-4d7e-bec5-911270d8a
Author: rsmith
Date: Tue Dec 5 13:29:36 2017
New Revision: 319835
URL: http://llvm.org/viewvc/llvm-project?rev=319835&view=rev
Log:
Use an even more precise triple to avoid errors on Darwin, where we don't use
comdats for inline entities.
Modified:
cfe/trunk/test/Modules/var-templates.cpp
Should be fixed in r319835. I'd forgotten that Darwin / MachO uses a
different mechanism from COMDATs here.
On 5 December 2017 at 13:27, Ahmed Bougacha via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Dec 5, 2017 at 11:40 AM, Richard Smith via cfe-commits
> wrote:
> > Sorry about t
I committed the fix in r319836.
On 5 December 2017 at 12:49, Alex L wrote:
> Thanks, I will take a look at it right now. I believe your solution is the
> right fix.
>
> On 5 December 2017 at 07:09, Sean Eveson wrote:
>
>> Hi,
>>
>> It looks like the test is still failing on one of the Windows b
Author: arphaman
Date: Tue Dec 5 13:33:05 2017
New Revision: 319836
URL: http://llvm.org/viewvc/llvm-project?rev=319836&view=rev
Log:
Fix one more record-parsing-invocation.c test issue on Windows
Lit's env should be used before not.
Sean Eveson pointed out the right solution. Thanks!
Modified
jdenny added a comment.
In https://reviews.llvm.org/D40752#945572, @ABataev wrote:
> In https://reviews.llvm.org/D40752#945571, @jdenny wrote:
>
> > In https://reviews.llvm.org/D40752#945255, @ABataev wrote:
> >
> > > In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
> > >
> > > > r319774
Author: smeenai
Date: Tue Dec 5 13:49:56 2017
New Revision: 319840
URL: http://llvm.org/viewvc/llvm-project?rev=319840&view=rev
Log:
[CMake] Use PRIVATE in target_link_libraries for executables
We currently use target_link_libraries without an explicit scope
specifier (INTERFACE, PRIVATE or PUBL
Author: smeenai
Date: Tue Dec 5 13:49:56 2017
New Revision: 319840
URL: http://llvm.org/viewvc/llvm-project?rev=319840&view=rev
Log:
[CMake] Use PRIVATE in target_link_libraries for executables
We currently use target_link_libraries without an explicit scope
specifier (INTERFACE, PRIVATE or PUBL
JonasToth created this revision.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai,
klimek.
This check implements rules ES.100 and ES.102 of the CppCoreGuidelines
forbidding to mix `signed` and `unsigned` integer types in arithmetic
expression.
It currently functions
Nebiroth marked an inline comment as done.
Nebiroth added inline comments.
Comment at: clangd/ClangdUnit.cpp:38
+class DelegatingPPCallbacks : public PPCallbacks {
+
ilya-biryukov wrote:
> What's the purpose of this class?
We need to be able to use a wrapper cl
JonasToth updated this revision to Diff 125614.
JonasToth added a comment.
- [Misc] remove iostream
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40854
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-t
NoQ added a subscriber: rsmith.
NoQ added a comment.
A reply from @rsmith was accidentally lost:
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20171204/211785.html
(seems that phabricator cuts away all text below the first "On ...,
Such-and-such wrote:" line)
https://reviews.llvm.
Nebiroth updated this revision to Diff 125619.
Nebiroth added a comment.
Added static_cast when unparsing
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clan
rwols created this revision.
This translates diagnostics correctly between 0-based LSP columns, and 1-based
clang columns.
https://reviews.llvm.org/D40860
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdLSPServer.h
clang-tools-extra/clangd/ClangdUnit.cp
Author: dyung
Date: Tue Dec 5 15:04:12 2017
New Revision: 319848
URL: http://llvm.org/viewvc/llvm-project?rev=319848&view=rev
Log:
Fix another record-parsing-invocation.c test issue on Windows
Lit's env should be used before not. (Another case missed by the previous
commit)
Modified:
cfe/
I missed that one, thanks!
Sorry about the breakages.
On 5 December 2017 at 15:04, Douglas Yung via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dyung
> Date: Tue Dec 5 15:04:12 2017
> New Revision: 319848
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319848&view=rev
> Log:
> Fi
aemerson created this revision.
Add a new -mstack-probe and -mno-stack-probe option to enable the generation of
stack probing functions on non-Windows platforms, if supported. This patch only
enables this for Darwin.
Repository:
rC Clang
https://reviews.llvm.org/D40864
Files:
include/cla
NoQ updated this revision to Diff 125629.
NoQ added a comment.
> Note that there is no constructor call here. This is aggregate
> initialization. And there's not really any part of this that's new, except
> that a class with base classes is now an a aggregate. You'll see the same
> kind of AS
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:288
+// this-region of the parent stack frame).
+if (dyn_cast_or_null(LCtx->getParentMap().getParent(CE))) {
+ MemRegionManager &MRMgr = getSValBuilder().getRegionManager();
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:131
+
+ Finds cases where unsigned and signed integers are used together in
arithmetic expressions.
+ Unsigned integers wrap to 0 when overflowing while the behaviour of signed
integers
I
Author: rsmith
Date: Tue Dec 5 15:54:25 2017
New Revision: 319858
URL: http://llvm.org/viewvc/llvm-project?rev=319858&view=rev
Log:
P0722R2: The first parameter in an implicit call to a destroying operator
delete should be a cv-unqualified pointer to the deleted object.
Modified:
cfe/trunk/l
jdenny updated this revision to Diff 125640.
jdenny edited the summary of this revision.
jdenny added a comment.
This update includes all of Hal's suggestions.
I'm also thinking of converting prefix storage from a std::vector to a std::map
so that lookup should be faster during parsing.
https:
tra created this revision.
Herald added a subscriber: sanjoy.
https://reviews.llvm.org/D40871
Files:
clang/lib/Headers/__clang_cuda_intrinsics.h
Index: clang/lib/Headers/__clang_cuda_intrinsics.h
===
--- clang/lib/Headers/__clang
tra created this revision.
Herald added subscribers: hiraditya, sanjoy, jholewinski.
https://reviews.llvm.org/D40872
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/Headers/__clang_cuda_intrinsics.h
llvm/include/llvm/IR/IntrinsicsNVVM.td
llvm/lib/Target/NVPTX/NVPTXIntrinsics.
Gerolf added reviewers: dexonsmith, ahatanak, MatzeB.
Gerolf added a comment.
It looks pretty straightforward, but I'd ask (at least) Duncan or Akira, and
Matthias to review this more carefully.
-Gerolf
Repository:
rC Clang
https://reviews.llvm.org/D40864
NoQ added a comment.
So we have an `ExplodedGraph`, in that there's an `ExplodedNode` against which
the report is being thrown, we have a bunch of `BugReporterVisitor`s that walk
from that node to the root of the graph and mark places they find interesting
with `PathDiagnosticPiece`s of differe
lichray marked an inline comment as done.
lichray added inline comments.
Comment at: test/Misc/warning-flags.c:19
The list of warnings below should NEVER grow. It should gradually shrink to 0.
rsmith wrote:
> lichray wrote:
> > rsmith wrote:
> > > Please re
lichray updated this revision to Diff 125665.
lichray marked an inline comment as done.
lichray added a comment.
Added -Wbinding-in-condition.
Repository:
rC Clang
https://reviews.llvm.org/D39284
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/DeclSpec.h
lib/Parse/
Author: rsmith
Date: Tue Dec 5 19:00:51 2017
New Revision: 319875
URL: http://llvm.org/viewvc/llvm-project?rev=319875&view=rev
Log:
Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.
An enumeration with a fixed underlying type can have any value in its
underlying type,
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D39284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
malaperle accepted this revision.
malaperle added a subscriber: sammccall.
malaperle added a comment.
This looks good to me. @ilya-biryukov, @sammccall Any objections?
I think we can do further iterations later to handle macros and other specific
cases (multiple Decls at the position, etc) . It'
lichray updated this revision to Diff 125668.
lichray added a comment.
Rebased.
Repository:
rC Clang
https://reviews.llvm.org/D39412
Files:
lib/Driver/ToolChains/AMDGPU.cpp
lib/Driver/ToolChains/AVR.cpp
lib/Driver/ToolChains/Ananas.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver
ahatanak added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:442
Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning();
+ Options.EnableStackProbe = CodeGenOpts.StackProbe;
Is there a reason you can't use function attributes
"probe-stack"="__
101 - 139 of 139 matches
Mail list logo
