I committed the fix in r319836. On 5 December 2017 at 12:49, Alex L <arpha...@gmail.com> wrote:
> Thanks, I will take a look at it right now. I believe your solution is the > right fix. > > On 5 December 2017 at 07:09, Sean Eveson <eveson.s...@gmail.com> wrote: > >> Hi, >> >> It looks like the test is still failing on one of the Windows build bots: >> http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015 >> >> From looking at the test locally it seems the problem is when you do `// >> RUN: not env...`. The env command doesn't get handled by llvm-lit.py, >> because it gets passed through to `not.exe`. >> >> In terms of fixing this test, changing from `not env X=Y COMMAND` to `env >> X=Y not COMMAND` works on my machine. Otherwise maybe llvm-lit could be >> changed to make the handling of env (and other utilities) consistent when >> used after a not? >> >> Thanks, >> >> Sean Eveson >> SN Systems - Sony Interactive Entertainment >> >> On Mon, Dec 4, 2017 at 11:21 PM, Alex Lorenz via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: arphaman >>> Date: Mon Dec 4 15:21:07 2017 >>> New Revision: 319715 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=319715&view=rev >>> Log: >>> Fix record-parsing-invocation.c test on Windows >>> >>> We should not check for the forward slash '/' >>> >>> Modified: >>> cfe/trunk/test/Index/record-parsing-invocation.c >>> >>> Modified: cfe/trunk/test/Index/record-parsing-invocation.c >>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/rec >>> ord-parsing-invocation.c?rev=319715&r1=319714&r2=319715&view=diff >>> ============================================================ >>> ================== >>> --- cfe/trunk/test/Index/record-parsing-invocation.c (original) >>> +++ cfe/trunk/test/Index/record-parsing-invocation.c Mon Dec 4 >>> 15:21:07 2017 >>> @@ -18,4 +18,4 @@ >>> # pragma clang __debug parser_crash >>> #endif >>> >>> -// CHECK: {"toolchain":"{{.*}}","libclang.operation":"parse","libclang >>> .opts":1,"args":["clang","-fno-spell-checking","{{.*}}/recor >>> d-parsing-invocation.c","-Xclang","-detailed-preprocessi >>> ng-record","-fallow-editor-placeholders"]} >>> +// CHECK: {"toolchain":"{{.*}}","libclang.operation":"parse","libclang >>> .opts":1,"args":["clang","-fno-spell-checking","{{.*}}record >>> -parsing-invocation.c","-Xclang","-detailed-preprocessi >>> ng-record","-fallow-editor-placeholders"]} >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> cfe-commits@lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >>> >> >> >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
