Hello Sam,
This commit broke one of our bots:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/18908
. . .
FAILED:
tools/clang/tools/extra/clangd/CMakeFiles/clangDaemon.dir/FuzzyMatch.cpp.o
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE
-D__STDC_CONSTANT_MACROS -D__S
mibintc updated this revision to Diff 125211.
mibintc added a comment.
I changed the patch to enable _Float128 only as keyword in mode "nocxx" - this
is the same mode being used by _Bool. I changed the test from .cpp to .c; I run
check-all and saw only the usual suspects fail. What do you think
Author: rsmith
Date: Fri Dec 1 13:24:36 2017
New Revision: 319584
URL: http://llvm.org/viewvc/llvm-project?rev=319584&view=rev
Log:
[c++17] When deducing the type of a non-type template parameter from the type
of its argument, perform function-to-pointer and array-to-pointer decay on the
paramete
malaperle added inline comments.
Comment at: clangd/Protocol.h:26
#include "llvm/ADT/Optional.h"
-#include
+#include "llvm/Support/YAMLParser.h"
#include
Nebiroth wrote:
> malaperle wrote:
> > revert this change?
> #include is not needed.
I meant removing YA
arphaman updated this revision to Diff 125214.
arphaman marked an inline comment as done.
arphaman added a comment.
Add "-simulator" environment even when `-m*simulator-version-min` isn't used
using the arch/OS heuristic.
Repository:
rC Clang
https://reviews.llvm.org/D40682
Files:
include
Author: abataev
Date: Fri Dec 1 13:31:08 2017
New Revision: 319585
URL: http://llvm.org/viewvc/llvm-project?rev=319585&view=rev
Log:
[OPENMP] Emit `__tgt_target_teams` for all teams directives.
Previously we emitted `__tgt_target_teams` only for standalone teams
directives. This patch allows emi
lebedev.ri added a comment.
@alexfh any thoughts on this one?
Repository:
rL LLVM
https://reviews.llvm.org/D36892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett updated this revision to Diff 125215.
juliehockett marked 7 inline comments as done.
juliehockett added a comment.
Updating tests
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInher
juliehockett added inline comments.
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:60
+ // To be an interface, all base classes must be interfaces as well.
+ for (const auto &I : Node->bases()) {
+const auto *Ty = I.getType()->getAs();
aaron.ba
xgsa updated this revision to Diff 125216.
xgsa added a comment.
Minor change: update default value of SmallVector of check names.
https://reviews.llvm.org/D40671
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/nolint.cpp
Galina
Hello everyone,
LLVM buildmaster will be OFF today at 3 PM Pacific for maintenance for
about half an hour.
Thank you for for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Nebiroth added inline comments.
Comment at: clangd/Protocol.h:26
#include "llvm/ADT/Optional.h"
-#include
+#include "llvm/Support/YAMLParser.h"
#include
malaperle wrote:
> Nebiroth wrote:
> > malaperle wrote:
> > > revert this change?
> > #include is not nee
vsk updated this revision to Diff 125220.
vsk added a comment.
- Update to test diagnostics seen after a call to the noreturn function.
https://reviews.llvm.org/D40700
Files:
lib/ubsan/ubsan_handlers.cc
test/ubsan/TestCases/Misc/Inputs/returns-unexpectedly.c
test/ubsan/TestCases/Misc/unre
vsk updated this revision to Diff 125221.
vsk edited the summary of this revision.
vsk added a comment.
- Diagnose in the scenario Eli pointed out, by stripping the 'noreturn'
attribute and emitting a check after the call.
- Test updates.
https://reviews.llvm.org/D40698
Files:
docs/Undefined
Author: eugenezelenko
Date: Fri Dec 1 14:04:49 2017
New Revision: 319589
URL: http://llvm.org/viewvc/llvm-project?rev=319589&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/DeclContextInterna
jdenny updated this revision to Diff 125223.
jdenny added a comment.
Rebased on master/trunk fetched today.
https://reviews.llvm.org/D39694
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticOptions.h
include/clang/Driver/CC1Options.td
lib/Frontend/Compile
rsmith added a comment.
The intent is to use a `FilenameID` of -1 to represent this situation; see the
documentation of the `LineEntry::FilenameID` member. Users of that field are
expected to deal with that value (see the handling of that case in
`SourceManager::getPresumedLoc` for example). I
Nebiroth updated this revision to Diff 125224.
Nebiroth added a comment.
Minor code cleanup
Merge with master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D35894
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
aheejin added a comment.
After this patch, a couple of gcc torture tests started to fail. Could you
possibly look at this? https://bugs.llvm.org/show_bug.cgi?id=35503
Repository:
rL LLVM
https://reviews.llvm.org/D39455
___
cfe-commits mailing li
hubert.reinterpretcast added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:817
DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L");
+ DefineFloatMacros(Builder, "FLT128", &TI.getFloat128Format(), "Q");
+
GCC //does// define the
hans added a comment.
In https://reviews.llvm.org/D40746#942824, @rsmith wrote:
> The intent is to use a `FilenameID` of -1 to represent this situation; see
> the documentation of the `LineEntry::FilenameID` member. Users of that field
> are expected to deal with that value (see the handling of
Nebiroth updated this revision to Diff 125228.
Nebiroth added a comment.
Minor code cleanup
unparse and parse methods for JSON are updated
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.c
hans updated this revision to Diff 125227.
hans retitled this revision from "Correctly handle line directives without
filenames that come first in the file" to "Correctly handle line table entries
without filenames during AST serialization".
hans edited the summary of this revision.
https://revi
Author: spatel
Date: Fri Dec 1 15:15:52 2017
New Revision: 319593
URL: http://llvm.org/viewvc/llvm-project?rev=319593&view=rev
Log:
[CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics
There are 20 LLVM math intrinsics that correspond to mathlib calls according to
the LangRef:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319593: [CodeGen] convert math libcalls/builtins to
equivalent LLVM intrinsics (authored by spatel).
Changed prior to commit:
https://reviews.llvm.org/D40044?vs=122881&id=125230#toc
Repository:
rL LL
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319593: [CodeGen] convert math libcalls/builtins to
equivalent LLVM intrinsics (authored by spatel).
Repository:
rC Clang
https://reviews.llvm.org/D40044
Files:
lib/CodeGen/CGBuiltin.cpp
test/Code
Author: eugenezelenko
Date: Fri Dec 1 15:23:28 2017
New Revision: 319594
URL: http://llvm.org/viewvc/llvm-project?rev=319594&view=rev
Log:
[AST] Try to fix build bot with modules broken r319589. However real fix may
belong to other place.
Modified:
cfe/trunk/include/clang/AST/DeclContextInt
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
Looks great!
Repository:
rC Clang
https://reviews.llvm.org/D40568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
dcoughlin added inline comments.
Comment at: include/clang/Basic/Attr.td:602
def AnalyzerNoReturn : InheritableAttr {
- let Spellings = [GNU<"analyzer_noreturn">];
+ let Spellings = [Clang<"analyzer_noreturn">];
let Documentation = [Undocumented];
aaron.bal
cameron314 added a comment.
Brilliant, didn't know `isInPreambleFileID` existed. All my tests pass for me
now with that change, thanks :-)
I'll update the patch on Monday.
https://reviews.llvm.org/D20124
___
cfe-commits mailing list
cfe-commits@lis
Author: rsmith
Date: Fri Dec 1 16:55:48 2017
New Revision: 319601
URL: http://llvm.org/viewvc/llvm-project?rev=319601&view=rev
Log:
Move comment back to being next to the code it's a comment for.
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
http://llvm.org
phosek created this revision.
Herald added a subscriber: mgorny.
Using comma can break in cases when we're passing flags that already
use comma as a separator.
Fixes PR35504.
Repository:
rC Clang
https://reviews.llvm.org/D40762
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
Author: sammccall
Date: Fri Dec 1 18:28:29 2017
New Revision: 319604
URL: http://llvm.org/viewvc/llvm-project?rev=319604&view=rev
Log:
[clangd] Try to appease gcc constexpr bug (58541)
Modified:
clang-tools-extra/trunk/clangd/FuzzyMatch.cpp
Modified: clang-tools-extra/trunk/clangd/FuzzyMatc
Apologies. This is a GCC bug I wasn't familiar with, and my first guess at
a fix was wrong. (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58541)
r319604 should fix this.
On Fri, Dec 1, 2017 at 10:20 PM, Galina Kistanova
wrote:
> Hello Sam,
>
> This commit broke one of our bots:
> http://lab.llvm
Author: rsmith
Date: Fri Dec 1 18:48:42 2017
New Revision: 319605
URL: http://llvm.org/viewvc/llvm-project?rev=319605&view=rev
Log:
PR35456: Track definedness of variable template specializations separately from
whether they have an initializer.
We cannot distinguish between a declaration of a v
Hi Sam, the FuzzyMatch tests you added in this commit seem to be failing on the
Windows bot:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13869
Can you take a look?
Douglas Yung
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-bo
Author: sammccall
Date: Fri Dec 1 19:35:19 2017
New Revision: 319606
URL: http://llvm.org/viewvc/llvm-project?rev=319606&view=rev
Log:
[clangd] Fix FuzzyMatch tests on windows, NFC
Without specifying the signedness of the underlying type for Action,
packing it in a 1-bit field may restrict its r
r319606 should fix that one, if I've understood the problem right.
On Sat, Dec 2, 2017 at 3:50 AM, Yung, Douglas wrote:
> Hi Sam, the FuzzyMatch tests you added in this commit seem to be failing
> on the Windows bot:
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_
> 64-scei-ps4-windows
Author: sammccall
Date: Fri Dec 1 20:15:55 2017
New Revision: 319608
URL: http://llvm.org/viewvc/llvm-project?rev=319608&view=rev
Log:
[clangd] Avoid enum in bitfields, can't satisfy old GCC and new MSVC
Modified:
clang-tools-extra/trunk/clangd/FuzzyMatch.h
Modified: clang-tools-extra/trunk
Great! Unfortunately it broke old GCC, and it doesn't seem possible to
satisfy both.
So r319608 removes the enum altogether.
On Sat, Dec 2, 2017 at 4:54 AM, Yung, Douglas wrote:
> That fixed it, thanks!
>
>
>
> Douglas Yung
>
>
>
> *From:* Sam McCall [mailto:sam.mcc...@gmail.com]
> *Sent:* Frida
Just catching up on this now.
r319363 looks good to me, It makes little sense to use GNU SEH in that case.
My remaining concern is mostly about why we still need the workaround for
> x86 in the function getting the default (returning None instead of WinEH
> for that case). But as long as this work
101 - 141 of 141 matches
Mail list logo
