rsmith added a comment.

The intent is to use a `FilenameID` of -1 to represent this situation; see the 
documentation of the `LineEntry::FilenameID` member. Users of that field are 
expected to deal with that value (see the handling of that case in 
`SourceManager::getPresumedLoc` for example). I think we need to handle it that 
way, rather than mapping to the main file name as this patch does, for 
correctness in the PCH case -- we don't actually *know* the correct main file 
name at the point where the line directive appears.

I imagine the cause of the crash is that the AST writer blindly calls 
`LineTableInfo::getFilename(LE.FilenameID)` without checking for this case?


https://reviews.llvm.org/D40746



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to