malaperle added inline comments.
Comment at: clangd/ClangdUnit.h:320
+
+StringRef getDataBufferFromSourceRange(ParsedAST &AST, SourceRange SR,
+ Location L);
I think this can be only in the source file, in a an anonymous name
juliehockett added a comment.
That'd be great -- thank you! I did request commit rights, so hopefully I'll
be able to do it myself next time.
https://reviews.llvm.org/D40611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: aaronballman
Date: Wed Nov 29 13:21:51 2017
New Revision: 319360
URL: http://llvm.org/viewvc/llvm-project?rev=319360&view=rev
Log:
Add the hasDefinition() AST matcher to match class declarations that also have
a definition.
Patch by Julie Hockett.
Modified:
cfe/trunk/docs/LibASTMatc
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r319360
https://reviews.llvm.org/D40611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans created this revision.
This matches MSVC's behaviour, and we already do it for class templates since
r270897.
https://reviews.llvm.org/D40621
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllimport.cpp
Index: test/CodeGenCXX/dllimport.cpp
=
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
https://reviews.llvm.org/D40574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: abataev
Date: Wed Nov 29 13:31:48 2017
New Revision: 319362
URL: http://llvm.org/viewvc/llvm-project?rev=319362&view=rev
Log:
[OPENMP] Allow only loop control variables in distribute simd
directives.
According to the OpenMP standard, only loop control variables can be
used in linear claus
ioeric added a comment.
In https://reviews.llvm.org/D40563#939555, @arphaman wrote:
> Could you please add a test?
Any tip on how this should be tested? I couldn't find any existing unit test
for either SemaCodeComplete or code completion context (under
`clang/unittests`). It might be possibl
Author: rnk
Date: Wed Nov 29 13:35:34 2017
New Revision: 319363
URL: http://llvm.org/viewvc/llvm-project?rev=319363&view=rev
Log:
[EH] Use __CxxFrameHandler3 for C++ EH in MS environments
Fixes regression introduced by r319297. MSVC environments still use SEH
unwind opcodes but they should use th
Author: rnk
Date: Wed Nov 29 13:36:00 2017
New Revision: 319364
URL: http://llvm.org/viewvc/llvm-project?rev=319364&view=rev
Log:
Reformat switch statement added in r319297, NFC
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
http
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
https://reviews.llvm.org/D40621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö wrote:
> On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote:
>
>> Thanks for letting me know Reid.
>> I’ll in work and won’t be able to access the repo until lunch time. (~3
>> hours)
>> Feel free to revert if it is not trivial.
>>
>> The ea
Nebiroth updated this revision to Diff 124810.
Nebiroth added a comment.
Added verification for llvm::Expected in onDocumentHighlight
Removed unused variable in ClangdUnit
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLS
kkwli0 added a comment.
The original case has the variables named "foo1" and foo2". Using "foo1" or
"foo2" causes the assert! I update the description.
https://reviews.llvm.org/D40588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
On Wed, 29 Nov 2017, Reid Kleckner wrote:
On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö wrote:
On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote:
Thanks for letting me know Reid.
I’ll in work and won’t be able to access the repo
until lunch t
malaperle added inline comments.
Comment at: clangd/ClangdUnit.cpp:1029
+ SourceLocation LocStart = ValSourceRange.getBegin();
+ SourceLocation LocEnd = Lexer::getLocForEndOfToken(ValSourceRange.getEnd(),
0,
+ SourceMgr, Lang
kkwli0 updated this revision to Diff 124811.
kkwli0 added a comment.
The assert occurs in VarOrFuncDeclFilterCCC::ValidateCandidate when
clang::Sema::CorrectTypo is called.
https://reviews.llvm.org/D40588
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/declare_target_messages.cpp
Index: test/
On Wed, 29 Nov 2017, Martin Storsjö via cfe-commits wrote:
On Wed, 29 Nov 2017, Reid Kleckner wrote:
On Wed, Nov 29, 2017 at 12:21 PM, Martin Storsjö wrote:
On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote:
Thanks for letting me know Reid.
I’ll in work a
mattd marked an inline comment as done.
mattd added a comment.
Thanks for the approval Aaron. I do not have commit access, would you mind
submitting this on my behalf?
https://reviews.llvm.org/D40574
___
cfe-commits mailing list
cfe-commits@lists.
Author: eugenezelenko
Date: Wed Nov 29 14:17:39 2017
New Revision: 319369
URL: http://llvm.org/viewvc/llvm-project?rev=319369&view=rev
Log:
[Documentation] Sort Clang-tidy changes next way: new modules, new checks,
renamed checks, extended checks, new check aliases.
Sort checks in each section a
Wizard added inline comments.
Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10
+``errorWithDomain:code:userInfo:`` to create new NSError objects instead
+of ``[NSError alloc] init]``. Otherwise it will lead to a warning message
+during compilation in Xcode.
-
Wizard updated this revision to Diff 124818.
Wizard marked 3 inline comments as done.
Wizard added a comment.
address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNserrorInitCheck.cpp
clang-tidy/objc/AvoidNserrorInitCheck.h
cla
Author: vedantk
Date: Wed Nov 29 14:25:14 2017
New Revision: 319373
URL: http://llvm.org/viewvc/llvm-project?rev=319373&view=rev
Log:
[Coverage] Emit gap areas in braces-optional statements (PR35387)
Emit a gap area starting after the r-paren location and ending at the
start of the body for the b
Eugene.Zelenko added a comment.
Please rebase from trunk. I just enforced some order in chaos of Release Notes
:-)
https://reviews.llvm.org/D40580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: eugenezelenko
Date: Wed Nov 29 14:39:22 2017
New Revision: 319376
URL: http://llvm.org/viewvc/llvm-project?rev=319376&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/DeclTemplate.h
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Thanks, this looks good to me!
Do you have commit access or do you need someone to commit it for you?
Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecke
aaron.ballman created this revision.
Herald added subscribers: kristof.beyls, Anastasia, mehdi_amini, aemerson.
Based on discussions at the WG21 meeting in Albuquerque and follow-up email
discussions, I believe the correct approach to exposing attributes from Clang
is to provide them with GNU-st
Author: aaronballman
Date: Wed Nov 29 15:10:14 2017
New Revision: 319383
URL: http://llvm.org/viewvc/llvm-project?rev=319383&view=rev
Log:
Perform a bounds check on a function's argument list before accessing any index
value specified by an 'argument_with_type_tag' attribute. Fixes PR28520.
Patc
aaron.ballman closed this revision.
aaron.ballman added a comment.
In https://reviews.llvm.org/D40574#939693, @mattd wrote:
> Thanks for the approval Aaron. I do not have commit access, would you mind
> submitting this on my behalf?
Happy to do so -- I've commit in r319383, thank you for the
Nebiroth updated this revision to Diff 124833.
Nebiroth added a comment.
Herald added a subscriber: klimek.
Invalid FileEntries now return llvm:ErrorOr
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D35894
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/C
tra added a comment.
ping.
https://reviews.llvm.org/D40198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:2200
+ Layout.getBaseClassOffset(Base->getAsCXXRecordDecl());
+ CharUnits BaseSize = Context.getTypeSizeInChars(Base);
+ if (BaseOffset != CurOffset)
On reflection, I don't think
malaperle added inline comments.
Comment at: clangd/ClangdUnit.cpp:1117
+
+ if (!DeclVector.empty()) {
+const Decl *LocationDecl = DeclVector[0];
malaperle wrote:
> I think we need to simplify this part a bit. I'll try to find a way. Feel
> free to wait unt
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/Protocol.cpp:498
+// Default Hover values
+Hover H;
+return json::obj{
remove, we have to return the conte
Nebiroth updated this revision to Diff 124834.
Nebiroth added a comment.
Fixed wrong content header making the test fail
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/Clangd
malaperle added a comment.
I copy/pasted the comments again so that you don't miss them.
Comment at: clangd/ClangdUnit.cpp:1117
+
+ if (!DeclVector.empty()) {
+const Decl *LocationDecl = DeclVector[0];
malaperle wrote:
> malaperle wrote:
> > I think we nee
malaperle added inline comments.
Comment at: clangd/ClangdUnit.cpp:1071
+Location getDeclarationLocation(ParsedAST &AST,
+const SourceRange &ValSourceRange) {
llvm::ErrorOr
Comment at: clangd/ClangdUnit.cpp:107
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319386: MS ABI: Treat explicit instantiation definitions of
dllimport function… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D40621?vs=124808&id=124839#toc
Repository:
rL LLV
Author: hans
Date: Wed Nov 29 15:44:11 2017
New Revision: 319386
URL: http://llvm.org/viewvc/llvm-project?rev=319386&view=rev
Log:
MS ABI: Treat explicit instantiation definitions of dllimport function
templates as explicit instantiation decls (PR35435)
This matches MSVC's behaviour, and we alre
erichkeane marked an inline comment as done.
erichkeane added inline comments.
Comment at: lib/AST/ASTContext.cpp:2200
+ Layout.getBaseClassOffset(Base->getAsCXXRecordDecl());
+ CharUnits BaseSize = Context.getTypeSizeInChars(Base);
+ if (BaseOffset != CurOffse
dberris updated this revision to Diff 124842.
dberris marked an inline comment as done.
dberris edited the summary of this revision.
dberris added a comment.
Updated description, address review comment(s).
https://reviews.llvm.org/D40601
Files:
clang/include/clang/Basic/LangOptions.def
clan
dberris added inline comments.
Comment at: clang/lib/Driver/XRayArgs.cpp:32-33
constexpr char XRayNeverInstrumentOption[] = "-fxray-never-instrument=";
+constexpr char XRayAlwaysEmitCustomEventsOption[] =
+"-fxray-always-emit-customevents";
} // namespace
d
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:2200
+ Layout.getBaseClassOffset(Base->getAsCXXRecordDecl());
+ CharUnits BaseSize = Context.getTypeSizeInChars(Base);
+ if (BaseOffset != CurOffset)
erichkeane wrote:
> rsmith wr
erichkeane added inline comments.
Comment at: lib/AST/ASTContext.cpp:2200
+ Layout.getBaseClassOffset(Base->getAsCXXRecordDecl());
+ CharUnits BaseSize = Context.getTypeSizeInChars(Base);
+ if (BaseOffset != CurOffset)
rsmith wrote:
> erichkean
Author: dberris
Date: Wed Nov 29 16:04:54 2017
New Revision: 319388
URL: http://llvm.org/viewvc/llvm-project?rev=319388&view=rev
Log:
[XRay][clang] Introduce -fxray-always-emit-customevents
Summary:
The -fxray-always-emit-customevents flag instructs clang to always emit
the LLVM IR for calls to t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319388: [XRay][clang] Introduce
-fxray-always-emit-customevents (authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D40601?vs=124842&id=124846#toc
Repository:
rL LLVM
https://re
george.karpenkov added a comment.
> If the type extension approach is proven to be sound
I lack the full context here, but in my experience Z3 is really great for
proving whether certain operations may or may not overflow, using the built-in
bitvector type.
(I'm not sure though if that is what
juliehockett updated this revision to Diff 124853.
juliehockett added a comment.
Rebasing for updated Release Notes -- so much nicer :)
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInheritanceC
juliehockett added inline comments.
Comment at: docs/clang-tidy/checks/fuchsia-multiple-inheritance.rst:46
+
+See the features disallowed in Fuchsia at
https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md
alexfh wrote:
> This is not about the check, rath
arphaman added a comment.
This change breaks cached completions for declarations in namespaces in
libclang. What exactly are you trying to achieve here? We could introduce
another flag maybe.
https://reviews.llvm.org/D40562
___
cfe-commits mailing
arphaman added a comment.
Here's a simple test that breaks:
$ cat test.cpp
namespace ns {
void func();
}
ns::
// complete
$ c-index-test -code-completion-at=test.cpp:5:1 test.cpp
FunctionDecl:{ResultType void}{TypedText func}{LeftParen (}{RightParen )} (50)
Completion contexts
arphaman added a comment.
If nothing uses `getCXXScopeSpecifier` right now we can't really test it with a
clang or c-index-test regression test. A completion unit test could work here.
I don't think we actually have existing completion unit tests though, so you
would have to create one from scr
erichkeane updated this revision to Diff 124859.
erichkeane added a comment.
Fixed the 'tail padding' mechanism to work correctly as suggested by @rsmith
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
lib/AST/ASTContext.cpp
lib/AST/CXXABI.
rsmith added inline comments.
Comment at: docs/clang-tidy/checks/fuchsia-multiple-inheritance.rst:46
+
+See the features disallowed in Fuchsia at
https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md
juliehockett wrote:
> alexfh wrote:
> > This is not abo
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:2200
+ Layout.getBaseClassOffset(Base->getAsCXXRecordDecl());
+ CharUnits BaseSize = Context.getTypeSizeInChars(Base);
+ if (BaseOffset != CurOffset)
erichkeane wrote:
> rsmith wr
erichkeane added inline comments.
Comment at: lib/AST/ASTContext.cpp:2200
+ Layout.getBaseClassOffset(Base->getAsCXXRecordDecl());
+ CharUnits BaseSize = Context.getTypeSizeInChars(Base);
+ if (BaseOffset != CurOffset)
rsmith wrote:
> erichkean
erichkeane updated this revision to Diff 124863.
erichkeane added a comment.
Fix for trailing padding BITS, which obviously won't be merged.
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
lib/AST/ASTContext.cpp
lib/AST/CXXABI.h
lib/AST/I
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks for your patience, this turned out to be surprisingly complicated.
https://reviews.llvm.org/D39347
___
cfe-commits mailing list
cfe-commit
rsmith added a comment.
What actual problem is this solving? These IR type names exist only for the
convenience of humans reading the IR, and making them long (potentially
extremely long) by including template arguments seems likely to hinder that
more than it helps.
https://reviews.llvm.org/
erichkeane added a comment.
In https://reviews.llvm.org/D39347#940015, @rsmith wrote:
> Thanks for your patience, this turned out to be surprisingly complicated.
Of course! Thank you as well for your input, I was surprised at how
complicated this ended up being as well!
https://reviews.llvm
rsmith added inline comments.
Comment at: include/clang/Basic/Attr.td:602
def AnalyzerNoReturn : InheritableAttr {
- let Spellings = [GNU<"analyzer_noreturn">];
+ let Spellings = [Clang<"analyzer_noreturn">];
let Documentation = [Undocumented];
Hmm, should
szepet marked an inline comment as done.
szepet added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:611
+ EXPECT_TRUE(testImport("template struct S;"
+ "template void declToImport() {"
+ " S::foo;"
-
sepavloff added a comment.
In https://reviews.llvm.org/D40567#940025, @rsmith wrote:
> What actual problem is this solving? These IR type names exist only for the
> convenience of humans reading the IR, and making them long (potentially
> extremely long) by including template arguments seems li
malaperle added inline comments.
Comment at: clangd/ClangdUnit.cpp:1117
+
+ if (!DeclVector.empty()) {
+const Decl *LocationDecl = DeclVector[0];
malaperle wrote:
> malaperle wrote:
> > malaperle wrote:
> > > I think we need to simplify this part a bit. I'll
phosek created this revision.
Herald added subscribers: Sanitizers, llvm-commits, mgorny, kubamracek.
Herald added a reviewer: EricWF.
This also slightly refactors the code that's checking the directory
presence which allows eliminating one unnecessary variable.
Repository:
rCRT Compiler Runti
sepavloff added a comment.
In https://reviews.llvm.org/D40508#939513, @rjmccall wrote:
> In https://reviews.llvm.org/D40508#938854, @sepavloff wrote:
>
> > In https://reviews.llvm.org/D40508#938686, @rjmccall wrote:
> >
> > > The LLVM linking model does not actually depend on struct type names
>
lebedev.ri added a comment.
In https://reviews.llvm.org/D40463#939772, @dcoughlin wrote:
> Thanks, this looks good to me!
Awesome, thank you!
> Do you have commit access or do you need someone to commit it for you?
I do have commit access.
Repository:
rC Clang
https://reviews.llvm.org/D4
rjmccall added a comment.
Are you trying to use LLVM struct type identity to infer information about the
source program? That is not and has never been a guarantee.
https://reviews.llvm.org/D40508
___
cfe-commits mailing list
cfe-commits@lists.llv
101 - 168 of 168 matches
Mail list logo
