[libunwind] r319299 - [CMake] Use the variable from the right project in install-unwind

Author: mstorsjo Date: Wed Nov 29 00:20:57 2017 New Revision: 319299 URL: http://llvm.org/viewvc/llvm-project?rev=319299&view=rev Log: [CMake] Use the variable from the right project in install-unwind Modified: libunwind/trunk/src/CMakeLists.txt Modified: libunwind/trunk/src/CMakeLists.txt U

[libunwind] r319300 - Support building libunwind as a DLL

Author: mstorsjo Date: Wed Nov 29 00:21:12 2017 New Revision: 319300 URL: http://llvm.org/viewvc/llvm-project?rev=319300&view=rev Log: Support building libunwind as a DLL Differential Revision: https://reviews.llvm.org/D40483 Modified: libunwind/trunk/CMakeLists.txt libunwind/trunk/src/c

[PATCH] D40594: [InstCombine] miscompile of __builtin_fmod

Quolyk created this revision. Motivation: https://bugs.llvm.org/show_bug.cgi?id=34870 I'm totally not sure this is correct https://reviews.llvm.org/D40594 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins.c Index: test/CodeGen/builtins.c ==

[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79 QualifiedRenameRule(const NamedDecl *ND, - std::string NewQualifiedName) + const std::string &NewQualifiedName) : ND(ND), New

[PATCH] D40528: add new check to find NSError init invocation

hokein added inline comments. Comment at: clang-tidy/objc/AvoidNserrorInitCheck.cpp:31 + diag(MatchedExpr->getLocStart(), + "use errorWithDomain:code:userInfo: to create a new NSError"); +} not sure what's the best message here. From apple's document: >

[PATCH] D40564: [clangd] Simplify common JSON-parsing patterns in Protocol.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clangd/Protocol.cpp:56 +assert(*this && "Must check this is an object before calling parse()"); +if (const json::Expr *E = O->get(Prop)) { + ret

[PATCH] D40060: [clangd] Fuzzy match scorer

ilya-biryukov added inline comments. Comment at: clangd/FuzzyMatch.cpp:118 +0x00, 0x00, 0x00, 0x00, // Control characters +0xff, 0xff, 0xff, 0xff, // Punctuation +0x55, 0x55, 0xf5, 0xff, // Numbers->Lower, more Punctuation. I'm not sure if we care, bu

[PATCH] D40310: Restructure how we break tokens.

klimek updated this revision to Diff 124709. klimek marked 4 inline comments as done. klimek added a comment. Address review comments. https://reviews.llvm.org/D40310 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/Fo

[PATCH] D40310: Restructure how we break tokens.

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1707 + RemainingTokenColumns = Token->getRemainingLength( + NextLineIndex, TailOffset, ContentStartColumn); + Reflow = true; krasimir wrote: > When we're

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

ilya-biryukov added a comment. This is how I always perceived this option in the first place, so LGTM. But maybe its intention is different, so we should wait for @arphaman's comments. Could you also update comments of `CodeCompleteConsumer::includeGlobals` and `CodeCompleteOptions::IncludeGlob

[PATCH] D40508: Replace long type names in IR with hashes

sepavloff added a comment. In https://reviews.llvm.org/D40508#938686, @rjmccall wrote: > In https://reviews.llvm.org/D40508#938675, @sepavloff wrote: > > > In https://reviews.llvm.org/D40508#938040, @rjmccall wrote: > > > > > My skepticism about the raw_ostream is not about the design of having a

[PATCH] D40310: Restructure how we break tokens.

krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1749 + } + if (!Reflow) { +// If we didn't reflow into the next line, the only space to consider is nit: Maybe change this to `if (Reflow)` and switch the if-else b

[PATCH] D40564: [clangd] Simplify common JSON-parsing patterns in Protocol.

This revision was automatically updated to reflect the committed changes. Closed by commit rL319309: [clangd] Simplify common JSON-parsing patterns in Protocol. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D40564?vs=124585&id=124713#toc Repository: rL LLVM http

[clang-tools-extra] r319309 - [clangd] Simplify common JSON-parsing patterns in Protocol.

Author: sammccall Date: Wed Nov 29 03:36:46 2017 New Revision: 319309 URL: http://llvm.org/viewvc/llvm-project?rev=319309&view=rev Log: [clangd] Simplify common JSON-parsing patterns in Protocol. Summary: This makes the parse() functions about as short as they can be given the current signature,

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40596: [clangd] New conventions for JSON-marshalling functions, centralize machinery

sammccall created this revision. Herald added subscribers: cfe-commits, klimek. - JSON<->Obj interface is now ADL functions, so they play nicely with enums - recursive vector/map parsing and ObjectMapper moved to JSONExpr and tested - renamed (un)parse to (de)serialize, since text -> JSON is calle

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris updated this revision to Diff 124717. dberris added a comment. - [XRay][compiler-rt][Darwin] Use dynamic initialisation as an alternative https://reviews.llvm.org/D39114 Files: compiler-rt/cmake/config-ix.cmake compiler-rt/lib/xray/CMakeLists.txt compiler-rt/lib/xray/weak_symbols.

[PATCH] D40310: Restructure how we break tokens.

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1749 + } + if (!Reflow) { +// If we didn't reflow into the next line, the only space to consider is krasimir wrote: > nit: Maybe change this to `if (Reflow)` and swit

[PATCH] D40463: [analyzer] Fix false negative on post-increment of uninitialized variable.

lebedev.ri added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp:64 +if (const UnaryOperator *U = dyn_cast(StoreE)) { + str = "The expression of the unary operator is an uninitialized value. " +"The computed value will

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ilya-biryukov added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:284 + llvm::Optional ScopeSpecifier; + Maybe add a brief comment for consistency with other decls? Comment at: lib/Sema/SemaCodeComplete.cpp:4609 +

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ilya-biryukov added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4609 + if (SS.isInvalid()) { +CodeCompletionContext CC(CodeCompletionContext::CCC_Name); ilya-biryukov wrote: > Why do we alter this code path? Maybe we should add a test or pro

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev updated this revision to Diff 124726. kosarev added a comment. - Added tests with nested unions. - Rebased. https://reviews.llvm.org/D39455 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/CodeGenTBAA.cpp lib/CodeGen/CodeGenTBAA.h test/CodeGen/tbaa-union.c

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev added a comment. Thanks Hal. Will commit it tomorrow. https://reviews.llvm.org/D39455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

dberris created this revision. The -fxray-always-emit-customevents flag instructs clang to always emit the LLVM IR for calls to the `__xray_customevent(...)` built-in function. The default behaviour currently respects whether the function has an `[[clang::xray_never_instrument]]` attribute, and th

[PATCH] D39279: Stringizing raw string literals containing newline

jkorous-apple added a comment. I am sorry I wasn't really clear. What I meant was to do something like this (pseudo-code, dealing only with newlines): if( Str.size() == 0) return; // Calculate all the extra space needed first. typename T::size_type extra_space = 0; bool previou

[PATCH] D40310: Restructure how we break tokens.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris closed this revision. dberris added a comment. Already commited; closing this revision out now. https://reviews.llvm.org/D39114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:22 +AST_MATCHER(CXXRecordDecl, hasDefinition) { + if (!Node.hasDefinition()) +return false; ---

[PATCH] D40594: [InstCombine] miscompile of __builtin_fmod

spatel added reviewers: efriedma, hfinkel. spatel added a comment. I don't know the history of the frem instruction in IR, and the description in http://llvm.org/docs/LangRef.html#frem-instruction is vague. But based on the existing code, I think this is working as intended. If the instruction

[PATCH] D40588: [OpenMP] Diagnose undeclared variables on declare target clause

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. I'm unable to reproduce a crash, the test works correctly even without you patch https://reviews.llvm.org/D40588 ___ cfe-commits mail

r319314 - Restructure how we break tokens.

Author: klimek Date: Wed Nov 29 06:29:43 2017 New Revision: 319314 URL: http://llvm.org/viewvc/llvm-project?rev=319314&view=rev Log: Restructure how we break tokens. This fixes some bugs in the reflowing logic and splits out the concerns of reflowing from BreakableToken. Things to do after this

[PATCH] D40310: Restructure how we break tokens.

This revision was automatically updated to reflect the committed changes. Closed by commit rL319314: Restructure how we break tokens. (authored by klimek). Repository: rL LLVM https://reviews.llvm.org/D40310 Files: cfe/trunk/lib/Format/BreakableToken.cpp cfe/trunk/lib/Format/BreakableToke

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ioeric updated this revision to Diff 124739. ioeric marked 4 inline comments as done. ioeric added a comment. - Address review comments. https://reviews.llvm.org/D40563 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp =

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ioeric added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4609 + if (SS.isInvalid()) { +CodeCompletionContext CC(CodeCompletionContext::CCC_Name); ilya-biryukov wrote: > ilya-biryukov wrote: > > Why do we alter this code path? > Maybe we shou

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

ioeric updated this revision to Diff 124740. ioeric added a comment. - Clarify comment for includeGlobals() https://reviews.llvm.org/D40562 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaLookup.cpp test/CodeCompletion/ignore-global-decls.cpp

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. Ping * 2. https://reviews.llvm.org/D39812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

alexfh added a comment. A couple of late comments. Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:39 + return; +} else if (DefaultArgRange.getBegin().isMacroID()) { + diag(D->getLocStart(), No `else` after `return`, please. http://llvm.

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

spetrovic added a comment. I tried to compile some important libraries for X86 and MIPS64 within Chromium with clang/llvm. I have compared results between LLVM trunk, and LLVM trunk with my patch. There is code size improvement on many libraries, here are some results: - X86 libframe

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

This revision was automatically updated to reflect the committed changes. Closed by commit rC319317: Add the nvidia-cuda-toolkit Debian package path to search path (authored by sylvestre). Repository: rC Clang https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: l

r319317 - Add the nvidia-cuda-toolkit Debian package path to search path

Author: sylvestre Date: Wed Nov 29 07:03:28 2017 New Revision: 319317 URL: http://llvm.org/viewvc/llvm-project?rev=319317&view=rev Log: Add the nvidia-cuda-toolkit Debian package path to search path Summary: Reported here: http://bugs.debian.org/882505 Patch by Andreas Beckmann Reviewers: Hah

[PATCH] D40594: [InstCombine] miscompile of __builtin_fmod

spatel added a comment. Side note: I think there is a different bug here in clang because from what I can tell, we convert the builtin or libcall to 'frem' even when errno could be set by the call. https://reviews.llvm.org/D40044 doesn't address this case because frem is an LLVM instruction rat

[PATCH] D40548: [clangd] Prototyping index support and naive index-based global code completion. WIP

ioeric updated this revision to Diff 124745. ioeric added a comment. Herald added a subscriber: klimek. Merged with origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40548 Files: clangd/ASTIndex.cpp clangd/ASTIndex.h clangd/CMakeLists.txt clangd/ClangdIndex.c

r319318 - Fix 'control reaches end of non-void' warning by using llvm_unreachable.

Author: klimek Date: Wed Nov 29 07:09:12 2017 New Revision: 319318 URL: http://llvm.org/viewvc/llvm-project?rev=319318&view=rev Log: Fix 'control reaches end of non-void' warning by using llvm_unreachable. Modified: cfe/trunk/lib/Format/BreakableToken.cpp Modified: cfe/trunk/lib/Format/Break

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

jkorous-apple added inline comments. Comment at: tools/libclang/CIndexer.cpp:131 + if (!File.empty()) +llvm::sys::fs::remove(File); +} Just a thought - since we are not propagating errors from constructor we are not really sure we were able to create the fi

r319319 - Follow up of r319317, add the missing header file

Author: sylvestre Date: Wed Nov 29 07:11:53 2017 New Revision: 319319 URL: http://llvm.org/viewvc/llvm-project?rev=319319&view=rev Log: Follow up of r319317, add the missing header file Modified: cfe/trunk/lib/Driver/ToolChains/Cuda.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Cuda.cpp URL:

r319320 - [OPENMP] General improvement of handling of `teams distribute`

Author: abataev Date: Wed Nov 29 07:14:16 2017 New Revision: 319320 URL: http://llvm.org/viewvc/llvm-project?rev=319320&view=rev Log: [OPENMP] General improvement of handling of `teams distribute` directive, NFC. Some general improvements in support of `teams distribute` directive. Modified:

[PATCH] D40463: [analyzer] Fix false negative on post-increment of uninitialized variable.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp:64 +if (const UnaryOperator *U = dyn_cast(StoreE)) { + str = "The expression of the unary operator is an uninitialized value. " +"The computed value will a

[PATCH] D40605: Better trade-off for excess characters vs. staying within the column limits.

klimek created this revision. When we break a long line like: Column limit: 21 | // foo foo foo foo foo foo foo foo foo foo foo foo The local decision when to allow protruding vs. breaking can lead to this outcome (2 excess characters, 2 breaks): // foo foo foo foo foo

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

jkorous-apple added inline comments. Comment at: tools/libclang/CIndexer.cpp:108 + // Write out the information about the invocation to it. + auto WriteStringKey = [&](StringRef Key, StringRef Value) { +OS << R"(")" << Key << R"(":")"; Nit: Maybe capturing

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

gerazo added a comment. Thanks George for the review. I will start working on the code right away. I've tried to answer the simpler cases. Comment at: tools/scan-build-py/libscanbuild/analyze.py:44 +CTU_FUNCTION_MAP_FILENAME = 'externalFnMap.txt' +CTU_TEMP_FNMAP_FOLDER = 'tm

r319269 - Reland "Fix vtable not receiving hidden visibility when using push(visibility)"

Author: jakehehrlich Date: Tue Nov 28 16:54:20 2017 New Revision: 319269 URL: http://llvm.org/viewvc/llvm-project?rev=319269&view=rev Log: Reland "Fix vtable not receiving hidden visibility when using push(visibility)" I had to reland this change in order to make the test work on windows This ch

r319322 - Fix function call to fix build

Author: ismail Date: Wed Nov 29 07:18:02 2017 New Revision: 319322 URL: http://llvm.org/viewvc/llvm-project?rev=319322&view=rev Log: Fix function call to fix build ../tools/clang/lib/Driver/ToolChains/Cuda.cpp:80:18: error: reference to non-static member function must be called; did you mean to

Re: [llvm-dev] LLVM buildmaster is back to work now but two builders remain OFF

> Two slaves remain off for now as they produce a lot of warnings and their log files are way too big. I think https://reviews.llvm.org/D40603 will fix this issue. -Greg On 28 November 2017 at 22:13, Galina Kistanova via llvm-dev < llvm-...@lists.llvm.org> wrote: > Hello everyone, > > LLVM bui

[PATCH] D40574: Bounds check argument_with_type_tag attribute.

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7922-7925 +def err_type_tag_out_of_range : Error< + "type tag index %0 is greater than the number of arguments specified">; +def err_arg_tag_out_of_range : Error< + "argument tag index %

r319323 - [Driver] Turns out the GNU assembler does support falkor/saphira.

Author: mcrosier Date: Wed Nov 29 08:42:44 2017 New Revision: 319323 URL: http://llvm.org/viewvc/llvm-project?rev=319323&view=rev Log: [Driver] Turns out the GNU assembler does support falkor/saphira. Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/trunk/test/Driver/as-mcpu.c Modif

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

mcrosier added a comment. In https://reviews.llvm.org/D40476#936700, @mcrosier wrote: > In https://reviews.llvm.org/D40476#936372, @pirama wrote: > > > Thanks for the review. Now let's just hope the windows bots stay happy :) > > > Actually, I just checked and it looks like falkor and saphira we

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:58 + // Interfaces should have exclusively pure methods. + for (auto method : Node->methods()) { +if (method->isUserProvided() && !method->isPure()) { Eugene.Ze

[clang-tools-extra] r319325 - [clang-tidy] make readability-simplify-bool-expr completely ignore macros

Author: alexfh Date: Wed Nov 29 09:16:09 2017 New Revision: 319325 URL: http://llvm.org/viewvc/llvm-project?rev=319325&view=rev Log: [clang-tidy] make readability-simplify-bool-expr completely ignore macros Modified: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane added inline comments. Comment at: lib/AST/ASTContext.cpp:2213 +Field->isBitField() +? Field->getBitWidthValue(Context) +: Context.toBits(Context.getTypeSizeInChars(Field->getType())); erichkeane wrote: > rsmith wrote: >

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane updated this revision to Diff 124765. https://reviews.llvm.org/D39347 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h lib/AST/ASTContext.cpp lib/AST/CXXABI.h lib/AST/ItaniumCXXABI.cpp lib/AST/MicrosoftCXXABI.cpp lib/AST/Type.cpp lib/Sema/SemaExprCXX.cpp

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added inline comments. Comment at: clangd/ClangdUnit.cpp:1173 +H.range = L.range; +Ref = getDataBufferFromSourceRange(AST, SR, L); + } malaperle wrote: > malaperle wrote: > > I get the same crash as I mentioned before if I hover on

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane updated this revision to Diff 124769. erichkeane added a comment. Woops, missed an 'svn add' and lost the member ptr test. Back now! https://reviews.llvm.org/D39347 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h lib/AST/ASTContext.cpp lib/AST/CXXABI.h lib/A

[PATCH] D40611: Add has definition AST matcher

juliehockett created this revision. Herald added a subscriber: klimek. Adds AST matcher for the definition of a CXXRecordDecl. https://reviews.llvm.org/D40611 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/

[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

sfertile added inline comments. Comment at: include/clang/Driver/Options.td:1907 def mvsx : Flag<["-"], "mvsx">, Group; +def msave_toc_indirect : Flag<["-"], "msave-toc-indirect">, Group; def mno_vsx : Flag<["-"], "mno-vsx">, Group; hfinkel wrote: > You also n

[PATCH] D40463: [analyzer] Fix false negative on post-increment of uninitialized variable.

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:1046 if (V2_untested.isUnknownOrUndef()) { Bldr.generateNode(U, *I, state->BindExpr(U, LCtx, V2_untested)); + lebedev.ri wrote: > dcoughlin wrote: > > Instead of gene

Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

I see a bunch of link errors that suggest we're using the wrong EH personality in MSVC mode now: FAILED: win_clang_nacl_win64/swiftshader/libEGL.dll win_clang_nacl_win64/swiftshader/libEGL.dll.lib win_clang_nacl_win64/swiftshader/libEGL.dll.pdb C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/pytho

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124772. juliehockett marked 11 inline comments as done. juliehockett added a comment. Moved AST matcher to ASTMatchers.h (see D40611 ), addressing comments. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/C

[PATCH] D40566: Check if MemberExpr arguments are type-dependent.

erik.pilkington added a comment. Hi, thanks for working on this! Why don't we just set the TypeDependent bit to false when building the underlying MemberExpr here? Based on the section of the standard you quoted that node shouldn't be considered type-dependent, but it is by clang. I think this

r319332 - [OPENMP] Do not allow `linear` clauses on non-simd distribute

Author: abataev Date: Wed Nov 29 10:20:04 2017 New Revision: 319332 URL: http://llvm.org/viewvc/llvm-project?rev=319332&view=rev Log: [OPENMP] Do not allow `linear` clauses on non-simd distribute directives. `linear` clause is not allowed on non-simd distribute-based directives. Removed: cfe

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added inline comments. Comment at: clangd/Protocol.h:453 +struct MarkedString { + /** + * MarkedString can be used to render human readable text. It is either a The doc should use /// like the others https://reviews.llvm.org/D35894 _

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

This revision was automatically updated to reflect the committed changes. Closed by commit rL319333: [analyzer] Fix unreachable creating PathDiagnosticLocation with widen-loops=true (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D37187?vs=124549&id=124778#toc Reposi

r319333 - [analyzer] Fix unreachable creating PathDiagnosticLocation with widen-loops=true

Author: dcoughlin Date: Wed Nov 29 10:25:37 2017 New Revision: 319333 URL: http://llvm.org/viewvc/llvm-project?rev=319333&view=rev Log: [analyzer] Fix unreachable creating PathDiagnosticLocation with widen-loops=true In the original design of the analyzer, it was assumed that a BlockEntrance does

[PATCH] D39279: Stringizing raw string literals containing newline

twoh added a comment. @jkorous-apple Thanks for the comments! Yeah, I was thinking of O(lenght_of_string) approach, but considering the complicatedness of the implementation (I guess the real implementation would be a bit more complex than your pseudo implementation to handle quote and '\n\r' '

[PATCH] D40463: [analyzer] Fix false negative on post-increment of uninitialized variable.

lebedev.ri added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp:64 +if (const UnaryOperator *U = dyn_cast(StoreE)) { + str = "The expression of the unary operator is an uninitialized value. " +"The computed value will

Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

Thanks for letting me know Reid. I’ll in work and won’t be able to access the repo until lunch time. (~3 hours) Feel free to revert if it is not trivial. The easy fix might be to change to == x86_64 from != x86 For is Windows in the default toolchain. That should restore the old behavior. I’m cur

r319336 - [clang-cl] Alias /wd4018 to -Wno-sign-compare

Author: rnk Date: Wed Nov 29 10:45:03 2017 New Revision: 319336 URL: http://llvm.org/viewvc/llvm-project?rev=319336&view=rev Log: [clang-cl] Alias /wd4018 to -Wno-sign-compare This warning is known to be noisy and projects frequently disable it. In particular, this should make building isl as bun

[PATCH] D40463: [analyzer] Fix false negative on post-increment of uninitialized variable.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp:64 +if (const UnaryOperator *U = dyn_cast(StoreE)) { + str = "The expression of the unary operator is an uninitialized value. " +"The computed value will a

[PATCH] D40574: Bounds check argument_with_type_tag attribute.

mattd updated this revision to Diff 124783. mattd added a comment. - Removed the new lines. - Added white space between the data type and pointer character. - Updated the test to check the exact bounds, and over-bounds cases - Combined the diagnostic messages into one via 'select' https://revi

[PATCH] D40569: Use default IR alignment for cleanup.dest.slot.

jacobly added a comment. Could someone commit this for me? Thanks. Repository: rC Clang https://reviews.llvm.org/D40569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40574: Bounds check argument_with_type_tag attribute.

mattd marked 6 inline comments as done. mattd added inline comments. Comment at: test/Sema/error-type-safety.cpp:3-4 + +static const int test_void + __attribute__((type_tag_for_datatype(test, void))) = 0; + aaron.ballman wrote: > Is this declaration necessary? H

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: tools/libclang/CIndexer.cpp:131 + if (!File.empty()) +llvm::sys::fs::remove(File); +} jkorous-apple wrote: > Just a thought - since we are not propagating errors from cons

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

arphaman updated this revision to Diff 124788. arphaman added a comment. - Capture OS only. - Guard toolchain path accessor with a mutex. Repository: rC Clang https://reviews.llvm.org/D40527 Files: include/clang-c/Index.h test/Index/record-parsing-invocation.c tools/c-index-test/c-inde

[PATCH] D40568: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

eugenis added inline comments. Comment at: docs/TaggedAddressSanitizerDesign.rst:22 +*quarantine* to find use-after-free. +The shadow, the redzones, and the quarantine are the +major sources of AddressSanitizer's memory overhead. kcc wrote: > davidxl wrote: > > W

[PATCH] D40568: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

kcc updated this revision to Diff 124797. kcc added a comment. rephrase the sources of asan overhead Repository: rC Clang https://reviews.llvm.org/D40568 Files: docs/TaggedAddressSanitizerDesign.rst Index: docs/TaggedAddressSanitizerDesign.rst =

[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Not totally clear to me why this feature is desirable, but assume you've got use cases/reasons :) Comment at: clang/lib/Driver/XRayArgs.cpp:32-33 constexpr char XRayNev

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

mgrang created this revision. This fixes the following failure uncovered by https://reviews.llvm.org/D39245: Clang :: Index/getcursor-preamble.m Repository: rC Clang https://reviews.llvm.org/D40618 Files: tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp =

Re: [llvm-dev] LLVM buildmaster is back to work now but two builders remain OFF

Hopefully these two should be good to re-enable as of r319330. -Greg On 29 November 2017 at 16:23, Greg Bedwell wrote: > > Two slaves remain off for now as they produce a lot of warnings and > their log files are way too big. > > I think https://reviews.llvm.org/D40603 will fix this issue. > >

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

mgrang added inline comments. Comment at: tools/libclang/CIndex.cpp:1028 SourceLocation L_B = B->getLocStart(); -assert(L_A.isValid() && L_B.isValid()); -return SM.isBeforeInTranslationUnit(L_A, L_B); +return L_A != L_B ? + SM.isBeforeInTranslationUnit(

[PATCH] D40508: Replace long type names in IR with hashes

rjmccall added a comment. In https://reviews.llvm.org/D40508#938854, @sepavloff wrote: > In https://reviews.llvm.org/D40508#938686, @rjmccall wrote: > > > In https://reviews.llvm.org/D40508#938675, @sepavloff wrote: > > > > > In https://reviews.llvm.org/D40508#938040, @rjmccall wrote: > > > > > >

Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

On Wed, 29 Nov 2017, Martell Malone via cfe-commits wrote: Thanks for letting me know Reid. I’ll in work and won’t be able to access the repo until lunch time. (~3 hours) Feel free to revert if it is not trivial. The easy fix might be to change to == x86_64 from != x86 For is Windows in the def

[PATCH] D40594: [InstCombine] miscompile of __builtin_fmod

efriedma added a comment. By many years of precedent, the "frem" instruction is supposed to match the C fmod(), as opposed to something else like the C99 remainder(); probably worth clarifying in LangRef. https://reviews.llvm.org/D40594 ___ cfe-co

[PATCH] D39627: Fix vtable not receiving hidden visibility when using push(visibility)

efriedma added a comment. You probably just need to pass a "-triple" flag so we don't use Windows mangling or something like that. Repository: rL LLVM https://reviews.llvm.org/D39627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rC Clang https://reviews.llvm.org/D40618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added inline comments. Comment at: clangd/ClangdUnit.cpp:1135 +RawComment *RC = +AST.getASTContext().getRawCommentForDeclNoCache(LocationDecl); +if (RC) { Not sure why but I don't get the comments when I hover on "push_back"

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

arphaman added a comment. Could you please add a test? https://reviews.llvm.org/D40563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D40611: Add has definition AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor commenting nit, LGTM! Do you need me to commit this on your behalf? (If so, I can take care of the commenting fix.) Comment at: include/clan

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL319357: [SourceLocations] Use stronger sort predicate to remove non-deterministic… (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D40618?vs=124798&id=124804#toc Repository: r

r319357 - [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

Author: mgrang Date: Wed Nov 29 12:55:13 2017 New Revision: 319357 URL: http://llvm.org/viewvc/llvm-project?rev=319357&view=rev Log: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering Summary: This fixes the following failure uncovered by D39245: Clang :: Index/

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rC319357: [SourceLocations] Use stronger sort predicate to remove non-deterministic… (authored by mgrang). Repository: rC Clang https://reviews.llvm.org/D40618 Files: tools/libclang/CIndex.cpp Index

  1   2   >