ilya-biryukov added inline comments.
================
Comment at: include/clang/Sema/CodeCompleteConsumer.h:284
+ llvm::Optional<CXXScopeSpec> ScopeSpecifier;
+
----------------
Maybe add a brief comment for consistency with other decls?
================
Comment at: lib/Sema/SemaCodeComplete.cpp:4609
+ if (SS.isInvalid()) {
+ CodeCompletionContext CC(CodeCompletionContext::CCC_Name);
----------------
Why do we alter this code path?
================
Comment at: lib/Sema/SemaCodeComplete.cpp:4611
+ CodeCompletionContext CC(CodeCompletionContext::CCC_Name);
+ CC.setCXXScopeSpecifier(SS);
+ HandleCodeCompleteResults(this, CodeCompleter, CC, nullptr, 0);
----------------
Do we really want to set invalid scope specifiers here?
https://reviews.llvm.org/D40563
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
