Hi Hal,
As soon as we get the support for 4.5, including offloading. Otherwise there
always are going to be some people blaming the compiler for not supporting 4.5
in full. Will try to support it ASAP.
Meanwhile, you can use -fopenmp-version=45 option to force to 4.5
Best regards,
Alexey Bataev
Looks like this caused PR34811, which caused a link error on a Chromium bot:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/7081
The link error might be caused by an unrelated LTO bug, but this bug does
seem real. Please take a look.
Peter
On Thu, Sep 21, 2017 at 9:3
Author: rnk
Date: Mon Oct 2 17:14:03 2017
New Revision: 314743
URL: http://llvm.org/viewvc/llvm-project?rev=314743&view=rev
Log:
[clang-cl] Claim ignored /O[12xd] arguments
Fixes PR34809
Modified:
cfe/trunk/lib/Driver/ToolChains/MSVC.cpp
cfe/trunk/test/Driver/cl-options.c
Modified: cfe
On 10/02/2017 07:08 PM, Alexey Bataev wrote:
Hi Hal,
As soon as we get the support for 4.5, including offloading. Otherwise
there always are going to be some people blaming the compiler for not
supporting 4.5 in full. Will try to support it ASAP.
Meanwhile, you can use -fopenmp-version=45 opt
No, there is no such page. We parse everything from 4.5, but have very limited
support in codegen for target-specific directives, especially combined one.
Moreover, some of them are not implemented at all and we may produce incorrect
code. I can try to revisit these "badly" supported constructs
Author: faisalv
Date: Mon Oct 2 17:52:14 2017
New Revision: 314747
URL: http://llvm.org/viewvc/llvm-project?rev=314747&view=rev
Log:
[NFC] Refactor PasteTokens so that it can be passed the Token Stream and Index
to start concatenating at.
In passing:
- change the name of the function to pa
On 10/02/2017 07:38 PM, Alexey Bataev wrote:
No, there is no such page. We parse everything from 4.5, but have very
limited support in codegen for target-specific directives, especially
combined one. Moreover, some of them are not implemented at all and we
may produce incorrect code. I can try
Author: faisalv
Date: Mon Oct 2 18:20:40 2017
New Revision: 314748
URL: http://llvm.org/viewvc/llvm-project?rev=314748&view=rev
Log:
Remove an assertion I added from the refactoring of pasteTokens
(https://reviews.llvm.org/rL314747).
- it made the bots v angry!
I'm not exactly sure why the as
Author: vedantk
Date: Mon Oct 2 18:27:24 2017
New Revision: 314749
URL: http://llvm.org/viewvc/llvm-project?rev=314749&view=rev
Log:
[ubsan] Save a ptrtoint when emitting alignment checks
The alignment check emits a ptrtoint instruction which can be reused in
the call to the diagnostic handler.
Author: vedantk
Date: Mon Oct 2 18:27:25 2017
New Revision: 314750
URL: http://llvm.org/viewvc/llvm-project?rev=314750&view=rev
Log:
[ubsan] Add helpers to decide when null/vptr checks are required. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
cfe/trunk/lib/CodeGen/CodeGenFunction.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314752: [ubsan] Skip alignment checks which are folded away
(authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D37544?vs=116374&id=117461#toc
Repository:
rL LLVM
https://review
Author: vedantk
Date: Mon Oct 2 18:27:26 2017
New Revision: 314751
URL: http://llvm.org/viewvc/llvm-project?rev=314751&view=rev
Log:
[ubsan] Save the result of getLLVMContext. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL:
http://llvm.org/vi
Author: vedantk
Date: Mon Oct 2 18:27:26 2017
New Revision: 314752
URL: http://llvm.org/viewvc/llvm-project?rev=314752&view=rev
Log:
[ubsan] Skip alignment checks which are folded away
Don't emit alignment checks which the IR constant folder throws away.
I've tested this out on X86FastISel.cpp.
Author: faisalv
Date: Mon Oct 2 18:33:36 2017
New Revision: 314753
URL: http://llvm.org/viewvc/llvm-project?rev=314753&view=rev
Log:
Add parens around the boolean condition of one of the added asserts in r314747
...
... in the hopes of teaching the bots the gift of silence ;)
For quick refere
efriedma added a comment.
As far as I can see, there are three significant issues with the current
-mgeneral-regs-only:
1. We don't correctly ignore inline asm clobbers for registers which aren't
allocatable (https://bugs.llvm.org/show_bug.cgi?id=30792)
2. We don't diagnose calls which need vec
Author: rsmith
Date: Mon Oct 2 18:58:15 2017
New Revision: 314754
URL: http://llvm.org/viewvc/llvm-project?rev=314754&view=rev
Log:
R34811: Allow visibilities other than 'default' for VisibleNoLinkage entities.
Modified:
cfe/trunk/lib/AST/Decl.cpp
cfe/trunk/test/CodeGenCXX/visibility-inl
On 2 October 2017 at 17:10, Peter Collingbourne via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Looks like this caused PR34811, which caused a link error on a Chromium
> bot:
> https://build.chromium.org/p/chromium.fyi/builders/CFI%
> 20Linux%20ToT/builds/7081
>
> The link error might be ca
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks fine to me too, assuming the other parts get approved.
Once this is all working, please don't forget:
- user documentation
- release notes
https://reviews.llvm.org/D32199
_
Author: ericwf
Date: Mon Oct 2 19:25:05 2017
New Revision: 314755
URL: http://llvm.org/viewvc/llvm-project?rev=314755&view=rev
Log:
Fix test suite misconfiguration on OS X
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://llvm
hfinkel added a comment.
In https://reviews.llvm.org/D37624#885438, @choikwa wrote:
> > Can you get more information on what GCC actually implemented and why? It's
> > not clear to me that ignoring the namespaces is the most-useful way to do
> > this. I don't want to emulate GCC bugs, but maybe
On Mon, Oct 2, 2017 at 7:02 PM, Richard Smith wrote:
> On 2 October 2017 at 17:10, Peter Collingbourne via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Looks like this caused PR34811, which caused a link error on a Chromium
>> bot:
>> https://build.chromium.org/p/chromium.fyi/builders/
malaperle added inline comments.
Comment at: clangd/Protocol.h:458
+///
+/// A parameter can have a label and a doc-comment.
+struct ParameterInformation {
rwols wrote:
> @malaperle I copied the sentences from the protocol markdown file over
> [here](https://git
george.burgess.iv added a comment.
I like the idea of fixing those things, too; I'll start poking them soon. :)
Even if we do end up fixing all of that, I still think it would be good to try
to diagnose this in the frontend. So, if anyone has comments on this while I'm
staring at the aarch64 ba
101 - 123 of 123 matches
Mail list logo