[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lgtm Repository: rL LLVM https://reviews.llvm.org/D37210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

jdoerrie added a comment. Thanks for applying a fix based on my patch! I could have sworn the added tests failed locally before applying the algorithm patch, though... oh well. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commit

[PATCH] D37143: [clang-format] Fixed missing enter before bracket in typedef enum and extern

PriMee updated this revision to Diff 113035. PriMee added a comment. Unit tests added. If there is indeed a necessity to separate these two cases just inform me :) https://reviews.llvm.org/D37143 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/For

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

mprobst updated this revision to Diff 113036. mprobst added a comment. - drop function name wrapping hack https://reviews.llvm.org/D37142 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp ==

r311988 - clang-format: [JS] simplify template string wrapping.

Author: mprobst Date: Tue Aug 29 01:30:07 2017 New Revision: 311988 URL: http://llvm.org/viewvc/llvm-project?rev=311988&view=rev Log: clang-format: [JS] simplify template string wrapping. Summary: Previously, clang-format would try to wrap template string substitutions by indenting relative to th

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

mprobst added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1139 + + // On lines containing template strings, propagate NoLineBreak even for dict + // and array literals. This is to force wrapping an initial function call if mprobst wrote: >

[PATCH] D37142: clang-format: [JS] simplify template string wrapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311988: clang-format: [JS] simplify template string wrapping. (authored by mprobst). Repository: rL LLVM https://reviews.llvm.org/D37142 Files: cfe/trunk/lib/Format/ContinuationIndenter.cpp cfe/tr

[PATCH] D37254: [Sema] Disallow assigning record lvalues with nested const-qualified fields.

bevinh created this revision. According to C99 6.3.2.1p1, structs and unions with nested const-qualified fields (that is, const-qualified fields declared at some recursive level of the aggregate) are not modifiable lvalues. However, Clang permits assignments of these lvalues. With this patch, we

[PATCH] D35955: clang-format: Add preprocessor directive indentation

krasimir added a comment. @euhlmann: are you planning to commit this? https://reviews.llvm.org/D35955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#854729, @dcoughlin wrote: > Except for some drive-by nits, this is a high-level review. > > I have some high-level questions about the design of the library: > > 1. **How do you intend to handle the case when there are multiple functio

r311990 - [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

Author: erikjv Date: Tue Aug 29 02:08:02 2017 New Revision: 311990 URL: http://llvm.org/viewvc/llvm-project?rev=311990&view=rev Log: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit* Looks like this one was forgotten for clang_parseTranslationUnit*, as LIBCLANG_NOTHREADS is che

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

This revision was automatically updated to reflect the committed changes. Closed by commit rL311990: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit* (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D36821?vs=111472&id=113041#toc Repository: rL LLVM

[PATCH] D37255: [analyzer] Fix bugreporter::getDerefExpr() again - a smaller targeted fix.

NoQ created this revision. Herald added a subscriber: xazax.hun. In order to be able to revert the risky refactoring in https://reviews.llvm.org/D37023 without bringing back the regression, i made a smaller (but uglier) isolated fix for the crash. Then https://reviews.llvm.org/D37023 will be ap

r311991 - [modules] Add test for using declaration in classes.

Author: teemperor Date: Tue Aug 29 02:27:41 2017 New Revision: 311991 URL: http://llvm.org/viewvc/llvm-project?rev=311991&view=rev Log: [modules] Add test for using declaration in classes. Summary: This adds a test that checks if the using declaration in classes still works as intended with modu

[PATCH] D37180: [modules] Add test for using declaration in classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311991: [modules] Add test for using declaration in classes. (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D37180?vs=112788&id=113044#toc Repository: rL LLVM https://rev

[PATCH] D37143: [clang-format] Fixed missing enter before bracket in typedef enum and extern

krasimir added a comment. Thank you! I prefer this patch to be split in two. I am still not convinced about the `extern` part: some clients might prefer the other style. https://reviews.llvm.org/D37143 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D37182: [libcxx] Special visibility macros for the experimental library

smeenai added reviewers: mclow.lists, compnerd. smeenai resigned from this revision. smeenai added a comment. It's really cool that you're getting the filesystem library to work on Windows :) This looks reasonable to me; it's the only way I can think of to get the experimental library working o

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:116 + // B32: store i32 4, i32* %[[TMP3]], align 4 + // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]], i32 [[FLAGS]], %struct.ndrange_t* [[NDR]]{{(.[0-9]+)?}},

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

ilya-biryukov added a comment. BTW, if you're only looking for providing extra compilation flags for some files, you could use an extension to LSP that is already in clangd source tree. (See tests from https://reviews.llvm.org/D34947 for more details). But your change is also useful, as it allow

[PATCH] D37231: Add half load and store builtins

Anastasia added inline comments. Comment at: include/clang/Basic/Builtins.def:1427 +// OpenCL half load/store builtin +BUILTIN(__builtin_store_half, "vdh*", "n") +BUILTIN(__builtin_store_halff, "vfh*", "n") I think this should be a language builtin (see above) bu

[PATCH] D36410: [OpenCL] Handle taking address of block captures

Anastasia added a comment. Ok, I will update it to be implicitly generic then. Just to be sure, @bader do you agree on this too? https://reviews.llvm.org/D36410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D37260: [clang-format] Fixed extern C brace wrapping

PriMee created this revision. Herald added a subscriber: klimek. Bug: https://bugs.llvm.org/show_bug.cgi?id=34016 - **"extern C part"** **Problem:** Due to the lack of "brace wrapping extern" flag, clang format does parse the block after **extern** keyword moving the opening bracket to the head

[PATCH] D37143: [clang-format] Fixed typedef enum brace wrapping

PriMee updated this revision to Diff 113062. PriMee added a comment. Done. **Extern C** part moved to: https://reviews.llvm.org/D37260 https://reviews.llvm.org/D37143 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel marked 4 inline comments as done. koldaniel added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:597-598 + + if(!BR.getContext().getLangOpts().C11) +return; + NoQ wrote: > Note that you cannot easily figure out

[PATCH] D37182: [libcxx] Special visibility macros for the experimental library

hamzasood added a comment. In https://reviews.llvm.org/D37182#855262, @smeenai wrote: > The other question, of course, is why the experimental library needs to be > static. If it were built shared, the annotations would just work on Windows > in theory (though I'm sure there are other issues th

[PATCH] D37143: [clang-format] Fixed typedef enum brace wrapping

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you. https://reviews.llvm.org/D37143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

djasper added a comment. Are you changing the line endings here? Phabricator tells me that basically all the lines change. If so, please don't ;). Comment at: lib/Format/TokenAnnotator.cpp:345 + +FormatToken *PreviousNoneOfConstVolatileReference = Parent; +while (Previ

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel updated this revision to Diff 113065. koldaniel added a comment. Updated checker name, minor modifications https://reviews.llvm.org/D35068 Files: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp Index: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp

[PATCH] D37136: [clang-format] Do not format likely xml

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Just a few minor comments, otherwise looks good. Comment at: lib/Format/Format.cpp:1542 +bool likelyXml(StringRef Code) { + return Code.ltrim().startswith("<");

[PATCH] D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Lgtm with two requests below Comment at: include/clang/AST/RecursiveASTVisitor.h:354 +protected: + bool TraverseStmtBase(Stmt *S, DataRecursionQueue *Queue) { +retur

[PATCH] D37005: [clang-diff] Initial implementation of patching

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTPatch.h:1 +//===- ASTDiff.h - Structural patching based on ASTDiff ---*- C++ -*- -===// +// Please update the file name in the comment Comment at: lib/Tooling/AST

[PATCH] D37005: [clang-diff] Initial implementation of patching

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:73 public: + /// Empty (invalid) SyntaxTree. + SyntaxTree(); Why do you need to create an empty tree? What about using llvm::Optional instead? Comment at: i

[PATCH] D36410: [OpenCL] Handle taking address of block captures

bader added a comment. In https://reviews.llvm.org/D36410#855282, @Anastasia wrote: > Ok, I will update it to be implicitly generic then. Just to be sure, @bader > do you agree on this too? > An alternative approached could be (in case we want to allow this code) to > **assume captures are

[PATCH] D37143: [clang-format] Fixed typedef enum brace wrapping

PriMee added a comment. I am glad to hear that. Would be great if someone could commit it. Thank You :) https://reviews.llvm.org/D37143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113073. curdeius added a comment. Fix line endings. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor

johannes added a comment. This is currently broken, if a user provides a TraverseClassTemplateDecl, then the same method in this class will not be called, I think I will add a flag (probably not user visible) in RecursiveASTVisitor.h to switch the order for templates https://reviews.llvm.org/

[PATCH] D37140: [clang-format] Fixed one-line if statement

PriMee updated this revision to Diff 113074. PriMee added a comment. Unit tests added. https://reviews.llvm.org/D37140 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

[PATCH] D37231: Add half load and store builtins

jvesely added inline comments. Comment at: include/clang/Basic/Builtins.def:1427 +// OpenCL half load/store builtin +BUILTIN(__builtin_store_half, "vdh*", "n") +BUILTIN(__builtin_store_halff, "vfh*", "n") Anastasia wrote: > I think this should be a language built

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113077. curdeius added a comment. Fix line endings again. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D37005: [clang-diff] Initial implementation of patching

johannes updated this revision to Diff 113078. johannes added a comment. fixes https://reviews.llvm.org/D37005 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTPatch.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/ASTPatch.cpp lib/Tooling/ASTDiff/C

[PATCH] D37005: [clang-diff] Initial implementation of patching

johannes added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:73 public: + /// Empty (invalid) SyntaxTree. + SyntaxTree(); arphaman wrote: > Why do you need to create an empty tree? What about using llvm::Optional > instead? ok, i use op

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113079. curdeius added a comment. Extract method. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

r311998 - [clang-format] Fixed typedef enum brace wrapping

Author: krasimir Date: Tue Aug 29 06:32:30 2017 New Revision: 311998 URL: http://llvm.org/viewvc/llvm-project?rev=311998&view=rev Log: [clang-format] Fixed typedef enum brace wrapping Summary: Bug: https://bugs.llvm.org/show_bug.cgi?id=34016 - **Typedef enum part** **Problem:** Clang format doe

[PATCH] D37143: [clang-format] Fixed typedef enum brace wrapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL311998: [clang-format] Fixed typedef enum brace wrapping (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D37143?vs=113062&id=113081#toc Repository: rL LLVM https://reviews.

[PATCH] D37143: [clang-format] Fixed typedef enum brace wrapping

PriMee added a comment. Could you change the "Contributed by" section? Wrong account is assigned. Full name would be more satisfying. Thank You in advance :) Repository: rL LLVM https://reviews.llvm.org/D37143 ___ cfe-commits mailing list cfe-co

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113084. curdeius added a comment. Fix: use do-while loop. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D37136: [clang-format] Do not format likely xml

krasimir updated this revision to Diff 113085. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D37136 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp unittests/Format/SortIncludesTest.cpp Index: unittes

r311999 - [clang-format] Do not format likely xml

Author: krasimir Date: Tue Aug 29 06:51:38 2017 New Revision: 311999 URL: http://llvm.org/viewvc/llvm-project?rev=311999&view=rev Log: [clang-format] Do not format likely xml Summary: This patch detects the leading '<' in likely xml files and stops formatting in that case. A recent use of a Qt xm

[PATCH] D37136: [clang-format] Do not format likely xml

This revision was automatically updated to reflect the committed changes. Closed by commit rL311999: [clang-format] Do not format likely xml (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D37136?vs=113085&id=113087#toc Repository: rL LLVM https://reviews.llvm.org/

r312000 - [clang-format] Refactor likely xml a bit, NFC

Author: krasimir Date: Tue Aug 29 06:57:31 2017 New Revision: 312000 URL: http://llvm.org/viewvc/llvm-project?rev=312000&view=rev Log: [clang-format] Refactor likely xml a bit, NFC Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL: http://llvm.org/viewv

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 113088. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Updates according to review comments. https://reviews.llvm.org/D34512 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt include/clang/Basic

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D37249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D37263: [clang-format] Ignore case when sorting using-declarations

krasimir created this revision. This ignores case while sorting using-declarations, fixing the wierd case in the last test case added. https://reviews.llvm.org/D37263 Files: lib/Format/UsingDeclarationsSorter.cpp unittests/Format/UsingDeclarationsSorterTest.cpp Index: unittests/Format/Usi

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rogfer01 added a comment. There are a few tests checking the precise interaction between `__fp16` and `_Float16` values but I don't see tests interacting `_Float16` and the other standard floating types `float`, `double` and `long double`. Do you reckon it is worth adding them as well? =

[PATCH] D37263: [clang-format] Ignore case when sorting using-declarations

krasimir updated this revision to Diff 113092. krasimir added a comment. - Actually add a test https://reviews.llvm.org/D37263 Files: lib/Format/UsingDeclarationsSorter.cpp unittests/Format/UsingDeclarationsSorterTest.cpp Index: unittests/Format/UsingDeclarationsSorterTest.cpp ===

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel updated this revision to Diff 113094. koldaniel added a comment. Renaming the unsafe checker, updating tests. https://reviews.llvm.org/D35068 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Driver/Tools.cpp lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp t

[PATCH] D35678: Omit sumbodule semantics for TS modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL312007: [modules-ts] Omit submodule semantics for TS modules (authored by borisk). Changed prior to commit: https://reviews.llvm.org/D35678?vs=110875&id=113098#toc Repository: rL LLVM https://review

r312007 - [modules-ts] Omit submodule semantics for TS modules

Author: borisk Date: Tue Aug 29 08:30:18 2017 New Revision: 312007 URL: http://llvm.org/viewvc/llvm-project?rev=312007&view=rev Log: [modules-ts] Omit submodule semantics for TS modules If a TS module name has more than one component (e.g., foo.bar) then we erroneously activated the submodule sem

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1104 +// expression classes separately. +if (!isa(Ex)) + for (auto Child : Ex->children()) { dcoughlin wrote: > What is special about ObjCBoxedExpr here? Naivel

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

NoQ updated this revision to Diff 113101. NoQ added a comment. Fix a bit of ObjCBoxedExpr behavior. https://reviews.llvm.org/D35216 Files: lib/StaticAnalyzer/Core/ExprEngine.cpp test/Analysis/initializer.cpp test/Analysis/objc-boxing.m Index: test/Analysis/objc-boxing.m =

[PATCH] D33719: Add _Float16 as a C/C++ source language type

SjoerdMeijer updated this revision to Diff 113100. SjoerdMeijer added a comment. No changes were needed to make the conversions work, the existing logic is taking care of that, but I agree it doesn't hurt to add a few test cases. So I've added tests to both files, and cleaned up that comment.

[PATCH] D37001: [clang-diff] Use data collectors for node comparison

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:537 + +#include "../../AST/DeclDataCollectors.inc" + I didn't realize that you're including files from within `lib`. That's not ideal. You should add a pre-commit that moves the *.inc fi

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Thanks @SjoerdMeijer This LGTM now. Wait a couple of days in case @rsmith has more comments. https://reviews.llvm.org/D33719 ___ cfe-commits

[PATCH] D36750: [analyzer] RetainCount: When diagnosing overrelease, mention if it's coming from a nested block.

NoQ updated this revision to Diff 113102. NoQ marked an inline comment as done. NoQ added a comment. Avoid creating a new `RefVal` kind. In https://reviews.llvm.org/D36750#843427, @dcoughlin wrote: > > By the way, plist-based tests in retain-release.m are disabled since > > r163536 (~2012), and

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

aprantl added a comment. This may have gotten lost earlier: Would it be possible to instruct CloneFunction to not clone any temporary MDNodes via one of the flags that are passed to the ValueMapper? https://reviews.llvm.org/D37038 ___ cfe-commits

Re: r311823 - Add flag to request Clang is ABI-compatible with older versions of itself

Merged in r312013. On Fri, Aug 25, 2017 at 6:06 PM, Richard Smith wrote: > Hi Hans, > > We should get this into Clang 5 so that people can opt out of the ABI bugfix > for passing C++ class types by value. > > On 25 August 2017 at 18:04, Richard Smith via cfe-commits > wrote: >> >> Author: rsmith

r312017 - [ms] Fix vbtable index for covariant overrides of vbase methods

Author: rnk Date: Tue Aug 29 10:40:04 2017 New Revision: 312017 URL: http://llvm.org/viewvc/llvm-project?rev=312017&view=rev Log: [ms] Fix vbtable index for covariant overrides of vbase methods Overriding a method from a virtual base with a covariant return type consumes a slot from the vftable i

r312018 - [Bash-autocomplete] Refactor autocomplete code into own function

Author: yamaguchi Date: Tue Aug 29 10:46:46 2017 New Revision: 312018 URL: http://llvm.org/viewvc/llvm-project?rev=312018&view=rev Log: [Bash-autocomplete] Refactor autocomplete code into own function Summary: We wrote many codes in HandleImediateArgs, so I've refactored it into handleAutocomplet

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

This revision was automatically updated to reflect the committed changes. Closed by commit rL312018: [Bash-autocomplete] Refactor autocomplete code into own function (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D37249?vs=113027&id=113118#toc Repository: rL LLVM

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson added a comment. In https://reviews.llvm.org/D37038#89, @aprantl wrote: > This may have gotten lost earlier: Would it be possible to instruct > CloneFunction to not clone any temporary MDNodes via one of the flags that > are passed to the ValueMapper? I did look at that, sorry

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

hans added inline comments. Comment at: compiler-rt/trunk/lib/asan/scripts/asan_device_setup:98 if [[ $_ABI == x86* ]]; then -_ARCH=i686 +_ARCH=i386 elif [[ $_ABI == armeabi* ]]; then There are lots of copies of this script in various pr

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

morehouse updated this revision to Diff 113129. morehouse added a comment. - Disable stack depth tracking on Mac. https://reviews.llvm.org/D37156 Files: clang/lib/Driver/SanitizerArgs.cpp compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc compiler-rt/lib/sanitizer_common/s

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Another fact: gcc 7.2.0 supports this attribute at x86_64. It would be great if two major compilers were feature compatible and worked in a similar way. https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cf

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

kcc added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:297 CoverageTraceCmp | CoveragePCTable; +#if !defined(__APPLE__) +// Due to TLS differences, stack depth tracking is disabled on Mac. please use if(Some

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

eugenis added a comment. I may have underestimated the number of places that will need to be patched because of this change. Perhaps we should restore the special case in the android library name? Repository: rL LLVM https://reviews.llvm.org/D26764 ___

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

mgorny added a comment. I'm happy to help with whatever needs to be done to keep breakage to the minimum, provided that we determine some clear path forward that doesn't involve regressing to the half-broken state for non-Android Linux systems and it's doable in the free time I can spare. Howev

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman added a comment. In https://reviews.llvm.org/D36272#851709, @erichkeane wrote: > Aaron would likely know better than me... but could it be the spelling type > should be GCC instead of GNU? Yes, this should be spelled with `GCC` rather than `GNU`, as it's a documented GCC attribu

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

morehouse updated this revision to Diff 113133. morehouse added a comment. - Eliminate "#if". - Replace uintptr_t with uptr. https://reviews.llvm.org/D37156 Files: clang/lib/Driver/SanitizerArgs.cpp compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc compiler-rt/lib/sanitiz

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor updated this revision to Diff 113134. andrew.w.kaylor added a comment. Added warnings for null pointer arithmetic. https://reviews.llvm.org/D37042 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGExprScalar.cpp lib/S

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

efriedma added a reviewer: rsmith. efriedma added a comment. I didn't think of this earlier, but strictly speaking, I think "(char*)nullptr+0" isn't undefined in C++? But probably worth emitting the warning anyway; anyone writing out arithmetic on null is probably doing something suspicious, e

r312024 - [OPENMP] Capture global variables in all target executable regions.

Author: abataev Date: Tue Aug 29 12:30:57 2017 New Revision: 312024 URL: http://llvm.org/viewvc/llvm-project?rev=312024&view=rev Log: [OPENMP] Capture global variables in all target executable regions. Capturing of the global variables occurs only in target regions. Patch fixes it and allows capt

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

kcc accepted this revision. kcc added a comment. LGTM https://reviews.llvm.org/D37156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r312026 - [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

Author: morehouse Date: Tue Aug 29 12:48:12 2017 New Revision: 312026 URL: http://llvm.org/viewvc/llvm-project?rev=312026&view=rev Log: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer Summary: - Don't sanitize __sancov_lowest_stack. - Don't instrument leaf functions. - Add Co

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL312026: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer (authored by morehouse). Changed prior to commit: https://reviews.llvm.org/D37156?vs=113133&id=113136#toc Repository: rL L

r312029 - Minimal runtime for UBSan.

Author: eugenis Date: Tue Aug 29 13:03:51 2017 New Revision: 312029 URL: http://llvm.org/viewvc/llvm-project?rev=312029&view=rev Log: Minimal runtime for UBSan. Summary: An implementation of ubsan runtime library suitable for use in production. Minimal attack surface. * No stack traces. * Defini

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

eugenis added a comment. IMHO it was a very bad idea to include the "architecture name" (not even a target triple!) in the library path in the first place. No one else does that. GCC made the right choice and called theirs "libasan.so". My plan is to tweak the code that sets the library name to

r312032 - Disable stack depth tracking on Windows.

Author: morehouse Date: Tue Aug 29 13:44:41 2017 New Revision: 312032 URL: http://llvm.org/viewvc/llvm-project?rev=312032&view=rev Log: Disable stack depth tracking on Windows. Windows doesn't support the tls_model attribute. Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp Modified: cfe/tr

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

rsmith added a comment. In https://reviews.llvm.org/D37042#855713, @efriedma wrote: > I didn't think of this earlier, but strictly speaking, I think > "(char*)nullptr+0" isn't undefined in C++? Yes, that's correct. (C++'s model is basically equivalent to having an object of size zero at the n

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

hans added a comment. In https://reviews.llvm.org/D26764#855791, @eugenis wrote: > IMHO it was a very bad idea to include the "architecture name" (not even a > target triple!) in the library path in the first place. No one else does > that. GCC made the right choice and called theirs "libasan.s

r312037 - Re-enable stack depth instrumentation on Windows.

Author: morehouse Date: Tue Aug 29 14:15:33 2017 New Revision: 312037 URL: http://llvm.org/viewvc/llvm-project?rev=312037&view=rev Log: Re-enable stack depth instrumentation on Windows. Specified tls_model attribute properly. Should compile on Windows now. Modified: cfe/trunk/lib/Driver/Sani

[PATCH] D37278: Restore clang_rt library name on i686-android.

eugenis created this revision. Herald added a subscriber: srhines. Recent changes canonicalized clang_rt library names to refer to "i386" on all x86 targets. Android historically uses i686. This change adds a special case to keep i686 in all clang_rt libraries when targeting Android. https://re

[PATCH] D37278: Restore clang_rt library name on i686-android.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! Looks good to me. Comment at: clang/lib/Driver/ToolChain.cpp:308 + if (TC.getArch() == llvm::Triple::x86 && Triple.isAndroid()) +return "i686"; Ma

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov updated this revision to Diff 113166. anatol.pomozov edited the summary of this revision. https://reviews.llvm.org/D36272 Files: include/clang/Basic/Attr.td lib/CodeGen/TargetInfo.cpp test/CodeGen/function-attributes.c Index: test/CodeGen/function-attributes.c =

r312047 - Revert "[SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer"

Author: morehouse Date: Tue Aug 29 14:56:56 2017 New Revision: 312047 URL: http://llvm.org/viewvc/llvm-project?rev=312047&view=rev Log: Revert "[SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer" This reverts r312026 due to bot breakage. Modified: cfe/trunk/lib/Driver/Sanit

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Did you figure out why this doesn't work on windows? Not having the windows-specific x64 test seems like a mistake, unless we're going to make this a linux-only attribute. In which case, you'll have to remove this attribute in the 32-bit windows case. https://rev

[PATCH] D37278: Restore clang_rt library name on i686-android.

eugenis updated this revision to Diff 113167. eugenis added a comment. +comment https://reviews.llvm.org/D37278 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/sanitizer-ld.c compiler-rt/cmake/Modules/AddCompilerRT.cmake Index: compiler-rt/cmake/Modules/AddCompilerRT.cmake =

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. The function-attributes.c test does not pass at Windows even without my patch. Unfortunately I am not familiar with clang enough to debug this issue. https://reviews.llvm.org/D36272 ___

r312048 - Restore clang_rt library name on i686-android.

Author: eugenis Date: Tue Aug 29 15:12:31 2017 New Revision: 312048 URL: http://llvm.org/viewvc/llvm-project?rev=312048&view=rev Log: Restore clang_rt library name on i686-android. Summary: Recent changes canonicalized clang_rt library names to refer to "i386" on all x86 targets. Android historic

[PATCH] D37278: Restore clang_rt library name on i686-android.

This revision was automatically updated to reflect the committed changes. Closed by commit rL312048: Restore clang_rt library name on i686-android. (authored by eugenis). Changed prior to commit: https://reviews.llvm.org/D37278?vs=113167&id=113170#toc Repository: rL LLVM https://reviews.llv

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

eugenis added a comment. I've landed the android special case in r312048 Repository: rL LLVM https://reviews.llvm.org/D26764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >