djasper added a comment.
Are you changing the line endings here? Phabricator tells me that basically all
the lines change. If so, please don't ;).
================
Comment at: lib/Format/TokenAnnotator.cpp:345
+
+ FormatToken *PreviousNoneOfConstVolatileReference = Parent;
+ while (PreviousNoneOfConstVolatileReference &&
----------------
I'd prefer to move this into a separate function or a lambda, i.e.:
bool isCppStructuredBinding(const FormatToken *Tok) {
if (!Style.isCpp() || !Tok->is(tok::l_square))
return false;
while (Tok && Tok->isOneOf(tok::kw_const, tok::kw_volatile, tok::amp,
tok::ampamp))
Tok = Tok->getPreviousNonComment()) {
return Tok && Tok->is(tok::kw_auto);
}
https://reviews.llvm.org/D37132
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
