Re: [PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

It'd be good if this could go in today. ubsanvptr has been broken for us for a while now. On Mon, Jul 31, 2017 at 4:43 PM, Vedant Kumar via Phabricator via cfe-commits wrote: > vsk created this revision. > > In r309007, I made -fsanitize=null a hard prerequisite for > -fsanitize=vptr. I did not

r309731 - Revert "Thread Safety Analysis: fix assert_capability."

Author: jmgao Date: Tue Aug 1 12:53:31 2017 New Revision: 309731 URL: http://llvm.org/viewvc/llvm-project?rev=309731&view=rev Log: Revert "Thread Safety Analysis: fix assert_capability." This reverts commit rL309725. Broke test/Sema/attr-capabilities.c. Modified: cfe/trunk/include/clang/Ba

[PATCH] D36171: AMDGPU: Use direct struct returns

arsenm created this revision. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl. This is an improvement over always using byval for structs. This will use registers until ~16 are used, and then switch back to byval. This needs more work, since I'm not sure it ever

r309738 - [clang-diff] Renames, NFC

Author: krobelus Date: Tue Aug 1 13:17:46 2017 New Revision: 309738 URL: http://llvm.org/viewvc/llvm-project?rev=309738&view=rev Log: [clang-diff] Renames, NFC Modified: cfe/trunk/include/clang/Tooling/ASTDiff/ASTDiff.h cfe/trunk/lib/Tooling/ASTDiff/ASTDiff.cpp Modified: cfe/trunk/inclu

r309737 - [clang-diff] Move data declarations to the public header

Author: krobelus Date: Tue Aug 1 13:17:40 2017 New Revision: 309737 URL: http://llvm.org/viewvc/llvm-project?rev=309737&view=rev Log: [clang-diff] Move data declarations to the public header Modified: cfe/trunk/include/clang/Tooling/ASTDiff/ASTDiff.h cfe/trunk/include/clang/Tooling/ASTDi

r309741 - Fix creating bitcasts with wrong address space

Author: arsenm Date: Tue Aug 1 13:36:57 2017 New Revision: 309741 URL: http://llvm.org/viewvc/llvm-project?rev=309741&view=rev Log: Fix creating bitcasts with wrong address space In a future commit AMDGPU will start passing aggregates directly to more functions, triggering asserts in test/CodeGe

Re: [PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

Alex is in a different time zone, so he may not get to this today. Do you have the time to give a review? > On Aug 1, 2017, at 12:38 PM, Nico Weber wrote: > > It'd be good if this could go in today. ubsanvptr has been broken for us for > a while now. > > On Mon, Jul 31, 2017 at 4:43 PM, Vedan

[PATCH] D36118: Fix creating bitcasts with wrong address space

arsenm closed this revision. arsenm added a comment. r309741 https://reviews.llvm.org/D36118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35921: [clang-diff] HTML side-by-side diff

johannes abandoned this revision. johannes added a comment. moved to https://reviews.llvm.org/D36182, sorry for the noise https://reviews.llvm.org/D35921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

yawanng updated this revision to Diff 109222. yawanng added a comment. Move tests to unitest and fix a bug. https://reviews.llvm.org/D35743 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cpp Index: un

[PATCH] D34748: [clang-diff] improve mapping accuracy

johannes abandoned this revision. johannes added a comment. split up in several commits starting from https://reviews.llvm.org/D36176 Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:170 + // Ignore everything from other files. + if (!SrcMgr.isInMainFile(SLoc)) +return true; -

[PATCH] D36191: [CodeGen] Don't make availability attributes imply default visibility on macos

erik.pilkington created this revision. Previously, the presence of `__attribute__((availability(macos, ...)))` on a declaration caused clang to make the vis of that decl implicitly default. This is a hack that is incomparable with how we're treating availability attributes now, and should be re

[PATCH] D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs.

zaks.anna added a comment. >> I tried to keep this as a minimal starting example because this currently >> blocks @yamaguchi 's GSoC project for bash completion. There we want to >> complete the values for -analyzer-config and we currently don't have a good >> way to get a complete list of av

r309750 - [clang] Change the condition of unnecessary packed warning

Author: yawanng Date: Tue Aug 1 14:41:39 2017 New Revision: 309750 URL: http://llvm.org/viewvc/llvm-project?rev=309750&view=rev Log: [clang] Change the condition of unnecessary packed warning Summary: Change the condition of this unnecessary packed warning. The packed is unnecessary when 1. the

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() phosek wrote: > I

r309752 - [Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7

Author: bruno Date: Tue Aug 1 15:10:36 2017 New Revision: 309752 URL: http://llvm.org/viewvc/llvm-project?rev=309752&view=rev Log: [Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7 This fixes PR31504 and it's a follow up from adding #include_next for Darwin in r289018. rdar:

[PATCH] D36194: [CMake] Include llvm-objcopy tool in Fuchsia toolchain

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D36194 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsi

[PATCH] D36194: [CMake] Include llvm-objcopy tool in Fuchsia toolchain

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D36194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker

haowei updated this revision to Diff 109237. haowei added a comment. Add 1 line fix for the constraint on allocated handle in function allocateSingleHandle at line 647 https://reviews.llvm.org/D36022 Files: lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp test/Analysis/mxhandle.c Inde

Re: r309722 - [Sema] Fix lax conversion between non ext vectors

Sounds good to me. Richard, what do you think? On Tue, Aug 1, 2017 at 12:05 PM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Tue Aug 1 12:05:25 2017 > New Revision: 309722 > > URL: http://llvm.org/viewvc/llvm-project?rev=309722&view=rev > Log: > [Sema] Fix lax conversion be

[PATCH] D34801: [coverage] Make smaller regions for the first case of a switch.

efriedma added a comment. I'm going to look over the overall algorithm one more time to make sure this direction makes sense. The current code for ending regions on break/continue/return/noreturn doesn't really work well, and the way we handle multiple consecutive case statments isn't really r

[PATCH] D36200: [Sema] Improve some -Wunguarded-availability diagnostic messages

erik.pilkington created this revision. This patch improves the decl-level unguarded availability warnings to use the same messages as the function-level ones. This makes the diagnostic have different parameters than deprecated/unavailable, so I moved some things around in DoEmitAvailabilityWarn

Re: r309752 - [Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7

Merged in r309764. You cc'd me on the bug, so I noticed that :-) Just marking a bug a release blocker doesn't generally work though; it needs to be marked as blocking PR33849. (Though I will search for "release blocker" severity bugs now and then.) On Tue, Aug 1, 2017 at 3:15 PM, Bruno Cardoso L

Re: r309722 - [Sema] Fix lax conversion between non ext vectors

I assume there's an implied "merge to 5.0 branch?" question here :) Yes, horrible as lax vector conversions are, we shouldn't accidentally regress support for them. On 1 August 2017 at 16:28, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Sounds good to me. Richard, what do

Re: r309752 - [Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7

On Tue, Aug 1, 2017 at 4:34 PM, Hans Wennborg wrote: > Merged in r309764. > > You cc'd me on the bug, so I noticed that :-) > > Just marking a bug a release blocker doesn't generally work though; it > needs to be marked as blocking PR33849. (Though I will search for > "release blocker" severity bu

Re: r309722 - [Sema] Fix lax conversion between non ext vectors

On Tue, Aug 1, 2017 at 4:41 PM, Richard Smith wrote: > I assume there's an implied "merge to 5.0 branch?" question here :) Yes :-) I lost that part somehow. > > Yes, horrible as lax vector conversions are, we shouldn't accidentally > regress support for them. r309770. Thanks. > > > On 1 August

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() mcgrathr wrote: > ph

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

phosek created this revision. Herald added a subscriber: mgorny. Don't support or build static C++ libraries for Fuchsia. Repository: rL LLVM https://reviews.llvm.org/D36202 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.cpp Index: test

[PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM. The nit below is orthogonal to this change. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:112 ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); -if (O

[PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

phosek added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:112 ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); -if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bdynamic"); - } CmdArgs.push_back("-lm"); } mc

[PATCH] D34801: [coverage] Make smaller regions for the first case of a switch.

vsk added a comment. In https://reviews.llvm.org/D34801#828382, @efriedma wrote: > I'm going to look over the overall algorithm one more time to make sure this > direction makes sense. The current code for ending regions on > break/continue/return/noreturn doesn't really work well, Maybe it's

[PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL309778: [Driver] Disable static C++ library support on Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36202?vs=109255&id=109258#toc Repository: rL LLVM https://revi

r309778 - [Driver] Disable static C++ library support on Fuchsia

Author: phosek Date: Tue Aug 1 18:18:02 2017 New Revision: 309778 URL: http://llvm.org/viewvc/llvm-project?rev=309778&view=rev Log: [Driver] Disable static C++ library support on Fuchsia Don't support or build static C++ libraries for Fuchsia. Differential Revision: https://reviews.llvm.org/D36

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

rjmccall added a comment. Has this proposal run aground? I'm going back over some old patches that I've been CC'ed on and trying to make sure they're not blocking on my review. https://reviews.llvm.org/D32199 ___ cfe-commits mailing list cfe-commi

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

rjmccall added a comment. Did this ever get committed? https://reviews.llvm.org/D24461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309786 - [CMake] Include llvm-objcopy tool in Fuchsia toolchain

Author: phosek Date: Tue Aug 1 19:49:09 2017 New Revision: 309786 URL: http://llvm.org/viewvc/llvm-project?rev=309786&view=rev Log: [CMake] Include llvm-objcopy tool in Fuchsia toolchain Differential Revision: https://reviews.llvm.org/D36194 Modified: cfe/trunk/cmake/caches/Fuchsia-stage2.c

[PATCH] D36194: [CMake] Include llvm-objcopy tool in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL309786: [CMake] Include llvm-objcopy tool in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36194?vs=109233&id=109265#toc Repository: rL LLVM https://revi

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

atanasyan created this revision. atanasyan added a project: clang. Herald added a subscriber: arichardson. This change enables `long_call/short_call/far/near`, `micromips`, and `interrupt` attributes on MIPS64 targets. In case of using the `mips16` attribute with any ABI except `O32` compiler sh

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

yamaguchi created this revision. clang/test/Driver/autocomplete.c is a test for --autocomplete, and this test might break if people add/modify flags or HelpText. So I've add comment for future developers so that they can fix this file according to the change they had made. https://reviews.llvm.o

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

ruiu added a comment. I wonder if this test is actually fragile. How can you break this test by adding a new flag? Comment at: clang/test/Driver/autocomplete.c:3 +// If this test had broke due to adding/modifying flags or changing HelpText, +// please modify this file accordin

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

yamaguchi updated this revision to Diff 109277. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D36209 Files: clang/test/Driver/autocomplete.c Index: clang/test/Driver/autocomplete.c === --- clang/test/Driver/a

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

djasper added a comment. Generally, please upload patches with full context to phabricator. (or use arc) I think this approach is a bit inside out. We are in a codepath where we try to find a lambda introducer and we the look one or two tokens back to see that we aren't as we have seen "auto".

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

ruiu added a comment. So, does this comment actually make sense? Looks like you cannot break this test by adding or modifying flags or by changing HelpText. (Theoretically, it'll break if you remove -fsyntax-only, for example, but that is not realistic.) https://reviews.llvm.org/D36209 ___

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

yamaguchi added a comment. @ruiu This test will break for instance, when someone add new value to mrelocation-model because values has to be shown in row 78- 83 order, or when someone made a new flags which start with `-Wno-invalid-pp-` because in row 96 only -Wno-invalid-pp-token is expected

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. E.g. If you add a flag that lands in between the results it breaks. Add `-Wmajor-new-feature` and the test goes red. Same with the flag results or changing the help test for `-std=`. We

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

yamaguchi updated this revision to Diff 109281. yamaguchi added a comment. Modified comment. https://reviews.llvm.org/D36209 Files: clang/test/Driver/autocomplete.c Index: clang/test/Driver/autocomplete.c === --- clang/test/Dri

[PATCH] D36155: Use VFS operations in FileManager::makeAbsolutePath.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Nice catch! lg https://reviews.llvm.org/D36155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

<    1   2