[PATCH] D36070: [coroutines] Evaluate the operand of void `co_return` expressions.

EricWF added inline comments. Comment at: test/CodeGenCoroutines/coro-ret-void.cpp:30 +coro1 f2() { + co_return(void) A{}; +} rsmith wrote: > This seems like an extremely confusing way to format this statement. Maybe > move the space left a bit? Urg. `git clang

r309545 - [coroutines] Evaluate the operand of void `co_return` expressions.

Author: ericwf Date: Mon Jul 31 00:48:13 2017 New Revision: 309545 URL: http://llvm.org/viewvc/llvm-project?rev=309545&view=rev Log: [coroutines] Evaluate the operand of void `co_return` expressions. Summary: Previously Clang incorrectly ignored the expression of a void `co_return`. This patch a

[PATCH] D36074: [x86][inline-asm]Allow a pack of Control Debug to be properly picked

coby created this revision. Herald added a subscriber: eraman. Allows the incorporation of legit (x86) Debug Regs within inline asm stataements Repository: rL LLVM https://reviews.llvm.org/D36074 Files: lib/Basic/Targets/X86.cpp test/CodeGen/ms-inline-asm.c Index: lib/Basic/Targets/X86

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman created this revision. Herald added a subscriber: mgorny. This patch implements a couple of functions that were described in my RFC from last week that’s available at http://lists.llvm.org/pipermail/cfe-dev/2017-July/054831.html. This patch adds the following pieces: `apply` function,

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan updated this revision to Diff 108878. yvvan marked 2 inline comments as done. yvvan added a comment. Make safe solution without regression https://reviews.llvm.org/D34873 Files: lib/AST/ExprConstant.cpp Index: lib/AST/ExprConstant.cpp ==

[PATCH] D30777: Added `applyAtomicChanges` function.

ioeric updated this revision to Diff 108881. ioeric added a comment. - Merged with origin/master https://reviews.llvm.org/D30777 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp lib/Tooling/Refactoring/CMakeLists.txt unittests/Tooling/Refa

r309548 - Added `applyAtomicChanges` function.

Author: ioeric Date: Mon Jul 31 02:22:34 2017 New Revision: 309548 URL: http://llvm.org/viewvc/llvm-project?rev=309548&view=rev Log: Added `applyAtomicChanges` function. This re-commits r298913. o See thread http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170327/189084.html o Tested wi

[PATCH] D30777: Added `applyAtomicChanges` function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309548: Added `applyAtomicChanges` function. (authored by ioeric). Repository: rL LLVM https://reviews.llvm.org/D30777 Files: cfe/trunk/include/clang/Tooling/Refactoring/AtomicChange.h cfe/trunk/l

[PATCH] D35986: [clangd] Add ':' to completion trigger characters.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309550: [clangd] Add ':' to completion trigger characters. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D35986?vs=108621&id=108887#toc Repository: rL LLVM https://revie

[clang-tools-extra] r309550 - [clangd] Add ':' to completion trigger characters.

Author: ibiryukov Date: Mon Jul 31 02:27:52 2017 New Revision: 309550 URL: http://llvm.org/viewvc/llvm-project?rev=309550&view=rev Log: [clangd] Add ':' to completion trigger characters. Summary: Without it we don't get completion requests from VSCode after nested name qualifiers (e.g. after 'std

[libcxxabi] r309551 - libcxxabi: Suppress LLVM_ENABLE_MODULES

Author: chapuni Date: Mon Jul 31 02:35:08 2017 New Revision: 309551 URL: http://llvm.org/viewvc/llvm-project?rev=309551&view=rev Log: libcxxabi: Suppress LLVM_ENABLE_MODULES Differential Revision: https://reviews.llvm.org/D35542 Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/t

[PATCH] D35542: libcxxabi: Suppress LLVM_ENABLE_MODULES

This revision was automatically updated to reflect the committed changes. Closed by commit rL309551: libcxxabi: Suppress LLVM_ENABLE_MODULES (authored by chapuni). Repository: rL LLVM https://reviews.llvm.org/D35542 Files: libcxxabi/trunk/CMakeLists.txt Index: libcxxabi/trunk/CMakeLists.t

Re: r309386 - Recommit r308327 3rd time: Add a warning for missing

That's an interesting case. I'll tweak the warning to diagnose this scenario better today. On 29 July 2017 at 00:56, Hans Wennborg wrote: > On Fri, Jul 28, 2017 at 7:41 AM, Alex Lorenz via cfe-commits > wrote: > > Author: arphaman > > Date: Fri Jul 28 07:41:21 2017 > > New Revision: 309386 > >

[PATCH] D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs.

xazax.hun added a comment. I like the directions of this patch. In general, I am in favor of explicitly registering the options from user defined checkers. But changing a config option will now break the command line compatibility, so I wonder how do we want to handle this: - Have a list of no

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#806505, @klimek wrote: > Yep, I want Richard's approval for the name. I think he already expressed a > pro-pulling-out stance. Great! Ping for the name approval. https://reviews.llvm.org/D34512 _

[PATCH] D34440: [Clang] Expand response files before loading compilation database

vladimir.plyashkun added a comment. > Many build systems normally generate response files on-fly in some > circumstances (e.g. if command line is longer than some platform-imposed > limit). So IMO response files should be a perfect citizen here. friendly ping Repository: rL LLVM https://re

r309557 - [CMake][Modules] libclang: Ignore _CINDEX_LIB_ and CLANG_TOOL_EXTRA_BUILD for -fmodules.

Author: chapuni Date: Mon Jul 31 04:45:20 2017 New Revision: 309557 URL: http://llvm.org/viewvc/llvm-project?rev=309557&view=rev Log: [CMake][Modules] libclang: Ignore _CINDEX_LIB_ and CLANG_TOOL_EXTRA_BUILD for -fmodules. CLANG_TOOL_EXTRA_BUILD doesn't affect headers. _CINDEX_LIB_ is defined w

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

arphaman created this revision. This script is useful while working on and debugging Clang's diagnostics, as you don't have to figure out where the diagnostic is emitted before setting a breakpoint for the emission of that diagnostic. Repository: rL LLVM https://reviews.llvm.org/D36083 Fil

[PATCH] D18174: Fix libcxx build on musl

bcraig added inline comments. Comment at: include/__mutex_base:51 #ifndef _LIBCPP_CXX03_LANG -constexpr mutex() = default; +#ifdef __GLIBC__ +constexpr smeenai wrote: > EricWF wrote: > > Limiting `constexpr` to GLIBC implementations only is incorrect; yo

r309559 - -Wpragma-pack: add an additional note and fixit when warning

Author: arphaman Date: Mon Jul 31 06:37:50 2017 New Revision: 309559 URL: http://llvm.org/viewvc/llvm-project?rev=309559&view=rev Log: -Wpragma-pack: add an additional note and fixit when warning about unterminated push directives that are followed by a reset ('#pragma pack()') This has been sugg

Re: r309386 - Recommit r308327 3rd time: Add a warning for missing

Add a note with a fixit in r309559. On 31 July 2017 at 10:50, Alex L wrote: > That's an interesting case. I'll tweak the warning to diagnose this > scenario better today. > > On 29 July 2017 at 00:56, Hans Wennborg wrote: > >> On Fri, Jul 28, 2017 at 7:41 AM, Alex Lorenz via cfe-commits >> wro

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

xazax.hun added inline comments. Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:22 +AST_MATCHER(CXXCtorInitializer, ctorInit) { + return cxxCtorInitializer( + isBaseInitializer(), Wouldn't something like: ``` static auto ctorInit = cxxCtor

r309562 - Document '-Wpragma-pack' in the release notes

Author: arphaman Date: Mon Jul 31 07:08:41 2017 New Revision: 309562 URL: http://llvm.org/viewvc/llvm-project?rev=309562&view=rev Log: Document '-Wpragma-pack' in the release notes Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewv

r309564 - Fix release notes indentation from r309562

Author: arphaman Date: Mon Jul 31 07:22:43 2017 New Revision: 309564 URL: http://llvm.org/viewvc/llvm-project?rev=309564&view=rev Log: Fix release notes indentation from r309562 The additions in r309562 triggered a docs buildbot failure. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: c

[PATCH] D35542: libcxxabi: Suppress LLVM_ENABLE_MODULES

jroelofs added a comment. Does the unwinder need this too? Repository: rL LLVM https://reviews.llvm.org/D35542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36044: [OpenCL] -cl-ext option can overwrite OpenCL features imported from a module

bader added inline comments. Comment at: test/SemaOpenCL/extensions-import.cl:14 + +#ifdef FP64 +// expected-no-diagnostics You can use `#ifdef cl_khr_fp64` to check if extension is supported. https://reviews.llvm.org/D36044 _

r309567 - [OpenCL] Add extension Sema check for subgroup builtins

Author: joey Date: Mon Jul 31 08:15:59 2017 New Revision: 309567 URL: http://llvm.org/viewvc/llvm-project?rev=309567&view=rev Log: [OpenCL] Add extension Sema check for subgroup builtins Check the subgroup extension is enabled, before doing other Sema checks. Modified: cfe/trunk/lib/Sema/Sem

r309569 - Fix -Wshadow false positives with function-local classes.

Author: alexfh Date: Mon Jul 31 08:21:26 2017 New Revision: 309569 URL: http://llvm.org/viewvc/llvm-project?rev=309569&view=rev Log: Fix -Wshadow false positives with function-local classes. Summary: Fixes http://llvm.org/PR33947. https://godbolt.org/g/54XRMT void f(int a) { struct A { vo

[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309569: Fix -Wshadow false positives with function-local classes. (authored by alexfh). Repository: rL LLVM https://reviews.llvm.org/D35941 Files: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/Se

[PATCH] D36072: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Good catch, thanks! https://reviews.llvm.org/D36072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

atanasyan added a comment. Is it possible to factor out Nan => IEEE754 renaming into the separate patch? Repository: rL LLVM https://reviews.llvm.org/D35982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r309571 - [OpenCL] Enable subgroup extension in tests

Author: joey Date: Mon Jul 31 08:50:27 2017 New Revision: 309571 URL: http://llvm.org/viewvc/llvm-project?rev=309571&view=rev Log: [OpenCL] Enable subgroup extension in tests This fixes the test, so that it can be run on different hosts that may have different OpenCL extensions enabled. Modified

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

Hi Vedant, after this change our ubsanvptr bot fails like so: clang-6.0: error: implicitly disabling vptr sanitizer because null checking wasn't enabled [-Werror,-Wauto-disable-vptr-sanitizer] The bot uses -fsanitize=vptr. I have no idea what this warning is supposed to tell me. Maybe it could b

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh added a comment. Ping. Thanks! https://reviews.llvm.org/D34796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r308996 - [coroutines] Add serialization/deserialization of coroutines

Richard, Gor asked for this to be merged to 5.0. What do you think? On Tue, Jul 25, 2017 at 11:01 AM, Gor Nishanov via cfe-commits wrote: > Author: gornishanov > Date: Tue Jul 25 11:01:49 2017 > New Revision: 308996 > > URL: http://llvm.org/viewvc/llvm-project?rev=308996&view=rev > Log: > [corout

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

/sub I believe Vedant asked for this to be merged to 5.0, so I'd like to merge the resolution too. On Mon, Jul 31, 2017 at 8:51 AM, Nico Weber via cfe-commits wrote: > Hi Vedant, > > after this change our ubsanvptr bot fails like so: > > clang-6.0: error: implicitly disabling vptr sanitizer beca

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

davidxl added a comment. The patch is missing documentation change. https://reviews.llvm.org/D34796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309575 - [OPENMP] Change the name of outer non-debug function in debug mode, NFC.

Author: abataev Date: Mon Jul 31 09:43:06 2017 New Revision: 309575 URL: http://llvm.org/viewvc/llvm-project?rev=309575&view=rev Log: [OPENMP] Change the name of outer non-debug function in debug mode, NFC. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified: cfe/trunk/lib/CodeGen/CGSt

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

ilya-biryukov created this revision. This is useful for managing lifetime of VFS-based caches. https://reviews.llvm.org/D36095 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h Index: clangd/ClangdServer.h === --- clangd/C

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

Craig, Simon asked for this to be merged to 5.0 together with r309382 and r309383 for PR33830. What do you think? On Sat, Jul 29, 2017 at 8:33 AM, Simon Pilgrim via cfe-commits wrote: > Author: rksimon > Date: Sat Jul 29 08:33:34 2017 > New Revision: 309488 > > URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

t.p.northover added a comment. Ping. https://reviews.llvm.org/D35817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg (it could use a test case though) https://reviews.llvm.org/D36095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: r309503 - PR33902: Invalidate line number cache when adding more text to existing buffer.

r309580. Thanks! On Sat, Jul 29, 2017 at 11:33 PM, Richard Smith wrote: > We should take this fix for Clang 5. > > On 29 July 2017 at 23:31, Richard Smith via cfe-commits > wrote: >> >> Author: rsmith >> Date: Sat Jul 29 23:31:29 2017 >> New Revision: 309503 >> >> URL: http://llvm.org/viewvc/llv

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev added a comment. ping? https://reviews.llvm.org/D35755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309585: [clangd] Allow to get vfs::FileSystem used inside codeComplete. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D36095 Files: clang-tools-extra/trunk/clangd/ClangdServe

[clang-tools-extra] r309585 - [clangd] Allow to get vfs::FileSystem used inside codeComplete.

Author: ibiryukov Date: Mon Jul 31 10:09:29 2017 New Revision: 309585 URL: http://llvm.org/viewvc/llvm-project?rev=309585&view=rev Log: [clangd] Allow to get vfs::FileSystem used inside codeComplete. Summary: This is useful for managing lifetime of VFS-based caches. Reviewers: bkramer, krasimir

[PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added inline comments. Comment at: test/Driver/stdc-predef.c:15 + /* In this test, the file stdc-predef.h is missing from the installation */ +#if _STDC_PREDEF_H + #error "stdc-predef.h should not be included" I would rather see a real check on in

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

The bot should start working again with -fsanitize=vptr,null. The warning can be improved. If we find -fno-sanitize=null in the argument list, we might say: implicitly disabling vptr sanitizer because "-fno-sanitize=null" was specified Otherwise we might say: implicitly disabling vptr sanitizer

Re: r309484 - Fix incorrect assertion condition.

Thank you! vedant > On Jul 29, 2017, at 1:18 AM, Victor Leschuk via cfe-commits > wrote: > > Author: vleschuk > Date: Sat Jul 29 01:18:38 2017 > New Revision: 309484 > > URL: http://llvm.org/viewvc/llvm-project?rev=309484&view=rev > Log: > Fix incorrect assertion condition. > > Modified: >

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

ilya-biryukov added a comment. In https://reviews.llvm.org/D36095#826275, @bkramer wrote: > lg (it could use a test case though) Will add a test case in one of further commits. Repository: rL LLVM https://reviews.llvm.org/D36095 ___ cfe-commit

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

We can merge all three patches to 5.0. ~Craig On Mon, Jul 31, 2017 at 9:59 AM, Hans Wennborg wrote: > Craig, Simon asked for this to be merged to 5.0 together with r309382 > and r309383 for PR33830. What do you think? > > On Sat, Jul 29, 2017 at 8:33 AM, Simon Pilgrim via cfe-commits > wrote:

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

hintonda added a comment. Cool, I'll try to play with this later today. BTW, since the call to DiagnosticsEngine::Report is delayed when using PartialDiagnostic, would it make sense to add them as well? Also, this doesn't seem to solve the initial problem of finding the Diag name in the first

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

Thanks! r309588. On Mon, Jul 31, 2017 at 10:25 AM, Craig Topper wrote: > We can merge all three patches to 5.0. > > ~Craig > > On Mon, Jul 31, 2017 at 9:59 AM, Hans Wennborg wrote: >> >> Craig, Simon asked for this to be merged to 5.0 together with r309382 >> and r309383 for PR33830. What do you

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

arphaman added a comment. It might make sense to add a breakpoint at `PartialDiagnostic(unsigned DiagID, StorageAllocator &Allocator)`, I'll check how that works. I reckon it should be possible to have a script that could find the name of all emitted diagnostics. Let's say we'd like to run clan

r309598 - [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

Author: mstorsjo Date: Mon Jul 31 11:17:38 2017 New Revision: 309598 URL: http://llvm.org/viewvc/llvm-project?rev=309598&view=rev Log: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC) This fixes a dependency inconsistency, where addMinGWDefines in Targets.cpp (used fro

[PATCH] D36072: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL309598: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC) (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36072?vs=108865&id=108954#toc Repository:

[PATCH] D36096: [ubsan] Make the 'vptr check disabled' warning more helpful

vsk created this revision. If -fsanitize=vptr is passed without -fsanitize=null being specified, it will say: warning: implicitly disabling vptr sanitizer because null checking wasn't enabled (try specifying -fsanitize=null or -fsanitize=undefined) Otherwise if the vptr check is enabled and

[PATCH] D35564: Suppress -pedantic warnings about GNU extension StmtExpr in glibc's assert macro

raj.khem added a comment. There is a proposed fix for glibc's assert here https://sourceware.org/ml/libc-alpha/2017-07/msg00227.html despite that, this patch in general seems useful. https://reviews.llvm.org/D35564 ___ cfe-commits mailing list cfe

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

+ Nico, sorry I missed your email in the reply-all. Here's a revised version of the warning: https://reviews.llvm.org/D36096 vedant > On Jul 31, 2017, at 10:18 AM, Vedant Kumar via cfe-commits > wrote: > > The bot should start working again with -fsanitize=v

Re: [libcxxabi] r309349 - [demangler] Fix some overzealous -Wreturn-type errors

On Thu, Jul 27, 2017 at 6:35 PM Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: epilk > Date: Thu Jul 27 18:35:14 2017 > New Revision: 309349 > > URL: http://llvm.org/viewvc/llvm-project?rev=309349&view=rev > Log: > [demangler] Fix some overzealous -Wreturn-type erro

Re: r309496 - Improve readability of CXX method overrides list

Test coverage? On Sun, Jul 30, 2017 at 5:52 AM Lenar Safin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: lll > Date: Sat Jul 29 13:42:58 2017 > New Revision: 309496 > > URL: http://llvm.org/viewvc/llvm-project?rev=309496&view=rev > Log: > Improve readability of CXX method overrid

Re: [PATCH] D35783: Ignore shadowing for declarations coming from within macros.

On Tue, Jul 25, 2017 at 1:19 AM Roman Lebedev via Phabricator via cfe-commits wrote: > lebedev.ri added a comment. > > How does this relate to the gcc behavior? > I suspect not everyone would want to have this relaxed `-Wshadow` mode. > Generally I think the goal hasn't been to allow a clang use

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh updated this revision to Diff 108967. twoh added a comment. Update documentation. Please let me know if I need to update other documents as well. Thanks! https://reviews.llvm.org/D34796 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/

[PATCH] D35449: [X86] Implement __builtin_cpu_is

craig.topper added a comment. @erichkeane are you ok with this code for now? I think validateCPUIs gives you what you need at least for Sema support for target attribute. You'll probably need to refactor the CG code to make your ifunc resolver. But I think you need to do that for the existing f

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

shenhan added a comment. Ping? Can we make a decision on this? I've this simple one D35849: [UBSan] Provide default blacklist filename for UBSan which, depending on this, shall be discarded or move forward. If this CL stalls, I'll seek to proceed with https://r

[PATCH] D35449: [X86] Implement __builtin_cpu_is

erichkeane added a comment. In https://reviews.llvm.org/D35449#826381, @craig.topper wrote: > @erichkeane are you ok with this code for now? I think validateCPUIs gives > you what you need at least for Sema support for target attribute. You'll > probably need to refactor the CG code to make you

Re: [PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

On Thu, Jul 27, 2017 at 8:30 AM Dehao Chen via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > danielcdh marked an inline comment as done. > danielcdh added a comment. > > Thanks for the review! > > In https://reviews.llvm.org/D35746#822498, @chandlerc wrote: > > > LGTM with a t

[PATCH] D36074: [x86][inline-asm]Allow a pack of Control Debug to be properly picked

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D36074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. Windows/ARM64 is a LLP64 environment, so don't set this default define. https://reviews.llvm.org/D36098 Files: lib/Basic/Targets/AArch64.cpp test/Preprocessor/init.c Index: test/Prepro

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D36099 Files: test/Preprocessor/init.c Index: test/Preprocessor/init.c === --- test/Preprocessor/init.c +++ tes

r309607 - [Driver] Allow users to silence the warning that is issued when the

Author: ahatanak Date: Mon Jul 31 12:16:40 2017 New Revision: 309607 URL: http://llvm.org/viewvc/llvm-project?rev=309607&view=rev Log: [Driver] Allow users to silence the warning that is issued when the deployment target is earlier than iOS 11 and the target is 32-bit. This is a follow-up to r306

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D36100 Files: include/clang/Basic/Attr.td test/Sema/dllimport.c Index: test/Sema/dllimport.c === --- test/Sem

[PATCH] D36101: Fix usage of right shift operator in fold expressions

Rakete created this revision. The right shift operator was not seen as a valid operator in a fold expression, which is PR32563. https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp Index: test/CXX/expr/expr.prim/expr.prim.fold/p

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

On Mon, Jul 31, 2017 at 1:18 PM, Vedant Kumar wrote: > The bot should start working again with -fsanitize=vptr,null. > > The warning can be improved. If we find -fno-sanitize=null in the argument > list, we might say: > implicitly disabling vptr sanitizer because "-fno-sanitize=null" was > specif

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. This is similar to what's done on arm and x86_64, where these calling conventions are silently ignored, as in SVN r245076 (https://reviews.llvm.org/D12034). https://reviews.llvm.org/D36105

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D36100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

rnk accepted this revision. rnk added a comment. lgtm https://reviews.llvm.org/D36098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

rnk added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:466-467 + case CC_X86ThisCall: + case CC_X86FastCall: + case CC_X86VectorCall: +return CCCR_Ignore; Do they really ignore __fastcall and __vectorcall on arm64? I assume __thiscall and __

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D36099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:466-467 + case CC_X86ThisCall: + case CC_X86FastCall: + case CC_X86VectorCall: +return CCCR_Ignore; rnk wrote: > Do they really ignore __fastcall and __vectorcall on arm64? > > I as

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

> On Jul 31, 2017, at 12:30 PM, Nico Weber wrote: > > On Mon, Jul 31, 2017 at 1:18 PM, Vedant Kumar > wrote: > The bot should start working again with -fsanitize=vptr,null. > > The warning can be improved. If we find -fno-sanitize=null in the argument > list, we might s

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth updated this revision to Diff 108979. Nebiroth marked 19 inline comments as done. Nebiroth added a comment. Implemention of Code Hover as described in LSP definition. Removed unintentional changes to formatting. Removed file id field in Location struct. https://reviews.llvm.org/D35894

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

vsk added a comment. In https://reviews.llvm.org/D32842#826383, @shenhan wrote: > Ping? Can we make a decision on this? > I've this simple one D35849: [UBSan] Provide default blacklist filename for > UBSan which, depending on this, shall be > discarded or mov

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. This lgtm, we shouldn't defer this until https://reviews.llvm.org/D32842 is done, as that may take a while. https://reviews.llvm.org/D35849 ___ cfe-co

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

saugustine created this revision. Herald added subscribers: aheejin, mgorny, dberris, nemanjai. Add powerpc64 to compiler-rt build infrastructure. https://reviews.llvm.org/D36108 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/builtin-config-ix.cmake compiler-rt/l

r309616 - [X86] Remove -O3 from tbm-builtins.c test file.

Author: ctopper Date: Mon Jul 31 13:21:53 2017 New Revision: 309616 URL: http://llvm.org/viewvc/llvm-project?rev=309616&view=rev Log: [X86] Remove -O3 from tbm-builtins.c test file. A change to InstCombine broke this test, but we generally frown on running optimizations clang tests anyway. So I'

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. https://reviews.llvm.org/D36111 Files: include/clang/Basic/BuiltinsAArch64.def test/CodeGen/builtins-arm64.c Index: test/CodeGen/builtins-arm64.c ===

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added a comment. Related llvm patch: https://reviews.llvm.org/D36110 https://reviews.llvm.org/D36111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") Shouldn't these be limited to MSVC mode only? Have a look at `BuiltinsARM.def`, where there's case

r309619 - [AArch64] Don't define __LP64__ when targeting Windows

Author: mstorsjo Date: Mon Jul 31 13:40:53 2017 New Revision: 309619 URL: http://llvm.org/viewvc/llvm-project?rev=309619&view=rev Log: [AArch64] Don't define __LP64__ when targeting Windows Windows/ARM64 is a LLP64 environment, so don't set this default define. Differential Revision: https://rev

r309618 - [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

Author: mstorsjo Date: Mon Jul 31 13:40:48 2017 New Revision: 309618 URL: http://llvm.org/viewvc/llvm-project?rev=309618&view=rev Log: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c Differential Revision: https://reviews.llvm.org/D36099 Modified: cfe/trunk/tes

r309620 - [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

Author: mstorsjo Date: Mon Jul 31 13:40:59 2017 New Revision: 309620 URL: http://llvm.org/viewvc/llvm-project?rev=309620&view=rev Log: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well Differential Revision: https://reviews.llvm.org/D36100 Modified: cfe/trunk/inclu

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL309618: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36099?vs=108969&id=108990#toc Repositor

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL309620: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36100?vs=108971&id=108992#toc Repository:

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL309619: [AArch64] Don't define __LP64__ when targeting Windows (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36098?vs=108968&id=108991#toc Repository: rL LLVM https://re

[PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

vsk created this revision. In r309007, I made -fsanitize=null a hard prerequisite for -fsanitize=vptr. I did not see the need for the two checks to have separate null checking logic for the same pointer. I expected the two checks to either always be enabled together, or to be mutually compatibl

[PATCH] D36096: [ubsan] Make the 'vptr check disabled' warning more helpful

vsk abandoned this revision. vsk added a comment. Abandoned in favor of https://reviews.llvm.org/D36112, since it turns out -fsanitize=null,vptr doesn't work for some use cases. https://reviews.llvm.org/D36096 ___ cfe-commits mailing list cfe-commi

r309622 - Fix logic for generating llvm.type.test()s

Author: pcc Date: Mon Jul 31 13:45:14 2017 New Revision: 309622 URL: http://llvm.org/viewvc/llvm-project?rev=309622&view=rev Log: Fix logic for generating llvm.type.test()s CodeGenFunction::EmitTypeMetadataCodeForVCall() could output an llvm.assume(llvm.type.test())when CFI was enabled, optimizin

[PATCH] D36013: Fix logic for generating llvm.type.test()s

This revision was automatically updated to reflect the committed changes. Closed by commit rL309622: Fix logic for generating llvm.type.test()s (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D36013?vs=108702&id=108994#toc Repository: rL LLVM https://reviews.llvm.org/D3

  1   2   >