r308574 - [NFC] Update local variable names to upper-case as per LLVM Coding Standards.

2017-07-19 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Wed Jul 19 18:10:56 2017 New Revision: 308574 URL: http://llvm.org/viewvc/llvm-project?rev=308574&view=rev Log: [NFC] Update local variable names to upper-case as per LLVM Coding Standards. Modified: cfe/trunk/lib/Lex/TokenLexer.cpp Modified: cfe/trunk/lib/Lex/TokenLexe

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

2017-07-19 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. As an aside, I think it'd be good to land https://reviews.llvm.org/D28954 and https://reviews.llvm.org/D28955 first, since they affect accuracy and precision of various analyzer parts that this depends on. > Here are some examples that should all be UNKNOWN (right?) but ar

[PATCH] D33852: Enable __declspec(selectany) on linux

2017-07-19 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added inline comments. Comment at: include/clang/Basic/Attr.td:2421 -def SelectAny : InheritableAttr, TargetSpecificAttr { +def SelectAny : InheritableAttr, TargetSpecificAttr { let Spellings = [Declspec<"selectany">, GCC<"selectany">]; davide wrote:

[PATCH] D32047: [Driver] Add support for default UBSan blacklists

2017-07-19 Thread Filipe Cabecinhas via Phabricator via cfe-commits
filcab added a comment. Should we simply not have `ubsan_blacklist.txt` if it's empty? Otherwise LGTM https://reviews.llvm.org/D32047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35546: [AArch64] Produce correct defaultlib directives for windows in MSVC style

2017-07-19 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308584: [AArch64] Produce correct defaultlib directives for windows in MSVC style (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D35546?vs=107058&id=107443#toc Repository:

r308584 - [AArch64] Produce correct defaultlib directives for windows in MSVC style

2017-07-19 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Wed Jul 19 22:47:06 2017 New Revision: 308584 URL: http://llvm.org/viewvc/llvm-project?rev=308584&view=rev Log: [AArch64] Produce correct defaultlib directives for windows in MSVC style Differential Revision: https://reviews.llvm.org/D35546 Modified: cfe/trunk/lib/Code

[PATCH] D35603: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=...

2017-07-19 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

r308587 - clang/module.modulemap: Split out Clang_RewriteFrontend from Clang_Rewrite.

2017-07-19 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Jul 19 23:08:53 2017 New Revision: 308587 URL: http://llvm.org/viewvc/llvm-project?rev=308587&view=rev Log: clang/module.modulemap: Split out Clang_RewriteFrontend from Clang_Rewrite. FIXME: Both Rewrite(Core) and RewriteFrontend don't cover just under clang/Rewrite. Th

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

2017-07-19 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan updated this revision to Diff 107446. atanasyan added a comment. My bad. I did not read your comment thoroughly. - Restore `IsForDefinition` checkings in `WinX86_32TargetCodeGenInfo::setTargetAttributes` and `WindowsARMTargetCodeGenInfo::setTargetAttributes` methods. Repository: r

<    1   2