arphaman added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:156
+int TreeRoot::getSubtreePostorder(std::vector &Ids, NodeId Root) const
{
+ int Leaves = 0;
+ std::function Traverse = [&](NodeId Id) {
Please use a more descriptive name e.g. `Num
klimek added a comment.
Reviewing this mainly from the API view, and leaving the technical details to
others :)
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:124
+
+class ASTDiff {
+ TreeRoot &T1, &T2;
Generally, can we put the public interface first in
xazax.hun added a comment.
In https://reviews.llvm.org/D34275#785294, @wangxindsb wrote:
> > What about:
> >
> > struct A {
> > A() {
> > X x;
> > x.virtualMethod(); // this virtual call is ok
> > foo(); // should warn here
> > }
> > virtual foo();
> > }
> > i
djasper added inline comments.
Comment at: include/clang/Format/Format.h:234
+ bool allowEmptyFunctionsOnASingleLine() const {
+ return AllowShortFunctionsOnASingleLine >= ShortFunctionStyle::SFS_Empty;
I'd prefer these functions not to be in the public h
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D34287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D33823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305890: Moved code hanlding precompiled preamble out of the
ASTUnit. (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D34287?vs=103216&id=103338#toc
Repository:
rL LLVM
htt
Author: ibiryukov
Date: Wed Jun 21 05:24:58 2017
New Revision: 305890
URL: http://llvm.org/viewvc/llvm-project?rev=305890&view=rev
Log:
Moved code hanlding precompiled preamble out of the ASTUnit.
Reviewers: bkramer, krasimir, arphaman, akyrtzi, klimek
Reviewed By: klimek
Subscribers: mgorny, k
Author: arphaman
Date: Wed Jun 21 05:27:24 2017
New Revision: 305891
URL: http://llvm.org/viewvc/llvm-project?rev=305891&view=rev
Log:
Revert r305678: [driver][macOS] Pick the system version for the
deployment target if the SDK is newer than the system
This commit also reverts follow-up commits r
puneetha updated this revision to Diff 103337.
puneetha added a comment.
Updated files to address the review comments.
https://reviews.llvm.org/D34198
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/type-traits.cpp
Index: test/SemaCXX/type-traits.cpp
=
teemperor created this revision.
GCC has named this `-Wnoexcept-type`, so let's add an alias to stay compatible
with the GCC flags.
https://reviews.llvm.org/D34439
Files:
include/clang/Basic/DiagnosticGroups.td
test/SemaCXX/cxx1z-noexcept-function-type.cpp
Index: test/SemaCXX/cxx1z-noexc
puneetha marked 2 inline comments as done.
puneetha added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4128
+return true;
+}
+
rjmccall wrote:
> I don't understand the difference you're creating between traits here. Three
> specific traits
vladimir.plyashkun created this revision.
vladimir.plyashkun added a project: clang.
Herald added a subscriber: mgorny.
Due to command line length restrictions, arguments can be passed through
response files.
Before trying to load compilation database from command line, response files
should be
Author: dergachev
Date: Wed Jun 21 06:12:07 2017
New Revision: 305896
URL: http://llvm.org/viewvc/llvm-project?rev=305896&view=rev
Log:
[analyzer] LocalizationChecker: Support new localizable APIs.
Add support for new methods that were added in macOS High Sierra & iOS 11
and require a localized s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305896: [analyzer] LocalizationChecker: Support new
localizable APIs. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D34266?vs=102771&id=103347#toc
Repository:
rL LLVM
ht
NoQ added a comment.
In https://reviews.llvm.org/D34102#783161, @zaks.anna wrote:
> > eg. checkers for portability across linux/bsd should be off on windows by
> > default, checkers for non-portable C++ APIs should be off in plain C code,
> > etc
>
> Is the checker you are moving to portability
vladimir.plyashkun updated this revision to Diff 103341.
vladimir.plyashkun added a comment.
Herald added subscribers: xazax.hun, mgorny.
updated CMakeLists.txt
Repository:
rL LLVM
https://reviews.llvm.org/D34404
Files:
unittests/Tooling/CMakeLists.txt
Index: unittests/Tooling/CMakeLists
Author: hokein
Date: Wed Jun 21 06:26:58 2017
New Revision: 305898
URL: http://llvm.org/viewvc/llvm-project?rev=305898&view=rev
Log:
Fix unused-variable compilation error.
Modified:
cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp
Modified: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp
URL:
Author: dergachev
Date: Wed Jun 21 06:29:35 2017
New Revision: 305900
URL: http://llvm.org/viewvc/llvm-project?rev=305900&view=rev
Log:
[analyzer] Bump a few default performance thresholds.
This makes the analyzer around 10% slower by default,
allowing it to find deeper bugs.
Default values for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305900: [analyzer] Bump a few default performance
thresholds. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D34277?vs=102816&id=103349#toc
Repository:
rL LLVM
https://re
wangxindsb added a comment.
> Oh, I think I see how it works now. How about:
>
>
> struct A;
> struct X {
> void callFooOfA(A*);
> };
> struct A {
> A() {
> X x;
> x.virtualMethod(); // this virtual call is ok
> x.callFooOfA(this)
> }
> virtual foo();
krasimir updated this revision to Diff 103352.
krasimir added a comment.
- Remove newline
https://reviews.llvm.org/D34441
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
l
krasimir added a comment.
Tests for `<>`-style message fields are missing because I discovered that they
don't really work in a multiline setting in proto options anyways. I'll address
this problem separately.
https://reviews.llvm.org/D34441
___
c
vladimir.plyashkun updated this revision to Diff 103353.
vladimir.plyashkun added a comment.
correct revision with all changes
Repository:
rL LLVM
https://reviews.llvm.org/D34404
Files:
include/clang/Tooling/DiagnosticsYaml.h
unittests/Tooling/CMakeLists.txt
unittests/Tooling/Diagnosti
Typz marked 3 inline comments as done.
Typz added inline comments.
Comment at: include/clang/Format/Format.h:234
+ bool allowEmptyFunctionsOnASingleLine() const {
+ return AllowShortFunctionsOnASingleLine >= ShortFunctionStyle::SFS_Empty;
djasper wrote:
>
Typz updated this revision to Diff 103357.
Typz marked an inline comment as done.
Typz added a comment.
Fix according to review comments
https://reviews.llvm.org/D34399
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineForma
Author: krasimir
Date: Wed Jun 21 07:03:12 2017
New Revision: 305901
URL: http://llvm.org/viewvc/llvm-project?rev=305901&view=rev
Log:
[clang-format] Support sorting using declarations
Summary:
This patch adds UsingDeclarationsSorter, a TokenAnalyzer that sorts consecutive
using declarations.
Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305901: [clang-format] Support sorting using declarations
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D33823?vs=103032&id=103359#toc
Repository:
rL LLVM
https://reviews
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D34399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
v.g.vassilev created this revision.
When `isIncrementalProcessingEnabled` is on we might call multiple times
`HandleEndOfTranslationUnit`. This would complete the `llvm::Module` CodeGen is
writing to.
This patch allows the clients to start a new `llvm::Module`, allowing CodeGen
to continue wri
v.g.vassilev updated this revision to Diff 103360.
v.g.vassilev added a comment.
Fix compilation issue.
https://reviews.llvm.org/D3
Files:
include/clang/CodeGen/ModuleBuilder.h
lib/CodeGen/ModuleBuilder.cpp
Index: lib/CodeGen/ModuleBuilder.cpp
=
Author: ibiryukov
Date: Wed Jun 21 07:34:27 2017
New Revision: 305902
URL: http://llvm.org/viewvc/llvm-project?rev=305902&view=rev
Log:
Fixed compiler warnings after r305890.
Should fix buildbots that pass -Werror.
Modified:
cfe/trunk/lib/Frontend/ASTUnit.cpp
Modified: cfe/trunk/lib/Fronten
Author: sepavloff
Date: Wed Jun 21 07:46:57 2017
New Revision: 305903
URL: http://llvm.org/viewvc/llvm-project?rev=305903&view=rev
Log:
Function with unparsed body is a definition
While a function body is being parsed, the function declaration is not
considered
as a definition because it does no
sepavloff added a comment.
Initial commit (r305379) was reverted (r305381) because it broke self builds.
The reason was not related to the WillHaveBody flag but was due to the change:
if (isFriend) {
Function->setObjectOfFriendDecl();
if (FunctionTemplate)
FunctionTemplate->setOb
Author: arphaman
Date: Wed Jun 21 08:51:04 2017
New Revision: 305911
URL: http://llvm.org/viewvc/llvm-project?rev=305911&view=rev
Log:
[index] Nested class declarations should be annotated with the
"specializationOf" relation if they pseudo-override a type in the base template
This commit fixes a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305911: [index] Nested class declarations should be
annotated with the (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D34392?vs=103179&id=103369#toc
Repository:
rL LLVM
ht
Author: typz
Date: Wed Jun 21 08:56:02 2017
New Revision: 305912
URL: http://llvm.org/viewvc/llvm-project?rev=305912&view=rev
Log:
clang-format: introduce InlineOnly short function style
Summary:
This is the same as Inline, except it does not imply all empty
functions are merged: with this style,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305912: clang-format: introduce InlineOnly short function
style (authored by Typz).
Changed prior to commit:
https://reviews.llvm.org/D34399?vs=103357&id=103370#toc
Repository:
rL LLVM
https://revie
xazax.hun created this revision.
xazax.hun added a project: clang-tools-extra.
Herald added a subscriber: whisperity.
Constexpr variable definitions should be ok in headers.
https://stackoverflow.com/questions/34445336/constexpr-global-constants-in-a-header-file-and-odr
Repository:
rL LLVM
h
iid_iunknown added a comment.
No hang with this patch on the test case from PR33484. Clang reports a number
of expected compilation errors instead.
Repository:
rL LLVM
https://reviews.llvm.org/D34430
___
cfe-commits mailing list
cfe-commits@list
aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180
+class CE {
+ constexpr static int i = 5; // OK: constexpr definition.
+};
This is not as safe as you might think. As-is, this is fine, however, if the
class is
szdominik updated this revision to Diff 103378.
szdominik marked 3 inline comments as done.
szdominik added a comment.
Fixed alpha.core.CallAndMessageUnInitRefArg.
https://reviews.llvm.org/D33645
Files:
www/analyzer/alpha_checks.html
www/analyzer/available_checks.html
www/analyzer/implici
Anastasia added a comment.
In https://reviews.llvm.org/D34342#785454, @bader wrote:
> Wow...
> Nice catch.
> For some reason I can't reproduce the problem neither.
> I will drop source code change, but I'd like to modify the test anyway.
I think we probably had this issue at some point... Ca
szdominik updated this revision to Diff 103385.
szdominik marked 4 inline comments as done.
szdominik added a comment.
Updated loop for searching the beginning of the initlist.
https://reviews.llvm.org/D33722
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/CopyConstructorInitCheck.cpp
aschwaighofer created this revision.
The layout must be compatible with the input layout, offsets are defined in
terms of offsets within a packed struct which are computed in terms of the alloc
size of a type.
Using the store size we would insert padding for the following type for example:
struc
arphaman added a comment.
Thanks for the fix! The implementation looks correct. A couple of misc comments:
- Please move the test to `test/Index` (Since it uses `c-index-test`).
- In the future please upload patches with full context (`git diff -U`).
Comment at: lib/Sema/S
hokein added inline comments.
Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:1
-// RUN: %check_clang_tidy %s misc-definitions-in-headers %t
+// RUN: %check_clang_tidy %s misc-definitions-in-headers %t -- -- -std=c++1z
The original code should work
erichkeane created this revision.
In running some internal vectorcall tests in 32 bit mode, we discovered that
the behavior I'd previously implemented for x64 (and applied to x32) regarding
the assignment of SSE registers was incorrect. See spec here:
https://msdn.microsoft.com/en-us/library/d
bader added a comment.
I think I found the way to reproduce the issue. There are two pre-requisites:
sampler must be declared in the constant address space and clang must be build
in Debug mode.
I'll fix the test and add the test cases from test/SemaOpenCL/sampler_t.cl as
mentioned earlier.
h
SjoerdMeijer updated this revision to Diff 103397.
SjoerdMeijer added a comment.
This fixes the “DefaultVariadicArgumentPromotion” for Float16: they should be
promoted to double, which makes now e.g. printf work.
I have added printf tests to both the AST and codegen test to check variadic
functi
Author: marshall
Date: Wed Jun 21 11:02:53 2017
New Revision: 305924
URL: http://llvm.org/viewvc/llvm-project?rev=305924&view=rev
Log:
Change -1LL to -1ULL to silence a gcc warning about left shifting a negative
value. Fixes https://bugs.llvm.org/show_bug.cgi?id=33358
Modified:
libunwind/tru
malaperle-ericsson updated this revision to Diff 103405.
malaperle-ericsson marked 12 inline comments as done.
malaperle-ericsson added a comment.
Address comments
https://reviews.llvm.org/D34269
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/Clan
malaperle-ericsson added inline comments.
Comment at: clangd/ClangdUnit.cpp:303
+ // fo|o -> foo| good!
+ if (InputLocation == SourceLocationBeg && Pos.character > 0) {
+SourceLocation PeekBeforeLocation = Unit->getLocation(FE, Pos.line + 1,
ilya-biryukov
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Oh joy. :)
lgtm, thanks for debugging this. The difference makes sense after the fact when
you think about Win x64's approach to va_arg and /homeparams, and how that
isn't relevant for x86.
https
johannes updated this revision to Diff 103409.
johannes marked 4 inline comments as done.
johannes added a comment.
- move some unnecessary things out of the public header
Is this a proper way to declutter the header file? Using inheritance would also
be possible.
I have to define a destructor
johannes added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:157
+ int Leaves = 0;
+ std::function Traverse = [&](NodeId Id) {
+const Node &N = getNode(Id);
arphaman wrote:
> you should be able to use `auto` instead of `std::function` here I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305928: Correct VectorCall x86 (32 bit) behavior for SSE
Register Assignment (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D34455?vs=103391&id=103412#toc
Repository:
rL
Author: erichkeane
Date: Wed Jun 21 11:37:22 2017
New Revision: 305928
URL: http://llvm.org/viewvc/llvm-project?rev=305928&view=rev
Log:
Correct VectorCall x86 (32 bit) behavior for SSE Register Assignment
In running some internal vectorcall tests in 32 bit mode, we discovered that
the
behavior
arphaman created this revision.
This patch fixes an issue where a forward declaration of a class template
specialization was not related to the base template. We need to relate even
forward declarations because specializations don't have to be defined.
Repository:
rL LLVM
https://reviews.ll
erichkeane added a comment.
Thanks Reid!
Repository:
rL LLVM
https://reviews.llvm.org/D34455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ruiu
Date: Wed Jun 21 11:50:38 2017
New Revision: 305930
URL: http://llvm.org/viewvc/llvm-project?rev=305930&view=rev
Log:
Use -NOT prefix instead of adding `not` to FileCheck.
If we want to make sure that a particular string is not in an output,
the regular way of doing it is to add `-NO
arphaman added a comment.
The API looks better IMHO. Some more comments:
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:57
+/// Within a tree, this identifies a node by its preorder offset.
+using NodeId = int;
+
I think that it's better to make make `Node
ahatanak added a comment.
I didn't know gcc had its own option. This change seems reasonable to me.
Since c++1z-compat-mangling was added just a few days ago, should we just
rename it instead of adding an alias?
https://reviews.llvm.org/D34439
___
bader updated this revision to Diff 103421.
bader added a comment.
This revision is now accepted and ready to land.
Added test case reproducing the issue described in the description.
Removed test cases from test/SemaOpenCL/sampler_t.cl covered by
test/CodeGenOpenCL/sampler.cl.
While I was movin
Does the GCC warning warn on the same cases?
On 21 Jun 2017 10:24 am, "Akira Hatanaka via Phabricator" <
revi...@reviews.llvm.org> wrote:
> ahatanak added a comment.
>
> I didn't know gcc had its own option. This change seems reasonable to me.
>
> Since c++1z-compat-mangling was added just a few
I couldn't find a case where both gcc and clang agreed at the same
time that they should emit this warning, but I think that's just bugs
in the way we detect these cases. From the near-identical warning
message I would say they both should emit warnings for the same cases
(and probably will in the
teemperor added a comment.
@ahatanak I think we can leave the more expressive clang name for this warning
and just add the bit cryptic GCC name for compability. But I don't have a
strong opinion on this.
https://reviews.llvm.org/D34439
___
cfe-com
rjmccall added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4128
+return true;
+}
+
puneetha wrote:
> rjmccall wrote:
> > I don't understand the difference you're creating between traits here.
> > Three specific traits about destructibility
johannes updated this revision to Diff 103432.
https://reviews.llvm.org/D34329
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
lib/Tooling/ASTDiff/CMakeLists.txt
lib/Tooling/CMakeLists.txt
test/Tooling/clang-diff-basic.cpp
tools/CMakeLists.txt
tools/cl
Author: akirtzidis
Date: Wed Jun 21 13:52:44 2017
New Revision: 305940
URL: http://llvm.org/viewvc/llvm-project?rev=305940&view=rev
Log:
[preprocessor] Fix assertion hit when 'SingleFileParseMode' option is enabled
and #if with an undefined identifier and without #else
'HandleEndifDirective' ass
johannes added inline comments.
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:57
+/// Within a tree, this identifies a node by its preorder offset.
+using NodeId = int;
+
arphaman wrote:
> I think that it's better to make make `NodeId` a structure as well a
ilya-biryukov created this revision.
It used to always call into the RealFileSystem before.
https://reviews.llvm.org/D34469
Files:
include/clang/Frontend/Utils.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/CreateInvocationFromCommandLine.cpp
Index: lib/Frontend/CreateInvocationFromCommandLine
ilya-biryukov created this revision.
https://reviews.llvm.org/D34470
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/ClangdUnitStore.h
Index: clangd/ClangdUnitStore.h
=
ilya-biryukov added a comment.
Looks good now, but I think we definitely need to change
`unique_ptr>` to `vector` before submitting it.
I won't be available until next Wednesday, so feel free to submit without my
final approval.
Comment at: clangd/ClangdUnit.cpp:276
+class D
malaperle-ericsson added inline comments.
Comment at: clangd/ClangdUnit.cpp:276
+class DeclarationLocationsFinder : public index::IndexDataConsumer {
+ std::unique_ptr> DeclarationLocations;
+ const SourceLocation &SearchedLocation;
ilya-biryukov wrote:
> Why d
malaperle-ericsson added inline comments.
Comment at: clangd/ClangdUnit.cpp:276
+class DeclarationLocationsFinder : public index::IndexDataConsumer {
+ std::unique_ptr> DeclarationLocations;
+ const SourceLocation &SearchedLocation;
malaperle-ericsson wrote:
>
Author: gbiv
Date: Wed Jun 21 14:59:05 2017
New Revision: 305947
URL: http://llvm.org/viewvc/llvm-project?rev=305947&view=rev
Log:
[test] Make absolute line numbers relative; NFC
Done to remove noise from https://reviews.llvm.org/D32332 (and to make
this test more resilient to changes in general)
sylvestre.ledru added a comment.
@klimek ping?
https://reviews.llvm.org/D30863
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv updated this revision to Diff 103448.
george.burgess.iv marked 6 inline comments as done.
george.burgess.iv added a comment.
Addressed all feedback
https://reviews.llvm.org/D32332
Files:
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Lex/P
george.burgess.iv added a comment.
Thank you both for the comments!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3294-3295
+def err_attribute_overloadable_multiple_unmarked_overloads : Error<
+ "at most one 'overloadable' function for a given name may lack the "
+ "
sberg updated this revision to Diff 103449.
sberg added a comment.
Herald added subscribers: kristof.beyls, mgorny, klimek.
added test
https://reviews.llvm.org/D22128
Files:
lib/AST/Expr.cpp
unittests/Tooling/CMakeLists.txt
unittests/Tooling/CastExprTest.cpp
Index: unittests/Tooling/Cast
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.
This behaves mostly the same as __builtin_ms_va_list on x86_64; a va_list on
windows on aarch64 is a single pointer.
In order to signal the kind of va_list to llvm for handling of va_start,
saugustine added a comment.
> Actually, now that I figured out you mean ArgumentAdjusters, I am making
> progress.
Unfortunately, ArgumentAdjusters only work on vector, and while
ToolInvocation::Invocation takes its arguments in that form,
tooling::newInvocation (which returns a CompilerInvoca
aschwaighofer updated this revision to Diff 103458.
aschwaighofer retitled this revision from "SwiftAggregateLowering: Use type
alloc size to determine the size of types" to "SwiftCC: Perform physical layout
when computing coercion types".
aschwaighofer edited the summary of this revision.
aschw
aschwaighofer updated this revision to Diff 103459.
aschwaighofer added a comment.
Same patch bug with added diff context.
https://reviews.llvm.org/D34454
Files:
lib/CodeGen/SwiftCallingConv.cpp
test/CodeGen/64bit-swiftcall.c
Index: test/CodeGen/64bit-swiftcall.c
=
rsmith accepted this revision.
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4128
+return true;
+}
+
rjmccall wrote:
> puneetha wrote:
> > rjmccall wrote:
> > > I don't understand the difference you're creating between traits here
rsmith added a comment.
It'd be good to also add tests for the other traits you're changing.
https://reviews.llvm.org/D34198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
There's plenty of precedent for supporting a name we like for a flag, and
also supporting an alias for GCC compatibility (especially for warning
flags).
On 21 June 2017 at 10:56, Raphael Isemann via Phabricator <
revi...@reviews.llvm.org> wrote:
> teemperor added a comment.
>
> @ahatanak I think
rjmccall added a comment.
Looks great, thanks!
https://reviews.llvm.org/D34454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This is OK once the dependent revision is approved.
https://reviews.llvm.org/D34425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
Author: ericwf
Date: Wed Jun 21 16:42:50 2017
New Revision: 305955
URL: http://llvm.org/viewvc/llvm-project?rev=305955&view=rev
Log:
Attempt to avoid static init ordering issues with globalMemCounter
Modified:
libcxx/trunk/test/support/count_new.hpp
Modified: libcxx/trunk/test/support/count_
Author: arnolds
Date: Wed Jun 21 16:43:40 2017
New Revision: 305956
URL: http://llvm.org/viewvc/llvm-project?rev=305956&view=rev
Log:
SwiftCC: Perform physical layout when computing coercion types
We need to take type alignment padding into account whe computing physical
layouts.
The layout must
Hi Richard,
Somehow this commit caused some methods in ObjC to do not become
visible in an interface when compiling with modules on. I filed
https://bugs.llvm.org/show_bug.cgi?id=33552, any idea what could have
gone wrong here? `hasVisibleDeclarationImpl` doesn't seem to have
changed the logic.
T
On 21 June 2017 at 14:51, Bruno Cardoso Lopes
wrote:
> Hi Richard,
>
> Somehow this commit caused some methods in ObjC to do not become
> visible in an interface when compiling with modules on. I filed
> https://bugs.llvm.org/show_bug.cgi?id=33552, any idea what could have
> gone wrong here? `has
On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith wrote:
> On 21 June 2017 at 14:51, Bruno Cardoso Lopes
> wrote:
>>
>> Hi Richard,
>>
>> Somehow this commit caused some methods in ObjC to do not become
>> visible in an interface when compiling with modules on. I filed
>> https://bugs.llvm.org/show_
On 21 June 2017 at 16:55, Bruno Cardoso Lopes
wrote:
> On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith
> wrote:
> > On 21 June 2017 at 14:51, Bruno Cardoso Lopes
> > wrote:
> >>
> >> Hi Richard,
> >>
> >> Somehow this commit caused some methods in ObjC to do not become
> >> visible in an interfa
haowei created this revision.
Herald added a subscriber: whisperity.
I noticed that when I use "-analyze-config" option in scan-build-py, it behaves
differently from original perl based scan-build.
For example, command:
$ scan-build -analyzer-config ipa=basic-inlining make
Will work without an
dexonsmith added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:7031
+Introduced) &&
+!S.Diags.isIgnored(diag::warn_unguarded_availability_new, Loc);
+diag = NewWarning ? diag::warn_partial_availability_new
arphaman wrote:
> erik.p
Author: marshall
Date: Wed Jun 21 19:49:03 2017
New Revision: 305977
URL: http://llvm.org/viewvc/llvm-project?rev=305977&view=rev
Log:
Add some catch(...) blocks to the tests so that if they fail, we get a good
error message. No functional change.
Modified:
libcxxabi/trunk/test/incomplete_ty
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D29654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
1 - 100 of 107 matches
Mail list logo
