johannes added inline comments.
================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:157
+ int Leaves = 0;
+ std::function<void(NodeId)> Traverse = [&](NodeId Id) {
+ const Node &N = getNode(Id);
----------------
arphaman wrote:
> you should be able to use `auto` instead of `std::function` here I think.
It does not work because the function is recursive. I'm not sure whether it is
good practise to do it like this.
================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:209
+ if (X->hasQualifier() && X->getQualifier()->getAsIdentifier())
+ Value += std::string(X->getQualifier()->getAsIdentifier()->getName());
+ Value += X->getDecl()->getNameAsString();
----------------
arphaman wrote:
> Qualifiers (i.e. `NestedNameSpecifier`s) can contain multiple identifiers
> (e.g. `foo::bar::`). You should use the `print` method from
> `NestedNameSpecifier` instead.
Ok nice, this works properly!
This function needs a lot of work. I try to extract relevant information from
base classes first.
https://reviews.llvm.org/D34329
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
