manojgupta added a comment.
Thanks for the quick review.
https://reviews.llvm.org/D34357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ed added a comment.
Final call: do any of you have any more feedback on this change? If not, I will
go ahead and commit this change one of these days (together with
https://reviews.llvm.org/D32937).
Thanks,
Ed
https://reviews.llvm.org/D32936
___
alexshap updated this revision to Diff 103090.
alexshap added a comment.
Address code review comments
Repository:
rL LLVM
https://reviews.llvm.org/D34268
Files:
include/clang/Edit/EditedSource.h
lib/Edit/EditedSource.cpp
test/FixIt/fixit-format-darwin.m
Index: test/FixIt/fixit-format-
alexshap marked 3 inline comments as done.
alexshap added inline comments.
Comment at: lib/Edit/EditedSource.cpp:80
+ return ArgUse.Identifier == U.Identifier &&
+ std::tie(ArgUse.ExpansionStack, ArgUse.Use) !=
+ std::tie(U.ExpansionSt
alexshap planned changes to this revision.
alexshap marked an inline comment as done.
alexshap added a comment.
probably we don't need to keep the entire expansion stack in MacroArgUse (i was
doing that because it was easier to understand what's going on).
I will update this diff soon.
Reposito
alexshap updated this revision to Diff 103093.
alexshap added a comment.
update, rerun the tests
Repository:
rL LLVM
https://reviews.llvm.org/D34268
Files:
include/clang/Edit/EditedSource.h
lib/Edit/EditedSource.cpp
test/FixIt/fixit-format-darwin.m
Index: test/FixIt/fixit-format-darwi
Author: aaronballman
Date: Mon Jun 19 15:08:20 2017
New Revision: 305738
URL: http://llvm.org/viewvc/llvm-project?rev=305738&view=rev
Log:
Typo fix: appropo -> apropos. NFC.
Modified:
cfe/trunk/docs/Block-ABI-Apple.rst
Modified: cfe/trunk/docs/Block-ABI-Apple.rst
URL:
http://llvm.org/viewvc
saugustine added a subscriber: klimek.
saugustine added a comment.
In https://reviews.llvm.org/D34304#783675, @klimek wrote:
> I think a better way might be to generally leave dependency options alone,
> add a default argument adapter to filter out all deps related flags, and
> allow users to a
mgorny created this revision.
Provide two new CMake cache variables -- CLANG_DEFAULT_STD_C
and CLANG_DEFAULT_STD_CXX -- that can be used to override the default
C/ObjC and C++/ObjC++ standards appropriately. They can be set to one of
the identifiers from LangStandards.def, or left unset (the defau
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D34353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
yaxunl created this revision.
The byval function argument is in alloca address space in LLVM IR. However,
during Clang codegen for C++, the address space of indirect function argument
should match its address space in the source code, even for byval argument.
This is because destructor of the byva
Author: vedantk
Date: Mon Jun 19 16:22:05 2017
New Revision: 305743
URL: http://llvm.org/viewvc/llvm-project?rev=305743&view=rev
Log:
[docs] Coverage: document issue with the BFD linker
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst
Author: vedantk
Date: Mon Jun 19 16:26:04 2017
New Revision: 305745
URL: http://llvm.org/viewvc/llvm-project?rev=305745&view=rev
Log:
[docs] Coverage: Improve the wording a bit
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst
URL:
htt
erichkeane created this revision.
As the bug report says,
struct A
{
template operator T();
};
void foo()
{
A().operator auto();
}
causes: "undeduced type in IR-generation
UNREACHABLE executed at llvm/tools/clang/lib/CodeGen/CodeGenFunction.cpp:208!"
The problem is that in this case, "T
rsmith added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:870-872
+auto *Ty =
+dyn_cast(R.getLookupName().getCXXNameType());
+if (Ty && Ty->isUndeducedType())
This is not sufficient to catch cases such as `operator auto*`, and one day
the
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
I think `-Wc++1z-mangling` is best. IMO, with C++1z in the name, it's already
clear that this is about compatibility. I also don't think we need to get as
specific as `-Wc++1z-compat
I don't think we're quite done yet: we still seem to be missing
serialization / deserialization support for coroutines.
On 27 May 2017 at 15:54, Gor Nishanov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: gornishanov
> Date: Sat May 27 17:54:52 2017
> New Revision: 304081
>
> URL:
Author: rsmith
Date: Mon Jun 19 18:09:36 2017
New Revision: 305758
URL: http://llvm.org/viewvc/llvm-project?rev=305758&view=rev
Log:
Support non-identifier module names when preprocessing modules.
Modified:
cfe/trunk/include/clang/Basic/Module.h
cfe/trunk/lib/Basic/Module.cpp
cfe/trun
rsmith accepted this revision.
rsmith added a comment.
We use the `-Wc++NN-compat-` prefix on all the other subwarnings of
`-Wc++NN-compat` warnings (examples: `-Wc++98-compat-bind-to-temporary-copy`,
`-Wc++11-compat-reserved-user-defined-literal`, ...). I'd prefer to include the
`-compat` in t
dexonsmith added a comment.
> We use the `-Wc++NN-compat-` prefix on all the other subwarnings of
> `-Wc++NN-compat` warnings
Interesting; I thought I saw a counter-example recently, and took that as the
rule (although I can't for the life of me remember what it was).
`-Wc++NN-compat-mangling
On 19 June 2017 at 16:25, Duncan P. N. Exon Smith via Phabricator via
cfe-commits wrote:
> dexonsmith added a comment.
>
> > We use the `-Wc++NN-compat-` prefix on all the other subwarnings of
> `-Wc++NN-compat` warnings
>
> Interesting; I thought I saw a counter-example recently, and took that a
Author: rsmith
Date: Mon Jun 19 20:31:53 2017
New Revision: 305764
URL: http://llvm.org/viewvc/llvm-project?rev=305764&view=rev
Log:
Turn off "disable free" mode when preprocessing imported module files in
-frewrite-imports mode.
This could end up accumulating a very large amount of intermediate
On Fri, Jun 16, 2017 at 5:08 PM, Duncan P. N. Exon Smith
wrote:
>
> On Jun 16, 2017, at 11:02, Reid Kleckner wrote:
>
> We should fix it.
>
>
> Agreed.
>
> We just need a new character code in the builtin function prototype
> encoding. Currently there is no encoding for a portable int32_t that
>
hintonda added a comment.
ping...
https://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
Reset ScopeSpec when parsing class, struct, etc.. Fixes PR32953.
https://reviews.llvm.org/D34383
Files:
lib/Parse/ParseDecl.cpp
test/SemaTemplate/instantiate-complete.cpp
Index: test/SemaTemplate/instantiate-complete.cpp
===
johannes updated this revision to Diff 103147.
johannes added a comment.
- style fixes
- do not compare nodes from system headers
https://reviews.llvm.org/D34329
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
lib/Tooling/ASTDiff/CMakeLists.txt
lib/Tooling
johannes added a comment.
In https://reviews.llvm.org/D34329#784090, @arphaman wrote:
> Generally we shouldn't have untested code in trunk, so I think that we need
> to find a way to test this before committing. We can start off by testing the
> output of the diff tool. Since there will be a lo
johannes updated this revision to Diff 103151.
https://reviews.llvm.org/D34329
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
lib/Tooling/ASTDiff/CMakeLists.txt
lib/Tooling/CMakeLists.txt
tools/CMakeLists.txt
tools/clang-diff/CMakeLists.txt
tools/clan
Author: ahatanak
Date: Tue Jun 20 01:18:46 2017
New Revision: 305772
URL: http://llvm.org/viewvc/llvm-project?rev=305772&view=rev
Log:
Add a subgroup of c++1z-compat to enable and disable the warning about
c++17's non-throwing exception specification in function signature.
rdar://problem/32628743
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305772: Add a subgroup of c++1z-compat to enable and disable
the warning about (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D34251?vs=102725&id=103159#toc
Repository:
rL
yvvan added a comment.
In https://reviews.llvm.org/D34279#784089, @hans wrote:
> I have 19.00.24210, so slightly earlier I suppose, but I believe we use
> Update 3 on our Chromium buildbots, and they seem happy.
>
> Can you paste the full error message? The part I see in your screenshot
> doesn
Author: xiangzhai
Date: Tue Jun 20 01:41:06 2017
New Revision: 305773
URL: http://llvm.org/viewvc/llvm-project?rev=305773&view=rev
Log:
[analyzer] Check NULL pointer dereference issue for memset function
Reviewers: dcoughlin, zaks.anna, NoQ, danielmarjamaki
Reviewed By: NoQ, danielmarjamaki
Dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305773: [analyzer] Check NULL pointer dereference issue for
memset function (authored by xiangzhai).
Changed prior to commit:
https://reviews.llvm.org/D31868?vs=101847&id=103161#toc
Repository:
rL LL
Author: xiangzhai
Date: Tue Jun 20 01:44:46 2017
New Revision: 305774
URL: http://llvm.org/viewvc/llvm-project?rev=305774&view=rev
Log:
[analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto
generated files
Reviewers: v.g.vassilev, teemperor
Reviewed By: teemperor
Differe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305774: [analyzer] Teach CloneDetection about Qt Meta-Object
Compiler to filter auto… (authored by xiangzhai).
Changed prior to commit:
https://reviews.llvm.org/D34353?vs=103063&id=103162#toc
Repositor
101 - 135 of 135 matches
Mail list logo
