[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

vsk created this revision. This patch makes ubsan's nonnull return value diagnostics more precise, which makes the diagnostics more useful when there are multiple return statements in a function. Example: 1 |__attribute__((returns_nonnull)) char *foo() { 2 | if (...) { 3 |return expr_w

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

arphaman updated this revision to Diff 102891. arphaman marked 2 inline comments as done. arphaman added a comment. Remove the assert and support the other partial availability warnings. Repository: rL LLVM https://reviews.llvm.org/D34264 Files: include/clang/Basic/DiagnosticGroups.td in

[PATCH] D34294: Rework libcxx strerror_r handling.

jyknight added a comment. In https://reviews.llvm.org/D34294#782806, @krytarowski wrote: > New one is harder to comprehend and less portable (usage of `__atribute__`). I can't disagree more strongly. This is fundamentally portable C++ code -- __attribute__((unused)) is simply warning suppress

r305600 - [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes

Author: phosek Date: Fri Jun 16 17:40:18 2017 New Revision: 305600 URL: http://llvm.org/viewvc/llvm-project?rev=305600&view=rev Log: [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes When -no-canonical-prefixes option is used and argv0 contains only a program name, we need to

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL305600: [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D34290?vs=102881&id=102894#toc Repository: rL LLV

Re: r305600 - [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes

On Fri, Jun 16, 2017 at 10:40:18PM -, Petr Hosek via cfe-commits wrote: > @@ -53,8 +53,15 @@ using namespace clang::driver; > using namespace llvm::opt; > > std::string GetExecutablePath(const char *Argv0, bool CanonicalPrefixes) { > - if (!CanonicalPrefixes) > -return Argv0; > + if (

[PATCH] D34294: Rework libcxx strerror_r handling.

krytarowski added a comment. In https://reviews.llvm.org/D34294#782856, @jyknight wrote: > In https://reviews.llvm.org/D34294#782806, @krytarowski wrote: > > > New one is harder to comprehend and less portable (usage of `__atribute__`). > > > I can't disagree more strongly. This is fundamentally

[PATCH] D34212: docs: Document binary compatibility issue due to bug in gcc

vsk added a comment. Could you add links to this document in index.rst and UsersManual.rst? Comment at: docs/BinaryCompatibilityWithOtherCompilers.rst:39 + +https://llvm.org/PR33161 This link is still showing up as 'insecure'. Mind using this?:

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:6944 -diag = !ObjCPropertyAccess ? diag::err_unavailable - : diag::err_property_method_unavailable; -diag_message = diag::err_unavailable_message; W

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

arphaman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:6944 -diag = !ObjCPropertyAccess ? diag::err_unavailable - : diag::err_property_method_unavailable; -diag_message = diag::err_unavailable_message; erik.pil

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

ahatanak created this revision. Herald added a subscriber: Prazek. The test case I added used to fail because of a linker error. Linkage failed because Sema::MarkDeclRefReferenced would prevent the virtual method definition from being emitted by setting OdrUse=false and then code-gen would devi

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

arphaman updated this revision to Diff 102902. arphaman marked an inline comment as done. arphaman added a comment. Swap the checking operators and bring back the accidentally deleted code. Repository: rL LLVM https://reviews.llvm.org/D34264 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF added inline comments. Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) || \ + (defined(__MAC_OS_X_VERSION

Re: r284060 - Implement MS _BitScan intrinsics

> On Jun 16, 2017, at 11:02, Reid Kleckner wrote: > > We should fix it. Agreed. > We just need a new character code in the builtin function prototype encoding. > Currently there is no encoding for a portable int32_t that magically becomes > "long" on 32-bit Windows. The closest thing we have

Buildbot numbers for the week of 05/28/2017 - 06/03/2017

Hello everyone, Below are some buildbot numbers for the week of 05/28/2017 - 06/03/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 06/04/2017 - 06/10/2017

Hello everyone, Below are some buildbot numbers for the last week of 06/04/2017 - 06/10/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

r305619 - Call setMustBuildLookupTable on TagDecls in ExternalASTMerger

Author: lhames Date: Fri Jun 16 19:12:38 2017 New Revision: 305619 URL: http://llvm.org/viewvc/llvm-project?rev=305619&view=rev Log: Call setMustBuildLookupTable on TagDecls in ExternalASTMerger Summary: setMustBuildLookupTable should be called on imported TagDecls otherwise we may fail to impor

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

echristo edited reviewers, added: bkramer; removed: echristo. echristo added a comment. Going to let Ben review this. I'd rather not pass the bool down and he might know a way to avoid that here by knowing the code more :) https://reviews.llvm.org/D34304 _

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

vsk added a comment. It looks Comment at: lib/Sema/SemaExpr.cpp:14715 +if (Method->isVirtual() && !(Method->hasAttr() || + Method->getParent()->hasAttr())) OdrUse = false; Do you think it makes sense to eliminate all c

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access? Repository: rL LLVM https://reviews.llvm.org/D34266 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D34102: [analyzer] Add portability package for the checkers.

zaks.anna added a comment. > eg. checkers for portability across linux/bsd should be off on windows by > default, checkers for non-portable C++ APIs should be off in plain C code, etc Is the checker you are moving to portability off and not useful on Windows? https://reviews.llvm.org/D34102

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thank you! (Not sure if @NoQ wants to do a final review.) Do you have commit access or should we commit on your behalf? https://reviews.llvm.org/D30406 ___

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

vlad.tsyrklevich added a comment. Please commit on my behalf. https://reviews.llvm.org/D30406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2