krytarowski added a comment. In https://reviews.llvm.org/D34294#782856, @jyknight wrote:
> In https://reviews.llvm.org/D34294#782806, @krytarowski wrote: > > > New one is harder to comprehend and less portable (usage of `__atribute__`). > > > I can't disagree more strongly. This is fundamentally portable C++ code -- > __attribute__((unused)) is simply warning suppression. > I used it directly, because I saw other .cpp files in libcxx already did so. > If it needs to be conditioned, it could be. OK with me. https://reviews.llvm.org/D34294 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
