[PATCH] D34267: do more processing in clang-fuzzer (use EmitAssemblyAction)

kcc created this revision. Herald added a subscriber: mgorny. use EmitAssemblyAction in clang-fuzzer https://reviews.llvm.org/D34267 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ClangFuzzer.cpp Index: tools/clang-fuzzer/ClangFuzzer.cpp ==

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

I just started working on a patch to add #if guards, and the first interesting thing I found was the basic_string constructor: > template > template > basic_string<_CharT, _Traits, _Allocator>::basic_string( > const _Tp& __t, size_type __pos, size_type __n, const > allocator_type&

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

Ah, also the enable_if for same: > template > _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS > basic_string(const _Tp& __t, size_type __pos, size_type __n, > const allocator_type& __a = allocator_type(), > typename > enable_if<__ca

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

On Thu, Jun 15, 2017 at 8:38 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > I just started working on a patch to add #if guards, and the first > interesting thing I found was the basic_string constructor: > > template > template > basic_string<_CharT, _Traits, _Allocator>::basic_st

r305543 - [ODRHash] Hash VarDecl members.

Author: rtrieu Date: Thu Jun 15 21:44:29 2017 New Revision: 305543 URL: http://llvm.org/viewvc/llvm-project?rev=305543&view=rev Log: [ODRHash] Hash VarDecl members. These VarDecl's are static data members of classes. Since the initializers are also hashed, this also provides checking for default

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

alexshap created this revision. ExpansionLoc was previously calculated incorrectly in the case of nested macros expansions. In this diff we build the stack of expansions where the last one is the actual expansion (in the source code) which should be used for grouping together the edits. The de

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

vlad.tsyrklevich updated this revision to Diff 102765. vlad.tsyrklevich added a comment. Herald added a subscriber: xazax.hun. Updates to cleanly rebase on a recent clang master. Ran all tests with ASan to ensure I avoided a broken build post-merge as with https://reviews.llvm.org/D30909 http

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL305544: [XRay][clang] Support capturing the implicit `this` argument to C++ class… (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D34052?vs=102491&id=102775#toc Repository:

r305544 - [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

Author: dberris Date: Thu Jun 15 22:22:09 2017 New Revision: 305544 URL: http://llvm.org/viewvc/llvm-project?rev=305544&view=rev Log: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions Summary: Before this change, we couldn't capture the `this` pointer tha

r305546 - [ubsan] PR33081: Skip the standard type checks for volatile

Author: vedantk Date: Thu Jun 15 22:27:36 2017 New Revision: 305546 URL: http://llvm.org/viewvc/llvm-project?rev=305546&view=rev Log: [ubsan] PR33081: Skip the standard type checks for volatile Skip checks for null dereference, alignment violation, object size violation, and dynamic type violatio

[PATCH] D34262: [ubsan] PR33081: Skip the standard type checks for volatile

vsk added a comment. Thanks for the review. I'll make the suggested test changes and commit. https://reviews.llvm.org/D34262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34262: [ubsan] PR33081: Skip the standard type checks for volatile

This revision was automatically updated to reflect the committed changes. Closed by commit rL305546: [ubsan] PR33081: Skip the standard type checks for volatile (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34262?vs=102758&id=102778#toc Repository: rL LLVM https:

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

mehdi_amini added a comment. Thanks for fixing! (I'm still not the best qualified to review this) Comment at: lib/Edit/EditedSource.cpp:78 if (I != ExpansionToArgMap.end() && -std::find_if( -I->second.begin(), I->second.end(), [&](const MacroArgUse &U)

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 102777. xiangzhai added a comment. Herald added a subscriber: xazax.hun. Dear Raphael, Thanks for your suggestion! > Would it solve your use case if allow specifying file patterns via the > command line like this -analyzer-config Fixed! /home/zhaixian

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

alexshap updated this revision to Diff 102781. alexshap added a comment. minor update Repository: rL LLVM https://reviews.llvm.org/D34268 Files: include/clang/Edit/EditedSource.h lib/Edit/EditedSource.cpp test/FixIt/fixit-format-darwin.m Index: test/FixIt/fixit-format-darwin.m ===

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF updated this revision to Diff 102782. https://reviews.llvm.org/D34249 Files: src/experimental/filesystem/operations.cpp Index: src/experimental/filesystem/operations.cpp === --- src/experimental/filesystem/operations.cpp +

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF updated this revision to Diff 102783. EricWF marked an inline comment as done. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D34249 Files: src/experimental/filesystem/operations.cpp Index: src/experimental/filesystem/operations.cpp ==

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

dexonsmith added inline comments. Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) || \ + (defined(__MAC_OS_X_VER

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

dexonsmith added inline comments. Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) || \ + (defined(__MAC_OS_X_VER

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF added inline comments. Comment at: src/experimental/filesystem/operations.cpp:22-24 +#if defined(__APPLE__) +#include +#endif dexonsmith wrote: > I only just noticed you were including Availability.h. That shouldn't be > necessary, since the macros shou

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

dexonsmith added inline comments. Comment at: src/experimental/filesystem/operations.cpp:22-24 +#if defined(__APPLE__) +#include +#endif EricWF wrote: > dexonsmith wrote: > > I only just noticed you were including Availability.h. That shouldn't be > > necessar

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

On Jun 15, 2017, at 19:42, Eric Fiselier wrote:On Thu, Jun 15, 2017 at 8:38 PM, Duncan P. N. Exon Smith  wrote:I just started working on a patch to add #if guards, and the first interesting thing I found was the basic_string constructor:template template basic_s

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

I should mention that depends on C++17 string_view in older dialects :-S So this change will break that. I would prefer to fix your specific use case by making std::experimental::string_view literally be std::string_view. /Eric On Thu, Jun 15, 2017 at 8:42 PM, Eric Fiselier wrote: > > > On Th

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

I would also want to do serious performance analysis on this patch. Does removing the string_view overloads cause less optimal overloads to be chosen? Perhaps allocating ones? That would be really unfortunate, and I'm not sure that's in the best interest of our users at large. /Eric On Thu, Jun 1

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

Your suggestion is essentially to replace experimental/string_view with something like: namespace std { inline namespace __1 { namespace experimental { template using basic_string_view = _VSTD::basic_string_view; }}} That breaks: 1. User compiles 1.cpp with older toolchain.

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Your suggestion is essentially to replace experimental/string_view with > something like: > > namespace std { inline namespace __1 { namespace experimental { > template > using basic_string_

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

On Jun 15, 2017 11:22 PM, "Eric Fiselier" wrote: On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Your suggestion is essentially to replace experimental/string_view with > something like: > > namespace std { inline namespace __1 { namespace experim

[PATCH] D33606: [Sema] Fix a crash-on-invalid when a template parameter list has a class definition or non-reference class type

ahatanak added a comment. ping https://reviews.llvm.org/D33606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33253: [index] Fix typo: inferface -> interface

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D33253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[libcxx] r305549 - Fix potential bug by casting to the POSIX specified type

Author: ericwf Date: Fri Jun 16 01:17:52 2017 New Revision: 305549 URL: http://llvm.org/viewvc/llvm-project?rev=305549&view=rev Log: Fix potential bug by casting to the POSIX specified type Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/experimen

<    1   2