dexonsmith added inline comments.
================ Comment at: src/experimental/filesystem/operations.cpp:22-24 +#if defined(__APPLE__) +#include <Availability.h> +#endif ---------------- EricWF wrote: > dexonsmith wrote: > > I only just noticed you were including Availability.h. That shouldn't be > > necessary, since the macros should be defined by the compiler. > __MAC_10_13 et al are defined in `Availability.h`, and > `AvailabilityInternal.h` seems to do the `__ENV` dance described above. Are > you sure it's not needed? I don't think the dance is necessary, since libcxx won't be overriding those macros. Also, we can skip the `__MAC_10_13` macros, ala src/chrono.cpp. https://reviews.llvm.org/D34249 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
