Author: gornishanov
Date: Wed May 24 15:09:14 2017
New Revision: 303803
URL: http://llvm.org/viewvc/llvm-project?rev=303803&view=rev
Log:
[coroutines] Add support for coroutines with non-scalar parameters
Summary:
Simple types like int are handled by LLVM Coroutines just fine.
But for non-scalar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303803: [coroutines] Add support for coroutines with
non-scalar parameters (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D33507?vs=100132&id=100152#toc
Repository:
rL L
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:83
+
+ Finds uses of __func__ or __FUNCTION__ inside lambdas.
+
Please highlight __func__ and __FUNCTION__ with ``.
https://reviews.llvm.org/D33497
Author: compnerd
Date: Wed May 24 15:27:09 2017
New Revision: 303804
URL: http://llvm.org/viewvc/llvm-project?rev=303804&view=rev
Log:
Basic: fix whitespace in file header (NFC)
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.org/viewvc/l
craig.topper added a comment.
Is there enough functional here that there should be tests for? i.e. make sure
march/mcpu switches are recognized, that the target is recognized, etc.
https://reviews.llvm.org/D33356
___
cfe-commits mailing list
cfe-co
kcc added a comment.
oss-fuzz finds the assertion failure in this new code:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1834
Repository:
rL LLVM
https://reviews.llvm.org/D33368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
brycel updated this revision to Diff 100159.
brycel marked an inline comment as done.
brycel added a comment.
Fixed ReleaseNotes.rst
https://reviews.llvm.org/D33497
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/LambdaFunctionNameCheck.cpp
clang-tidy/misc/LambdaFunctionNameCheck.h
Author: epilk
Date: Wed May 24 15:53:13 2017
New Revision: 303806
URL: http://llvm.org/viewvc/llvm-project?rev=303806&view=rev
Log:
[Demangler] Remove a failing assert introduced in r303718
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified: libcxxabi/trunk/src/cxa_demangle.cpp
URL:
ht
erik.pilkington added a comment.
r303806 removes the assertion (instead just returning first). I though this
should never happen, I'm looking into this testcase to see if there is another
bug here.
Thanks,
Erik
Repository:
rL LLVM
https://reviews.llvm.org/D33368
_
kcc added a comment.
I also encourage you to run the fuzzer on every change in this code.
Repository:
rL LLVM
https://reviews.llvm.org/D33368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
kcc added a comment.
Also, are you now maintaining this code?
I am trying to find someone who wants to be CC-ed to other demangler bugs
automatically reported by oss-fuzz.
Repository:
rL LLVM
https://reviews.llvm.org/D33368
___
cfe-commits mail
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:83
+
+ Finds uses of __func__ or __FUNCTION__ inside lambdas.
+
Eugene.Zelenko wrote:
> Please highlight __func__ and __FUNCTION__ with ``.
I meant double ``, not single `.
https://re
brycel marked an inline comment as done.
brycel added inline comments.
Comment at: docs/ReleaseNotes.rst:83
+
+ Finds uses of __func__ or __FUNCTION__ inside lambdas.
+
Eugene.Zelenko wrote:
> Eugene.Zelenko wrote:
> > Please highlight __func__ and __FUNCTI
brycel updated this revision to Diff 100161.
brycel added a comment.
Double backticks, not single.
https://reviews.llvm.org/D33497
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/LambdaFunctionNameCheck.cpp
clang-tidy/misc/LambdaFunctionNameCheck.h
clang-tidy/misc/MiscTidyModule.c
erik.pilkington added a comment.
> Also, are you now maintaining this code?
> I am trying to find someone who wants to be CC-ed to other demangler bugs
> automatically reported by oss-fuzz.
I don’t think I’ll accept the title of maintainer, (I only have one commit in
this file!) but I have som
kcc added a comment.
Done (see
https://github.com/google/oss-fuzz/blob/master/projects/llvm_libcxxabi/project.yaml)
Repository:
rL LLVM
https://reviews.llvm.org/D33368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
mclow.lists added a comment.
This broke a libc++ test. The following is expected to fail to compile:
#include
#include
int main()
{
std::complex foo = 1.0if; // should fail w/conversion operator
not found
}
when build as C++1z
https://reviews.llvm.org/D33424
___
On 24 May 2017 at 14:35, Marshall Clow via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mclow.lists added a comment.
>
> This broke a libc++ test. The following is expected to fail to compile:
>
> #include
> #include
>
> int main()
> {
> std::complex foo = 1
Author: tnorthover
Date: Wed May 24 17:18:35 2017
New Revision: 303813
URL: http://llvm.org/viewvc/llvm-project?rev=303813&view=rev
Log:
Revert "Sema: allow imaginary constants via GNU extension if UDL overloads not
present."
This reverts commit r303697. It broke libc++ tests that were specifica
On 24 May 2017 at 15:06, Richard Smith wrote:
> I think this is expected. Clang has an extension where it treats 1.0if as a
> _Complex float if no operator""if is available;
Since it's breaking some bots, I've reverted my commit while we hash
this out. r303813.
> libc++ has an extension
> where
mclow.lists added a comment.
More. Trying the above code on godbolt.org, gcc 6.1/6.2/6.3/7.1 all reject it
(with `-std=c++14` and `-std=c++1z`) with the error message:
> : In function 'int main()':
> :4:30: error: unable to find numeric literal operator 'operator""if'
>
> { std::complex foo
jroelofs updated this revision to Diff 100177.
jroelofs marked an inline comment as done.
jroelofs added a comment.
Fix a cmake warning:
Platform/baremetal to use this system, please send your config file to
cm...@www.cmake.org so it can be added to cmake
Your CMakeCache.txt file was copied
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Makes sense. LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D33357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, that looks great.
Repository:
rL LLVM
https://reviews.llvm.org/D33328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
timshen created this revision.
Herald added subscribers: eraman, inglorion, Prazek, mehdi_amini.
Also see https://reviews.llvm.org/D33429 for other ThinLTO + New PM related
changes.
https://reviews.llvm.org/D33525
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/test/CodeGen/thin_link_bitcod
mehdi_amini added inline comments.
Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:423
+
+class AARGetter {
+ FunctionAnalysisManager &AM;
Can't you do it with a lambda?
https://reviews.llvm.org/D33525
__
Author: marshall
Date: Wed May 24 19:22:33 2017
New Revision: 303824
URL: http://llvm.org/viewvc/llvm-project?rev=303824&view=rev
Log:
Add some constexpr tests for optional's move/copy ctor
Modified:
libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/copy.pass.cpp
timshen added inline comments.
Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:423
+
+class AARGetter {
+ FunctionAnalysisManager &AM;
mehdi_amini wrote:
> Can't you do it with a lambda?
I can, except that AAR needs to be allocated outside of the la
On 24 May 2017 3:19 pm, "Tim Northover" wrote:
On 24 May 2017 at 15:06, Richard Smith wrote:
> I think this is expected. Clang has an extension where it treats 1.0if as
a
> _Complex float if no operator""if is available;
Since it's breaking some bots, I've reverted my commit while we hash
this
On 24 May 2017 at 15:32, Marshall Clow via Phabricator
wrote:
> More. Trying the above code on godbolt.org, gcc 6.1/6.2/6.3/7.1 all reject it
> (with `-std=c++14` and `-std=c++1z`) with the error message:
This was a pretty explicit intent in Richard's proposal: treat
incoming code as charitably
EricWF created this revision.
This patch fixes a number of issues with the analysis warnings emitted when a
coroutine may reach the end of the function w/o returning.
- Fix bug where coroutines with `return_value` are incorrectly diagnosed as
missing `co_return`'s.
- Rework diagnostic message t
GorNishanov added inline comments.
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:378
const Stmt *S = CS.getStmt();
-if ((isa(S) && !IsCoroutine) || isa(S)) {
+if (isa(S) || isa(S)) {
HasLiveReturn = true;
Is this check no longer needed becaus
EricWF added inline comments.
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:378
const Stmt *S = CS.getStmt();
-if ((isa(S) && !IsCoroutine) || isa(S)) {
+if (isa(S) || isa(S)) {
HasLiveReturn = true;
GorNishanov wrote:
> Is this check no long
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: ericwf
Date: Wed May 24 21:16:53 2017
New Revision: 303831
URL: http://llvm.org/viewvc/llvm-project?rev=303831&view=rev
Log:
[coroutines] Fix fallthrough diagnostics for coroutines
Summary:
This patch fixes a number of issues with the analysis warnings emitted when a
coroutine may reach
Author: marshall
Date: Wed May 24 21:29:54 2017
New Revision: 303833
URL: http://llvm.org/viewvc/llvm-project?rev=303833&view=rev
Log:
Add non-parallel version of for_each_n (+tests) from the Parallelism TS
Added:
libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.foreach/for_each_n.pass.
EricWF created this revision.
According to the PDTS it's perfectly legal to have a promise type that defines
neither `return_value` nor `return_void`. However a coroutine that uses such a
promise type will almost always have UB, because it can never `co_return`.
This patch changes Clang to diag
george.burgess.iv updated this revision to Diff 100201.
george.burgess.iv added a comment.
Herald added a subscriber: jfb.
Fix the aforementioned issue; PTAL.
Note that this fix is slightly backwards incompatible. It disallows code like:
void foo(int);
void foo(int) __attribute__((overloadab
Author: ericwf
Date: Wed May 24 23:09:07 2017
New Revision: 303835
URL: http://llvm.org/viewvc/llvm-project?rev=303835&view=rev
Log:
Fix broken links on C++1z status page
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/ll
Author: ericwf
Date: Wed May 24 23:36:24 2017
New Revision: 303836
URL: http://llvm.org/viewvc/llvm-project?rev=303836&view=rev
Log:
Add
This patch adds the library portions of the coroutines PDTS,
which should now be supported by Clang.
Added:
libcxx/trunk/include/experimental/coroutine
Author: ericwf
Date: Thu May 25 00:11:40 2017
New Revision: 303837
URL: http://llvm.org/viewvc/llvm-project?rev=303837&view=rev
Log:
Disable the coroutines tests until Clang bumps __cpp_coroutines to reflect
recent changes
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/
EricWF created this revision.
This patch is needed so that Libc++ can actually tess if Clang supports
coroutines, instead of just paying lip service with a partial implementation.
Otherwise the libc++ test suite will fail against older versions of Clang
https://reviews.llvm.org/D33536
Files:
Author: ericwf
Date: Thu May 25 00:30:05 2017
New Revision: 303838
URL: http://llvm.org/viewvc/llvm-project?rev=303838&view=rev
Log:
Remove from the module map for now. It doesn't work
unless modules are enabled
Modified:
libcxx/trunk/include/module.modulemap
Modified: libcxx/trunk/include
baloghadamsoftware created this revision.
Herald added a subscriber: mgorny.
Finds functions which should not throw exceptions: Destructors, move
constructors, move assignment operators, the main() function, swap() functions,
functions marked with throw() or noexcept and functions given as optio
EricWF created this revision.
In order for libc++ to add `` to its module map, there
has to be a feature that can be used to detect if coroutines support is enabled
in Clang.
https://reviews.llvm.org/D33538
Files:
docs/Modules.rst
lib/Basic/Module.cpp
test/Modules/Inputs/DependsOnModule
baloghadamsoftware added a comment.
Supersedes https://reviews.llvm.org/D32350
https://reviews.llvm.org/D33537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
baloghadamsoftware abandoned this revision.
baloghadamsoftware added a comment.
Superseded by https://reviews.llvm.org/D33537
https://reviews.llvm.org/D32350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
EricWF updated this revision to Diff 100207.
EricWF added a comment.
- Alphabetize newly added switch case.
https://reviews.llvm.org/D33538
Files:
docs/Modules.rst
lib/Basic/Module.cpp
test/Modules/Inputs/DependsOnModule.framework/Headers/coroutines.h
test/Modules/Inputs/DependsOnModule
baloghadamsoftware added a comment.
Any comments regarding the last changes?
https://reviews.llvm.org/D32592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echuraev updated this revision to Diff 100210.
https://reviews.llvm.org/D31745
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/clang-builtin-version.cl
test/SemaOpenCL/to_addr_builtin.cl
Index: test/SemaOpenCL/to_addr_builtin.cl
===
101 - 150 of 150 matches
Mail list logo
