djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D30874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
pete created this revision.
Its possible for a header to be a symlink to another header. In this case,
both are actually the same underlying file, and will both have the same include
guards.
Because of this, if we #include the header, then #include the symlink, or vice
versa, then one will ge
Author: mprobst
Date: Mon Mar 13 02:10:18 2017
New Revision: 297605
URL: http://llvm.org/viewvc/llvm-project?rev=297605&view=rev
Log:
clang-format: [JS] do not wrap after interface and type.
Summary:
`interface` and `type` are pseudo keywords and cause automatic semicolon
insertion when followed
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297605: clang-format: [JS] do not wrap after interface and
type. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D30874?vs=91500&id=91519#toc
Repository:
rL LLVM
https://rev
ahatanak added a comment.
Could you elaborate on the motivation for this change?
I was wondering why clang (CodeGen) needed the help of a command line option to
decide whether vec3 should be converted to vec4. Can it just preserve vec3 when
the architecture is spir?
https://reviews.llvm.org/D
igorb accepted this revision.
igorb added a comment.
This revision is now accepted and ready to land.
LGTM,
Could you please add test that check scale and hint parameter errors for
BI__builtin_ia32_gatherpfdpd for example.
https://reviews.llvm.org/D30875
pete created this revision.
Herald added a subscriber: nemanjai.
This adds a PP callback for the __has_include and __has_include_next directives.
Checking for the presence of a header should add it to the list of header
dependencies so this overrides the callback in the dependency scanner.
I ke
jaykang10 marked an inline comment as done.
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#699006, @ahatanak wrote:
> Could you elaborate on the motivation for this change?
>
> I was wondering why clang (CodeGen) needed the help of a command line option
> to decide whether vec3 sh
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good from my side.
https://reviews.llvm.org/D30720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
JDevlieghere abandoned this revision.
JDevlieghere added a comment.
In https://reviews.llvm.org/D30792#697802, @mehdi_amini wrote:
> Off topic, but since this is a rev lock change with LLVM, you can to all of
> in a single revision with:
> http://llvm.org/docs/GettingStarted.html#for-developers
Author: mprobst
Date: Mon Mar 13 04:14:23 2017
New Revision: 297606
URL: http://llvm.org/viewvc/llvm-project?rev=297606&view=rev
Log:
clang-format: [JS] allow breaking after non-null assertions.
Summary:
Previously clang-format would not break after any !. However in TypeScript, !
can be used as
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297606: clang-format: [JS] allow breaking after non-null
assertions. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D30705?vs=90988&id=91526#toc
Repository:
rL LLVM
https:/
a.sidorin added a comment.
Hello Zoltan,
Thank you for the patch. There is an inline comment.
Comment at: lib/AST/ASTImporter.cpp:5221
IdentifierInfo *ToII = Importer.Import(S->getOutputIdentifier(I));
-if (!ToII)
- return nullptr;
+// ToII is nullptr when no
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/MiscTidyModule.cpp:70
+CheckFactories.registerCheck(
+"misc-forwarding-reference-overload");
CheckFactories.registerCheck("misc-misplaced-const");
aaron.ballman wrote:
> leanil wr
mprobst created this revision.
Herald added a subscriber: klimek.
@see is special among JSDoc tags in that it is commonly followed by URLs. The
JSDoc spec suggests that users should wrap URLs in an additional {@link url...}
tag (@see http://usejsdoc.org/tags-see.html), but this is very commonly
xazax.hun added inline comments.
Comment at: clang-tidy/misc/MiscTidyModule.cpp:70
+CheckFactories.registerCheck(
+"misc-forwarding-reference-overload");
CheckFactories.registerCheck("misc-misplaced-const");
malcolm.parsons wrote:
> aaron.ballman
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D30883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: mprobst
Date: Mon Mar 13 04:39:23 2017
New Revision: 297607
URL: http://llvm.org/viewvc/llvm-project?rev=297607&view=rev
Log:
clang-format: [JS] do not wrap @see tags.
Summary:
@see is special among JSDoc tags in that it is commonly followed by URLs. The
JSDoc spec suggests that users sh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297607: clang-format: [JS] do not wrap @see tags. (authored
by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D30883?vs=91527&id=91529#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: docs/tools/dump_format_style.py:67
def __str__(self):
-return '* ``%s`` %s' % (self.name, doxygen2rst(self.comment))
+return '\n* ``%s``
bader added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
---
Hi Galina,
Thanks for reporting it! I believe the issue is fixed in r297530.
Cheers,
Anastasia
From: Galina Kistanova [mailto:gkistan...@gmail.com]
Sent: 10 March 2017 20:29
To: Anastasia Stulova
Cc: cfe-commits
Subject: Re: r297468 - [OpenCL] Fix type compatibility check and generic AS
manglin
rogfer01 created this revision.
Given that we have already explicitly stated in the qualifier that the
expression is `__unaligned`,
it makes little sense to diagnose that the address of the packed member may not
be aligned.
https://reviews.llvm.org/D30884
Files:
lib/Sema/SemaChecking.cpp
Author: arphaman
Date: Mon Mar 13 06:17:41 2017
New Revision: 297614
URL: http://llvm.org/viewvc/llvm-project?rev=297614&view=rev
Log:
Add -iframeworkwithsysroot compiler option
This commit adds support for a new -iframeworkwithsysroot compiler option which
allows the user to specify a framework
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297614: Add -iframeworkwithsysroot compiler option (authored
by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D30183?vs=89152&id=91534#toc
Repository:
rL LLVM
https://reviews.llvm.org
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/MiscTidyModule.cpp:70
+CheckFactories.registerCheck(
+"misc-forwarding-reference-overload");
CheckFactories.registerCheck("misc-misplaced-const");
xazax.hun wrote:
> malcolm.parsons
echuraev updated this revision to Diff 91536.
https://reviews.llvm.org/D30643
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
lib/Sema/SemaInit.cpp
test/Parser/opencl-atomics-cl20.cl
test/SemaOpenCL/atomic-init.cl
Index: test/SemaOpenCL/atomic-init.cl
=
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D30884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
rogfer01 added a comment.
Thanks for the review @aaron.ballman!
https://reviews.llvm.org/D30884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
madsravn added a comment.
In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote:
> In https://reviews.llvm.org/D30158#696534, @madsravn wrote:
>
> > Any updates on this?
>
>
> Have you run it over the test suite on the revision before random_shuffle was
> removed from libc++?
I can't
gerazo updated this revision to Diff 91541.
gerazo added a comment.
Better check not letting a real import problem passing through
https://reviews.llvm.org/D30831
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/asm/Inputs/asm-function.cpp
test/ASTMerge/asm/test.cpp
Index: test/ASTMerge/asm
bader added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
---
gerazo marked an inline comment as done.
gerazo added inline comments.
Comment at: lib/AST/ASTImporter.cpp:5221
IdentifierInfo *ToII = Importer.Import(S->getOutputIdentifier(I));
-if (!ToII)
- return nullptr;
+// ToII is nullptr when no symbolic name is given fo
Author: xazax
Date: Mon Mar 13 07:48:26 2017
New Revision: 297619
URL: http://llvm.org/viewvc/llvm-project?rev=297619&view=rev
Log:
[analyzer] Fix a rare crash for valist check.
It looks like on some host-triples the result of a valist related expr can be
a LazyCompoundVal. Handle that case in th
Author: rogfer01
Date: Mon Mar 13 08:18:21 2017
New Revision: 297620
URL: http://llvm.org/viewvc/llvm-project?rev=297620&view=rev
Log:
When diagnosing taking address of packed members skip __unaligned-qualified
expressions
Given that we have already explicitly stated in the qualifier that the
ex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297620: When diagnosing taking address of packed members
skip __unaligned-qualified… (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D30884?vs=91531&id=91548#toc
Repository:
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck {
v.g.vassilev added a comment.
@rsmith ping...
https://reviews.llvm.org/D29877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sylvestre
Date: Mon Mar 13 09:42:47 2017
New Revision: 297623
URL: http://llvm.org/viewvc/llvm-project?rev=297623&view=rev
Log:
[clang-format] Add more examples and fix a bug in the py generation script
Reviewers: djasper
Reviewed By: djasper
Subscribers: cfe-commits, klimek
Differenti
marsupial updated this revision to Diff 91563.
marsupial retitled this revision from "Send UndefMacroDirective to MacroDefined
callback" to "Add test for PPCallbacks::MacroUndefined".
marsupial edited the summary of this revision.
https://reviews.llvm.org/D29923
Files:
unittests/Basic/SourceMa
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
https://reviews.llvm.org/D30831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: xazax
Date: Mon Mar 13 10:32:24 2017
New Revision: 297627
URL: http://llvm.org/viewvc/llvm-project?rev=297627&view=rev
Log:
[ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands
Patch by Zoltan Gera!
Differential Revision: https://reviews.llvm.org/D30831
Modified:
cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297627: [ASTImporter] Import fix of GCCAsmStmts w/ missing
symbolic operands (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D30831?vs=91541&id=91567#toc
Repository:
rL LLVM
h
sammccall added a comment.
bkramer: ping
https://reviews.llvm.org/D30720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe created this revision.
jbcoe added a project: clang-tools-extra.
Herald added subscribers: JDevlieghere, mgorny.
Add a check to find enums used in `==` or `!=` expressions. Using a switch
statement leads to more easily maintained code.
Repository:
rL LLVM
https://reviews.llvm.org/D3089
Author: arphaman
Date: Mon Mar 13 10:43:42 2017
New Revision: 297628
URL: http://llvm.org/viewvc/llvm-project?rev=297628&view=rev
Log:
[CodeCompletion] Format block parameter placeholders in implicit property
setters using the block type information that's obtained from the property
rdar://126042
bkramer accepted this revision.
bkramer added a comment.
lg as a prototype.
https://reviews.llvm.org/D30720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
I like that check. But I think it could take another feature.
In my opinion it would be valueable to check if enums are compared against ints
as well.
For example
enum Kind k = Kind::a;
if (k == 3) { /* something */ }
This usecase is not specially considered here
jroelofs added a comment.
In https://reviews.llvm.org/D30158#699132, @madsravn wrote:
> In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D30158#696534, @madsravn wrote:
> >
> > > Any updates on this?
> >
> >
> > Have you run it over the test suite
Author: sammccall
Date: Mon Mar 13 10:55:59 2017
New Revision: 297630
URL: http://llvm.org/viewvc/llvm-project?rev=297630&view=rev
Log:
[include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.
Summary:
Add fuzzy SymbolIndex, where identifier needn't match exactly.
The purpo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297630: [include-fixer] Add fuzzy SymbolIndex, where
identifier needn't match exactly. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D30720?vs=91042&id=91570#toc
Repository
rogfer01 created this revision.
This is the clang side of the RFC in
http://lists.llvm.org/pipermail/cfe-dev/2017-February/052549.html
Note that in contrast to the original suggestion `-fsource-asm` here we use the
preferred `-fverbose-asm`. Basically explicitly saying `-fverbose-asm` in the
c
ahatanak updated this revision to Diff 91577.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address Alex's review comments.
https://reviews.llvm.org/D30766
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Ba
ahatanak added inline comments.
Comment at: test/Sema/enum-attr.c:27
+
+enum __attribute__((enum_extensibility(arg1))) EnumInvalidArg { //
expected-warning{{'enum_extensibility' attribute argument not supported:
'arg1'}}
+ G
arphaman wrote:
> Should this be an
Anastasia added inline comments.
Comment at: test/SemaOpenCL/overload-scalar-widening.cl:4
+
+typedef short short4 __attribute__((ext_vector_type(4)));
+
I am thinking could this be a CodeGen test instead and we could check that the
right overload is selected ba
Anastasia added a comment.
Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation
accordingly to make things consistent?
https://reviews.llvm.org/D30810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Do you need someone to commit this patch for you?
> On Mar 10, 2017, at 6:44 AM, Lobron, David wrote:
>
> Hi Akira,
>
> Thank you very much! Please let me know if I need to take any further steps
> beyond this email to cfe-commits in order for the patch and the unit test to
> be committed.
>
Yes, please, if you don't mind! I'd like to commit both the path and the unit
test, if possible.
Thanks,
David
> On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote:
>
> Do you need someone to commit this patch for you?
>
>> On Mar 10, 2017, at 6:44 AM, Lobron, David wrote:
>>
>> Hi Akira,
Author: ctopper
Date: Mon Mar 13 12:16:50 2017
New Revision: 297642
URL: http://llvm.org/viewvc/llvm-project?rev=297642&view=rev
Log:
[X86] Add checking of the scale argument to scatter/gather builtins
The only valid values for scale immediate of scatter/gather builtins are 1, 2,
4, or 8. This p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297642: [X86] Add checking of the scale argument to
scatter/gather builtins (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D30875?vs=91508&id=91586#toc
Repository:
rL LLVM
jbcoe updated this revision to Diff 91588.
jbcoe added a comment.
Minor edits in response to review comments. A few questions outstanding.
https://reviews.llvm.org/D30896
Files:
clang-tools-extra/clang-tidy/misc/CMakeLists.txt
clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
clang-too
Anastasia added inline comments.
Comment at: lib/Driver/Tools.cpp:5288
// parser.
- Args.AddAllArgValues(CmdArgs, options::OPT_Xclang);
+ if (C.getDriver().isSaveTempsEnabled() &&
+ !isa(JA)) {
It would be nice to add a comment around here explaining th
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
Handling
enum Kind k = Kind::a;
if (k == 3) { /* something */ }
is intentionally out of scope for now as the author is doing something that I
can't trivially replace with a switch.
Comment at: clang-tools-ext
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
---
fgross added a comment.
No commit access, could someone please take care of this? Thanks!
https://reviews.llvm.org/D30610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jdevlieghere
Date: Mon Mar 13 13:08:11 2017
New Revision: 297649
URL: http://llvm.org/viewvc/llvm-project?rev=297649&view=rev
Log:
[Linker] Provide callback for internalization
Differential Revision: https://reviews.llvm.org/D30738
Modified:
cfe/trunk/include/clang/CodeGen/CodeGenAct
JonasToth added a comment.
alright. then i have a good check for myself to write ;)
https://reviews.llvm.org/D30896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
In https://reviews.llvm.org/D28136#697844, @bader wrote:
> > Why do you think this is a bug? It seems to follow standard behavior in C
> > to promote char to int if required. Just like if you would have a C code:
> >
> > int as_int(int i);
> > void foo() {
> >
Author: rnk
Date: Mon Mar 13 13:42:30 2017
New Revision: 297654
URL: http://llvm.org/viewvc/llvm-project?rev=297654&view=rev
Log:
Widen bitfield for type specifiers for OpenCL types
Added a static_assert to catch this issue at compile time.
Modified:
cfe/trunk/include/clang/Basic/Specifiers.
guansong updated this revision to Diff 91600.
https://reviews.llvm.org/D30743
Files:
lib/Driver/Tools.cpp
test/Driver/include-default-header.cl
Index: test/Driver/include-default-header.cl
===
--- /dev/null
+++ test/Driver/incl
Author: dexonsmith
Date: Mon Mar 13 13:45:08 2017
New Revision: 297655
URL: http://llvm.org/viewvc/llvm-project?rev=297655&view=rev
Log:
Modules: Use hash of PCM content for SIGNATURE
Change ASTFileSignature from a random 32-bit number to the hash of the
PCM content.
- Move definition ASTFileS
dexonsmith closed this revision.
dexonsmith marked 3 inline comments as done.
dexonsmith added a comment.
Thanks for the review Richard! Committed in r297655 with those changes.
Sorry for the long delay on this. Somehow I missed until today the review
after my ultimate ping. I'd like to blame
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:96
+
+ Finds uses of enumeration values in equality and inequality expressions
where a switch would be preferred.
+
Please highlight switch with `` and indent preferred on
Hello everyone,
The SVN mirror in the LLVM Lab seems behind with the changes.
I'm looking at the issue.
Thank you for understanding.
Thanks
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#699428, @Anastasia wrote:
> Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation
> accordingly to make things consistent?
Probably, No... the load/store with vec3 generates vec4 temporarily to be
aligned bu
Author: arsenm
Date: Mon Mar 13 14:47:53 2017
New Revision: 297659
URL: http://llvm.org/viewvc/llvm-project?rev=297659&view=rev
Log:
AMDGPU: Make 0 the private nullptr value
We can't actually pretend that 0 is valid for address space 0.
r295877 added a workaround to stop allocating user objects
t
arsenm closed this revision.
arsenm added a comment.
r297658, r297659
https://reviews.llvm.org/D30316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a reviewer: bruno.
bruno added a comment.
Hi JinGu,
I just read the discussion on cfe-dev, some comments:
> My colleague and I are implementing a transformation pass between LLVM IR and
> another IR and we want to keep the 3-component vector types in our target IR
Why can't you go
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Hi Pete, thanks for working on this!
LGTM with the minor comments below.
Comment at: include/clang/Lex/PPCallbacks.h:264
+ virtual void HasInclude(SourceLocation Loc, const F
bruno added a comment.
Hi Pete,
Comment at: lib/Frontend/DependencyFile.cpp:191
+ const Token &FilenameTok,
+ SrcMgr::CharacteristicKind FileType) override;
+
Is there any `FileSkipped` callback invocation that might trigger
rsmith added inline comments.
Comment at: lib/Sema/Sema.cpp:472-477
+// If this is a function template, we should remove if it has no
+// specializations.
+if (FunctionTemplateDecl *Template = FD->getDescribedFunctionTemplate()) {
+ if (std::distance(Template->sp
vlad.tsyrklevich created this revision.
This is the second part of https://reviews.llvm.org/D28445, it extends taint
propagation to cases where the tainted region is a sub-region and we can't
taint a conjured symbol entirely. This required adding a new map in the GDM
that maps tainted parent sy
vlad.tsyrklevich updated this revision to Diff 91614.
vlad.tsyrklevich added a comment.
Fix a stray assert()
https://reviews.llvm.org/D30909
Files:
lib/StaticAnalyzer/Core/ProgramState.cpp
Index: lib/StaticAnalyzer/Core/ProgramState.cpp
==
vlad.tsyrklevich updated this revision to Diff 91615.
vlad.tsyrklevich added a comment.
Fix a stray assert(), correctly this time..
https://reviews.llvm.org/D30909
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
include/clang/StaticAnalyzer/Core/PathSensitive/TaintMana
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#699695, @bruno wrote:
> Hi JinGu,
>
> I just read the discussion on cfe-dev, some comments:
>
> > My colleague and I are implementing a transformation pass between LLVM IR
> > and another IR and we want to keep the 3-component vector
andreybokhanko added a comment.
Hi Roger,
I'm very glad to see you started to work on this!
A somewhat obvious comment: no chance for this to be accepted without LIT
tests. I understand you have your doubts on the best approach to testing -- and
it's OK to ask either here or on llvm-dev -- but
Author: aaronballman
Date: Mon Mar 13 16:39:00 2017
New Revision: 297671
URL: http://llvm.org/viewvc/llvm-project?rev=297671&view=rev
Log:
Add the 'AllowSoleDefaultDtor' and 'AllowMissingMoveFunctions' options to the
cppcoreguidelines-special-member-functions check.
Patch by Florian Gross.
Adde
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r297671, thanks!
https://reviews.llvm.org/D30610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
marsupial updated this revision to Diff 91627.
marsupial retitled this revision from "Add test for
PPCallbacks::MacroUndefined" to "PPCallbacks::MacroUndefined, change signature
and add test.".
marsupial edited the summary of this revision.
Herald added a subscriber: nemanjai.
https://reviews.ll
Hi Eric,
> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR
> @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER)
> message(WARNING "LLVM_USE_SANITIZER=${LLVM_USE_SANITIZER} is not
> supported on OS X")
>endif()
>if (LIBFILE)
> -execute_process(COMMAND ${CMAKE_CXX_
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck
aprantl created this revision.
This fixes lookup mismatches that could previously happen when the module cache
path contained a '/./' component.
In combination with https://reviews.llvm.org/D28299 this bug can cause a
use-after-free.
rdar://problem/30413458
https://reviews.llvm.org/D30915
Fi
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1969
+ let Content = [{
+Attribute ``enum_extensibility`` is used to distinguish between enum
definitions that are extensible and those that are not. The attribute can take
either ``closed`` or ``
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Frontend/CompilerInvocation.cpp:1434
+
+ // Canonicalize -fmodules-cache-path before storing it.
+ SmallString<128> P(Args.getLastArgValue(OPT_fmodules_c
aaron.ballman added a comment.
I'm curious what kind of results you get when running this over a large code
base. There are definitely times when using == or != for a specific value is
*way* cleaner than using a switch statement, and I worry about this being so
chatty that it needs to be disabl
pirama updated this revision to Diff 91633.
pirama added a comment.
- Rebase
- Added command line flag and updated tests.
https://reviews.llvm.org/D30700
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/arch-specific-libdir-rpath.c
test/Driver/arch-specific-libdir.c
test/lit.cfg
rnk added a comment.
In https://reviews.llvm.org/D30700#695358, @Hahnfeld wrote:
> No build system will ever set `-frtlib-add-rpath` to enable this "feature".
> I'm for keeping this opt-out until we have configuration files to set this by
> default. Making it opt-in would weaken its main reason
pirama updated this revision to Diff 91635.
pirama added a comment.
*Actually* add the command line flags.
https://reviews.llvm.org/D30700
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/arch-specific-libdir-rpath.c
test/Driver/arch-specific-libdi
pirama added inline comments.
Comment at: lib/Driver/ToolChain.cpp:652
+// libc++ may be installed per arch.
+addArchSpecificRPath(*this, Args, CmdArgs);
break;
Hahnfeld wrote:
> pirama wrote:
> > `addArchSpecificRPath` is a static function in Tools.
Author: rnk
Date: Mon Mar 13 17:33:07 2017
New Revision: 297681
URL: http://llvm.org/viewvc/llvm-project?rev=297681&view=rev
Log:
Fix -Wunused-lambda-capture warning in new code
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL:
http://l
1 - 100 of 126 matches
Mail list logo
